Re: [PR] Bump github.com/docker/go-connections from 0.4.0 to 0.5.0 in /sdks [beam]

github-actions[bot] commented on PR #30247: URL: https://github.com/apache/beam/pull/30247#issuecomment-1931292057 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. Available commands: - `stop r

Re: [PR] Bump github.com/aws/aws-sdk-go-v2/config from 1.26.2 to 1.26.6 in /sdks [beam]

github-actions[bot] commented on PR #30248: URL: https://github.com/apache/beam/pull/30248#issuecomment-1931292014 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck for label go. Available commands: - `stop revi

Re: [PR] Bump google.golang.org/grpc from 1.60.1 to 1.61.0 in /sdks [beam]

github-actions[bot] commented on PR #30249: URL: https://github.com/apache/beam/pull/30249#issuecomment-1931291956 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label go. Available commands: - `stop

Re: [PR] Bump google.golang.org/grpc from 1.60.1 to 1.61.0 in /sdks [beam]

codecov[bot] commented on PR #30249: URL: https://github.com/apache/beam/pull/30249#issuecomment-1931274039 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30249?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

Re: [PR] Bump github.com/aws/aws-sdk-go-v2/config from 1.26.2 to 1.26.6 in /sdks [beam]

codecov[bot] commented on PR #30248: URL: https://github.com/apache/beam/pull/30248#issuecomment-1931269957 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

Re: [PR] Bump github.com/docker/go-connections from 0.4.0 to 0.5.0 in /sdks [beam]

codecov[bot] commented on PR #30247: URL: https://github.com/apache/beam/pull/30247#issuecomment-1931270035 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/30247?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[PR] Bump google.golang.org/grpc from 1.60.1 to 1.61.0 in /sdks [beam]

dependabot[bot] opened a new pull request, #30249: URL: https://github.com/apache/beam/pull/30249 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.60.1 to 1.61.0. Release notes Sourced from https://github.com/grpc/grpc-go/releases";>google.golang.org/grpc's r

[PR] Bump github.com/aws/aws-sdk-go-v2/config from 1.26.2 to 1.26.6 in /sdks [beam]

dependabot[bot] opened a new pull request, #30248: URL: https://github.com/apache/beam/pull/30248 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.26.2 to 1.26.6. Commits https://github.com/aws/aws-sdk-go-v2/commit/857d5277b41f290ab7ba0e

[PR] Bump github.com/docker/go-connections from 0.4.0 to 0.5.0 in /sdks [beam]

dependabot[bot] opened a new pull request, #30247: URL: https://github.com/apache/beam/pull/30247 Bumps [github.com/docker/go-connections](https://github.com/docker/go-connections) from 0.4.0 to 0.5.0. Commits https://github.com/docker/go-connections/commit/fa09c952e3eadbffaf8

Re: [PR] Generate external transform wrappers using a script [beam]

ahmedabu98 commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480782455 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Fix a naming conflict of the TransformService test suite [beam]

Abacn merged PR #30243: URL: https://github.com/apache/beam/pull/30243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480775490 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480775490 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Fix a naming conflict of the TransformService test suite [beam]

github-actions[bot] commented on PR #30243: URL: https://github.com/apache/beam/pull/30243#issuecomment-1931080370 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label build. Available commands: - `stop r

Re: [PR] Generate external transform wrappers using a script [beam]

ahmedabu98 commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480758119 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Generate external transform wrappers using a script [beam]

ahmedabu98 commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480758119 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Generate external transform wrappers using a script [beam]

ahmedabu98 commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480753787 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480748410 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480748410 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480745997 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480745997 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [I] [Failing Test]: PostCommit TransformService Direct Python 3.11 perma-red (transformServicePythonUsingJava) [beam]

chamikaramj commented on issue #30238: URL: https://github.com/apache/beam/issues/30238#issuecomment-1931039835 https://github.com/apache/beam/pull/30243 fixes a naming conflict but might not fully fix the test suite. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480743936 ## sdks/python/test-suites/xlang/build.gradle: ## @@ -67,12 +67,22 @@ def ioXlang = new CrossLanguageTask().tap { // This list should include all expansion service

Re: [PR] [Cherry Pick #30188] gcsio: support dict as the input of delete_batch [beam]

lostluck merged PR #30241: URL: https://github.com/apache/beam/pull/30241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480718257 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -140,12 +137,12 @@ public interface JmsIOITOptions extends IOTestPipelineOptions, Streami

Re: [PR] Fix Jms drop record [beam]

Abacn commented on PR #30218: URL: https://github.com/apache/beam/pull/30218#issuecomment-1931012480 Thanks, @damondouglas PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480542584 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws IOException { M

Re: [I] [Failing Test]: JmsIOTest. testCheckpointMark flaky [beam]

Abacn commented on issue #30225: URL: https://github.com/apache/beam/issues/30225#issuecomment-1931011154 The underlying cause is that there is no guarantee `receiveNoWait` here: https://github.com/apache/beam/blob/27f1c0774fd93e846de9a8b668e6effc5a41eb10/sdks/java/io/jms/src/main/java/org/a

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480714479 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws IOException { M

Re: [PR] Extract ThrottleTimeCounter for PerWorkerMetrics [beam]

github-actions[bot] commented on PR #30245: URL: https://github.com/apache/beam/pull/30245#issuecomment-1931006339 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

[PR] Only populate DataflowHistogramValue::OutlierStats when overflow/underflow values exist. [beam]

JayajP opened a new pull request, #30246: URL: https://github.com/apache/beam/pull/30246 This field is usually zero-valued (because there are no overflows/underflows recorded) for BigQuerySinkMetrics so we can reduce the JSON RPC request size by not populating it instead of populating it wi

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480694853 ## sdks/python/gen_xlang_wrappers.py: ## @@ -18,6 +18,8 @@ """ Generates Python wrappers for external transforms (specifically, SchemaTransforms) + +Experimental; n

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480688045 ## sdks/python/apache_beam/transforms/xlang/__init__.py: ## @@ -16,6 +16,12 @@ # """ -This is a subdirectory for generated external transforms. -Refer to sdks/pyth

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480688045 ## sdks/python/apache_beam/transforms/xlang/__init__.py: ## @@ -16,6 +16,12 @@ # """ -This is a subdirectory for generated external transforms. -Refer to sdks/pyth

Re: [PR] Generate external transform wrappers using a script [beam]

tvalentyn commented on code in PR #29834: URL: https://github.com/apache/beam/pull/29834#discussion_r1480676716 ## sdks/python/setup.py: ## @@ -275,8 +274,8 @@ def get_portability_package_data(): # executes below. generate_protos_first() - # Generate wrappers - generat

Re: [PR] Beam 2.54.0 release blog. [beam]

lostluck commented on code in PR #30201: URL: https://github.com/apache/beam/pull/30201#discussion_r1480657592 ## website/www/site/content/en/blog/beam-2.54.0.md: ## @@ -0,0 +1,173 @@ +--- +title: "Apache Beam 2.54.0" +date: -MM-DD H:MM:00 Z Review Comment: Note to up

Re: [PR] Beam 2.54.0 release blog. [beam]

lostluck commented on code in PR #30201: URL: https://github.com/apache/beam/pull/30201#discussion_r1480657459 ## website/www/site/content/en/get-started/downloads.md: ## @@ -96,10 +96,18 @@ versions denoted `0.x.y`. ## Releases +### 2.54.0 (2024-02-DD) Review Comment:

Re: [PR] Fix change point analysis unit test [beam]

github-actions[bot] commented on PR #30244: URL: https://github.com/apache/beam/pull/30244#issuecomment-1930918355 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

Re: [PR] Beam 2.54.0 release blog. [beam]

lostluck commented on code in PR #30201: URL: https://github.com/apache/beam/pull/30201#discussion_r1480620103 ## website/www/site/content/en/get-started/downloads.md: ## @@ -96,6 +96,14 @@ versions denoted `0.x.y`. ## Releases +### 2.54.0 (2024-02-DD) +Official [source cod

Re: [PR] Fix Jms drop record [beam]

Abacn commented on PR #30218: URL: https://github.com/apache/beam/pull/30218#issuecomment-1930878747 Just re-enable a skipped integration test to see if #26175 is still an issue for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[PR] Extract ThrottleTimeCounter for PerWorkerMetrics [beam]

JayajP opened a new pull request, #30245: URL: https://github.com/apache/beam/pull/30245 Throttled time represents the amount of time waiting due to RPC retries. It is used to make better autoscaling decisions in our backend. Currently, we report throttled time metrics for the BigQuer

Re: [PR] Bump golang.org/x/oauth2 from 0.15.0 to 0.16.0 in /sdks [beam]

dependabot[bot] closed pull request #30223: Bump golang.org/x/oauth2 from 0.15.0 to 0.16.0 in /sdks URL: https://github.com/apache/beam/pull/30223 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump golang.org/x/oauth2 from 0.15.0 to 0.16.0 in /sdks [beam]

dependabot[bot] commented on PR #30223: URL: https://github.com/apache/beam/pull/30223#issuecomment-1930870140 Looks like golang.org/x/oauth2 is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Bump cloud.google.com/go/spanner from 1.53.1 to 1.56.0 in /sdks [beam]

lostluck merged PR #30224: URL: https://github.com/apache/beam/pull/30224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[PR] Adds options to print more logs [beam]

chamikaramj opened a new pull request, #30243: URL: https://github.com/apache/beam/pull/30243 **Please** add a meaningful description for your change here WIP Thank you for your contribution! Follow this checklist to help us incorporate your cont

[PR] Fix change point analysis unit test [beam]

AnandInguva opened a new pull request, #30244: URL: https://github.com/apache/beam/pull/30244 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution qu

Re: [PR] [CherryPick #30220] Add Default method for OutputReceiver.outputWindowedValue [beam]

lostluck commented on PR #30240: URL: https://github.com/apache/beam/pull/30240#issuecomment-1930861667 The uploads for test results are flaky apparently, but the test suites themselves all passed. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[PR] Extract ThrottleTimeCounter for PerWorkerMetrics [beam]

JayajP opened a new pull request, #30242: URL: https://github.com/apache/beam/pull/30242 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [PR] Extract ThrottleTimeCounter for PerWorkerMetrics [beam]

JayajP closed pull request #30242: Extract ThrottleTimeCounter for PerWorkerMetrics URL: https://github.com/apache/beam/pull/30242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [Cherry Pick #30188] gcsio: support dict as the input of delete_batch [beam]

github-actions[bot] commented on PR #30241: URL: https://github.com/apache/beam/pull/30241#issuecomment-1930851765 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [PR] [CherryPick #30220] Add Default method for OutputReceiver.outputWindowedValue [beam]

lostluck merged PR #30240: URL: https://github.com/apache/beam/pull/30240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] [Cherry Pick #30188] gcsio: support dict as the input of delete_batch [beam]

lostluck commented on PR #30241: URL: https://github.com/apache/beam/pull/30241#issuecomment-1930841128 R: @liferoad @shunping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[PR] [Cherry Pick #30188] gcsio: support dict as the input of delete_batch [beam]

lostluck opened a new pull request, #30241: URL: https://github.com/apache/beam/pull/30241 Cherry Pick #30188 into the 2.54.0 release branch. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and eas

Re: [PR] Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes - Part 3 [beam]

damccorm commented on PR #29860: URL: https://github.com/apache/beam/pull/29860#issuecomment-1930840396 The website publish job I linked to runs every 6 hours and hasn't run since we merged the PR -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes - Part 3 [beam]

talatuyarer commented on PR #29860: URL: https://github.com/apache/beam/pull/29860#issuecomment-1930815276 But i dont see the post on blog page https://beam.apache.org/blog/ On Tue, Feb 6, 2024, 1:37 PM Danny McCormick ***@***.***> wrote: > @talatuyarer

Re: [PR] Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes - Part 3 [beam]

damccorm commented on PR #29860: URL: https://github.com/apache/beam/pull/29860#issuecomment-1930792245 @talatuyarer which check? Looks like https://github.com/apache/beam/actions/workflows/beam_Publish_Website.yml is green at least -- This is an automated message from the Apache Git Ser

Re: [PR] Add Drain to Job Management proto [beam]

lostluck commented on code in PR #30157: URL: https://github.com/apache/beam/pull/30157#discussion_r1480559292 ## model/job-management/src/main/proto/org/apache/beam/model/job_management/v1/beam_job_api.proto: ## @@ -127,6 +130,19 @@ message CancelJobResponse { JobState.Enum

Re: [PR] Generate external transform wrappers using a script [beam]

ahmedabu98 commented on PR #29834: URL: https://github.com/apache/beam/pull/29834#issuecomment-1930784234 R: @tvalentyn R: @robertwb Ready for another review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes - Part 3 [beam]

talatuyarer commented on PR #29860: URL: https://github.com/apache/beam/pull/29860#issuecomment-1930781328 @damccorm Looks like Master build is broken. fyi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Fix Jms drop record [beam]

Abacn commented on PR #30218: URL: https://github.com/apache/beam/pull/30218#issuecomment-1930773853 > Overall design SGTM. It sounds like it would have a performance impact, but is still worth it. Do you know if the recreating a session has a performance impact that could matter? >

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480551458 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws IOException { M

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480551458 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws IOException { M

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480542584 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws IOException { M

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480542584 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws IOException { M

Re: [PR] Beam 2.54.0 release blog. [beam]

damccorm commented on code in PR #30201: URL: https://github.com/apache/beam/pull/30201#discussion_r1480541485 ## website/www/site/content/en/get-started/downloads.md: ## @@ -96,6 +96,14 @@ versions denoted `0.x.y`. ## Releases +### 2.54.0 (2024-02-DD) +Official [source cod

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480541037 ## sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java: ## @@ -39,87 +40,66 @@ class JmsCheckpointMark implements UnboundedSource.CheckpointM

Re: [PR] Beam 2.54.0 release blog. [beam]

github-actions[bot] commented on PR #30201: URL: https://github.com/apache/beam/pull/30201#issuecomment-1930749801 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label website. Available commands: - `stop

Re: [PR] Adjust transform-service module names and deps with sdks/java/core [beam]

chamikaramj commented on PR #30237: URL: https://github.com/apache/beam/pull/30237#issuecomment-1930740571 +1 for also updating https://github.com/apache/beam/blob/08a717dc5c297844c5ebef5712bb491ca66a8ede/sdks/java/transform-service/app/build.gradle#L23 -- This is an automated message fro

Re: [PR] Update artifacts fetcher to download artifacts locally using FileSystems [beam]

AnandInguva commented on PR #30202: URL: https://github.com/apache/beam/pull/30202#issuecomment-1930735230 https://github.com/apache/beam/actions/runs/7805971680 - IT test run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] Remove avro dependency from runners-core-construction [beam]

kennknowles commented on PR #30235: URL: https://github.com/apache/beam/pull/30235#issuecomment-1930728115 It looks like there is a problem with shading again :-( It seems that the coder translator registered in the Avro extension is not considered the correct type. Probably because s

Re: [PR] Fix Jms drop record [beam]

kennknowles commented on PR #30218: URL: https://github.com/apache/beam/pull/30218#issuecomment-1930726124 Overall design SGTM. It sounds like it would have a performance impact, but is still worth it. Do you know if the recreating a session has a performance impact that could matter?

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480497997 ## sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java: ## @@ -39,87 +40,66 @@ class JmsCheckpointMark implements UnboundedSource.CheckpointM

Re: [PR] Fix Jms drop record [beam]

Abacn commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480495756 ## sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java: ## @@ -39,87 +40,66 @@ class JmsCheckpointMark implements UnboundedSource.CheckpointM

Re: [PR] Fix Jms drop record [beam]

damondouglas commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480480174 ## sdks/java/io/jms/src/test/java/org/apache/beam/sdk/io/jms/JmsIOIT.java: ## @@ -196,11 +204,18 @@ public void testPublishingThenReadingAll() throws IOException {

Re: [PR] Fix Jms drop record [beam]

liferoad commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480478395 ## sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java: ## @@ -39,87 +40,66 @@ class JmsCheckpointMark implements UnboundedSource.Checkpoi

Re: [PR] Fix Jms drop record [beam]

liferoad commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480477938 ## sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java: ## @@ -39,87 +40,66 @@ class JmsCheckpointMark implements UnboundedSource.Checkpoi

Re: [PR] Fix Jms drop record [beam]

liferoad commented on code in PR #30218: URL: https://github.com/apache/beam/pull/30218#discussion_r1480477196 ## sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsCheckpointMark.java: ## @@ -39,87 +40,66 @@ class JmsCheckpointMark implements UnboundedSource.Checkpoi

Re: [PR] [DO NOT MERGE] [Dataflow Streaming] Add Channelz staus page exporting GRPC channelz data [beam]

scwhittle commented on code in PR #30211: URL: https://github.com/apache/beam/pull/30211#discussion_r1480458218 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/status/ChannelzServlet.java: ## @@ -0,0 +1,245 @@ +package org.apach

Re: [PR] Fix to take StreamingDataflowWorkerOptions from external options [beam]

scwhittle merged PR #30232: URL: https://github.com/apache/beam/pull/30232 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apach

Re: [PR] [Release-2.54.0] Cherry pick #30220 into release branch [beam]

Abacn commented on PR #30239: URL: https://github.com/apache/beam/pull/30239#issuecomment-1930597573 superceded by #30240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Release-2.54.0] Cherry pick #30220 into release branch [beam]

Abacn closed pull request #30239: [Release-2.54.0] Cherry pick #30220 into release branch URL: https://github.com/apache/beam/pull/30239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [CherryPick #30220] Add Default method for OutputReceiver.outputWindowedValue [beam]

github-actions[bot] commented on PR #30240: URL: https://github.com/apache/beam/pull/30240#issuecomment-1930596764 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [I] Performance Regression or Improvement: pytorch_image_classification_benchmarks-resnet101-mean_load_model_latency_milli_secs:mean_load_model_latency_milli_secs [beam]

tvalentyn commented on issue #29491: URL: https://github.com/apache/beam/issues/29491#issuecomment-1930595989 @AnandInguva @damccorm in case you remember whether we reported this to Pytorch folks -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] [CherryPick #30220] Add Default method for OutputReceiver.outputWindowedValue [beam]

lostluck opened a new pull request, #30240: URL: https://github.com/apache/beam/pull/30240 Cherry pick #30220 into the 2.54.0 release branch. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and eas

Re: [PR] [CherryPick #30220] Add Default method for OutputReceiver.outputWindowedValue [beam]

lostluck commented on PR #30240: URL: https://github.com/apache/beam/pull/30240#issuecomment-1930594727 R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Adjust transform-service module names and deps with sdks/java/core [beam]

Abacn commented on PR #30237: URL: https://github.com/apache/beam/pull/30237#issuecomment-1930593631 There was a recent change #30190 might need to change here as well: https://github.com/apache/beam/blob/08a717dc5c297844c5ebef5712bb491ca66a8ede/sdks/java/transform-service/app/build.gradle#L

[PR] [Release-2.54.0] Cherry pick #30220 into release branch [beam]

Abacn opened a new pull request, #30239: URL: https://github.com/apache/beam/pull/30239 Fixes #30203 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your c

Re: [I] [Failing Test]: PostCommit TransformService Direct Python 3.11 perma-red (transformServicePythonUsingJava) [beam]

chamikaramj commented on issue #30238: URL: https://github.com/apache/beam/issues/30238#issuecomment-1930586959 The Jenkins was green last time I checked. Seems like it has been turned down ? Github Actions version was migrated from the Jenkins test that I added initially but it sta

Re: [PR] Creating a Fully Managed Beam Streaming System with Flink Runner on Kubernetes - Part 3 [beam]

damccorm merged PR #29860: URL: https://github.com/apache/beam/pull/29860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] Add Default method for OutputReceiver.outputWindowedValue [beam]

Abacn merged PR #30220: URL: https://github.com/apache/beam/pull/30220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

Re: [PR] Add Default method for OutputReceiver.outputWindowedValue [beam]

Abacn commented on PR #30220: URL: https://github.com/apache/beam/pull/30220#issuecomment-1930580892 Thanks for reviewing, merging for now and will open a cherry-pick PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [CherryPick #30229] [Dataflow Streaming] Invalidate caches and remove work on failure before commit [beam]

lostluck merged PR #30234: URL: https://github.com/apache/beam/pull/30234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] [CherryPick #30229] [Dataflow Streaming] Invalidate caches and remove work on failure before commit [beam]

arunpandianp commented on PR #30234: URL: https://github.com/apache/beam/pull/30234#issuecomment-1930548450 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch [beam]

lostluck commented on PR #30104: URL: https://github.com/apache/beam/pull/30104#issuecomment-1930546008 PostCommit XVR GoUsingJava Dataflow - Has never been successful, using #28339 to track. PostCommit Java Sickbay - Has never been successful, filed #30236 to track. PostCommit Transf

Re: [I] [Task]: Update beam_PostCommit_Java_IO_Performance_Tests.yml to select release branch automatically [beam]

lostluck commented on issue #28330: URL: https://github.com/apache/beam/issues/28330#issuecomment-1930543926 The suite appears to be Permared at present. https://github.com/apache/beam/actions/workflows/beam_PostCommit_Java_IO_Performance_Tests.yml?query=is%3Afailure In particu

Re: [PR] Adjust transform-service module names and deps with sdks/java/core [beam]

github-actions[bot] commented on PR #30237: URL: https://github.com/apache/beam/pull/30237#issuecomment-1930538917 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [I] [Failing Test]: Go tests are flaky in beam_PostCommit_XVR_Direct [beam]

lostluck commented on issue #28972: URL: https://github.com/apache/beam/issues/28972#issuecomment-1930538626 At this point it appears to be hard failing for a few Python 3.11 related issues. https://github.com/apache/beam/actions/runs/7803720204/job/21284093581 https://github.

Re: [PR] Remove avro dependency from runners-core-construction [beam]

github-actions[bot] commented on PR #30235: URL: https://github.com/apache/beam/pull/30235#issuecomment-1930536081 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

Re: [PR] Adjust transform-service module names and deps with sdks/java/core [beam]

kennknowles commented on PR #30237: URL: https://github.com/apache/beam/pull/30237#issuecomment-1930535354 R: @chamikaramj since you have context on the series of adjustments. This one got really small because actually the changes come with the bigger PR, but still since I've prepared

Re: [PR] Remove avro dependency from runners-core-construction [beam]

kennknowles commented on PR #30235: URL: https://github.com/apache/beam/pull/30235#issuecomment-1930534524 R: @chamikaramj since you have context on the series of adjustments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   >