tvalentyn merged PR #30958:
URL: https://github.com/apache/beam/pull/30958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
damccorm commented on code in PR #30959:
URL: https://github.com/apache/beam/pull/30959#discussion_r1563640076
##
CHANGES.md:
##
@@ -119,6 +119,7 @@
* Merged sdks/java/fn-execution and runners/core-construction-java into the
main SDK. These artifacts were never meant for
github-actions[bot] commented on PR #30959:
URL: https://github.com/apache/beam/pull/30959#issuecomment-2052900909
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
robertwb commented on PR #30959:
URL: https://github.com/apache/beam/pull/30959#issuecomment-2052897653
R: @damccorm or @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
robertwb opened a new pull request, #30959:
URL: https://github.com/apache/beam/pull/30959
This version is guarded by an experiment in case the old behavior is needed.
Thank you for your contribution! Follow this checklist to help us
incorporate your
Abacn commented on PR #30958:
URL: https://github.com/apache/beam/pull/30958#issuecomment-2052842519
Now it apppears PyDoc PreCommit is a different breakage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tvalentyn commented on issue #30927:
URL: https://github.com/apache/beam/issues/30927#issuecomment-2052729627
gdb backtrace of the stuck that thread holds up GIL:
https://github.com/grpc/grpc/issues/36256#issuecomment-2052729097
--
This is an automated message from the Apache Git
github-actions[bot] commented on PR #30958:
URL: https://github.com/apache/beam/pull/30958#issuecomment-2052686382
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
tvalentyn commented on PR #30958:
URL: https://github.com/apache/beam/pull/30958#issuecomment-2052685823
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Abacn commented on code in PR #30879:
URL: https://github.com/apache/beam/pull/30879#discussion_r1563292058
##
contributor-docs/code-change-guide.md:
##
@@ -0,0 +1,518 @@
+
+
+This guide is for Beam users and developers changing and testing Beam code.
+Specifically, this guide
Abacn commented on code in PR #30879:
URL: https://github.com/apache/beam/pull/30879#discussion_r1563291081
##
contributor-docs/code-change-guide.md:
##
@@ -0,0 +1,518 @@
+
+
+This guide is for Beam users and developers changing and testing Beam code.
+Specifically, this guide
JayajP commented on PR #30796:
URL: https://github.com/apache/beam/pull/30796#issuecomment-2052638999
Java IO precommit failing due to #30941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tvalentyn commented on PR #30939:
URL: https://github.com/apache/beam/pull/30939#issuecomment-2052630389
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tvalentyn commented on code in PR #30939:
URL: https://github.com/apache/beam/pull/30939#discussion_r1563277851
##
.github/workflows/update_python_dependencies.yml:
##
@@ -80,6 +78,11 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
+
tvalentyn commented on code in PR #30939:
URL: https://github.com/apache/beam/pull/30939#discussion_r1563277851
##
.github/workflows/update_python_dependencies.yml:
##
@@ -80,6 +78,11 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
+
tvalentyn merged PR #30953:
URL: https://github.com/apache/beam/pull/30953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
damccorm commented on PR #30894:
URL: https://github.com/apache/beam/pull/30894#issuecomment-2052510228
We're taking a different (runner driven) approach here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
damccorm closed pull request #30894: Revert "Revert #30533: Automatically
execute unbounded pipelines in streaming mode."
URL: https://github.com/apache/beam/pull/30894
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
damccorm commented on code in PR #30895:
URL: https://github.com/apache/beam/pull/30895#discussion_r1563185528
##
website/www/site/content/en/documentation/sdks/yaml-udf.md:
##
@@ -133,11 +184,26 @@ expressions are supported as well
another_col: "col2 + col3"
```
damccorm commented on code in PR #30895:
URL: https://github.com/apache/beam/pull/30895#discussion_r1563185014
##
website/www/site/content/en/documentation/sdks/yaml-udf.md:
##
@@ -133,11 +184,26 @@ expressions are supported as well
another_col: "col2 + col3"
```
MelodyShen commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052472089
> do you need the revert to be _merged_ in order to test performance change?
We plan to create an import cl and let the performance tests run against
head during the weekends.
Abacn merged PR #30956:
URL: https://github.com/apache/beam/pull/30956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Abacn commented on PR #30956:
URL: https://github.com/apache/beam/pull/30956#issuecomment-2052468005
merge for now to make most Python PostCommit back green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
tvalentyn commented on PR #30938:
URL: https://github.com/apache/beam/pull/30938#issuecomment-2052437277
> I think we should call this out in CHANGES.md, otherwise LGTM
Done, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
riteshghorse opened a new pull request, #30957:
URL: https://github.com/apache/beam/pull/30957
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
tvalentyn commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052413019
do you need the revert to be *merged* in order to test performance change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Abacn commented on PR #30956:
URL: https://github.com/apache/beam/pull/30956#issuecomment-2052406061
Python Doc PreCommit seems still failing, and the attempt fix (second
commit) didn't work. I'm going to revert the second commit and merge the
reviewed and tested first one
--
This is an
Abacn commented on issue #30955:
URL: https://github.com/apache/beam/issues/30955#issuecomment-2052374308
> They also changed the handling of dashes: apache-beam becomes apache_beam
Yeah, this is https://github.com/pypa/setuptools/issues/4300
--
This is an automated message from
tvalentyn commented on issue #30955:
URL: https://github.com/apache/beam/issues/30955#issuecomment-2052366329
They also changed the handling of dashes: apache-beam becomes apache_beam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Abacn opened a new pull request, #30956:
URL: https://github.com/apache/beam/pull/30956
Mitigate #30955
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate
kennknowles merged PR #30805:
URL: https://github.com/apache/beam/pull/30805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tvalentyn opened a new issue, #30954:
URL: https://github.com/apache/beam/issues/30954
### What happened?
Repro:
```
gradlew :sdks:python:cleanPython
To honour the JVM settings for this build a single-use Daemon process will
be forked. For more on this, please refer to
github-actions[bot] commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052231920
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @tvalentyn added as fallback since no labels match configuration
jrmccluskey merged PR #30922:
URL: https://github.com/apache/beam/pull/30922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #30953:
URL: https://github.com/apache/beam/pull/30953#issuecomment-2052209410
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
tvalentyn commented on PR #30953:
URL: https://github.com/apache/beam/pull/30953#issuecomment-2052207810
R: @andreydevyatkin or @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tvalentyn opened a new pull request, #30953:
URL: https://github.com/apache/beam/pull/30953
Document workarounds for #28909 in the beginning of the doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
MelodyShen commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052178600
Hi @damccorm @tudorm here is the pr to revert the
https://github.com/apache/beam/pull/30439 that caused performance regression.
Would you mind taking a look? Thanks!
--
This is an
MelodyShen opened a new pull request, #30952:
URL: https://github.com/apache/beam/pull/30952
This reverts commit d4990744cda3afe052422f5ae19ba17e0145218f.
Performance regression was detected. The potential reason might be that we
added additional lock on the metrics.
rszper commented on code in PR #30879:
URL: https://github.com/apache/beam/pull/30879#discussion_r1562791368
##
contributor-docs/code-change-guide.md:
##
@@ -0,0 +1,516 @@
+
+
+This guide is for Beam users and developers changing and testing Beam codes.
+Specifically,
+
+1.
damccorm merged PR #30949:
URL: https://github.com/apache/beam/pull/30949
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Abacn commented on PR #30942:
URL: https://github.com/apache/beam/pull/30942#issuecomment-2052018774
fixed the cross link to the script, merging for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Abacn merged PR #30942:
URL: https://github.com/apache/beam/pull/30942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
damccorm commented on PR #30915:
URL: https://github.com/apache/beam/pull/30915#issuecomment-2052002208
@xianhualiu any update here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
robertwb commented on issue #30950:
URL: https://github.com/apache/beam/issues/30950#issuecomment-2051996241
Underlying test was skipped, not resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
robertwb closed issue #30950: [Failing Test]: beam_PreCommit_Yaml_Xlang_Direct
fails with with external bigquery write
URL: https://github.com/apache/beam/issues/30950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
robertwb merged PR #30951:
URL: https://github.com/apache/beam/pull/30951
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #30949:
URL: https://github.com/apache/beam/pull/30949#issuecomment-2051992626
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop
robertwb merged PR #30880:
URL: https://github.com/apache/beam/pull/30880
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #30951:
URL: https://github.com/apache/beam/pull/30951#issuecomment-2051986808
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
robertwb commented on PR #30951:
URL: https://github.com/apache/beam/pull/30951#issuecomment-2051984865
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
robertwb opened a new pull request, #30951:
URL: https://github.com/apache/beam/pull/30951
This should resolve https://github.com/apache/beam/issues/30950 from
breaking presubmits until we figure out what the issue is.
Thank you for your contribution!
damccorm merged PR #30920:
URL: https://github.com/apache/beam/pull/30920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kennknowles commented on code in PR #30805:
URL: https://github.com/apache/beam/pull/30805#discussion_r1562599790
##
sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/ScanSource.java:
##
@@ -0,0 +1,136 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
github-actions[bot] commented on PR #30879:
URL: https://github.com/apache/beam/pull/30879#issuecomment-2051963313
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
Abacn commented on PR #30879:
URL: https://github.com/apache/beam/pull/30879#issuecomment-2051961119
R: @rszper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
robertwb commented on code in PR #30910:
URL: https://github.com/apache/beam/pull/30910#discussion_r1562688850
##
sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/IcebergWriteSchemaTransformProvider.java:
##
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software
github-actions[bot] commented on PR #30879:
URL: https://github.com/apache/beam/pull/30879#issuecomment-2051944271
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @robertwb added as fallback since no labels match configuration
robertwb commented on PR #30793:
URL: https://github.com/apache/beam/pull/30793#issuecomment-2051924037
> Took a bit for me to wrap my head around the logic, but this makes sense
to me.
>
> So now with this logic, if we were to package all turnkey external
transforms in a common
liferoad opened a new pull request, #30949:
URL: https://github.com/apache/beam/pull/30949
Address #30505. The current time out value is 20 minutes. I checked few
successful runs, which usually took less than 20 minutes. However, given
sleeping 1 min
github-actions[bot] commented on PR #30942:
URL: https://github.com/apache/beam/pull/30942#issuecomment-2051916495
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
Abacn commented on PR #30942:
URL: https://github.com/apache/beam/pull/30942#issuecomment-2051914215
R: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
AnandInguva closed issue #26333: [Task]: Python Jdbc xlang test uses deprecated
API for sqlalchemy
URL: https://github.com/apache/beam/issues/26333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Dippatel98 commented on issue #26333:
URL: https://github.com/apache/beam/issues/26333#issuecomment-2051886983
This issue has been fixed by #30919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Dippatel98 commented on PR #30919:
URL: https://github.com/apache/beam/pull/30919#issuecomment-2051886183
Fixes #26333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #30942:
URL: https://github.com/apache/beam/pull/30942#issuecomment-2051881147
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @damondouglas added as fallback since no labels match
Abacn merged PR #30893:
URL: https://github.com/apache/beam/pull/30893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Abacn merged PR #30940:
URL: https://github.com/apache/beam/pull/30940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Abacn commented on PR #30940:
URL: https://github.com/apache/beam/pull/30940#issuecomment-2051796175
local environment test fail should be irrelevant, merging for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lhoestq commented on PR #23808:
URL: https://github.com/apache/beam/pull/23808#issuecomment-2051778305
Feel free to re-open a PR with these changes (and possibly the missing
test), I don't think I'll continue this PR
--
This is an automated message from the Apache Git Service.
To respond
lpolisi commented on PR #23808:
URL: https://github.com/apache/beam/pull/23808#issuecomment-2051730843
No plans to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
scwhittle commented on PR #30940:
URL: https://github.com/apache/beam/pull/30940#issuecomment-2051688760
Closed and reopened to retrigger tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
scwhittle closed pull request #30940: Fix broken lint and improve lint rules.
URL: https://github.com/apache/beam/pull/30940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
scwhittle commented on issue #28776:
URL: https://github.com/apache/beam/issues/28776#issuecomment-2051652566
I believe this is a long-standing bug within the python sdk. Side inputs
within the global window are cached in
codecov-commenter commented on PR #30693:
URL: https://github.com/apache/beam/pull/30693#issuecomment-2051644673
##
[Codecov](https://app.codecov.io/gh/apache/beam/pull/30693?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
github-actions[bot] commented on PR #30693:
URL: https://github.com/apache/beam/pull/30693#issuecomment-2051644369
Reminder, please take a look at this pr: @johnjcasey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
je-ik commented on code in PR #30905:
URL: https://github.com/apache/beam/pull/30905#discussion_r1562135025
##
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/source/bounded/FlinkBoundedSourceReader.java:
##
@@ -61,8 +55,6 @@
*/
andreydevyatkin commented on PR #30940:
URL: https://github.com/apache/beam/pull/30940#issuecomment-2051467203
@tvalentyn @liferoad Seems one of the checks has failed. Shall we merge it
as it is or re-run it manually? Notice that there is no way to re-run it by
leaving a comment
--
This
je-ik commented on PR #30197:
URL: https://github.com/apache/beam/pull/30197#issuecomment-2051253260
I verified the current implementation works and can read savepoint created
by 1.16 (at least with the same beam version), but I need more tests regarding
upgrade from current stable
JozoVilcek commented on code in PR #30905:
URL: https://github.com/apache/beam/pull/30905#discussion_r1562178562
##
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/source/bounded/FlinkBoundedSourceReader.java:
##
@@ -61,8 +55,6 @@
je-ik commented on code in PR #30905:
URL: https://github.com/apache/beam/pull/30905#discussion_r1562135025
##
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/source/bounded/FlinkBoundedSourceReader.java:
##
@@ -61,8 +55,6 @@
*/
JozoVilcek commented on code in PR #30905:
URL: https://github.com/apache/beam/pull/30905#discussion_r1562080961
##
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/io/source/bounded/FlinkBoundedSourceReader.java:
##
@@ -61,8 +55,6 @@
github-actions[bot] commented on PR #30948:
URL: https://github.com/apache/beam/pull/30948#issuecomment-2051044866
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated
83 matches
Mail list logo
