github-actions[bot] commented on PR #32450:
URL: https://github.com/apache/beam/pull/32450#issuecomment-2352113677
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @Abacn for label java.
R: @shunping for label io.
Availa
kberezin-nshl commented on PR #32450:
URL: https://github.com/apache/beam/pull/32450#issuecomment-2352112580
Looks like the build failure is a flake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kberezin-nshl commented on PR #32450:
URL: https://github.com/apache/beam/pull/32450#issuecomment-2352112250
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
lostluck merged PR #32466:
URL: https://github.com/apache/beam/pull/32466
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache
github-actions[bot] commented on PR #32466:
URL: https://github.com/apache/beam/pull/32466#issuecomment-2352027659
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @lostluck for label go.
Available commands:
- `stop revi
github-actions[bot] commented on PR #32467:
URL: https://github.com/apache/beam/pull/32467#issuecomment-2352027635
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated me
dependabot[bot] opened a new pull request, #32467:
URL: https://github.com/apache/beam/pull/32467
Bumps
[github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2)
from 1.27.28 to 1.27.33.
Commits
https://github.com/aws/aws-sdk-go-v2/commit/f1d71c59a1499981873f
dependabot[bot] opened a new pull request, #32466:
URL: https://github.com/apache/beam/pull/32466
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.17.0 to
0.18.0.
Commits
https://github.com/golang/text/commit/1e3e9fdab19c86b2b575f3bdb8831eaa3468381f";>1e3e9fd
a
proost commented on PR #32465:
URL: https://github.com/apache/beam/pull/32465#issuecomment-2351963887
@ahmedabu98
I update "CHANGES.md".
can you review again? because i notice that `Write` doesn't validate topic.
when topic is given statically, check topic is valid or not.
--
T
m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1760445402
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java:
##
@@ -251,14 +300,16 @@
m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1760443991
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/harness/FanOutStreamingEngineWorkerHarness.java:
##
@@ -272,
m-trieu commented on code in PR #31902:
URL: https://github.com/apache/beam/pull/31902#discussion_r1760442848
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/ActiveWorkState.java:
##
@@ -337,8 +337,17 @@ synchronized v
damccorm commented on code in PR #32460:
URL: https://github.com/apache/beam/pull/32460#discussion_r1760416747
##
contributor-docs/discussion-docs/2016.md:
##
@@ -0,0 +1,55 @@
+
+
+# List Of Documents Submitted To d...@beam.apache.org In 2016
+| No. | Author | Subject | Date (UT
github-actions[bot] commented on PR #32463:
URL: https://github.com/apache/beam/pull/32463#issuecomment-2351807628
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @jrmccluskey for label python.
R: @chamikaramj for label io.
ahmedabu98 commented on PR #32367:
URL: https://github.com/apache/beam/pull/32367#issuecomment-2351786117
Thanks @damondouglas, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
ahmedabu98 commented on code in PR #32367:
URL: https://github.com/apache/beam/pull/32367#discussion_r1760324402
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowStringInterpolator.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
ahmedabu98 commented on code in PR #32367:
URL: https://github.com/apache/beam/pull/32367#discussion_r1760320003
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowStringInterpolator.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
ahmedabu98 commented on code in PR #32367:
URL: https://github.com/apache/beam/pull/32367#discussion_r1760318971
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowStringInterpolator.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
ahmedabu98 commented on code in PR #32367:
URL: https://github.com/apache/beam/pull/32367#discussion_r1760318534
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowStringInterpolator.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
ahmedabu98 commented on code in PR #32367:
URL: https://github.com/apache/beam/pull/32367#discussion_r1760316333
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowStringInterpolator.java:
##
@@ -0,0 +1,181 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
ahmedabu98 merged PR #32443:
URL: https://github.com/apache/beam/pull/32443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apac
ahmedabu98 commented on PR #31608:
URL: https://github.com/apache/beam/pull/31608#issuecomment-2351780201
Thanks for reviewing @scwhittle, @sjvanrossum
Can you take another look? If everything's good, I can merge this PR
--
This is an automated message from the Apache Git Service.
To r
ahmedabu98 commented on code in PR #31608:
URL: https://github.com/apache/beam/pull/31608#discussion_r1760315624
##
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PreparePubsubWriteDoFn.java:
##
@@ -175,6 +193,16 @@ public void process(
ahmedabu98 commented on code in PR #32366:
URL: https://github.com/apache/beam/pull/32366#discussion_r1760314125
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowFilter.java:
##
@@ -0,0 +1,347 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
ahmedabu98 commented on code in PR #32366:
URL: https://github.com/apache/beam/pull/32366#discussion_r1760310029
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowFilter.java:
##
@@ -0,0 +1,347 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
ahmedabu98 commented on code in PR #32366:
URL: https://github.com/apache/beam/pull/32366#discussion_r1760310029
##
sdks/java/core/src/main/java/org/apache/beam/sdk/util/RowFilter.java:
##
@@ -0,0 +1,347 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * o
ahmedabu98 commented on PR #32366:
URL: https://github.com/apache/beam/pull/32366#issuecomment-2351769761
@robertwb That makes sense, I can get behind that. We can always add more
complexity later if it becomes a big ask.
So what I'm hearing is we want to support keeping/dropping top-
iht commented on PR #32060:
URL: https://github.com/apache/beam/pull/32060#issuecomment-2351738514
Another round of commits just added, each commit should roughly correspond
to one of the resolved comments.
--
This is an automated message from the Apache Git Service.
To respond to the mes
iht commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1760247728
##
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/write/UnboundedBatchedSolaceWriter.java:
##
@@ -0,0 +1,177 @@
+/*
+ * Licensed to the Apache Software Foun
iht commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1760241993
##
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/SolaceIO.java:
##
@@ -1026,8 +1057,180 @@ abstract static class Builder {
@Override
public Sol
iht commented on code in PR #32060:
URL: https://github.com/apache/beam/pull/32060#discussion_r1760215957
##
sdks/java/io/solace/src/main/java/org/apache/beam/sdk/io/solace/broker/SessionService.java:
##
@@ -195,42 +221,49 @@ private static JCSMPProperties
overrideConnectorProp
github-actions[bot] commented on PR #32465:
URL: https://github.com/apache/beam/pull/32465#issuecomment-2351668755
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @m-trieu for label java.
R: @ahmedabu98 for label io.
Av
proost opened a new pull request, #32465:
URL: https://github.com/apache/beam/pull/32465
**Please** add a meaningful description for your change here
fix: https://github.com/apache/beam/issues/18027
adding validation to check topic exist or not for PubsubIO
--
github-actions[bot] commented on PR #31816:
URL: https://github.com/apache/beam/pull/31816#issuecomment-2351576846
This pull request has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any
time.
--
This is
github-actions[bot] closed pull request #31816: Update RowJsonUtils.java
URL: https://github.com/apache/beam/pull/31816
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
github-actions[bot] commented on PR #31783:
URL: https://github.com/apache/beam/pull/31783#issuecomment-2351576858
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull r
github-actions[bot] commented on PR #32464:
URL: https://github.com/apache/beam/pull/32464#issuecomment-2351465676
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @rszper for label website.
Available commands:
- `stop r
37 matches
Mail list logo
