Re: [I] [Feature Request]: Update Python JDBC write transforms to support configuring the batch size [beam]

2024-11-04 Thread via GitHub
chamikaramj commented on issue #32891: URL: https://github.com/apache/beam/issues/32891#issuecomment-2456282375 Absolutely. Thank you for looking into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Clean up logger handling for boot.go script in Python SDK [beam]

2024-11-04 Thread via GitHub
willvo2004 commented on PR #33015: URL: https://github.com/apache/beam/pull/33015#issuecomment-2456250434 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Clean up logger handling for boot.go script in Python SDK [beam]

2024-11-04 Thread via GitHub
willvo2004 commented on PR #33015: URL: https://github.com/apache/beam/pull/33015#issuecomment-2456232017 Failed Gradle tasks: Task :sdks:python:test-suites:tox:py39:testPy39CloudCoverage FAILED Task :sdks:go:goTest FAILED -- This is an automated message from the Apache Git Service.

Re: [I] [Feature Request]: Update Python JDBC write transforms to support configuring the batch size [beam]

2024-11-04 Thread via GitHub
mravi commented on issue #32891: URL: https://github.com/apache/beam/issues/32891#issuecomment-2456198213 @chamikaramj Can I take this issue ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Clean up logger handling for boot.go script in Python SDK [beam]

2024-11-04 Thread via GitHub
willvo2004 commented on PR #33015: URL: https://github.com/apache/beam/pull/33015#issuecomment-2456166109 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Clean up logger handling for boot.go script in Python SDK [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #33015: URL: https://github.com/apache/beam/pull/33015#issuecomment-2456162259 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

Re: [I] The PostCommit Python Arm job is flaky [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on issue #30760: URL: https://github.com/apache/beam/issues/30760#issuecomment-2456161744 Reopening since the workflow is still flaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [JdbcIO] Adding disableAutoCommit flag [beam]

2024-11-04 Thread via GitHub
Abacn commented on code in PR #32988: URL: https://github.com/apache/beam/pull/32988#discussion_r1828659455 ## sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java: ## @@ -799,6 +810,11 @@ public ReadRows withOutputParallelization(boolean outputParallelizatio

Re: [PR] [JdbcIO] Adding disableAutoCommit flag [beam]

2024-11-04 Thread via GitHub
Abacn commented on PR #32988: URL: https://github.com/apache/beam/pull/32988#issuecomment-2456120500 Does this also affect Jdbc write where it always set "setAutoCommit" also https://github.com/apache/beam/blob/14be0f6613b1454ddbbbe42e61883aa46573821b/sdks/java/io/jdbc/src/main/java/org/apac

Re: [PR] [JdbcIO] Adding disableAutoCommit flag [beam]

2024-11-04 Thread via GitHub
Abacn commented on code in PR #32988: URL: https://github.com/apache/beam/pull/32988#discussion_r1828654290 ## sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java: ## @@ -1575,10 +1629,15 @@ private Connection getConnection() throws SQLException { public

[PR] Clean up logger handling for boot.go script in Python SDK [beam]

2024-11-04 Thread via GitHub
willvo2004 opened a new pull request, #33015: URL: https://github.com/apache/beam/pull/33015 fixes #29819 Unsure if it is safe to add an accessor method within the buffer logger file. Otherwise the proposed changes addresses the issue and gradle build tests on the corresponding modul

Re: [I] [Feature Request]: Support draining Spanner Change Stream connectors [beam]

2024-11-04 Thread via GitHub
bangau1 commented on issue #30167: URL: https://github.com/apache/beam/issues/30167#issuecomment-2456082649 > > @Abacn I meant I cancelled it (stopped it), then proceed by submit a new pipeline with the same jobName and metadata table. But it returns error. > > It takes time to have j

[I] [Bug]: FlatMapTuple with certain callables can result in wrong type hints [beam]

2024-11-04 Thread via GitHub
hjtran opened a new issue, #33014: URL: https://github.com/apache/beam/issues/33014 ### What happened? I'm not exactly sure what the general condition is for this bug, but I have at least one pipeline where using `FlatMapTuple` with a lambda results in a weird output type hint that i

[PR] Add ability to encode and decode histogram data to portable runners [beam]

2024-11-04 Thread via GitHub
Naireen opened a new pull request, #33013: URL: https://github.com/apache/beam/pull/33013 Add ability to encode and decode histogram data to portable runners Thank you for your contribution! Follow this checklist to help us incorporate your contribution

Re: [PR] [JdbcIO] Adding disableAutoCommit flag [beam]

2024-11-04 Thread via GitHub
cwashcraft commented on code in PR #32988: URL: https://github.com/apache/beam/pull/32988#discussion_r1828558709 ## sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java: ## @@ -1575,10 +1629,15 @@ private Connection getConnection() throws SQLException { p

Re: [PR] [JdbcIO] Adding disableAutoCommit flag [beam]

2024-11-04 Thread via GitHub
cwashcraft commented on code in PR #32988: URL: https://github.com/apache/beam/pull/32988#discussion_r1828558709 ## sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java: ## @@ -1575,10 +1629,15 @@ private Connection getConnection() throws SQLException { p

[I] The PostCommit XVR Spark3 job is flaky [beam]

2024-11-04 Thread via GitHub
github-actions[bot] opened a new issue, #30602: URL: https://github.com/apache/beam/issues/30602 The PostCommit XVR Spark3 is failing over 50% of the time Please visit https://github.com/apache/beam/actions/workflows/beam_PostCommit_XVR_Spark3.yml?query=is%3Afailure+branch%3Amaster to s

Re: [I] The PostCommit XVR Spark3 job is flaky [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on issue #30602: URL: https://github.com/apache/beam/issues/30602#issuecomment-2455747738 Reopening since the workflow is still flaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] [Task]: Improve Enrichment docs [beam]

2024-11-04 Thread via GitHub
damccorm commented on issue #33012: URL: https://github.com/apache/beam/issues/33012#issuecomment-2455730343 @claudevdm this would be good to pick up at some point when you have space (don't drop other things, just when this fits in nicely) -- This is an automated message from the Apache

Re: [PR] Update code-change-guide.md [beam]

2024-11-04 Thread via GitHub
liferoad merged PR #33008: URL: https://github.com/apache/beam/pull/33008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [I] Apache Beam Java Lib and ANTLR [beam]

2024-11-04 Thread via GitHub
ygw commented on issue #32696: URL: https://github.com/apache/beam/issues/32696#issuecomment-2455694435 We are running into a similar issue where we have a 4.13 dependency elsewhere in our codebase, and now 4.7 through Beam. Can Beam upgrade to 4.13? -- This is an automated message from t

Re: [PR] Disable gradle cache for spark job server shadowjar [beam]

2024-11-04 Thread via GitHub
Abacn merged PR #33010: URL: https://github.com/apache/beam/pull/33010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

Re: [PR] Add Flush Interval to default Buffered Logger in Python boot.go [beam]

2024-11-04 Thread via GitHub
jrmccluskey commented on code in PR #33009: URL: https://github.com/apache/beam/pull/33009#discussion_r1828308962 ## sdks/python/container/boot.go: ## @@ -278,7 +280,7 @@ func launchSDKProcess() error { go func(workerId string) { defer wg.

Re: [PR] Disable gradle cache for spark job server shadowjar [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #33010: URL: https://github.com/apache/beam/pull/33010#issuecomment-2455573021 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] Disable gradle cache for spark job server shadowjar [beam]

2024-11-04 Thread via GitHub
Abacn commented on PR #33010: URL: https://github.com/apache/beam/pull/33010#issuecomment-2455569698 R: @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] Clean up creating StreamingWorkerHarness and dependencies [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #32982: URL: https://github.com/apache/beam/pull/32982#issuecomment-241793 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] Add Flush Interval to default Buffered Logger in Python boot.go [beam]

2024-11-04 Thread via GitHub
tvalentyn commented on code in PR #33009: URL: https://github.com/apache/beam/pull/33009#discussion_r1828283878 ## sdks/python/container/boot.go: ## @@ -278,7 +280,7 @@ func launchSDKProcess() error { go func(workerId string) { defer wg.Do

Re: [PR] Clean up creating StreamingWorkerHarness and dependencies [beam]

2024-11-04 Thread via GitHub
m-trieu commented on PR #32982: URL: https://github.com/apache/beam/pull/32982#issuecomment-2455549557 R: @arunpandianp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] bump hadoop version [beam]

2024-11-04 Thread via GitHub
Abacn opened a new pull request, #33011: URL: https://github.com/apache/beam/pull/33011 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [PR] Add Flush Interval to default Buffered Logger in Python boot.go [beam]

2024-11-04 Thread via GitHub
jrmccluskey commented on code in PR #33009: URL: https://github.com/apache/beam/pull/33009#discussion_r1828274508 ## sdks/python/container/boot.go: ## @@ -278,7 +280,7 @@ func launchSDKProcess() error { go func(workerId string) { defer wg.

Re: [PR] Add Flush Interval to default Buffered Logger in Python boot.go [beam]

2024-11-04 Thread via GitHub
tvalentyn commented on code in PR #33009: URL: https://github.com/apache/beam/pull/33009#discussion_r1828246943 ## sdks/python/container/boot.go: ## @@ -278,7 +280,7 @@ func launchSDKProcess() error { go func(workerId string) { defer wg.Do

Re: [I] Make cloudpickle the default pickle library [beam]

2024-11-04 Thread via GitHub
tvalentyn commented on issue #21298: URL: https://github.com/apache/beam/issues/21298#issuecomment-2455476062 Blocking issue has been resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add Flush Interval to default Buffered Logger in Python boot.go [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #33009: URL: https://github.com/apache/beam/pull/33009#issuecomment-2455489820 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @shunping for label python. Available commands: - `stop

Re: [PR] Add option to adjust ReadChangeStream API timeout to allow longer timeout for longer checkpoint durations [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #33001: URL: https://github.com/apache/beam/pull/33001#issuecomment-2455439297 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @Abacn for label java. R: @johnjcasey for label io. R: @muti

Re: [PR] Suppress errors in JvmInitializer#beforeProcessing if successfully initialized before [beam]

2024-11-04 Thread via GitHub
Abacn merged PR #32991: URL: https://github.com/apache/beam/pull/32991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

[PR] Disable gradle cache for spark job server shadowjar [beam]

2024-11-04 Thread via GitHub
Abacn opened a new pull request, #33010: URL: https://github.com/apache/beam/pull/33010 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

Re: [I] The PostCommit Java Avro Versions job is flaky [beam]

2024-11-04 Thread via GitHub
Abacn commented on issue #33007: URL: https://github.com/apache/beam/issues/33007#issuecomment-2455318677 looks like bad gradle cache again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Add option to adjust ReadChangeStream API timeout to allow longer timeout for longer checkpoint durations [beam]

2024-11-04 Thread via GitHub
tonytanger commented on code in PR #33001: URL: https://github.com/apache/beam/pull/33001#discussion_r1828132276 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java: ## @@ -2351,6 +2355,22 @@ public ReadChangeStream withBacklo

Re: [PR] [JdbcIO] Adding disableAutoCommit flag [beam]

2024-11-04 Thread via GitHub
Abacn commented on code in PR #32988: URL: https://github.com/apache/beam/pull/32988#discussion_r1828116072 ## sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java: ## @@ -1575,10 +1629,15 @@ private Connection getConnection() throws SQLException { public

Re: [PR] [JdbcIO] Adding disableAutoCommit flag [beam]

2024-11-04 Thread via GitHub
Abacn commented on code in PR #32988: URL: https://github.com/apache/beam/pull/32988#discussion_r1828116072 ## sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java: ## @@ -1575,10 +1629,15 @@ private Connection getConnection() throws SQLException { public

[PR] Add Flush Interval to default Buffered Logger in Python boot.go [beam]

2024-11-04 Thread via GitHub
jrmccluskey opened a new pull request, #33009: URL: https://github.com/apache/beam/pull/33009 Adds a default flush interval of 15 seconds to the Python container's boot.go to avoid logs being held until the job ends. Thank you for your contribution! Fo

Re: [PR] Distroless python sdk [beam]

2024-11-04 Thread via GitHub
Abacn commented on code in PR #32960: URL: https://github.com/apache/beam/pull/32960#discussion_r1828056327 ## sdks/python/test-suites/dataflow/common.gradle: ## @@ -380,6 +380,51 @@ task validatesContainer() { } } +/** + * Validates the distroless (https://github.com/Goo

Re: [PR] add generics support to AutoValueUtils helpers [beam]

2024-11-04 Thread via GitHub
tilgalas commented on PR #32977: URL: https://github.com/apache/beam/pull/32977#issuecomment-2455164733 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] add generics support to AutoValueUtils helpers [beam]

2024-11-04 Thread via GitHub
tilgalas commented on PR #32977: URL: https://github.com/apache/beam/pull/32977#issuecomment-2455164334 Run Java_IOs_Direct PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Remove extraneous/incorrect ValidatesRunner classification from examples unit tests [beam]

2024-11-04 Thread via GitHub
kennknowles merged PR #32910: URL: https://github.com/apache/beam/pull/32910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

Re: [I] [Feature Request]: Remove dependency of KafkaIO withDynamicRead on beam_fn_api [beam]

2024-11-04 Thread via GitHub
kennknowles commented on issue #29998: URL: https://github.com/apache/beam/issues/29998#issuecomment-2455152087 The way this should work is that the transform should expand for dynamic reads and the runner can say yes/no to whether it can execute it. We should definitely eliminate the `beam

Re: [PR] Bump Hadoop versions for compatibility test [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #32980: URL: https://github.com/apache/beam/pull/32980#issuecomment-2455080577 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] Bump Hadoop versions for compatibility test [beam]

2024-11-04 Thread via GitHub
Abacn commented on PR #32980: URL: https://github.com/apache/beam/pull/32980#issuecomment-2455077584 R: @ahmedabu98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Parsing location from HTTPError response instead of initiate a query [beam]

2024-11-04 Thread via GitHub
Abacn merged PR #32967: URL: https://github.com/apache/beam/pull/32967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.or

Re: [PR] Update code-change-guide.md [beam]

2024-11-04 Thread via GitHub
liferoad commented on code in PR #33008: URL: https://github.com/apache/beam/pull/33008#discussion_r1827963000 ## contributor-docs/code-change-guide.md: ## @@ -115,6 +115,8 @@ To run a Gradle task, use the command `./gradlew -p ` or th ./gradlew :sdks:java:harness:test ```

Re: [PR] Update code-change-guide.md [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #33008: URL: https://github.com/apache/beam/pull/33008#issuecomment-2455035938 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @johnjcasey added as fallback since no labels match configuration

Re: [I] [Feature Request]: Support draining Spanner Change Stream connectors [beam]

2024-11-04 Thread via GitHub
Abacn commented on issue #30167: URL: https://github.com/apache/beam/issues/30167#issuecomment-2455012677 > @Abacn I meant I cancelled it (stopped it), then proceed by submit a new pipeline with the same jobName and metadata table. But it returns error. It takes time to have job move

Re: [I] The PostCommit Python job is flaky [beam]

2024-11-04 Thread via GitHub
Abacn commented on issue #30513: URL: https://github.com/apache/beam/issues/30513#issuecomment-2455005910 > Looks like after sickbaying TensorRT tests, there are still failures. https://ge.apache.org/s/27igat7sfmcsu/console-log/task/:sdks:python:test-suites:portable:py310:portableWordCountSp

Re: [PR] Add option to adjust ReadChangeStream API timeout to allow longer timeout for longer checkpoint durations [beam]

2024-11-04 Thread via GitHub
jackdingilian commented on code in PR #33001: URL: https://github.com/apache/beam/pull/33001#discussion_r1827908791 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java: ## @@ -2351,6 +2355,22 @@ public ReadChangeStream withBac

Re: [PR] Update typecheck err msg [beam]

2024-11-04 Thread via GitHub
jrmccluskey merged PR #32880: URL: https://github.com/apache/beam/pull/32880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apa

Re: [PR] Update code-change-guide.md [beam]

2024-11-04 Thread via GitHub
Abacn commented on code in PR #33008: URL: https://github.com/apache/beam/pull/33008#discussion_r1827901655 ## contributor-docs/code-change-guide.md: ## @@ -115,6 +115,8 @@ To run a Gradle task, use the command `./gradlew -p ` or th ./gradlew :sdks:java:harness:test ``` +*

[PR] Update code-change-guide.md [beam]

2024-11-04 Thread via GitHub
liferoad opened a new pull request, #33008: URL: https://github.com/apache/beam/pull/33008 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

Re: [PR] Remove beam logging in playground for Python [beam]

2024-11-04 Thread via GitHub
liferoad merged PR #32740: URL: https://github.com/apache/beam/pull/32740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [I] [Bug]: OnnxModelHandlerNumpy broken with latest onnx version [beam]

2024-11-04 Thread via GitHub
gariepyalex commented on issue #32998: URL: https://github.com/apache/beam/issues/32998#issuecomment-2454819193 Wow thanks @damccorm for the fast fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [yaml] Add use cases for Enrichment transform in YAML [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #32289: URL: https://github.com/apache/beam/pull/32289#issuecomment-2454788932 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] [yaml] Add use cases for Enrichment transform in YAML [beam]

2024-11-04 Thread via GitHub
damccorm commented on PR #32289: URL: https://github.com/apache/beam/pull/32289#issuecomment-2454785864 R: @Polber @Polber @reeba212 what are next steps here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] [Task]: Update the minor version of protobuf library in the upper bound prior to Beam release. [beam]

2024-11-04 Thread via GitHub
damccorm closed issue #25590: [Task]: Update the minor version of protobuf library in the upper bound prior to Beam release. URL: https://github.com/apache/beam/issues/25590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [I] [Task]: Update the minor version of protobuf library in the upper bound prior to Beam release. [beam]

2024-11-04 Thread via GitHub
damccorm commented on issue #25590: URL: https://github.com/apache/beam/issues/25590#issuecomment-2454777368 We now support arbitrary 5.x versions (as of https://github.com/apache/beam/pull/32679) so we can close this -- This is an automated message from the Apache Git Service. To respond

Re: [I] The PreCommit YAML Xlang Direct job is flaky [beam]

2024-11-04 Thread via GitHub
damccorm closed issue #32603: The PreCommit YAML Xlang Direct job is flaky URL: https://github.com/apache/beam/issues/32603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Update typecheck err msg [beam]

2024-11-04 Thread via GitHub
hjtran commented on PR #32880: URL: https://github.com/apache/beam/pull/32880#issuecomment-2454740762 Bump @jrmccluskey (note, I'm away from computer for the month of November after today) -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] Remove beam logging in playground for Python [beam]

2024-11-04 Thread via GitHub
hjtran commented on PR #32740: URL: https://github.com/apache/beam/pull/32740#issuecomment-2454741303 Bump @liferoad (note, I'm away from computer for the month of November after today) -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [I] The PostCommit Python job is flaky [beam]

2024-11-04 Thread via GitHub
damccorm commented on issue #30513: URL: https://github.com/apache/beam/issues/30513#issuecomment-2454732214 Looks like after sickbaying TensorRT tests, there are still failures. https://ge.apache.org/s/27igat7sfmcsu/console-log/task/:sdks:python:test-suites:portable:py310:portableWordCountS

Re: [PR] add generics support to AutoValueUtils helpers [beam]

2024-11-04 Thread via GitHub
tilgalas commented on code in PR #32977: URL: https://github.com/apache/beam/pull/32977#discussion_r1827650827 ## sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/AutoValueUtils.java: ## @@ -70,45 +72,55 @@ /** Utilities for managing AutoValue schemas. */ @Suppre

Re: [PR] [yaml] Add use cases for Enrichment transform in YAML [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #32289: URL: https://github.com/apache/beam/pull/32289#issuecomment-2454561345 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm f

Re: [PR] Integrate direct path with StreamingDataflowWorker code path [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #32778: URL: https://github.com/apache/beam/pull/32778#issuecomment-2454561253 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @johnjcasey

Re: [PR] SolaceIO.Read: Make sure the messageReceiver is always initialized. [beam]

2024-11-04 Thread via GitHub
ppawel commented on PR #32964: URL: https://github.com/apache/beam/pull/32964#issuecomment-2454302827 > cc @ppawel - it would be great if you could test this fix. Thanks! OK, I will try to test it report back some time this week. Thanks for the fix. -- This is an automated message

Re: [PR] Add Managed Iceberg example [beam]

2024-11-04 Thread via GitHub
ahmedabu98 merged PR #32678: URL: https://github.com/apache/beam/pull/32678 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apac

Re: [PR] Add equals/hashcode to test data class to avoid direct runner coder warning [beam]

2024-11-04 Thread via GitHub
scwhittle commented on PR #32883: URL: https://github.com/apache/beam/pull/32883#issuecomment-2454223031 failures appear unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Add equals/hashcode to test data class to avoid direct runner coder warning [beam]

2024-11-04 Thread via GitHub
github-actions[bot] commented on PR #32883: URL: https://github.com/apache/beam/pull/32883#issuecomment-2454224118 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] Add equals/hashcode to test data class to avoid direct runner coder warning [beam]

2024-11-04 Thread via GitHub
scwhittle commented on PR #32883: URL: https://github.com/apache/beam/pull/32883#issuecomment-2454221661 R: @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Support poisioning instruction ids to prevent the FnApi data stream from blocking on failed instructions [beam]

2024-11-04 Thread via GitHub
scwhittle closed pull request #32857: Support poisioning instruction ids to prevent the FnApi data stream from blocking on failed instructions URL: https://github.com/apache/beam/pull/32857 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Changes to reduce memory pinned while iterating through state backed iterable [beam]

2024-11-04 Thread via GitHub
scwhittle closed pull request #32961: Changes to reduce memory pinned while iterating through state backed iterable URL: https://github.com/apache/beam/pull/32961 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab