Re: [PR] Honor JAVA_HOME when it is set [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34313: URL: https://github.com/apache/beam/pull/34313#issuecomment-2727167652 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label python. Available commands: - `stop

Re: [PR] [Java] Add Gauge Metric Extraction to DataflowMetrics [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34307: URL: https://github.com/apache/beam/pull/34307#issuecomment-2727153606 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] [Java] Add Gauge Metric Extraction to DataflowMetrics [beam]

2025-03-15 Thread via GitHub
Suvrat1629 commented on PR #34307: URL: https://github.com/apache/beam/pull/34307#issuecomment-2727153118 R: @rohitsinha54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] Honor JAVA_HOME when it is set [beam]

2025-03-15 Thread via GitHub
liferoad opened a new pull request, #34313: URL: https://github.com/apache/beam/pull/34313 Fix #21006 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropria

Re: [I] Update Python SDK example tests to use assert_that [beam]

2025-03-15 Thread via GitHub
liferoad commented on issue #18029: URL: https://github.com/apache/beam/issues/18029#issuecomment-2727116909 https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/cookbook/multiple_output_pardo_test.py Probably keeping the current code is good for now. We can alw

Re: [I] Update Python SDK example tests to use assert_that [beam]

2025-03-15 Thread via GitHub
liferoad closed issue #18029: Update Python SDK example tests to use assert_that URL: https://github.com/apache/beam/issues/18029 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [AnomalyDetection] Better type hinting in specifiable. [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34310: URL: https://github.com/apache/beam/pull/34310#issuecomment-2727114339 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] [AnomalyDetection] Better typehinting in specifiable. [beam]

2025-03-15 Thread via GitHub
shunping commented on PR #34310: URL: https://github.com/apache/beam/pull/34310#issuecomment-2727113869 r: @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] Add an experiment named enableLineageRollup which when passed to Java… [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34312: URL: https://github.com/apache/beam/pull/34312#issuecomment-2727107827 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [PR] Add an experiment named enableLineageRollup which when passed to Java… [beam]

2025-03-15 Thread via GitHub
rohitsinha54 commented on PR #34312: URL: https://github.com/apache/beam/pull/34312#issuecomment-2727107364 R: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Add an experiment named enableLineageRollup which when passed to Java… [beam]

2025-03-15 Thread via GitHub
rohitsinha54 opened a new pull request, #34312: URL: https://github.com/apache/beam/pull/34312 … SDK will make it report Lineage as BoundedTrie **Please** add a meaningful description for your change here Thank you for your contribution! Follow th

Re: [PR] [AnomalyDetection] Better typehinting in specifiable. [beam]

2025-03-15 Thread via GitHub
shunping commented on PR #34310: URL: https://github.com/apache/beam/pull/34310#issuecomment-2727042999 Run Python_Dataframes PreCommit 3.12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[PR] [AnomalyDetection] Support offline detectors [beam]

2025-03-15 Thread via GitHub
shunping opened a new pull request, #34311: URL: https://github.com/apache/beam/pull/34311 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

[PR] [AnomalyDetection] Better typehinting in specifiable. [beam]

2025-03-15 Thread via GitHub
shunping opened a new pull request, #34310: URL: https://github.com/apache/beam/pull/34310 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

Re: [I] GCS IO fails with uninformative 'Broken pipe' errors while attempting to write to a GCS bucket without proper permissions. [beam]

2025-03-15 Thread via GitHub
liferoad closed issue #19899: GCS IO fails with uninformative 'Broken pipe' errors while attempting to write to a GCS bucket without proper permissions. URL: https://github.com/apache/beam/issues/19899 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [I] GCS IO fails with uninformative 'Broken pipe' errors while attempting to write to a GCS bucket without proper permissions. [beam]

2025-03-15 Thread via GitHub
liferoad commented on issue #19899: URL: https://github.com/apache/beam/issues/19899#issuecomment-2727019145 Tested this with this using `gs://test`, which I do not have the access: ``` cd sdks/python pip install build && python -m build --sdist scripts/run_integration_test.sh --t

[PR] Add Offline Detectors [beam]

2025-03-15 Thread via GitHub
shunping opened a new pull request, #34309: URL: https://github.com/apache/beam/pull/34309 Support offline detectors that are based on ModelHandler. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] Log GCS upload ID for Python GCS connector [beam]

2025-03-15 Thread via GitHub
liferoad commented on issue #21577: URL: https://github.com/apache/beam/issues/21577#issuecomment-2726983578 https://github.com/apache/beam/issues/25676 switched to the gcs library. This probably logs this inside the library. Close this for now. -- This is an automated message from the A

Re: [I] Log GCS upload ID for Python GCS connector [beam]

2025-03-15 Thread via GitHub
liferoad closed issue #21577: Log GCS upload ID for Python GCS connector URL: https://github.com/apache/beam/issues/21577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [I] The StressTests Java BigQueryIO job is flaky [beam]

2025-03-15 Thread via GitHub
Amar3tto commented on issue #31968: URL: https://github.com/apache/beam/issues/31968#issuecomment-2726929272 Fixed by https://github.com/apache/beam/pull/34078 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] The StressTests Java BigQueryIO job is flaky [beam]

2025-03-15 Thread via GitHub
Amar3tto closed issue #31968: The StressTests Java BigQueryIO job is flaky URL: https://github.com/apache/beam/issues/31968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Java] Add Gauge Metric Extraction to DataflowMetrics [beam]

2025-03-15 Thread via GitHub
lostluck commented on PR #34307: URL: https://github.com/apache/beam/pull/34307#issuecomment-2726906977 assign to next reviewer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [Java] Add Gauge Metric Extraction to DataflowMetrics [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34307: URL: https://github.com/apache/beam/pull/34307#issuecomment-2726900386 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @lostluck added as fallback since no labels match configuration

Re: [PR] [DO NOT MERGE] Removed < 1.66 for grpcio [beam]

2025-03-15 Thread via GitHub
liferoad commented on PR #34196: URL: https://github.com/apache/beam/pull/34196#issuecomment-2726864670 https://github.com/apache/beam/actions/runs/13814130500/job/38824779287 also keeps failing. -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Remove a note about cloudpickle support being experimental [beam]

2025-03-15 Thread via GitHub
tvalentyn closed pull request #34199: Remove a note about cloudpickle support being experimental URL: https://github.com/apache/beam/pull/34199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] Fix Stress Tests Java Bigquery [beam]

2025-03-15 Thread via GitHub
damccorm commented on code in PR #34078: URL: https://github.com/apache/beam/pull/34078#discussion_r1993611275 ## it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/bigquery/BigQueryIOST.java: ## @@ -255,7 +257,9 @@ private void runTest() throws IOException {

Re: [PR] Factor out data file discovery. [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34238: URL: https://github.com/apache/beam/pull/34238#issuecomment-2712044243 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label python. Available commands: - `stop

Re: [PR] [AnomalyDetection] Add detectors and some necessary univariate trackers. [beam]

2025-03-15 Thread via GitHub
shunping commented on code in PR #34232: URL: https://github.com/apache/beam/pull/34232#discussion_r1987842803 ## sdks/python/apache_beam/ml/anomaly/detectors/robust_zscore.py: ## @@ -0,0 +1,119 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

Re: [PR] [Managed Iceberg] unbounded source [beam]

2025-03-15 Thread via GitHub
ahmedabu98 commented on code in PR #33504: URL: https://github.com/apache/beam/pull/33504#discussion_r1987873614 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergIO.java: ## @@ -310,7 +409,155 @@ * * * - * For internal use only; no backwards

Re: [PR] More precise binary operation inference. [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34305: URL: https://github.com/apache/beam/pull/34305#issuecomment-2726046159 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

[I] [Bug]: Python doc misses Copyright [beam]

2025-03-15 Thread via GitHub
liferoad opened a new issue, #34287: URL: https://github.com/apache/beam/issues/34287 ### What happened? https://beam.apache.org/releases/pydoc/current/apache_beam.transforms.core.html https://github.com/user-attachments/assets/c9c613c7-9cb3-4b68-9174-7762cad3cb50"; />

Re: [PR] Healthcare Label Update [beam]

2025-03-15 Thread via GitHub
svetakvsundhar commented on PR #34299: URL: https://github.com/apache/beam/pull/34299#issuecomment-2725578973 R: @liferoad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [AnomalyDetection] Support functions and classes as init arguments in specifiable. [beam]

2025-03-15 Thread via GitHub
shunping commented on PR #34273: URL: https://github.com/apache/beam/pull/34273#issuecomment-2723099684 > > Oh, please fix linting though > > Fixed. Waiting for the tests to finish. @damccorm, the tests are fine now. PTAL. Thanks! -- This is an automated message from the Apac

Re: [PR] Add sdf kafka poll latencies [beam]

2025-03-15 Thread via GitHub
Naireen commented on code in PR #34275: URL: https://github.com/apache/beam/pull/34275#discussion_r1996399018 ## sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java: ## @@ -454,7 +454,9 @@ public ProcessContinuation processElement( final S

[PR] [Java] Add Gauge Metric Extraction to DataflowMetrics [beam]

2025-03-15 Thread via GitHub
Suvrat1629 opened a new pull request, #34307: URL: https://github.com/apache/beam/pull/34307 **Please** add a meaningful description for your change here This PR addresses issue #33448, where gauge metrics were not being extracted into the metrics results i

Re: [PR] [DO NOT MERGE] Removed < 1.66 for grpcio [beam]

2025-03-15 Thread via GitHub
liferoad commented on PR #34196: URL: https://github.com/apache/beam/pull/34196#issuecomment-2726779979 `grpcio==1.71.0` seems not working well. many tests keep failing: https://github.com/apache/beam/actions/runs/13873590601/job/38823181322?pr=34196 -- This is an automated message from t

Re: [PR] Use individual windows rather than window sets in the combining table. [beam]

2025-03-15 Thread via GitHub
robertwb commented on code in PR #34193: URL: https://github.com/apache/beam/pull/34193#discussion_r1985471758 ## sdks/python/apache_beam/runners/worker/operations.py: ## @@ -1280,33 +1280,37 @@ def process(self, wkv): # pylint: disable=unidiomatic-typecheck # Opti

Re: [PR] Update allowed lateness in FixedWindows example to 2 days [beam]

2025-03-15 Thread via GitHub
liferoad commented on PR #34227: URL: https://github.com/apache/beam/pull/34227#issuecomment-2711343539 which python are you using? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [Java] Add InsertRetryPolicy for non-successful BigQuery insertAll responses [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34222: URL: https://github.com/apache/beam/pull/34222#issuecomment-2708788645 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

Re: [PR] Spark Runner : Fix invalid translateImpulse [beam]

2025-03-15 Thread via GitHub
twosom commented on PR #34272: URL: https://github.com/apache/beam/pull/34272#issuecomment-2719745586 Run Java Spark v3 PortableValidatesRunner Streaming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [Task]: Improve project documentation on apache-beam pypi page. [beam]

2025-03-15 Thread via GitHub
liferoad commented on issue #30145: URL: https://github.com/apache/beam/issues/30145#issuecomment-2724858384 Good idea. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[PR] Support functions and classes as init arguments in specifiable. [beam]

2025-03-15 Thread via GitHub
shunping opened a new pull request, #34273: URL: https://github.com/apache/beam/pull/34273 With this PR, we will now support generating Spec for a specifiable initialized with classes or functions as init arguments. -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] Fix cleanup timer timestamp to not exceed max allowed timestamp [beam]

2025-03-15 Thread via GitHub
kennknowles commented on code in PR #33037: URL: https://github.com/apache/beam/pull/33037#discussion_r1987545549 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/SimpleParDoFn.java: ## @@ -516,10 +520,14 @@ private void regist

Re: [PR] Refactor per worker histogram metrics [beam]

2025-03-15 Thread via GitHub
Naireen commented on PR #34244: URL: https://github.com/apache/beam/pull/34244#issuecomment-2720101993 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [Managed Iceberg] unbounded source [beam]

2025-03-15 Thread via GitHub
ahmedabu98 commented on code in PR #33504: URL: https://github.com/apache/beam/pull/33504#discussion_r1987743929 ## sdks/java/managed/src/main/java/org/apache/beam/sdk/managed/Managed.java: ## @@ -108,6 +110,7 @@ public class Managed { * * * {@link Managed#ICEBERG

Re: [PR] Fix test [beam]

2025-03-15 Thread via GitHub
claudevdm commented on PR #34162: URL: https://github.com/apache/beam/pull/34162#issuecomment-2703816929 Looks like the tests are all green @damccorm . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Clean up ExternalTransformRegistrar [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34237: URL: https://github.com/apache/beam/pull/34237#issuecomment-2711500128 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damondouglas for label java. Available commands: - `sto

Re: [PR] Implement ClickHouse Integration Testing Resource Manager [beam]

2025-03-15 Thread via GitHub
Abacn commented on PR #34230: URL: https://github.com/apache/beam/pull/34230#issuecomment-2711082480 Thank you for the contribution! Would you mind find a team member (for example, another contributor in ClickHouse) for first pass of review and I can help merging the change -- This is an

Re: [PR] Add sdf kafka poll latencies [beam]

2025-03-15 Thread via GitHub
scwhittle commented on code in PR #34275: URL: https://github.com/apache/beam/pull/34275#discussion_r1995479936 ## sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java: ## @@ -558,8 +560,8 @@ public ProcessContinuation processElement(

Re: [I] The PostCommit Python job is flaky [beam]

2025-03-15 Thread via GitHub
Amar3tto commented on issue #30513: URL: https://github.com/apache/beam/issues/30513#issuecomment-2724822414 Job has been stable for 1 day. Closing as resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[PR] More precise binary operation inference. [beam]

2025-03-15 Thread via GitHub
robertwb opened a new pull request, #34305: URL: https://github.com/apache/beam/pull/34305 Handle numeric promotion, sequence multiplication, and fix division for Python 3.11+. Thank you for your contribution! Follow this checklist to help us incorpora

Re: [PR] [Managed Iceberg] unbounded source [beam]

2025-03-15 Thread via GitHub
ahmedabu98 commented on code in PR #33504: URL: https://github.com/apache/beam/pull/33504#discussion_r1985714490 ## sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IncrementalScanSource.java: ## @@ -0,0 +1,163 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] refactor main.py so that it can be called by runner.run_async(). [beam]

2025-03-15 Thread via GitHub
robertwb merged PR #34290: URL: https://github.com/apache/beam/pull/34290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] Fix failing test: Add more time for grpc cleanup [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34180: URL: https://github.com/apache/beam/pull/34180#issuecomment-2703543445 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewer

Re: [I] [Bug]: typo in docs - Python Composition with AfterWatermark example [beam]

2025-03-15 Thread via GitHub
mataralhawiti commented on issue #34224: URL: https://github.com/apache/beam/issues/34224#issuecomment-2710580358 thanks @liferoad for the update, that's what I thought. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] Healthcare Label Update [beam]

2025-03-15 Thread via GitHub
svetakvsundhar opened a new pull request, #34299: URL: https://github.com/apache/beam/pull/34299 Remove `svetakvsundhar` as a healthcare reviewer assigned by the bot. Thank you for your contribution! Follow this checklist to help us incorporate you

Re: [PR] Fix pre/postprocess type hints [beam]

2025-03-15 Thread via GitHub
damccorm merged PR #34298: URL: https://github.com/apache/beam/pull/34298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] Precommit flink container 2 (PR for testing purposes) [beam]

2025-03-15 Thread via GitHub
akashorabek closed pull request #34229: Precommit flink container 2 (PR for testing purposes) URL: https://github.com/apache/beam/pull/34229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Update allowed lateness in FixedWindows example to 2 days [beam]

2025-03-15 Thread via GitHub
Brijeshthummar02 commented on PR #34227: URL: https://github.com/apache/beam/pull/34227#issuecomment-2711229200 @mataralhawiti just to mention i have used this to check ``` yapf --diff --parallel --recursive sdks/python/apache_beam ``` and this to automatically fix the formattin

Re: [PR] [Java] Added Metrics Configuration Support to Iceberg Data Writers [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34140: URL: https://github.com/apache/beam/pull/34140#issuecomment-2703671496 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damondouglas for label java. R: @chamikaramj for label io.

Re: [PR] Add support for collections.abc.Mapping [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34001: URL: https://github.com/apache/beam/pull/34001#issuecomment-2703679389 Reminder, please take a look at this pr: @liferoad -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [AnomalyDetection] Add main and auxiliary transforms. [beam]

2025-03-15 Thread via GitHub
shunping opened a new pull request, #34234: URL: https://github.com/apache/beam/pull/34234 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Update to latest bom [beam]

2025-03-15 Thread via GitHub
damccorm merged PR #34231: URL: https://github.com/apache/beam/pull/34231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

[PR] Clean up ExternalTransformRegistrar [beam]

2025-03-15 Thread via GitHub
Abacn opened a new pull request, #34237: URL: https://github.com/apache/beam/pull/34237 We don't need this after avro is fully moved out of sdks/java/core Resolve a TODO added in #25611 **Please** add a meaningful description for your change here

Re: [PR] Fix Docker dev environment set up [beam]

2025-03-15 Thread via GitHub
charlespnh commented on PR #34142: URL: https://github.com/apache/beam/pull/34142#issuecomment-2712506768 Here it is https://github.com/apache/beam/issues/34242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] Update allowed lateness in FixedWindows example to 2 days [beam]

2025-03-15 Thread via GitHub
Brijeshthummar02 commented on PR #34227: URL: https://github.com/apache/beam/pull/34227#issuecomment-2711287638 @liferoad your point makes sense, but what i think using ``` yapf --in-place --parallel --recursive sdks/python/apache_beam ``` will like format our whole repo that sho

Re: [PR] Revert Skip BoundedTrie on Dataflow till service is have BoundedTrie … [beam]

2025-03-15 Thread via GitHub
rohitsinha54 commented on PR #34294: URL: https://github.com/apache/beam/pull/34294#issuecomment-2724132667 This PR submission will start making the post submit Dataflow worker tests which exercises Dataflow runner test fails since the backend can accept BoundedTrie but cannot persist and s

Re: [PR] Bump google.golang.org/api from 0.221.0 to 0.223.0 in /sdks [beam]

2025-03-15 Thread via GitHub
dependabot[bot] commented on PR #34157: URL: https://github.com/apache/beam/pull/34157#issuecomment-2705519186 Superseded by #34203. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Clean up ExternalTransformRegistrar [beam]

2025-03-15 Thread via GitHub
Abacn commented on PR #34237: URL: https://github.com/apache/beam/pull/34237#issuecomment-2711784404 R: @claudevdm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[PR] Declare volitile to ExecutionStateTracker.nextBundleLullDurationReportMs [beam]

2025-03-15 Thread via GitHub
Abacn opened a new pull request, #34214: URL: https://github.com/apache/beam/pull/34214 in an attempt to fix "data race ExecutionStateTracker.java:261 in org.apache.beam.runners.core.metrics.ExecutionStateTracker.deactivate()V" reported by internal test (internal bug: 401543527) The

Re: [PR] docs: fix typo in snippets_test.py [beam]

2025-03-15 Thread via GitHub
liferoad merged PR #34297: URL: https://github.com/apache/beam/pull/34297 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [PR] do not block other threads from health checking if a stream is blocked [beam]

2025-03-15 Thread via GitHub
scwhittle commented on code in PR #34283: URL: https://github.com/apache/beam/pull/34283#discussion_r1995469504 ## runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/AbstractWindmillStream.java: ## @@ -236,14 +236,20 @

Re: [PR] Add Year and Apache Beam in Copyright [beam]

2025-03-15 Thread via GitHub
liferoad merged PR #34306: URL: https://github.com/apache/beam/pull/34306 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache

Re: [I] [Bug]: The submission_environment_dependencies.txt file does not get staged when running with Flink runner on Dataproc [beam]

2025-03-15 Thread via GitHub
liferoad commented on issue #32743: URL: https://github.com/apache/beam/issues/32743#issuecomment-2726579160 `ARTIFACTS_DIR` should accept the gs bucket. This is what we do with the Dataproc Flink cluster:https://github.com/apache/beam/blob/bef5238b76b6fe6c3c55be0926148f6b8dc5eb95/.test-inf

Re: [I] [Bug]: Python doc misses Copyright [beam]

2025-03-15 Thread via GitHub
liferoad closed issue #34287: [Bug]: Python doc misses Copyright URL: https://github.com/apache/beam/issues/34287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [PR] Add Year and Apache Beam in Copyright [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34306: URL: https://github.com/apache/beam/pull/34306#issuecomment-2726719249 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label python. Available commands: - `st

Re: [PR] Add Year and Apache Beam in Copyright [beam]

2025-03-15 Thread via GitHub
liferoad commented on PR #34306: URL: https://github.com/apache/beam/pull/34306#issuecomment-2726573979 Thanks for contributing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [I] [Bug]: Roadmap page is out of date. [beam]

2025-03-15 Thread via GitHub
liferoad commented on issue #28342: URL: https://github.com/apache/beam/issues/28342#issuecomment-2726576341 I think we can at least update these: Python 3 support: we already support Python 3.12 and sunset Python 3.8. Supporting 3.13 is on the roadmap. Java 17 support: this is

Re: [PR] [WIP] [Do not Merge] [Dataflow Streaming] Support for using virtual harness threads [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #33543: URL: https://github.com/apache/beam/pull/33543#issuecomment-2726498849 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull r

Re: [PR] Fix: Replace deprecated DataFrame.applymap with map for compatibility [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #33532: URL: https://github.com/apache/beam/pull/33532#issuecomment-2726498855 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull r

Re: [PR] BigQueryIO uniformize direct and export reads [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #32360: URL: https://github.com/apache/beam/pull/32360#issuecomment-2726482256 Reminder, please take a look at this pr: @robertwb @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Read RabbitMQ messages with headers containing nested objects [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #33072: URL: https://github.com/apache/beam/pull/33072#issuecomment-2726482252 Reminder, please take a look at this pr: @damondouglas @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [BEAM-6394] Add support to write protobuf data using ProtoParquetReader [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #34063: URL: https://github.com/apache/beam/pull/34063#issuecomment-2726482239 Reminder, please take a look at this pr: @kennknowles @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Support writing to Pubsub with ordering key; Add PubsubMessage SchemaCoder [beam]

2025-03-15 Thread via GitHub
github-actions[bot] commented on PR #31608: URL: https://github.com/apache/beam/pull/31608#issuecomment-2726482264 Reminder, please take a look at this pr: @kennknowles @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Healthcare Label Update [beam]

2025-03-15 Thread via GitHub
liferoad merged PR #34299: URL: https://github.com/apache/beam/pull/34299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache