TheNeuralBit commented on a change in pull request #11951:
URL: https://github.com/apache/beam/pull/11951#discussion_r436984551
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/bigquery/BigQueryTableProviderTest.java
##########
@@ -91,6 +94,16 @@ public void testSelectExportMethod() {
assertEquals(Method.EXPORT, sqlTable.method);
}
+ @Test
+ public void testSelectWriteDispositionMethod() {
+ Table table =
+ fakeTableWithProperties(
+ "hello", "{ " + WRITE_DISPOSITION_PROPERTY + ": " + "\"" +
WriteDisposition.WRITE_APPEND.toString() + "\" }");
+ BigQueryTable sqlTable = (BigQueryTable) provider.buildBeamSqlTable(table);
+
+ assertEquals(WriteDisposition.WRITE_APPEND, sqlTable.writeDisposition);
+ }
+
Review comment:
Could you add a test like this for EMPTY and TRUNCATE as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
