TheNeuralBit commented on a change in pull request #13341:
URL: https://github.com/apache/beam/pull/13341#discussion_r524484614
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1917,9 +1918,12 @@ def func(df, *args, **kwargs):
'__i%s__' % base,
frame_base._elementwise_method('__i%s__' % base, inplace=True))
-for name in ['__lt__', '__le__', '__gt__', '__ge__', '__eq__', '__ne__']:
- setattr(DeferredSeries, name, frame_base._elementwise_method(name))
- setattr(DeferredDataFrame, name, frame_base._elementwise_method(name))
+for name in ['lt', 'le', 'gt', 'ge', 'eq', 'ne']:
+ for p in '%s', '__%s__':
+ # Note that non-underscore name is used for both as the __xxx__ methods are
+ # order-sensitive.
Review comment:
That's odd. So I guess `series > other` will be one place where we
diverge from the Pandas API (in an easily documented way).
Is there a similar issue for arithmetic operations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
