subject:"\[GitHub\] \[beam\] TheNeuralBit commented on a change in pull request #13345\: \[BEAM\-4136\] Keep strong reference to loggers to avoid potential NPE"

[GitHub] [beam] TheNeuralBit commented on a change in pull request #13345: [BEAM-4136] Keep strong reference to loggers to avoid potential NPE

2020-11-16 Thread GitBox

TheNeuralBit commented on a change in pull request #13345: URL: https://github.com/apache/beam/pull/13345#discussion_r524431127 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java ## @@ -146,20 +147,25 @@ public void

[GitHub] [beam] TheNeuralBit commented on a change in pull request #13345: [BEAM-4136] Keep strong reference to loggers to avoid potential NPE

2020-11-13 Thread GitBox

TheNeuralBit commented on a change in pull request #13345: URL: https://github.com/apache/beam/pull/13345#discussion_r523336104 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/logging/BeamFnLoggingClientTest.java ## @@ -146,20 +147,25 @@ public void