TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655715080
Removing the ValueProvider line didn't actually break any Google tests, but
I lost my resolve to remove it. It seems likely it would break some untested
behavior, e.g.
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655207778
Oh I see now. I tried to fix this issue by adding `drop_defaults=true` but
we explicitly don't drop the default value for ValueProvider arguments:
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655192320
Looks like the CI failure is actually another flake due to BEAM-10006. It
can be replicated reliably locally with
```
$ pytest
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-649012660
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631673799
Ah yeah I could change the test to just verify the options that are being
set there (either by dropping default values in the get_all_options call, or by
adding explicit
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631661434
```
self =
def test_parse_pipeline_options(self):
expected_options = PipelineOptions([])
expected_options.view_as(
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631653792
Somehow this seems to introduce an additional flake in `SdkWorkerMainTest`.
I can't replicate it locally... I suspect it only occurs when pipeline options
get polluted from
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-631630548
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
