amaliujia commented on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-650489631
Run SQL_Java11 PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, p
amaliujia commented on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-650490127
@Imfuyuwei
Can you add a unit test to test `NULL` value?
This is an automated message from the Apache G
amaliujia commented on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-650588727
NULL value can be tested:
https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpec
amaliujia commented on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-650592810
Sometimes you might need a CAST though:
https://github.com/apache/beam/blob/master/sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/Zeta
amaliujia commented on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-650624450
The easiest way I know is to write a ParDo by your own, which
1. pass through elements.
2. but also save elements in a List.
So you can append this ParDo to the PCo
amaliujia commented on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-651418090
@Imfuyuwei
can you revert changes in `BeamBuiltinAggregations.java ` and
`BeamSqlDslAggregationTest.java`
-
