[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r456124634 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/SplittableParDoExpander.java ## @@ -273,4

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r454089322 ## File path: sdks/python/apache_beam/runners/worker/operations.py ## @@ -743,11 +743,36 @@ def pcollection_count_monitoring_infos(self,

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r454081616 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokersTest.java ## @@ -742,10 +785,202 @@ public void

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r454081206 ## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/reflect/DoFnInvokersTest.java ## @@ -742,10 +785,202 @@ public void

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r454077833 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java ## @@ -99,6 +99,24 @@ */ public

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r454073301 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java ## @@ -99,6 +99,24 @@ */ public

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r454070888 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java ## @@ -140,4 +140,15 @@ public

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r449736466 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py ## @@ -681,7 +681,21 @@ def input_for(self, transform_id,

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r449735426 ## File path: sdks/python/apache_beam/runners/worker/bundle_processor.py ## @@ -1079,6 +1079,13 @@ def construct_bundle_application(self,

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r449734236 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/reflect/DoFnInvoker.java ## @@ -95,7 +96,8 @@ void invokeOnTimer( void

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r448060178 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -320,6 +320,22 @@ def split_and_size(self, element, restriction): for part in

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447387903 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java ## @@ -99,6 +100,10 @@ */ public

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447337646 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -320,6 +320,22 @@ def split_and_size(self, element, restriction): for part in

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447331663 ## File path: sdks/python/apache_beam/transforms/core.py ## @@ -622,6 +638,16 @@ class DoFn(WithTypeHints, HasDisplayData, urns.RunnerApiFn): def

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447327762 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -829,6 +917,68 @@ private void

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447311084 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java ## @@ -99,6 +100,10 @@ */ public

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447281112 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java ## @@ -1051,7 +1092,7 @@ public Duration getAllowedTimestampSkew() {

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447275211 ## File path: runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java ## @@ -113,6 +113,8 @@

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447264730 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -574,6 +578,99 @@ public Instant timestamp(DoFn

[GitHub] [beam] boyuanzz commented on a change in pull request #12016: [BEAM-10341] Support drain in python and java SDF

boyuanzz commented on a change in pull request #12016: URL: https://github.com/apache/beam/pull/12016#discussion_r447263762 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java ## @@ -140,4 +140,9 @@ public