[GitHub] [beam] chamikaramj commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-12-14 Thread GitBox
chamikaramj commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-744944339 Allen, any updates ? Seems like there's a conflict to be resolved now. Feel free to close if this is no longer needed.

[GitHub] [beam] chamikaramj commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-689895432 Retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] chamikaramj commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-689895246 Allen, are you doing further updates here ? If not we can merge. This is an automated message from the Apache

[GitHub] [beam] chamikaramj commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-07-29 Thread GitBox
chamikaramj commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-665768931 @allenpradeep given that this seems to be a per-element change, have we done a performance analysis to confirm that there's won't be a significant performance degradation due