[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-09 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485891627 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -135,6 +135,16 @@ * ... * } * + * Reading wit

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-09 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485887994 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -135,6 +135,20 @@ * ... * } * + * Reading wit

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-09 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485779725 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -135,6 +135,16 @@ * ... * } * + * Reading wit

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485264309 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -194,6 +204,10 @@ public static ReadFiles readFiles

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485264174 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -299,9 +344,14 @@ public ReadFiles withSplit() {

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485264135 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -135,6 +135,16 @@ * ... * } * + * Reading wit

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485262811 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260498 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260498 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260306 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -336,36 +388,41 @@ public void processElement(

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-08 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485260041 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -312,12 +362,14 @@ public ReadFiles withSplit() {