[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426241932 ## File path: learning/katas/python/Windowing/Fixed Time Window/Fixed Time Window/task-info.yaml ## @@ -22,7 +22,7 @@ files: - name: task.py visible: true

[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426241264 ## File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task.py ## @@ -24,30 +25,30 @@ class Event: -def __init__(self, id, event, date):

[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426235990 ## File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task-info.yaml ## @@ -22,10 +22,10 @@ files: - name: task.py visible: true placehol

[GitHub] [beam] iht commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-17 Thread GitBox
iht commented on a change in pull request #11731: URL: https://github.com/apache/beam/pull/11731#discussion_r426235925 ## File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task.py ## @@ -16,6 +16,7 @@ import datetime import time Review comment: Done