[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-12 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-726414519 You can pass `-PskipCheckerFramework` as a workaround. So far I have not reproduced the problem on the bug.

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-12 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-726416118 But I would mention that is a real error. It should be suppressed at the class level until it can be fixed.

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-13 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-726932271 ``` git checkout github/master git merge github/pr/13311 ./gradlew -Ppublishing -PskipCheckerFramework -PjavaLinkageArtifactIds=beam-sdks-java-io-google-cloud-platfor

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-13 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-726933959 It seems that `sdks/java/build-tools/beam-linkage-check.sh` makes a number of assumptions about the state of the git repo so I cannot run it as simply as above. ---

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-13 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-727060096 I fixed it in https://github.com/apache/beam/pull/13342. With those changes I could run: /bin/bash sdks/java/build-tools/beam-linkage-check.sh github/master github

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-13 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-727060995 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-13 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-727080429 Is there a way to reproduce the NPE in a Beam test? This is an automated message from the Apache Git Service.

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-13 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-727080341 run java postcommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] kennknowles commented on pull request #13311: [BEAM-8889] Upgrade GCSIO to 2.1.6

2020-11-16 Thread GitBox
kennknowles commented on pull request #13311: URL: https://github.com/apache/beam/pull/13311#issuecomment-728345583 OK then I am happy to merge. It is an experiment and there are no linkage errors and existing tests pass. Th