[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-16 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r523124215 ## File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx_test.go ## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-13 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r523128139 ## File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx.go ## @@ -0,0 +1,181 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mo

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-13 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r523124215 ## File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx_test.go ## @@ -0,0 +1,166 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-12 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r522423683 ## File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx_test.go ## @@ -0,0 +1,165 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-12 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r522347395 ## File path: sdks/go/pkg/beam/core/metrics/metrics.go ## @@ -448,3 +453,116 @@ func (m *gauge) get() (int64, time.Time) { defer m.mu.Unlock()

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-12 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r522344928 ## File path: sdks/go/pkg/beam/core/monitoring/monitoring.go ## @@ -341,3 +343,189 @@ func int64Distribution(count, sum, min, max int64) ([]byte, error)

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-12 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r522330612 ## File path: sdks/go/pkg/beam/core/metrics/monitoring_infos.go ## @@ -0,0 +1,176 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-11 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r521706785 ## File path: sdks/go/pkg/beam/core/metrics/monitoring_infos.go ## @@ -0,0 +1,176 @@ +// Licensed to the Apache Software Foundation (ASF) under one or mor

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-11 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r521694702 ## File path: sdks/go/pkg/beam/core/monitoring/monitoring.go ## @@ -341,3 +343,189 @@ func int64Distribution(count, sum, min, max int64) ([]byte, error)

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-09 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r520070443 ## File path: sdks/go/pkg/beam/core/monitoring/monitoring.go ## @@ -13,10 +13,12 @@ // See the License for the specific language governing permissions an

[GitHub] [beam] lostluck commented on a change in pull request #13272: [BEAM-11207] Metric Extraction via proto RPC API

2020-11-09 Thread GitBox
lostluck commented on a change in pull request #13272: URL: https://github.com/apache/beam/pull/13272#discussion_r520036345 ## File path: sdks/go/pkg/beam/core/monitoring/monitoring.go ## @@ -13,10 +13,12 @@ // See the License for the specific language governing permissions an