[GitHub] [beam] lukecwik commented on a change in pull request #12089: [BEAM-10283] Add new overloads of withKeyRanges and withRowFilter met…

2020-07-06 Thread GitBox
lukecwik commented on a change in pull request #12089: URL: https://github.com/apache/beam/pull/12089#discussion_r450541065 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java ## @@ -410,13 +417,22 @@ public Read w

[GitHub] [beam] lukecwik commented on a change in pull request #12089: [BEAM-10283] Add new overloads of withKeyRanges and withRowFilter met…

2020-07-06 Thread GitBox
lukecwik commented on a change in pull request #12089: URL: https://github.com/apache/beam/pull/12089#discussion_r450541889 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableReadOptions.java ## @@ -0,0 +1,73 @@ +package

[GitHub] [beam] lukecwik commented on a change in pull request #12089: [BEAM-10283] Add new overloads of withKeyRanges and withRowFilter met…

2020-07-06 Thread GitBox
lukecwik commented on a change in pull request #12089: URL: https://github.com/apache/beam/pull/12089#discussion_r450541973 ## File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIOTest.java ## @@ -1100,7 +1141,7 @@ public vo

[GitHub] [beam] lukecwik commented on a change in pull request #12089: [BEAM-10283] Add new overloads of withKeyRanges and withRowFilter met…

2020-07-07 Thread GitBox
lukecwik commented on a change in pull request #12089: URL: https://github.com/apache/beam/pull/12089#discussion_r451120512 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java ## @@ -410,13 +417,22 @@ public Read w