[GitHub] [beam] lukecwik commented on pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

2020-07-08 Thread GitBox
lukecwik commented on pull request #12192: URL: https://github.com/apache/beam/pull/12192#issuecomment-655709449 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik commented on pull request #12192: [WIP][BEAM-10420] Migrate SDF logic into PerWindowInvoker

2020-07-07 Thread GitBox
lukecwik commented on pull request #12192: URL: https://github.com/apache/beam/pull/12192#issuecomment-655239038 R: @robertwb @chamikaramj Style-wise does it make sense to use the `kwargs` to pass these through or should I continue to make them explicit like the