[GitHub] [beam] lukecwik commented on pull request #12262: [BEAM-10491] Simplify PeriodicSequence generator to use OffsetRanges with whole whole numbers

2020-07-15 Thread GitBox
lukecwik commented on pull request #12262: URL: https://github.com/apache/beam/pull/12262#issuecomment-658980867 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] lukecwik commented on pull request #12262: [BEAM-10491] Simplify PeriodicSequence generator to use OffsetRanges with whole whole numbers

2020-07-15 Thread GitBox
lukecwik commented on pull request #12262: URL: https://github.com/apache/beam/pull/12262#issuecomment-658934055 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #12262: [BEAM-10491] Simplify PeriodicSequence generator to use OffsetRanges with whole whole numbers

2020-07-15 Thread GitBox
lukecwik commented on pull request #12262: URL: https://github.com/apache/beam/pull/12262#issuecomment-658805021 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on pull request #12262: [BEAM-10491] Simplify PeriodicSequence generator to use OffsetRanges with whole whole numbers

2020-07-14 Thread GitBox
lukecwik commented on pull request #12262: URL: https://github.com/apache/beam/pull/12262#issuecomment-658503845 R: @Ardagan @pabloem I wanted to simplify the existing implementation because users will look at existing code to see how to use it. Note that the tests won't pass with