[GitHub] [beam] pabloem commented on pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

2020-06-29 Thread GitBox
pabloem commented on pull request #11582: URL: https://github.com/apache/beam/pull/11582#issuecomment-651401099 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

2020-06-17 Thread GitBox
pabloem commented on pull request #11582: URL: https://github.com/apache/beam/pull/11582#issuecomment-645607827 Run Python 3.7 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

2020-06-16 Thread GitBox
pabloem commented on pull request #11582: URL: https://github.com/apache/beam/pull/11582#issuecomment-644919326 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

2020-06-15 Thread GitBox
pabloem commented on pull request #11582: URL: https://github.com/apache/beam/pull/11582#issuecomment-644418471 fyi Python precommit for 2.7 has been fixed only now. So the failure seems unrelated This is an automated

[GitHub] [beam] pabloem commented on pull request #11582: [BEAM-9650] Add ReadAllFromBigQuery PTransform

2020-04-30 Thread GitBox
pabloem commented on pull request #11582: URL: https://github.com/apache/beam/pull/11582#issuecomment-622092973 This is looking good. Something I think we should do is change the underlying implementation of ReadFromBigQuery ``` class ReadFromBQ: def expand(self):