piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-728248437
> Looks good, merging now. Thanks for all your work on this @piotr-szuberski
:)
Thank you too for your reviews! :)
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727154152
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727145037
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727022314
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-727010594
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726984319
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726976356
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726932495
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726829353
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726253827
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726125340
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726117163
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-726035603
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-723916260
@TheNeuralBit I promise that this is the last big review from me. I've just
recently realized how much work I've made you to do. Better late than never I
guess!
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-717413326
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-717339318
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-717285241
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-717282468
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-717180857
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-717180946
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-716890864
@TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-716871424
Run Website_Stage_GCS PreCommit
This is an automated message from the Apache Git Service.
To respond to
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-716871303
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-716839061
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-716801835
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-716740271
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-716736973
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-712244810
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-712094472
I've just run pydocs command and the generated html looks good.
This is an automated message from the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-710517731
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-710247484
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-710027902
I've solved the docs problem by making an annotation that modifies the
__doc__ property. I'm not sure whether it's a good solution (whether the users
using Beam will get
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-709965751
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-709461345
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-709456631
My greatest concern about current changes is that there is a lot of
duplicated docs and constructor parameters code.. I'm not sure if something can
be done. I've
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-704255878
@nielm Could you take a look at this thread?
https://github.com/apache/beam/pull/12611#discussion_r480429441
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-697267984
@TheNeuralBit @nielm @allenpradeep ping
This is an automated message from the Apache Git Service.
To
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-688837568
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-688837483
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-687192168
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-687192502
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-687108482
@chamikaramj Brian asked me to ask you for the further review as he is going
OOO this week.
I've changed the API of WriteToSpanner to use
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686576737
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686502850
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686493626
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686482934
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686475344
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686447747
@TheNeuralBit I've upgraded it a bit.
- Checking schemas equality is redundant because it will throw an exception
with a good message anyway (class cast failure or
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-686441745
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-677656948
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
50 matches
Mail list logo
