robertwb commented on a change in pull request #12857:
URL: https://github.com/apache/beam/pull/12857#discussion_r490019398
##########
File path: sdks/python/apache_beam/dataframe/doctests.py
##########
@@ -316,31 +354,39 @@ def run(self, test, **kwargs):
example.source = 'pass'
example.want = ''
self.skipped += 1
- elif example.exc_msg is None and any(
- wont_implement(example)
- for wont_implement in self._wont_implement_ok.get(test.name, [])):
+ elif example.exc_msg is None and self._is_wont_implement_ok(example,
+ test):
+ # Don't fail doctests that raise this error.
+ example.exc_msg = '%s: ...' % WONT_IMPLEMENT
+ elif example.exc_msg is None and self._is_not_implemented_ok(example,
Review comment:
What about doctests where both wont_implement_error and
not_implemented_ok are True? (On that note, since we're also handling name
errors, does the contents of this really matter anymore?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
