[GitHub] [beam] robertwb commented on pull request #25394: Validate that GBK coders are always set correctly.

2023-02-10 Thread via GitHub
robertwb commented on PR #25394: URL: https://github.com/apache/beam/pull/25394#issuecomment-1426530931 Looks like all the tests are passing. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] robertwb commented on pull request #25394: Validate that GBK coders are always set correctly.

2023-02-10 Thread via GitHub
robertwb commented on PR #25394: URL: https://github.com/apache/beam/pull/25394#issuecomment-1426166983 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] robertwb commented on pull request #25394: Validate that GBK coders are always set correctly.

2023-02-10 Thread via GitHub
robertwb commented on PR #25394: URL: https://github.com/apache/beam/pull/25394#issuecomment-1426166488 Precommit failed with "java.io.IOException: Backing channel 'apache-beam-jenkins-12' is disconnected." -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] robertwb commented on pull request #25394: Validate that GBK coders are always set correctly.

2023-02-10 Thread via GitHub
robertwb commented on PR #25394: URL: https://github.com/apache/beam/pull/25394#issuecomment-1426083073 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] robertwb commented on pull request #25394: Validate that GBK coders are always set correctly.

2023-02-09 Thread via GitHub
robertwb commented on PR #25394: URL: https://github.com/apache/beam/pull/25394#issuecomment-1424564680 Thanks for the error message fixes. I also found and fixed another case. As for redundancy, `group_by_key_input_visitor` is what coerces them, this is a check that in the end (at t

[GitHub] [beam] robertwb commented on pull request #25394: Validate that GBK coders are always set correctly.

2023-02-08 Thread via GitHub
robertwb commented on PR #25394: URL: https://github.com/apache/beam/pull/25394#issuecomment-1423451567 R: @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns