[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-12-04 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-739034628 Thanks a lot, @y1chi ! This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-12-04 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-738982545 Please fix YAPF. Thanks. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-12-03 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-738474225 > Whether cache is used in the docker build will be apparent in the build log. Agreed. However I currently build log shows only on error path. How about: we move the log lin

[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-12-01 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-736915744 > > Thanks. It seems that caching may improve the startup time, and be useful for users who frequently launch the same pipeline. However I think caching may result in a differe

[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-11-30 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-736125811 cc: @emilymye who may also have feedback. This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-11-30 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-736125575 Thanks. It seems that caching may improve the startup time, and be useful for users who frequently launch the same pipeline. However I think caching may result in a difference

[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-11-24 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-733432617 > friendly ping for review Thanks, I think I missed this PR. This is an automated message from the Apach

[GitHub] [beam] tvalentyn commented on pull request #13399: [BEAM-11312] Log cloud build url and enable kaniko cache in sdk_conta…

2020-11-24 Thread GitBox
tvalentyn commented on pull request #13399: URL: https://github.com/apache/beam/pull/13399#issuecomment-733432328 Could you please add some details to the PR description about Kaniko and why are we want to use it? Thanks. Th