[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-02-08 Thread via GitHub
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1422923669 Ok, this should now be ready for review, @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-02-07 Thread via GitHub
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1421713771 Also bumping up lower bounds for pyarrow, for similar reason. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-02-06 Thread via GitHub
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1419982350 note that pandas==1.4.3 is not available on Python 3.7, but neither is numpy==1.24.x. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-02-06 Thread via GitHub
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1419976468 > Pandas 1.1.x issue is reproducible in: `import pandas as pd; pd.DataFrame(columns=pd.CategoricalIndex(['A'], dtype='category'), dtype='int64')` , so bumping pandas is appropriate.

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-02-06 Thread via GitHub
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1419956971 Pandas 1.1.x issue is reproducible in: `pd.DataFrame(columns=pd.CategoricalIndex(['A'], dtype='category'), dtype='int64')` , so bumping pandas is appropriate. -- This is an automated

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-02-06 Thread via GitHub
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1419591165 > needs one more patch... PAIR-code/facets#251 should be released now. One more issue. Looks like some DF tests fail with pandas 1.11. The bug seems to be in Pandas 1.11, th

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-01-30 Thread via GitHub
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1409444550 > Interactive runner tests need a release from facets-overview: https://github.com/PAIR-code/facets/pull/250 This has been done -- This is an automated message from the Apache G

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-01-19 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1397873408 Dataframes (ParquetIO) test requires numpy<1.20.0, this is a preexisting issue: https://github.com/apache/beam/blob/428ec97e30cc6587c2ae0f81d3ba44a8a9b34f93/sdks/python/tox.ini#L286 , a

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-01-19 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1397824135 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-01-19 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1397814614 Interactive runner tests need a fix in facets-overview: https://github.com/PAIR-code/facets/pull/250 -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2023-01-19 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1397813354 cc: @jli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-22 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1362732587 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-21 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1361893115 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-21 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1361650325 thanks. that's WAI. Bot sent it for review too early. I have intentionally temporarily increased the lower bound temporarily to have a meaningful postcommit signal in https://ci-beam.ap

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-21 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1361290488 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-20 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1359452602 Rootcause tracked in: https://github.com/NVIDIA/TensorRT/issues/2557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-20 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1359435931 Another issue: ``` 10:41:08 Traceback (most recent call last): 10:41:08 File "apache_beam/runners/common.py", line 1465, in apache_beam.runners.common.DoFnRunner._invoke_lifec

[GitHub] [beam] tvalentyn commented on pull request #24725: Update upper bound for numpy.

2022-12-20 Thread GitBox
tvalentyn commented on PR #24725: URL: https://github.com/apache/beam/pull/24725#issuecomment-1359064857 Run Python 3.8 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com