[GitHub] [beam] henryken commented on pull request #11806: [BEAM-9679] Flatten Kata for Go

2020-05-29 Thread GitBox
henryken commented on pull request #11806: URL: https://github.com/apache/beam/pull/11806#issuecomment-63589 Yes it is correct @damondouglas. This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] henryken commented on pull request #11803: [BEAM-9679] Add a CoGroupByKey lesson to the Core Transforms section

2020-05-29 Thread GitBox
henryken commented on pull request #11803: URL: https://github.com/apache/beam/pull/11803#issuecomment-635811715 Thanks @damondouglas! This PR can be merged now. This is an automated message from the Apache Git Service. To re

[GitHub] [beam] mwalenia commented on pull request #11331: [BEAM-9646] Add Google Cloud vision integration transform

2020-05-29 Thread GitBox
mwalenia commented on pull request #11331: URL: https://github.com/apache/beam/pull/11331#issuecomment-635824527 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] mwalenia commented on pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-29 Thread GitBox
mwalenia commented on pull request #11566: URL: https://github.com/apache/beam/pull/11566#issuecomment-635824470 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] iemejia removed a comment on pull request #11855: [BEAM-10005] | combinefn for ApproximateQuantiles and ApproximateUnique

2020-05-29 Thread GitBox
iemejia removed a comment on pull request #11855: URL: https://github.com/apache/beam/pull/11855#issuecomment-635844667 retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] iemejia commented on pull request #11855: [BEAM-10005] | combinefn for ApproximateQuantiles and ApproximateUnique

2020-05-29 Thread GitBox
iemejia commented on pull request #11855: URL: https://github.com/apache/beam/pull/11855#issuecomment-635844667 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] aromanenko-dev merged pull request #11848: [BEAM-9916] Fixed some IO Urls on website

2020-05-29 Thread GitBox
aromanenko-dev merged pull request #11848: URL: https://github.com/apache/beam/pull/11848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] iemejia commented on pull request #11780: [BEAM-9948] Uploading mascot to the website

2020-05-29 Thread GitBox
iemejia commented on pull request #11780: URL: https://github.com/apache/beam/pull/11780#issuecomment-635865071 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] mwalenia commented on pull request #11331: [BEAM-9646] Add Google Cloud vision integration transform

2020-05-29 Thread GitBox
mwalenia commented on pull request #11331: URL: https://github.com/apache/beam/pull/11331#issuecomment-635867331 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] mwalenia commented on pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-29 Thread GitBox
mwalenia commented on pull request #11566: URL: https://github.com/apache/beam/pull/11566#issuecomment-635867251 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] kamilwu commented on a change in pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on a change in pull request #11661: URL: https://github.com/apache/beam/pull/11661#discussion_r432361075 ## File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_Performance_Tests.json ## @@ -0,0 +1,297 @@ +{ Review comment: Yes,

[GitHub] [beam] kamilwu commented on a change in pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on a change in pull request #11661: URL: https://github.com/apache/beam/pull/11661#discussion_r432364827 ## File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_Performance_Tests.json ## @@ -77,7 +77,7 @@ ], "orderB

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-05-29 Thread GitBox
kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-635890295 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] kamilwu opened a new pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-05-29 Thread GitBox
kamilwu opened a new pull request #11856: URL: https://github.com/apache/beam/pull/11856 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://be

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-05-29 Thread GitBox
kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-635895300 Run Python Load Tests SideInput Dataflow Batch This is an automated message from the Apache Git Service. To respo

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432407631 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/package-info.java ## @@ -0,0 +1,2 @@ +/** Snowflake IO servi

[GitHub] [beam] kamilwu edited a comment on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform

2020-05-29 Thread GitBox
kamilwu edited a comment on pull request #11776: URL: https://github.com/apache/beam/pull/11776#issuecomment-635908932 @lakshmanok Do you mean the response object returned from the API? If so, tt would look like this: ``` sentences { text { content: "My experience so f

[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform

2020-05-29 Thread GitBox
kamilwu commented on pull request #11776: URL: https://github.com/apache/beam/pull/11776#issuecomment-635908932 @lakshmanok Do you mean the response object returned from the API? If so, tt would look like this: ``` sentences { text { content: "My experience so far has

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432407862 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/enums/package-info.java ## @@ -0,0 +1,2 @@ +/** Snowflake IO data typ

[GitHub] [beam] kamilwu edited a comment on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform

2020-05-29 Thread GitBox
kamilwu edited a comment on pull request #11776: URL: https://github.com/apache/beam/pull/11776#issuecomment-635908932 @lakshmanok Do you mean the response object returned from the API? If so, it would look like this: ``` sentences { text { content: "My experience so f

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432409517 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakePipelineOptions.java ## @@ -111,23 +111,13 @@ void setL

[GitHub] [beam] piotr-szuberski commented on a change in pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
piotr-szuberski commented on a change in pull request #11661: URL: https://github.com/apache/beam/pull/11661#discussion_r432409480 ## File path: .test-infra/metrics/grafana/dashboards/perftests_metrics/Python_Performance_Tests.json ## @@ -77,7 +77,7 @@ ],

[GitHub] [beam] piotr-szuberski commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
piotr-szuberski commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-635910908 @tvalentyn @kamilwu I changed the metric name to 'runtime' and cleared up the commit history. This is a

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432412298 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432413521 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] mwalenia commented on pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-29 Thread GitBox
mwalenia commented on pull request #11566: URL: https://github.com/apache/beam/pull/11566#issuecomment-635917868 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] mwalenia commented on pull request #11331: [BEAM-9646] Add Google Cloud vision integration transform

2020-05-29 Thread GitBox
mwalenia commented on pull request #11331: URL: https://github.com/apache/beam/pull/11331#issuecomment-635917920 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] kamilwu commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-635922165 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] kamilwu commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-635922568 Retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] kamilwu removed a comment on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu removed a comment on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-635922165 Retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] kamilwu commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-635922817 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432423695 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -257,23 +301,12 @@ } /** - * N

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432412298 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432427386 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432427386 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432427386 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432427386 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432429729 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -447,6 +494,346 @@ public void populateDisplay

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432432306 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -447,6 +494,346 @@ public void populateDisplay

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432437111 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -339,10 +360,31 @@ emptyCollection

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432437111 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -339,10 +360,31 @@ emptyCollection

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432427386 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432429729 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -447,6 +494,346 @@ public void populateDisplay

[GitHub] [beam] mwalenia commented on pull request #11331: [BEAM-9646] Add Google Cloud vision integration transform

2020-05-29 Thread GitBox
mwalenia commented on pull request #11331: URL: https://github.com/apache/beam/pull/11331#issuecomment-635941924 The flakes in Java PreCommit are killing me :( This is an automated message from the Apache Git Service. To resp

[GitHub] [beam] mwalenia commented on pull request #11331: [BEAM-9646] Add Google Cloud vision integration transform

2020-05-29 Thread GitBox
mwalenia commented on pull request #11331: URL: https://github.com/apache/beam/pull/11331#issuecomment-635941816 run java precommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] echauchot commented on a change in pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on a change in pull request #11732: URL: https://github.com/apache/beam/pull/11732#discussion_r432453437 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -330,6 +331,24 @@ private CassandraIO() {}

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432453524 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/Location.java ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] echauchot commented on a change in pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on a change in pull request #11732: URL: https://github.com/apache/beam/pull/11732#discussion_r432453785 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -330,6 +331,24 @@ private CassandraIO() {}

[GitHub] [beam] echauchot commented on a change in pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on a change in pull request #11732: URL: https://github.com/apache/beam/pull/11732#discussion_r432455805 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -330,6 +331,24 @@ private CassandraIO() {}

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432456811 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -339,10 +360,31 @@ emptyCollection

[GitHub] [beam] echauchot commented on a change in pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on a change in pull request #11732: URL: https://github.com/apache/beam/pull/11732#discussion_r432453437 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -330,6 +331,24 @@ private CassandraIO() {}

[GitHub] [beam] echauchot commented on a change in pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on a change in pull request #11732: URL: https://github.com/apache/beam/pull/11732#discussion_r432455805 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -330,6 +331,24 @@ private CassandraIO() {}

[GitHub] [beam] purbanow commented on a change in pull request #11794: [BEAM-9894] Add batch SnowflakeIO.Write to Java SDK

2020-05-29 Thread GitBox
purbanow commented on a change in pull request #11794: URL: https://github.com/apache/beam/pull/11794#discussion_r432458477 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -447,6 +494,346 @@ public void populateDisplay

[GitHub] [beam] kamilwu commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-635954344 @piotr-szuberski There is a problem with `preCommitIT_streaming` and `preCommitIT_batch` tasks. Could you take a look? And one more thing: because you are going to remove

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-05-29 Thread GitBox
kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-635954578 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] echauchot commented on a change in pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on a change in pull request #11732: URL: https://github.com/apache/beam/pull/11732#discussion_r432461930 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -1116,6 +1163,18 @@ private static Cluster ge

[GitHub] [beam] echauchot commented on pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on pull request #11732: URL: https://github.com/apache/beam/pull/11732#issuecomment-635960916 @nfisher reviewed your last changes, only missing last small changes: please rely on un-resolved conversations

[GitHub] [beam] kamilwu commented on pull request #11856: [BEAM-7505] SideInput Python Load Test job

2020-05-29 Thread GitBox
kamilwu commented on pull request #11856: URL: https://github.com/apache/beam/pull/11856#issuecomment-635966723 @tysonjh Could you take a look? I managed to set up six side input tests. Here's a list: ``` 2gb-1kb-5workers-1window-1key-percent-dict 2gb-1kb-5workers-1window-99k

[GitHub] [beam] echauchot commented on pull request #11732: [BEAM-10017] Expose Cassandra Connect and Read timeouts

2020-05-29 Thread GitBox
echauchot commented on pull request #11732: URL: https://github.com/apache/beam/pull/11732#issuecomment-635975058 @nfisher also run spotless task to fix format violations This is an automated message from the Apache Git Servi

[GitHub] [beam] darshanj commented on pull request #11855: [BEAM-10005] | combinefn for ApproximateQuantiles and ApproximateUnique

2020-05-29 Thread GitBox
darshanj commented on pull request #11855: URL: https://github.com/apache/beam/pull/11855#issuecomment-635981947 Looks like test is failing which is not related: org.apache.beam.sdk.transforms.ParDoLifecycleTest.testTeardownCalledAfterExceptionInProcessElementStateful May be rerun che

[GitHub] [beam] dmvk opened a new pull request #11857: [BEAM-8850,BEAM-8849] FlinkBatchTranslationContext respects input par…

2020-05-29 Thread GitBox
dmvk opened a new pull request #11857: URL: https://github.com/apache/beam/pull/11857 Preparation for https://issues.apache.org/jira/browse/BEAM-8848 This PR covers: https://issues.apache.org/jira/browse/BEAM-8849 https://issues.apache.org/jira/browse/BEAM-8850 --

[GitHub] [beam] piotr-szuberski commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
piotr-szuberski commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-636017228 > @piotr-szuberski There is a problem with `preCommitIT_streaming` and `preCommitIT_batch` tasks. Could you take a look? > > And one more thing: because you are goi

[GitHub] [beam] piotr-szuberski edited a comment on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
piotr-szuberski edited a comment on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-636017228 > @piotr-szuberski There is a problem with `preCommitIT_streaming` and `preCommitIT_batch` tasks. Could you take a look? > > And one more thing: because you

[GitHub] [beam] dmvk commented on pull request #11857: [BEAM-8850,BEAM-8849] FlinkBatchTranslationContext respects input par…

2020-05-29 Thread GitBox
dmvk commented on pull request #11857: URL: https://github.com/apache/beam/pull/11857#issuecomment-636018589 Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] lukecwik commented on pull request #11821: [BEAM-10097, BEAM-5982, BEAM-3080] Use primitive views directly instead of transforming KV> to the view type via a naive ma

2020-05-29 Thread GitBox
lukecwik commented on pull request #11821: URL: https://github.com/apache/beam/pull/11821#issuecomment-636027113 Existing spark failure is due to BEAM-10024 This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] piotr-szuberski edited a comment on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
piotr-szuberski edited a comment on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-636017228 > @piotr-szuberski There is a problem with `preCommitIT_streaming` and `preCommitIT_batch` tasks. Could you take a look? > > And one more thing: because you

[GitHub] [beam] lakshmanok commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform

2020-05-29 Thread GitBox
lakshmanok commented on pull request #11776: URL: https://github.com/apache/beam/pull/11776#issuecomment-636037842 Kamil, Yes, exactly. On Fri, May 29, 2020, 3:53 AM Kamil Wasilewski wrote: > @lakshmanok Do you mean the response > object r

[GitHub] [beam] dmvk commented on pull request #11857: [BEAM-8850,BEAM-8849] FlinkBatchTranslationContext respects input par…

2020-05-29 Thread GitBox
dmvk commented on pull request #11857: URL: https://github.com/apache/beam/pull/11857#issuecomment-636043662 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] TheNeuralBit merged pull request #11854: [BEAM-8019] Cherry pick 11844

2020-05-29 Thread GitBox
TheNeuralBit merged pull request #11854: URL: https://github.com/apache/beam/pull/11854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] dmvk opened a new pull request #11858: [BEAM-8608] Chain DoFns in Flink batch runner when possible.

2020-05-29 Thread GitBox
dmvk opened a new pull request #11858: URL: https://github.com/apache/beam/pull/11858 https://issues.apache.org/jira/browse/BEAM-8608 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] chamikaramj commented on pull request #11854: [BEAM-8019] Cherry pick 11844

2020-05-29 Thread GitBox
chamikaramj commented on pull request #11854: URL: https://github.com/apache/beam/pull/11854#issuecomment-636045979 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] TheNeuralBit merged pull request #11814: [BEAM-10078] uniquify Dataflow specific jars when staging

2020-05-29 Thread GitBox
TheNeuralBit merged pull request #11814: URL: https://github.com/apache/beam/pull/11814 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] dmvk commented on pull request #11858: [BEAM-8608] Chain DoFns in Flink batch runner when possible.

2020-05-29 Thread GitBox
dmvk commented on pull request #11858: URL: https://github.com/apache/beam/pull/11858#issuecomment-636047529 Run Flink ValidatesRunner This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] TheNeuralBit opened a new pull request #11859: [BEAM-10078][release-2.22.0] uniquify Dataflow specific jars when staging

2020-05-29 Thread GitBox
TheNeuralBit opened a new pull request #11859: URL: https://github.com/apache/beam/pull/11859 Cherrypick of #11814 R: @ihji @chamikaramj Post-Commit Tests Status (on master branch) ---

[GitHub] [beam] chamikaramj commented on pull request #11859: [BEAM-10078][release-2.22.0] uniquify Dataflow specific jars when staging

2020-05-29 Thread GitBox
chamikaramj commented on pull request #11859: URL: https://github.com/apache/beam/pull/11859#issuecomment-636048991 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] kamilwu commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-636051928 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] kamilwu removed a comment on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu removed a comment on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-636051928 Retest this please This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] kamilwu commented on pull request #11661: [BEAM-7774] Remove perfkit benchmarking tool from python performance …

2020-05-29 Thread GitBox
kamilwu commented on pull request #11661: URL: https://github.com/apache/beam/pull/11661#issuecomment-636053560 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] TheNeuralBit commented on a change in pull request #11852: [BEAM-10107] Remove outdated instructions for website updates in rele…

2020-05-29 Thread GitBox
TheNeuralBit commented on a change in pull request #11852: URL: https://github.com/apache/beam/pull/11852#discussion_r432593273 ## File path: website/www/site/content/en/contribute/release-guide.md ## @@ -686,14 +682,12 @@ branch. **PR 2: apache/beam** -This pull request i

[GitHub] [beam] kamilwu commented on pull request #11776: [BEAM-9421] Better documentation of output results from AnnotateText transform

2020-05-29 Thread GitBox
kamilwu commented on pull request #11776: URL: https://github.com/apache/beam/pull/11776#issuecomment-636067245 I have added that. Please take a look, the link is the same. This is an automated message from the Apache Git Ser

[GitHub] [beam] robertwb opened a new pull request #11860: [BEAM-10122] Remove obstruction from using RowCoder on Dataflow.

2020-05-29 Thread GitBox
robertwb opened a new pull request #11860: URL: https://github.com/apache/beam/pull/11860 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] ibzib commented on a change in pull request #11852: [BEAM-10107] Remove outdated instructions for website updates in rele…

2020-05-29 Thread GitBox
ibzib commented on a change in pull request #11852: URL: https://github.com/apache/beam/pull/11852#discussion_r432606801 ## File path: website/www/site/content/en/contribute/release-guide.md ## @@ -686,14 +682,12 @@ branch. **PR 2: apache/beam** -This pull request is again

[GitHub] [beam] TheNeuralBit commented on pull request #11860: [BEAM-10122] Remove obstruction from using RowCoder on Dataflow.

2020-05-29 Thread GitBox
TheNeuralBit commented on pull request #11860: URL: https://github.com/apache/beam/pull/11860#issuecomment-636072770 This is the same as #11839 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [beam] TheNeuralBit merged pull request #11852: [BEAM-10107] Remove outdated instructions for website updates in rele…

2020-05-29 Thread GitBox
TheNeuralBit merged pull request #11852: URL: https://github.com/apache/beam/pull/11852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] TheNeuralBit commented on pull request #11841: [BEAM-10121] Python RowCoder doesn't support nested structs

2020-05-29 Thread GitBox
TheNeuralBit commented on pull request #11841: URL: https://github.com/apache/beam/pull/11841#issuecomment-636076249 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] robertwb merged pull request #11839: [BEAM-10122] Python RowCoder throws NotImplementedError in DataflowRunner

2020-05-29 Thread GitBox
robertwb merged pull request #11839: URL: https://github.com/apache/beam/pull/11839 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] TheNeuralBit merged pull request #11859: [BEAM-10078][release-2.22.0] uniquify Dataflow specific jars when staging

2020-05-29 Thread GitBox
TheNeuralBit merged pull request #11859: URL: https://github.com/apache/beam/pull/11859 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] TheNeuralBit commented on pull request #11859: [BEAM-10078][release-2.22.0] uniquify Dataflow specific jars when staging

2020-05-29 Thread GitBox
TheNeuralBit commented on pull request #11859: URL: https://github.com/apache/beam/pull/11859#issuecomment-636083653 The only failure is the VideoIntelligenceIT known flake. Merging this now This is an automated message from

[GitHub] [beam] pabloem commented on pull request #11849: [BEAM-9964] Move workerCacheMb to a user-visible place

2020-05-29 Thread GitBox
pabloem commented on pull request #11849: URL: https://github.com/apache/beam/pull/11849#issuecomment-636084490 Just a question - I am a little confused. How come the `DataflowPipelineDebugOptions` class is visible, but `DataflowWorkerHarnessOptions` isn't? If you inherit from it, shouldn'

[GitHub] [beam] TheNeuralBit opened a new pull request #11861: [BEAM-10122][release-2.22.0] Cherrypick #11839

2020-05-29 Thread GitBox
TheNeuralBit opened a new pull request #11861: URL: https://github.com/apache/beam/pull/11861 R: @robertwb Post-Commit Tests Status (on master branch) Lang | SDK | Apex | Dataf

[GitHub] [beam] steveniemitz commented on pull request #11849: [BEAM-9964] Move workerCacheMb to a user-visible place

2020-05-29 Thread GitBox
steveniemitz commented on pull request #11849: URL: https://github.com/apache/beam/pull/11849#issuecomment-636086069 If you look at [DataflowPipelineOptions](https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/

[GitHub] [beam] pabloem commented on pull request #11849: [BEAM-9964] Move workerCacheMb to a user-visible place

2020-05-29 Thread GitBox
pabloem commented on pull request #11849: URL: https://github.com/apache/beam/pull/11849#issuecomment-636086329 gotcha. Makes sense. LGTM. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] lostluck commented on pull request #11832: [BEAM-10110] Propagate ids for custom coders.

2020-05-29 Thread GitBox
lostluck commented on pull request #11832: URL: https://github.com/apache/beam/pull/11832#issuecomment-636086556 Run Go PostCommit This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] pabloem merged pull request #11849: [BEAM-9964] Move workerCacheMb to a user-visible place

2020-05-29 Thread GitBox
pabloem merged pull request #11849: URL: https://github.com/apache/beam/pull/11849 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] steveniemitz edited a comment on pull request #11849: [BEAM-9964] Move workerCacheMb to a user-visible place

2020-05-29 Thread GitBox
steveniemitz edited a comment on pull request #11849: URL: https://github.com/apache/beam/pull/11849#issuecomment-636086069 If you look at [DataflowPipelineOptions](https://github.com/apache/beam/blob/master/runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/o

[GitHub] [beam] jaketf opened a new pull request #11862: [BEAM-10141] HL7v2 io timestamps / watermark estimate

2020-05-29 Thread GitBox
jaketf opened a new pull request #11862: URL: https://github.com/apache/beam/pull/11862 Use timestamps / watermark estimate in `HL7v2IO.[Read, ListHL7v2Messages]` and provide interface to opt-in to `TimestampedValue` to preserve the existing interface. R: @lukecwik -

[GitHub] [beam] mxm commented on a change in pull request #11858: [BEAM-8608] Chain DoFns in Flink batch runner when possible.

2020-05-29 Thread GitBox
mxm commented on a change in pull request #11858: URL: https://github.com/apache/beam/pull/11858#discussion_r432632340 ## File path: runners/flink/1.10/src/main/java/org/apache/beam/runners/flink/FlinkCapabilities.java ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [beam] TheNeuralBit opened a new pull request #11863: [BEAM-10121][release-2.22.0] Python RowCoder doesn't support nested structs

2020-05-29 Thread GitBox
TheNeuralBit opened a new pull request #11863: URL: https://github.com/apache/beam/pull/11863 Cherrypick #11841 R: @robertwb Post-Commit Tests Status (on master branch) Lang

[GitHub] [beam] mxm commented on a change in pull request #11858: [BEAM-8608] Chain DoFns in Flink batch runner when possible.

2020-05-29 Thread GitBox
mxm commented on a change in pull request #11858: URL: https://github.com/apache/beam/pull/11858#discussion_r432638128 ## File path: runners/flink/1.10/src/main/java/org/apache/beam/runners/flink/FlinkCapabilities.java ## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Softwar

[GitHub] [beam] TheNeuralBit commented on pull request #11841: [BEAM-10121] Python RowCoder doesn't support nested structs

2020-05-29 Thread GitBox
TheNeuralBit commented on pull request #11841: URL: https://github.com/apache/beam/pull/11841#issuecomment-636097728 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

  1   2   >