[GitHub] [beam] iemejia merged pull request #13091: [BEAM-8674] Update cassandra-driver-core dependency

2020-10-14 Thread GitBox
iemejia merged pull request #13091: URL: https://github.com/apache/beam/pull/13091 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] pawelpasterz commented on pull request #13097: [BEAM-5905] Update qpid dependency

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13097: URL: https://github.com/apache/beam/pull/13097#issuecomment-708217587 R: @iemejia R: @aromanenko-dev This is an automated message from the Apache Git Service. To respond to th

[GitHub] [beam] iemejia merged pull request #13090: [BEAM-10800] Update azure-storage-blob dependency

2020-10-14 Thread GitBox
iemejia merged pull request #13090: URL: https://github.com/apache/beam/pull/13090 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] iemejia merged pull request #13092: [BEAM-10803] Update azure-storage dependency

2020-10-14 Thread GitBox
iemejia merged pull request #13092: URL: https://github.com/apache/beam/pull/13092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] iemejia commented on pull request #13095: [BEAM-5573] Update jna dependency

2020-10-14 Thread GitBox
iemejia commented on pull request #13095: URL: https://github.com/apache/beam/pull/13095#issuecomment-708223870 It seems jna is not used at all in the tests code, so I wonder if this is just a transitive dependency that ended up trapped. Can you verfify if we can better remove it or worse

[GitHub] [beam] iemejia merged pull request #13098: [BEAM-5544] Update cassandra-all dependency

2020-10-14 Thread GitBox
iemejia merged pull request #13098: URL: https://github.com/apache/beam/pull/13098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] iemejia merged pull request #13097: [BEAM-5905] Update qpid dependency

2020-10-14 Thread GitBox
iemejia merged pull request #13097: URL: https://github.com/apache/beam/pull/13097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] iemejia merged pull request #13093: [BEAM-10355] Update s3mock dependency

2020-10-14 Thread GitBox
iemejia merged pull request #13093: URL: https://github.com/apache/beam/pull/13093 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] iemejia commented on pull request #13094: [BEAM-5570] Update javacc dependency

2020-10-14 Thread GitBox
iemejia commented on pull request #13094: URL: https://github.com/apache/beam/pull/13094#issuecomment-708226554 We also use javacc for Beam's SQL so worth to check the update there too. This is an automated message from the A

[GitHub] [beam] kplanes commented on pull request #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler.

2020-10-14 Thread GitBox
kplanes commented on pull request #11351: URL: https://github.com/apache/beam/pull/11351#issuecomment-708284564 Hi @lukecwik - Interestingly enough the codebase which is failing is on the 2.23.0 version ? Do you think there might be a sub dependency which wasn't appropriately updated or

[GitHub] [beam] pawelpasterz commented on pull request #13094: [BEAM-5570] Update javacc dependency

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13094: URL: https://github.com/apache/beam/pull/13094#issuecomment-708293826 Run SQL PreCommit This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] pawelpasterz opened a new pull request #13106: [BEAM-8637] Update http client

2020-10-14 Thread GitBox
pawelpasterz opened a new pull request #13106: URL: https://github.com/apache/beam/pull/13106 Update http client Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] pawelpasterz opened a new pull request #13107: [BEAM-8721] Update stax2-api

2020-10-14 Thread GitBox
pawelpasterz opened a new pull request #13107: URL: https://github.com/apache/beam/pull/13107 Update stax2-api Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] pawelpasterz opened a new pull request #13108: [BEAM-8643] Update elasticmq-rest-sqs

2020-10-14 Thread GitBox
pawelpasterz opened a new pull request #13108: URL: https://github.com/apache/beam/pull/13108 Update elasticmq-rest-sqs Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [*

[GitHub] [beam] jobegrabber closed pull request #13058: [BEAM-11047] Convert Avro INTEGER to Long, not String

2020-10-14 Thread GitBox
jobegrabber closed pull request #13058: URL: https://github.com/apache/beam/pull/13058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] pawelpasterz commented on pull request #13106: [BEAM-8637] Update http client

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13106: URL: https://github.com/apache/beam/pull/13106#issuecomment-708315195 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] pawelpasterz commented on pull request #13095: [BEAM-5573] Update jna dependency

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13095: URL: https://github.com/apache/beam/pull/13095#issuecomment-708315766 @iemejia Looks like you are right, with removed, tests are still green This is an automated message from the

[GitHub] [beam] pawelpasterz commented on pull request #13107: [BEAM-8721] Update stax2-api

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13107: URL: https://github.com/apache/beam/pull/13107#issuecomment-708316931 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] pawelpasterz commented on pull request #13108: [BEAM-8643] Update elasticmq-rest-sqs

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13108: URL: https://github.com/apache/beam/pull/13108#issuecomment-708317377 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] aromanenko-dev commented on pull request #13073: [BEAM-11055] Update log4j to version 2.13.3

2020-10-14 Thread GitBox
aromanenko-dev commented on pull request #13073: URL: https://github.com/apache/beam/pull/13073#issuecomment-708320932 @iemejia Thanks! Could you take a look on failed tests? Looks that some of them are caused by this change. ---

[GitHub] [beam] aromanenko-dev edited a comment on pull request #13073: [BEAM-11055] Update log4j to version 2.13.3

2020-10-14 Thread GitBox
aromanenko-dev edited a comment on pull request #13073: URL: https://github.com/apache/beam/pull/13073#issuecomment-708320932 @iemejia Thanks! Could you take a look on failed tests? Looks like that some of them are caused by this change. ---

[GitHub] [beam] kplanes edited a comment on pull request #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler.

2020-10-14 Thread GitBox
kplanes edited a comment on pull request #11351: URL: https://github.com/apache/beam/pull/11351#issuecomment-708284564 Hi @lukecwik - Interestingly enough the codebase which is failing is on the 2.23.0 version ? Do you think there might be a sub dependency which wasn't appropriately upda

[GitHub] [beam] pawelpasterz commented on pull request #13106: [BEAM-8637] Update http client

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13106: URL: https://github.com/apache/beam/pull/13106#issuecomment-708331071 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] pawelpasterz removed a comment on pull request #13106: [BEAM-8637] Update http client

2020-10-14 Thread GitBox
pawelpasterz removed a comment on pull request #13106: URL: https://github.com/apache/beam/pull/13106#issuecomment-708315195 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] pawelpasterz commented on pull request #13107: [BEAM-8721] Update stax2-api

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13107: URL: https://github.com/apache/beam/pull/13107#issuecomment-708334773 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] kplanes edited a comment on pull request #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler.

2020-10-14 Thread GitBox
kplanes edited a comment on pull request #11351: URL: https://github.com/apache/beam/pull/11351#issuecomment-708284564 Hi @lukecwik - Interestingly enough, I'm having it failing on the 2.23.0 version ? Code : catch (Exception e) { System.out.println("Failed to filt

[GitHub] [beam] pawelpasterz commented on pull request #13106: [BEAM-8637] Update http client

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13106: URL: https://github.com/apache/beam/pull/13106#issuecomment-708347584 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pawelpasterz commented on pull request #13094: [BEAM-5570] Update javacc dependency

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13094: URL: https://github.com/apache/beam/pull/13094#issuecomment-708348288 > We also use javacc for Beam's SQL so worth to check the update there too. Looks like updating javacc in `extensions/sql` broke something, I will investigate --

[GitHub] [beam] pawelpasterz opened a new pull request #13109: [BEAM-8723] Update postgresql

2020-10-14 Thread GitBox
pawelpasterz opened a new pull request #13109: URL: https://github.com/apache/beam/pull/13109 Update postgresql Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] pawelpasterz commented on pull request #13107: [BEAM-8721] Update stax2-api

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13107: URL: https://github.com/apache/beam/pull/13107#issuecomment-708350879 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] rworley-monster commented on pull request #12389: [BEAM-10587] Support Maps in BigQuery

2020-10-14 Thread GitBox
rworley-monster commented on pull request #12389: URL: https://github.com/apache/beam/pull/12389#issuecomment-708359843 Based on feedback from the dev list, I have added a `SchemaConversionOptions` class with the option to infer maps when converting a BigQuery `TableSchema` to a Beam `Sche

[GitHub] [beam] aromanenko-dev merged pull request #13089: [BEAM-10628] Update amazon-kinesis-producer dependency

2020-10-14 Thread GitBox
aromanenko-dev merged pull request #13089: URL: https://github.com/apache/beam/pull/13089 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] pawelpasterz commented on pull request #13109: [BEAM-8723] Update postgresql

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13109: URL: https://github.com/apache/beam/pull/13109#issuecomment-708369116 Run Python_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [beam] pawelpasterz commented on pull request #13109: [BEAM-8723] Update postgresql

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13109: URL: https://github.com/apache/beam/pull/13109#issuecomment-708369794 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] iemejia commented on pull request #12583: [BEAM-10706] Fix duplicate key error in DynamoDBIO.Write

2020-10-14 Thread GitBox
iemejia commented on pull request #12583: URL: https://github.com/apache/beam/pull/12583#issuecomment-708375803 I have forgotten about this issue, did you have any progress @dennisylyung, any chance you can get this rebased so we can have some progress. I also just realized that you made

[GitHub] [beam] pawelpasterz removed a comment on pull request #13107: [BEAM-8721] Update stax2-api

2020-10-14 Thread GitBox
pawelpasterz removed a comment on pull request #13107: URL: https://github.com/apache/beam/pull/13107#issuecomment-708334773 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] pawelpasterz commented on pull request #13107: [BEAM-8721] Update stax2-api

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13107: URL: https://github.com/apache/beam/pull/13107#issuecomment-708379982 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pawelpasterz commented on pull request #13095: [BEAM-5573] Update jna dependency

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13095: URL: https://github.com/apache/beam/pull/13095#issuecomment-708380376 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] iemejia merged pull request #13107: [BEAM-8721] Update stax2-api to version 4.2.1

2020-10-14 Thread GitBox
iemejia merged pull request #13107: URL: https://github.com/apache/beam/pull/13107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] iemejia merged pull request #13106: [BEAM-8637] Update Apache Http Components client to version 4.5.12

2020-10-14 Thread GitBox
iemejia merged pull request #13106: URL: https://github.com/apache/beam/pull/13106 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] iemejia commented on pull request #13106: [BEAM-8637] Update Apache Http Components client to version 4.5.12

2020-10-14 Thread GitBox
iemejia commented on pull request #13106: URL: https://github.com/apache/beam/pull/13106#issuecomment-708384086 For future updates please include the version in the commit/PR title This is an automated message from the Apache

[GitHub] [beam] pawelpasterz opened a new pull request #13110: [BEAM-10370] Update jedis to version 3.3.0

2020-10-14 Thread GitBox
pawelpasterz opened a new pull request #13110: URL: https://github.com/apache/beam/pull/13110 Update jedis Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose revi

[GitHub] [beam] pawelpasterz opened a new pull request #13111: [BEAM-8928] Update clickhouse-jdbc to version 0.2.4

2020-10-14 Thread GitBox
pawelpasterz opened a new pull request #13111: URL: https://github.com/apache/beam/pull/13111 Update clickhouse-jdbc to version 0.2.4 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] iemejia commented on pull request #13073: [BEAM-11055] Update log4j to version 2.13.3

2020-10-14 Thread GitBox
iemejia commented on pull request #13073: URL: https://github.com/apache/beam/pull/13073#issuecomment-708391073 Arrghh I executed by mistake the `hcatalog` tests locally instead of `hadoop-format` ones. Let's hope it is ok this time :crossed_fingers: -

[GitHub] [beam] pawelpasterz commented on pull request #13110: [BEAM-10370] Update jedis to version 3.3.0

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13110: URL: https://github.com/apache/beam/pull/13110#issuecomment-708400105 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pawelpasterz commented on pull request #13109: [BEAM-8723] Update postgresql

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13109: URL: https://github.com/apache/beam/pull/13109#issuecomment-708400274 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pawelpasterz commented on pull request #13111: [BEAM-8928] Update clickhouse-jdbc to version 0.2.4

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13111: URL: https://github.com/apache/beam/pull/13111#issuecomment-708443142 R: @iemejia This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] pawelpasterz commented on pull request #13111: [BEAM-8928] Update clickhouse-jdbc to version 0.2.4

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13111: URL: https://github.com/apache/beam/pull/13111#issuecomment-708445731 Looks like GH action failed on: ``` Execution failed for task ':buildSrc:pluginUnderTestMetadata'. > Could not resolve all files for configuration ':buildSrc:runtimeC

[GitHub] [beam] pawelpasterz edited a comment on pull request #13111: [BEAM-8928] Update clickhouse-jdbc to version 0.2.4

2020-10-14 Thread GitBox
pawelpasterz edited a comment on pull request #13111: URL: https://github.com/apache/beam/pull/13111#issuecomment-708445731 Looks like GH action failed on: ``` Execution failed for task ':buildSrc:pluginUnderTestMetadata'. > Could not resolve all files for configuration ':buildSrc:r

[GitHub] [beam] pawelpasterz commented on pull request #13110: [BEAM-10370] Update jedis to version 3.3.0

2020-10-14 Thread GitBox
pawelpasterz commented on pull request #13110: URL: https://github.com/apache/beam/pull/13110#issuecomment-708466509 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] ilya-kozyrev opened a new pull request #13112: [WIP] Apache Beam Template to ingest from Apache Kafka to Google Pub/Sub

2020-10-14 Thread GitBox
ilya-kozyrev opened a new pull request #13112: URL: https://github.com/apache/beam/pull/13112 [Proposal] Apache Beam Template to ingest data from Apache Kafka to Google Cloud Pub/Sub. It can be used as a Dataflow Flex template in the Google Cloud Platform. We suggest adding /templat

[GitHub] [beam] kamilwu commented on pull request #13048: [BEAM-3736] Add CombineFn.setup and CombineFn.teardown to Python SDK

2020-10-14 Thread GitBox
kamilwu commented on pull request #13048: URL: https://github.com/apache/beam/pull/13048#issuecomment-708515000 > Are setup/teardown invoked for its use in CombineFnState? @robertwb Do you mean `CombiningValueRuntimeState`? If so, they're not. I can fix that, but I wonder where

[GitHub] [beam] lukecwik commented on pull request #13078: Rename ProcessBundleProgressMetadataRequest to MonitoringInfosMetadataRequest. And rename ProcessBundleProgressMetadataResponse to Monitoring

2020-10-14 Thread GitBox
lukecwik commented on pull request #13078: URL: https://github.com/apache/beam/pull/13078#issuecomment-708522376 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kennknowles opened a new pull request #13113: Upgrade checkerframework and gradle plugin

2020-10-14 Thread GitBox
kennknowles opened a new pull request #13113: URL: https://github.com/apache/beam/pull/13113 This is a routine upgrade. The new checkerframework version has a "Called Methods" analysis that may help analyze our classes that have protocols like "must call method X before method Y". -

[GitHub] [beam] lukecwik commented on pull request #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler.

2020-10-14 Thread GitBox
lukecwik commented on pull request #11351: URL: https://github.com/apache/beam/pull/11351#issuecomment-708536481 That would work. > Hi @lukecwik - Interestingly enough, I'm having it failing on the 2.23.0 version ? > > Code : catch (Exception e) { > System.out.println("Fail

[GitHub] [beam] lukecwik commented on a change in pull request #13069: [BEAM-10475] Add a well-known coder for ShardedKey in Java/Python SDK

2020-10-14 Thread GitBox
lukecwik commented on a change in pull request #13069: URL: https://github.com/apache/beam/pull/13069#discussion_r504841758 ## File path: sdks/python/apache_beam/coders/coder_impl.py ## @@ -1365,3 +1366,38 @@ def estimate_size(self, value, nested=False): # type: (Any, bool

[GitHub] [beam] reuvenlax commented on pull request #12864: [BEAM-10650] Windmill implementation for TimestampOrderedState

2020-10-14 Thread GitBox
reuvenlax commented on pull request #12864: URL: https://github.com/apache/beam/pull/12864#issuecomment-708542712 Run Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] aromanenko-dev commented on pull request #13073: [BEAM-11055] Update log4j to version 2.13.3

2020-10-14 Thread GitBox
aromanenko-dev commented on pull request #13073: URL: https://github.com/apache/beam/pull/13073#issuecomment-708562973 retest this please This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] rohdesamuel commented on a change in pull request #12985: [BEAM-10994] Adds ability to log literal hot key in Batch Dataflow

2020-10-14 Thread GitBox
rohdesamuel commented on a change in pull request #12985: URL: https://github.com/apache/beam/pull/12985#discussion_r504869807 ## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowWorkProgressUpdater.java ## @@ -

[GitHub] [beam] lostluck commented on pull request #13078: Rename ProcessBundleProgressMetadataRequest to MonitoringInfosMetadataRequest. And rename ProcessBundleProgressMetadataResponse to Monitoring

2020-10-14 Thread GitBox
lostluck commented on pull request #13078: URL: https://github.com/apache/beam/pull/13078#issuecomment-708570925 Ack. It looks like the head process for Go Protos has change enough that the instructions need to be adjusted and updated as well. I don't anticipate any additional changes to t

[GitHub] [beam] rohdesamuel commented on a change in pull request #12986: [BEAM-10994] Adds ability to log literal hot key in Streaming Dataflow

2020-10-14 Thread GitBox
rohdesamuel commented on a change in pull request #12986: URL: https://github.com/apache/beam/pull/12986#discussion_r504884674 ## File path: runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java ## @@ -1384

[GitHub] [beam] nehsyc commented on a change in pull request #13069: [BEAM-10475] Add a well-known coder for ShardedKey in Java/Python SDK

2020-10-14 Thread GitBox
nehsyc commented on a change in pull request #13069: URL: https://github.com/apache/beam/pull/13069#discussion_r504885576 ## File path: sdks/python/apache_beam/coders/coder_impl.py ## @@ -1365,3 +1366,38 @@ def estimate_size(self, value, nested=False): # type: (Any, bool)

[GitHub] [beam] ihji commented on a change in pull request #13025: [BEAM-10967] adding validate runner for Dataflow runner v2 to Java SDK

2020-10-14 Thread GitBox
ihji commented on a change in pull request #13025: URL: https://github.com/apache/beam/pull/13025#discussion_r504891903 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/testing/DataflowRunnerV2Incompatible.java ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache S

[GitHub] [beam] ihji commented on a change in pull request #13087: [BEAM-2146] Disable unsupported categories for Dataflow streaming

2020-10-14 Thread GitBox
ihji commented on a change in pull request #13087: URL: https://github.com/apache/beam/pull/13087#discussion_r504898528 ## File path: runners/google-cloud-dataflow-java/build.gradle ## @@ -210,6 +216,18 @@ task buildAndPushDockerContainer() { } } +// Clean up built images

[GitHub] [beam] y1chi opened a new pull request #13114: [BEAM-11066] Fix java wordcount example in streaming mode

2020-10-14 Thread GitBox
y1chi opened a new pull request #13114: URL: https://github.com/apache/beam/pull/13114 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] robertwb commented on pull request #13016: [BEAM-10409] Yield stages in topological order for eliminate_common_key_with_void and pack_combiners

2020-10-14 Thread GitBox
robertwb commented on pull request #13016: URL: https://github.com/apache/beam/pull/13016#issuecomment-708617305 Thanks for the update. Note that you can make PRs "WIP" and still keep them open as well. Also, I was just talking to Gus, and it would be preferable to not impose this

[GitHub] [beam] lostluck commented on pull request #13115: Update go protocol buffers to v2.

2020-10-14 Thread GitBox
lostluck commented on pull request #13115: URL: https://github.com/apache/beam/pull/13115#issuecomment-708617517 Run Go PostCommit This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] lostluck opened a new pull request #13115: Update go protocol buffers to v2.

2020-10-14 Thread GitBox
lostluck opened a new pull request #13115: URL: https://github.com/apache/beam/pull/13115 Updates Go SDK protos to use v2 of the Go protocol buffer package. This is largely behind the protos existing interfaces, and so is transparent to the SDK's use of them. The proto option go_pac

[GitHub] [beam] lostluck commented on pull request #13078: Rename ProcessBundleProgressMetadataRequest to MonitoringInfosMetadataRequest. And rename ProcessBundleProgressMetadataResponse to Monitoring

2020-10-14 Thread GitBox
lostluck commented on pull request #13078: URL: https://github.com/apache/beam/pull/13078#issuecomment-708618178 I've now got a compiling and passing version of the go protos. It's in PR https://github.com/apache/beam/pull/13115 which will be updated once this PR is in. -

[GitHub] [beam] scwhittle commented on pull request #11351: [BEAM-9399] Ensure that empty messages are not flushed to handler.

2020-10-14 Thread GitBox
scwhittle commented on pull request #11351: URL: https://github.com/apache/beam/pull/11351#issuecomment-708619117 On Wed, Oct 14, 2020, 7:06 PM Lukasz Cwik wrote: > That would work. > > Hi @lukecwik - Interestingly enough, I'm > having it failin

[GitHub] [beam] mxm opened a new pull request #13116: [BEAM-9855] Provide an option to configure the Flink state backend

2020-10-14 Thread GitBox
mxm opened a new pull request #13116: URL: https://github.com/apache/beam/pull/13116 We should make it easier to configure a Flink state backend. At the moment, users have to either: (A) Configure the default state backend in their Flink cluster (B1) Include the dependency

[GitHub] [beam] lukecwik commented on pull request #13078: Rename ProcessBundleProgressMetadataRequest to MonitoringInfosMetadataRequest. And rename ProcessBundleProgressMetadataResponse to Monitoring

2020-10-14 Thread GitBox
lukecwik commented on pull request #13078: URL: https://github.com/apache/beam/pull/13078#issuecomment-708629004 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lostluck edited a comment on pull request #13078: Rename ProcessBundleProgressMetadataRequest to MonitoringInfosMetadataRequest. And rename ProcessBundleProgressMetadataResponse to Mon

2020-10-14 Thread GitBox
lostluck edited a comment on pull request #13078: URL: https://github.com/apache/beam/pull/13078#issuecomment-708618178 I've now got a compiling and passing version of the go protos. It's in PR https://github.com/apache/beam/pull/13115 which will be updated once this PR is in. Edit: now

[GitHub] [beam] lostluck commented on pull request #13115: Update go protocol buffers to v2.

2020-10-14 Thread GitBox
lostluck commented on pull request #13115: URL: https://github.com/apache/beam/pull/13115#issuecomment-708632592 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] lostluck commented on pull request #13115: Update go protocol buffers to v2.

2020-10-14 Thread GitBox
lostluck commented on pull request #13115: URL: https://github.com/apache/beam/pull/13115#issuecomment-708632667 Run Go Postcommit This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] y1chi commented on pull request #13114: [BEAM-11066] Fix java wordcount example in streaming mode

2020-10-14 Thread GitBox
y1chi commented on pull request #13114: URL: https://github.com/apache/beam/pull/13114#issuecomment-708634913 R: @kennknowles This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] kanterov commented on pull request #13094: [BEAM-5570] Update javacc dependency

2020-10-14 Thread GitBox
kanterov commented on pull request #13094: URL: https://github.com/apache/beam/pull/13094#issuecomment-708639097 @iemejia @pawelpasterz looks fine (for ClickHouse module), as soon as tests pass :) This is an automated messa

[GitHub] [beam] robertwb commented on a change in pull request #13102: [BEAM-9547] Add support for `DataFrame.assign`

2020-10-14 Thread GitBox
robertwb commented on a change in pull request #13102: URL: https://github.com/apache/beam/pull/13102#discussion_r504950839 ## File path: sdks/python/apache_beam/dataframe/frame_base.py ## @@ -216,20 +216,42 @@ def wrapper(*args, **kwargs): else: constant_args[i

[GitHub] [beam] lostluck commented on pull request #13115: Update go protocol buffers to v2.

2020-10-14 Thread GitBox
lostluck commented on pull request #13115: URL: https://github.com/apache/beam/pull/13115#issuecomment-708645433 The python failure is expected until #13078 is merged in and this PR rebased on top of it. The important part is the Go tests pass.

[GitHub] [beam] reuvenlax commented on pull request #12864: [BEAM-10650] Windmill implementation for TimestampOrderedState

2020-10-14 Thread GitBox
reuvenlax commented on pull request #12864: URL: https://github.com/apache/beam/pull/12864#issuecomment-708649344 Run Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] alanmyrvold opened a new pull request #13117: [BEAM-11067] Update java license script to include source for GNU and Mozilla dependencies

2020-10-14 Thread GitBox
alanmyrvold opened a new pull request #13117: URL: https://github.com/apache/beam/pull/13117 License script was not pulling source for license names that were spelled out. LGPL/MPL worked, but "GNU Lesser Public License" and "Mozzilla Public License" were not matched. This uncovered

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #13117: [BEAM-11067] Update java license script to include source for GNU and Mozilla dependencies

2020-10-14 Thread GitBox
Hannah-Jiang commented on a change in pull request #13117: URL: https://github.com/apache/beam/pull/13117#discussion_r504979231 ## File path: sdks/java/container/license_scripts/pull_licenses_java.py ## @@ -101,13 +101,22 @@ def pull_from_url(file_name, url, dep, no_list): d

[GitHub] [beam] lukecwik commented on pull request #13078: Rename ProcessBundleProgressMetadataRequest to MonitoringInfosMetadataRequest. And rename ProcessBundleProgressMetadataResponse to Monitoring

2020-10-14 Thread GitBox
lukecwik commented on pull request #13078: URL: https://github.com/apache/beam/pull/13078#issuecomment-708671760 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kennknowles opened a new pull request #13118: Only work with fully expanded PCollections in TransformHierarchy and PTransformReplacements

2020-10-14 Thread GitBox
kennknowles opened a new pull request #13118: URL: https://github.com/apache/beam/pull/13118 While developing #13053 I discovered that some output replacements were not being re-wired correctly, because the PValues were at different levels of expansion: since a PCollectionView is still a P

[GitHub] [beam] codecov[bot] edited a comment on pull request #13017: [BEAM-11018] Use metric for Python BigQuery streaming insert API late…

2020-10-14 Thread GitBox
codecov[bot] edited a comment on pull request #13017: URL: https://github.com/apache/beam/pull/13017#issuecomment-703976988 # [Codecov](https://codecov.io/gh/apache/beam/pull/13017?src=pr&el=h1) Report > Merging [#13017](https://codecov.io/gh/apache/beam/pull/13017?src=pr&el=desc) into

[GitHub] [beam] ihji commented on a change in pull request #13017: [BEAM-11018] Use metric for Python BigQuery streaming insert API late…

2020-10-14 Thread GitBox
ihji commented on a change in pull request #13017: URL: https://github.com/apache/beam/pull/13017#discussion_r505013809 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1102,7 +1096,7 @@ def __init__( retry_strategy=None, additional_bq_parameters=No

[GitHub] [beam] ihji commented on a change in pull request #13017: [BEAM-11018] Use metric for Python BigQuery streaming insert API late…

2020-10-14 Thread GitBox
ihji commented on a change in pull request #13017: URL: https://github.com/apache/beam/pull/13017#discussion_r505014935 ## File path: sdks/python/apache_beam/metrics/cells.py ## @@ -238,6 +250,57 @@ def to_runner_api_monitoring_info(self, name, transform_id): ptransfo

[GitHub] [beam] ihji commented on a change in pull request #13017: [BEAM-11018] Use metric for Python BigQuery streaming insert API late…

2020-10-14 Thread GitBox
ihji commented on a change in pull request #13017: URL: https://github.com/apache/beam/pull/13017#discussion_r505015101 ## File path: sdks/python/apache_beam/metrics/metric.py ## @@ -139,6 +169,22 @@ def __init__(self, metric_name): super(Metrics.DelegatingGauge, self)._

[GitHub] [beam] ihji commented on a change in pull request #13017: [BEAM-11018] Use metric for Python BigQuery streaming insert API late…

2020-10-14 Thread GitBox
ihji commented on a change in pull request #13017: URL: https://github.com/apache/beam/pull/13017#discussion_r505015346 ## File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py ## @@ -271,6 +276,11 @@ def __init__(self, client=None): # randomized prefix for row IDs.

[GitHub] [beam] vmarquez commented on a change in pull request #10546: [BEAM-9008] Add CassandraIO readAll method

2020-10-14 Thread GitBox
vmarquez commented on a change in pull request #10546: URL: https://github.com/apache/beam/pull/10546#discussion_r505024604 ## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ## @@ -143,6 +148,36 @@ private CassandraIO() {}

[GitHub] [beam] KevinGG opened a new pull request #13119: [BEAM-11045] Upgraded chromedriver-binary

2020-10-14 Thread GitBox
KevinGG opened a new pull request #13119: URL: https://github.com/apache/beam/pull/13119 1. Upgraded chromedriver-binary to the most recent version 86. 2. Updated the golden screenshot for Linux platform due to the driver change (diff by a distance of 55418.82). Platform Darwin is n

[GitHub] [beam] KevinGG commented on pull request #13119: [BEAM-11045] Upgraded chromedriver-binary

2020-10-14 Thread GitBox
KevinGG commented on pull request #13119: URL: https://github.com/apache/beam/pull/13119#issuecomment-708697065 R: @pabloem PTAL, thx! This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] TheNeuralBit commented on a change in pull request #13082: [BEAM-9547] Flesh out dataframe groupby (and related) implementation.

2020-10-14 Thread GitBox
TheNeuralBit commented on a change in pull request #13082: URL: https://github.com/apache/beam/pull/13082#discussion_r504989018 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -27,12 +28,118 @@ from apache_beam.dataframe import partitionings -@frame_base.De

[GitHub] [beam] codecov[bot] edited a comment on pull request #13017: [BEAM-11018] Use metric for Python BigQuery streaming insert API late…

2020-10-14 Thread GitBox
codecov[bot] edited a comment on pull request #13017: URL: https://github.com/apache/beam/pull/13017#issuecomment-703976988 # [Codecov](https://codecov.io/gh/apache/beam/pull/13017?src=pr&el=h1) Report > Merging [#13017](https://codecov.io/gh/apache/beam/pull/13017?src=pr&el=desc) into

[GitHub] [beam] boyuanzz opened a new pull request #13120: [BEAM-10940] Lengthprefix any input coder for an ProcessBundleDescriptor.

2020-10-14 Thread GitBox
boyuanzz opened a new pull request #13120: URL: https://github.com/apache/beam/pull/13120 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

[GitHub] [beam] KevinGG commented on pull request #13119: [BEAM-11045] Upgraded chromedriver-binary

2020-10-14 Thread GitBox
KevinGG commented on pull request #13119: URL: https://github.com/apache/beam/pull/13119#issuecomment-708702800 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] KevinGG commented on pull request #13119: [BEAM-11045] Upgraded chromedriver-binary

2020-10-14 Thread GitBox
KevinGG commented on pull request #13119: URL: https://github.com/apache/beam/pull/13119#issuecomment-708711775 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] kennknowles commented on pull request #13118: Only work with fully expanded PCollections in TransformHierarchy and PTransformReplacements

2020-10-14 Thread GitBox
kennknowles commented on pull request #13118: URL: https://github.com/apache/beam/pull/13118#issuecomment-708718665 Even though the raw LOC is large, it is mostly super trivial. It should just remove a source of errors. It simplifies runner code a little, removing casting all over the plac

[GitHub] [beam] kennknowles commented on pull request #13118: Only work with fully expanded PCollections in TransformHierarchy and PTransformReplacements

2020-10-14 Thread GitBox
kennknowles commented on pull request #13118: URL: https://github.com/apache/beam/pull/13118#issuecomment-708718789 run flink validatesrunner This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [beam] kennknowles commented on pull request #13118: Only work with fully expanded PCollections in TransformHierarchy and PTransformReplacements

2020-10-14 Thread GitBox
kennknowles commented on pull request #13118: URL: https://github.com/apache/beam/pull/13118#issuecomment-708720293 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

  1   2   >