[GitHub] [beam] reuvenlax commented on pull request #15984: [BEAM-2791] OrderedListState for Flink

2022-01-04 Thread GitBox
reuvenlax commented on pull request #15984: URL: https://github.com/apache/beam/pull/15984#issuecomment-1004609768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [beam] aromanenko-dev commented on pull request #16404: [BEAM-13586] Fix NPE in DefaultS3ClientBuilderFactory

2022-01-04 Thread GitBox
aromanenko-dev commented on pull request #16404: URL: https://github.com/apache/beam/pull/16404#issuecomment-1004847873 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] aromanenko-dev commented on pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-04 Thread GitBox
aromanenko-dev commented on pull request #16271: URL: https://github.com/apache/beam/pull/16271#issuecomment-1004862134 CC: @kennknowles @lukecwik @TheNeuralBit I think that this PR brings some significant changes to `AvroCoder` and it should be discussed before. -- This is an automa

[GitHub] [beam] RustedBones commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-04 Thread GitBox
RustedBones commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r778182570 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java ## @@ -272,26 +263,8 @@ public Schema get() { } } - /*

[GitHub] [beam] aromanenko-dev merged pull request #16404: [BEAM-13586] Fix NPE in DefaultS3ClientBuilderFactory

2022-01-04 Thread GitBox
aromanenko-dev merged pull request #16404: URL: https://github.com/apache/beam/pull/16404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] lukecwik commented on pull request #16412: [BEAM-13015] Add jamm as a java agent to the Java SDK harness container

2022-01-04 Thread GitBox
lukecwik commented on pull request #16412: URL: https://github.com/apache/beam/pull/16412#issuecomment-1005014389 https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_PR/40/testReport/org.apache.beam.sdk/SdkHarnessEnvironmentTest/ is the relevant new test -- This is an aut

[GitHub] [beam] aromanenko-dev closed pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-04 Thread GitBox
aromanenko-dev closed pull request #16287: URL: https://github.com/apache/beam/pull/16287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] aromanenko-dev commented on pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-04 Thread GitBox
aromanenko-dev commented on pull request #16287: URL: https://github.com/apache/beam/pull/16287#issuecomment-1005017234 @mosche > Please make sure to also document this as breaking change in CHANGES.md. For sure it will worth to mention but I don't see the real breaking change fo

[GitHub] [beam] aromanenko-dev removed a comment on pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-04 Thread GitBox
aromanenko-dev removed a comment on pull request #16287: URL: https://github.com/apache/beam/pull/16287#issuecomment-1005017234 @mosche > Please make sure to also document this as breaking change in CHANGES.md. For sure it will worth to mention but I don't see the real breaking ch

[GitHub] [beam] aromanenko-dev commented on pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-04 Thread GitBox
aromanenko-dev commented on pull request #16287: URL: https://github.com/apache/beam/pull/16287#issuecomment-1005017990 I'm sorry, I closed this one by mistake. Reopened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [beam] codecov[bot] edited a comment on pull request #16351: Fix default type inference of CombinePerKey.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16351: URL: https://github.com/apache/beam/pull/16351#issuecomment-1000563335 # [Codecov](https://codecov.io/gh/apache/beam/pull/16351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] chamikaramj commented on pull request #15377: Add auto creation of client if is not passed

2022-01-04 Thread GitBox
chamikaramj commented on pull request #15377: URL: https://github.com/apache/beam/pull/15377#issuecomment-1005036852 gcsio is not a part of the documented Beam API and hence is intended for internal usage. If you need to connect to GCS consider using an official GCS client library [1]. If

[GitHub] [beam] chamikaramj commented on pull request #16222: [BEAM-13432] Skip ExpansionService creation in Job Server

2022-01-04 Thread GitBox
chamikaramj commented on pull request #16222: URL: https://github.com/apache/beam/pull/16222#issuecomment-1005038803 LGTM. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] chamikaramj commented on pull request #16222: [BEAM-13432] Skip ExpansionService creation in Job Server

2022-01-04 Thread GitBox
chamikaramj commented on pull request #16222: URL: https://github.com/apache/beam/pull/16222#issuecomment-1005039407 Could you add a test ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] codecov[bot] edited a comment on pull request #16351: Fix default type inference of CombinePerKey.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16351: URL: https://github.com/apache/beam/pull/16351#issuecomment-1000563335 # [Codecov](https://codecov.io/gh/apache/beam/pull/16351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16351: Fix default type inference of CombinePerKey.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16351: URL: https://github.com/apache/beam/pull/16351#issuecomment-1000563335 # [Codecov](https://codecov.io/gh/apache/beam/pull/16351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] y1chi opened a new pull request #16417: Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
y1chi opened a new pull request #16417: URL: https://github.com/apache/beam/pull/16417 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] y1chi commented on pull request #16417: Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
y1chi commented on pull request #16417: URL: https://github.com/apache/beam/pull/16417#issuecomment-1005057738 Run Python Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] edited a comment on pull request #16351: Fix default type inference of CombinePerKey.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16351: URL: https://github.com/apache/beam/pull/16351#issuecomment-1000563335 # [Codecov](https://codecov.io/gh/apache/beam/pull/16351?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] commented on pull request #16417: Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
codecov[bot] commented on pull request #16417: URL: https://github.com/apache/beam/pull/16417#issuecomment-1005069079 # [Codecov](https://codecov.io/gh/apache/beam/pull/16417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] fernando-wizeline commented on pull request #15675: [BEAM-12313] - Initial changes to support Java 17 SDK Harness docker image

2022-01-04 Thread GitBox
fernando-wizeline commented on pull request #15675: URL: https://github.com/apache/beam/pull/15675#issuecomment-1005069477 Hi @lukecwik! It looks like the CoGBK load tests rely on the Caches class which in turn rely on the jamm library. The jamm library is using a the setAccessible me

[GitHub] [beam] codecov[bot] edited a comment on pull request #16417: Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16417: URL: https://github.com/apache/beam/pull/16417#issuecomment-1005069079 # [Codecov](https://codecov.io/gh/apache/beam/pull/16417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16417: Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16417: URL: https://github.com/apache/beam/pull/16417#issuecomment-1005069079 # [Codecov](https://codecov.io/gh/apache/beam/pull/16417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] y1chi opened a new pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
y1chi opened a new pull request #16418: URL: https://github.com/apache/beam/pull/16418 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] TheNeuralBit merged pull request #16255: [BEAM-13480] Sickbay PubSubIntegrationTest.test_streaming_data_only on Dataflow

2022-01-04 Thread GitBox
TheNeuralBit merged pull request #16255: URL: https://github.com/apache/beam/pull/16255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] ibzib commented on pull request #16396: [BEAM-13569] Change Spark dependencies to implementation.

2022-01-04 Thread GitBox
ibzib commented on pull request #16396: URL: https://github.com/apache/beam/pull/16396#issuecomment-1005075946 run python 3.6 postcommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] ibzib commented on pull request #16396: [BEAM-13569] Change Spark dependencies to implementation.

2022-01-04 Thread GitBox
ibzib commented on pull request #16396: URL: https://github.com/apache/beam/pull/16396#issuecomment-1005076309 Run Java Spark PortableValidatesRunner Batch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] ibzib commented on a change in pull request #16396: [BEAM-13569] Change Spark dependencies to implementation.

2022-01-04 Thread GitBox
ibzib commented on a change in pull request #16396: URL: https://github.com/apache/beam/pull/16396#discussion_r778307647 ## File path: runners/spark/spark_runner.gradle ## @@ -163,12 +163,12 @@ dependencies { implementation library.java.vendored_grpc_1_36_0 implementation

[GitHub] [beam] y1chi commented on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
y1chi commented on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005078281 Run Java AvroIO Performance Test HDFS -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] y1chi commented on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
y1chi commented on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005078486 R: @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] y1chi commented on pull request #16417: Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
y1chi commented on pull request #16417: URL: https://github.com/apache/beam/pull/16417#issuecomment-1005078977 R: @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] MarcoRob edited a comment on pull request #16386: [Beam-12622] Modified PR Trigger Phrases Jenkins tests and README updated with changes and missed jobs

2022-01-04 Thread GitBox
MarcoRob edited a comment on pull request #16386: URL: https://github.com/apache/beam/pull/16386#issuecomment-1004343170 Hi @tvalentyn @pabloem can you help me to run again the `seed job` for this PR? Thanks in advance -- This is an automated message from the Apache Git Service. To

[GitHub] [beam] codecov[bot] commented on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] commented on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16417: [BEAM-13459] Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16417: URL: https://github.com/apache/beam/pull/16417#issuecomment-1005069079 # [Codecov](https://codecov.io/gh/apache/beam/pull/16417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16417: [BEAM-13459] Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16417: URL: https://github.com/apache/beam/pull/16417#issuecomment-1005069079 # [Codecov](https://codecov.io/gh/apache/beam/pull/16417?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] y1chi merged pull request #16417: [BEAM-13459] Fix sdk_container_builder too many values to unpack error

2022-01-04 Thread GitBox
y1chi merged pull request #16417: URL: https://github.com/apache/beam/pull/16417 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr..

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] chamikaramj commented on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
chamikaramj commented on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-1005094818 LGTM. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] chamikaramj commented on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
chamikaramj commented on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-1005094927 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] lukecwik commented on a change in pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
lukecwik commented on a change in pull request #16418: URL: https://github.com/apache/beam/pull/16418#discussion_r778326765 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -1762,14 +1762,17 @@ class BeamModulePlugin implements Plugin

[GitHub] [beam] lukecwik commented on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
lukecwik commented on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005100424 I believe this will address some failures with other runners but still seeing "java.lang.IllegalArgumentException: Class interface org.apache.beam.sdk.testing.TestPipelineOptio

[GitHub] [beam] lukecwik merged pull request #16400: [BEAM-13430] Swap to use "mainClass" instead of "main" since it was deprecated.

2022-01-04 Thread GitBox
lukecwik merged pull request #16400: URL: https://github.com/apache/beam/pull/16400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] lukecwik merged pull request #16401: [BEAM-13430] Replace deprecated "appendix" with "archiveAppendix"

2022-01-04 Thread GitBox
lukecwik merged pull request #16401: URL: https://github.com/apache/beam/pull/16401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo commented on a change in pull request #16377: [BEAM-13576] update bom

2022-01-04 Thread GitBox
suztomo commented on a change in pull request #16377: URL: https://github.com/apache/beam/pull/16377#discussion_r778339359 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -472,7 +472,7 @@ class BeamModulePlugin implements Plugin {

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] aaltay merged pull request #16415: [BEAM-13591] Bump log4j2 version to 2.17.1

2022-01-04 Thread GitBox
aaltay merged pull request #16415: URL: https://github.com/apache/beam/pull/16415 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] aaltay commented on pull request #16402: [release-2.36.0][BEAM-13541] More intelligent caching of CoGBK values. (#16354)

2022-01-04 Thread GitBox
aaltay commented on pull request #16402: URL: https://github.com/apache/beam/pull/16402#issuecomment-1005118270 You may also need to cherry pick https://github.com/apache/beam/pull/16407 as well. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lukecwik merged pull request #16412: [BEAM-13015] Add jamm as a java agent to the Java SDK harness container

2022-01-04 Thread GitBox
lukecwik merged pull request #16412: URL: https://github.com/apache/beam/pull/16412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] y1chi commented on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
y1chi commented on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005127748 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] codecov[bot] edited a comment on pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16246: URL: https://github.com/apache/beam/pull/16246#issuecomment-995015430 # [Codecov](https://codecov.io/gh/apache/beam/pull/16246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] lukecwik opened a new pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
lukecwik opened a new pull request #16419: URL: https://github.com/apache/beam/pull/16419 Partially revert https://github.com/apache/beam/commit/eaacf709a861ea1c260e3856b720266348b1aecc Thank you for your contribution! Follow this checklist to help

[GitHub] [beam] lukecwik commented on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
lukecwik commented on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-1005131389 R: @chamikaramj @emilymye -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [beam] kileys commented on a change in pull request #16263: [BEAM-13015] Migrate all user state and side input implementations to support caching.

2022-01-04 Thread GitBox
kileys commented on a change in pull request #16263: URL: https://github.com/apache/beam/pull/16263#discussion_r778331126 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/FnApiStateAccessor.java ## @@ -738,7 +743,21 @@ private StateKey createBagUs

[GitHub] [beam] tvalentyn commented on pull request #15489: [BEAM-12865] Allow custom batch_duration in WriteToBigQuery

2022-01-04 Thread GitBox
tvalentyn commented on pull request #15489: URL: https://github.com/apache/beam/pull/15489#issuecomment-1005136650 Closed. you can email dev mailing list to ask to be added to Jira contributors. for future changes. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lukecwik commented on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
lukecwik commented on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-1005139700 Run GoPortable PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] lukecwik opened a new pull request #16420: [BEAM-13015] Use 20% of memory when the maximum has been configured.

2022-01-04 Thread GitBox
lukecwik opened a new pull request #16420: URL: https://github.com/apache/beam/pull/16420 The boot.go always sets the `-Xmx` value but we need a fallback incase used in different environments. Thank you for your contribution! Follow this checklist to h

[GitHub] [beam] lukecwik commented on pull request #16420: [BEAM-13015] Use 20% of memory when the maximum has been configured.

2022-01-04 Thread GitBox
lukecwik commented on pull request #16420: URL: https://github.com/apache/beam/pull/16420#issuecomment-1005142358 R: @y1chi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] commented on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
codecov[bot] commented on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-100512 # [Codecov](https://codecov.io/gh/apache/beam/pull/16419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-100512 # [Codecov](https://codecov.io/gh/apache/beam/pull/16419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16418: Fix remaining failing perf IT tests.

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16418: URL: https://github.com/apache/beam/pull/16418#issuecomment-1005088616 # [Codecov](https://codecov.io/gh/apache/beam/pull/16418?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-100512 # [Codecov](https://codecov.io/gh/apache/beam/pull/16419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-100512 # [Codecov](https://codecov.io/gh/apache/beam/pull/16419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-100512 # [Codecov](https://codecov.io/gh/apache/beam/pull/16419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-100512 # [Codecov](https://codecov.io/gh/apache/beam/pull/16419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16419: URL: https://github.com/apache/beam/pull/16419#issuecomment-100512 # [Codecov](https://codecov.io/gh/apache/beam/pull/16419?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lukecwik merged pull request #16419: [BEAM-13430] Bump the version back to 2.37

2022-01-04 Thread GitBox
lukecwik merged pull request #16419: URL: https://github.com/apache/beam/pull/16419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] reuvenlax commented on pull request #16377: [BEAM-13576] update bom

2022-01-04 Thread GitBox
reuvenlax commented on pull request #16377: URL: https://github.com/apache/beam/pull/16377#issuecomment-1005151960 @suztomo I keep getting test failures that seem related to AVRO. Do we know if we have compatibility issues with newer versions of avro? -- This is an automated message from

[GitHub] [beam] codecov[bot] edited a comment on pull request #16377: [BEAM-13576] update bom

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16377: URL: https://github.com/apache/beam/pull/16377#issuecomment-1002260247 # [Codecov](https://codecov.io/gh/apache/beam/pull/16377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] chamikaramj merged pull request #16246: [BEAM-12391] update avro sink to close the opened file handle directly

2022-01-04 Thread GitBox
chamikaramj merged pull request #16246: URL: https://github.com/apache/beam/pull/16246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsu

[GitHub] [beam] chamikaramj commented on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2022-01-04 Thread GitBox
chamikaramj commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-1005158063 LGTM. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] robertwb commented on pull request #16266: [BEAM-13482] Python fully qualified name external transforms.

2022-01-04 Thread GitBox
robertwb commented on pull request #16266: URL: https://github.com/apache/beam/pull/16266#issuecomment-1005158966 The failures in apache_beam.tools.microbenchmarks_test.MicrobenchmarksTest.test_coders_microbenchmark are irrelevent. -- This is an automated message from the Apache Git Ser

[GitHub] [beam] robertwb merged pull request #16266: [BEAM-13482] Python fully qualified name external transforms.

2022-01-04 Thread GitBox
robertwb merged pull request #16266: URL: https://github.com/apache/beam/pull/16266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] pabloem merged pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2022-01-04 Thread GitBox
pabloem merged pull request #15863: URL: https://github.com/apache/beam/pull/15863 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16377: [BEAM-13576] update bom

2022-01-04 Thread GitBox
codecov[bot] edited a comment on pull request #16377: URL: https://github.com/apache/beam/pull/16377#issuecomment-1002260247 # [Codecov](https://codecov.io/gh/apache/beam/pull/16377?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] suztomo commented on pull request #16377: [BEAM-13576] update bom

2022-01-04 Thread GitBox
suztomo commented on pull request #16377: URL: https://github.com/apache/beam/pull/16377#issuecomment-1005171546 In https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/58/console, I see NoClassDefFoundError : ``` 12:39:49 > Task :runners:google-cloud-dataflow-java:

[GitHub] [beam] suztomo edited a comment on pull request #16377: [BEAM-13576] update bom

2022-01-04 Thread GitBox
suztomo edited a comment on pull request #16377: URL: https://github.com/apache/beam/pull/16377#issuecomment-1005171546 In https://ci-beam.apache.org/job/beam_PostCommit_Java_DataflowV1_PR/58/console, I see NoClassDefFoundError : ``` 12:39:49 > Task :runners:google-cloud-dataflo

[GitHub] [beam] chamikaramj commented on a change in pull request #15765: [BEAM-13091] Generate missing staged names from hash for Dataflow runner

2022-01-04 Thread GitBox
chamikaramj commented on a change in pull request #15765: URL: https://github.com/apache/beam/pull/15765#discussion_r778389100 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -870,16 +873,26 @@ private D

[GitHub] [beam] chamikaramj commented on a change in pull request #16225: [BEAM-13455] Remove duplicated artifacts when using multiple environm…

2022-01-04 Thread GitBox
chamikaramj commented on a change in pull request #16225: URL: https://github.com/apache/beam/pull/16225#discussion_r778391168 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -958,6 +959,11 @@ private De

[GitHub] [beam] chamikaramj commented on a change in pull request #16225: [BEAM-13455] Remove duplicated artifacts when using multiple environm…

2022-01-04 Thread GitBox
chamikaramj commented on a change in pull request #16225: URL: https://github.com/apache/beam/pull/16225#discussion_r778391168 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -958,6 +959,11 @@ private De

[GitHub] [beam] ibzib commented on pull request #16396: [BEAM-13569] Change Spark dependencies to implementation.

2022-01-04 Thread GitBox
ibzib commented on pull request #16396: URL: https://github.com/apache/beam/pull/16396#issuecomment-1005178905 Run Python 3.6 PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] reuvenlax commented on pull request #15984: [BEAM-2791] OrderedListState for Flink

2022-01-04 Thread GitBox
reuvenlax commented on pull request #15984: URL: https://github.com/apache/beam/pull/15984#issuecomment-1005179931 run flink validatesrunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [beam] emilymye closed pull request #16402: [release-2.36.0][BEAM-13541] More intelligent caching of CoGBK values. (#16354)

2022-01-04 Thread GitBox
emilymye closed pull request #16402: URL: https://github.com/apache/beam/pull/16402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] emilymye opened a new pull request #16421: [release-2.36.0][BEAM-13541] More intelligent caching of CoGBK values. (#16354, #16407)

2022-01-04 Thread GitBox
emilymye opened a new pull request #16421: URL: https://github.com/apache/beam/pull/16421 Cherrypick of #16354 and #16407 (replacing https://github.com/apache/beam/pull/16402) Thank you for your contribution! Follow this checklist to help us incorpora

  1   2   >