[GitHub] [beam] ihji commented on a change in pull request #15765: [BEAM-13091] Generate missing staged names from hash for Dataflow runner

2022-01-06 Thread GitBox
ihji commented on a change in pull request #15765: URL: https://github.com/apache/beam/pull/15765#discussion_r779363532 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -870,16 +873,26 @@ private Debuggee

[GitHub] [beam] suztomo opened a new pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
suztomo opened a new pull request #14921: URL: https://github.com/apache/beam/pull/14921 Running the tests with the sp versions of Google Cloud libraries. The library version change was written on top of the tag: v2.30.0-RC1. No intention to merge this to master or 2.30 branch.

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-1006439008 Run Java Precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] github-actions[bot] commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
github-actions[bot] commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-1006439035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] suztomo opened a new pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
suztomo opened a new pull request #16441: URL: https://github.com/apache/beam/pull/16441 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickl

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] commented on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] commented on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-1006472304 SQL Post Commit Tests org.apache.beam.sdk.extensions.sql.meta.provider.pubsub.PubsubTableProviderIT.testSQLSelectsPayloadContentFlat[0] failed: ``` com.google.api.gax.

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-1006472502 Run SQL PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] suztomo commented on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
suztomo commented on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006515910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [beam] suztomo commented on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
suztomo commented on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006517257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] vitaly-ivanov opened a new pull request #16442: [BEAM-13604] NPE while getting null from BigDecimal column

2022-01-06 Thread GitBox
vitaly-ivanov opened a new pull request #16442: URL: https://github.com/apache/beam/pull/16442 Argument values are calculated in any case, so when the base value is null, NPE occures. Thank you for your contribution! Follow this checklist to help us i

[GitHub] [beam] vitaly-ivanov commented on pull request #16442: [BEAM-13604] NPE while getting null from BigDecimal column

2022-01-06 Thread GitBox
vitaly-ivanov commented on pull request #16442: URL: https://github.com/apache/beam/pull/16442#issuecomment-1006574171 R: @timrobertson100 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] vitaly-ivanov commented on pull request #16442: [BEAM-13604] NPE while getting null from BigDecimal column

2022-01-06 Thread GitBox
vitaly-ivanov commented on pull request #16442: URL: https://github.com/apache/beam/pull/16442#issuecomment-1006587020 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-1006626830 Run Java Precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-852365651 # [Codecov](https://codecov.io/gh/apache/beam/pull/14921?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15623: [BEAM-12984]: Add support to collection PCollections from composites

2022-01-06 Thread GitBox
TheNeuralBit commented on a change in pull request #15623: URL: https://github.com/apache/beam/pull/15623#discussion_r779683142 ## File path: sdks/python/apache_beam/runners/interactive/pipeline_fragment_test.py ## @@ -129,6 +129,41 @@ def test_fragment_does_not_prune_teststrea

[GitHub] [beam] TheNeuralBit merged pull request #16440: Fixed empty labels treated as wildcard when matching cache files

2022-01-06 Thread GitBox
TheNeuralBit merged pull request #16440: URL: https://github.com/apache/beam/pull/16440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] TheNeuralBit edited a comment on pull request #16440: Fixed empty labels treated as wildcard when matching cache files

2022-01-06 Thread GitBox
TheNeuralBit edited a comment on pull request #16440: URL: https://github.com/apache/beam/pull/16440#issuecomment-1006734071 For posterity: this is fixing a bug reported in https://github.com/apache/beam/pull/15623#discussion_r779205403 -- This is an automated message from the Apache Git

[GitHub] [beam] TheNeuralBit commented on pull request #16440: Fixed empty labels treated as wildcard when matching cache files

2022-01-06 Thread GitBox
TheNeuralBit commented on pull request #16440: URL: https://github.com/apache/beam/pull/16440#issuecomment-1006734071 For posterity: this is fixing a bug reported here: https://github.com/apache/beam/pull/15623#discussion_r779205403 -- This is an automated message from the Apache Git Ser

[GitHub] [beam] lukecwik merged pull request #16438: [BEAM-13570] Remove erroneous compileClasspath dependency.

2022-01-06 Thread GitBox
lukecwik merged pull request #16438: URL: https://github.com/apache/beam/pull/16438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] lukecwik merged pull request #16423: [BEAM-13015] Plumb through process wide and bundle cache through the FnApiStateAccessor.

2022-01-06 Thread GitBox
lukecwik merged pull request #16423: URL: https://github.com/apache/beam/pull/16423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] suztomo commented on pull request #14921: [WIP][no need to review] Testing the sp versions of Google Cloud libraries

2022-01-06 Thread GitBox
suztomo commented on pull request #14921: URL: https://github.com/apache/beam/pull/14921#issuecomment-1006753670 GoPortable, Java Hadoop Versions Post Commit, Java_PVR_Flink_Batch, and Java_PVR_Flink_Docker failed but these are not my interest. Other tests succeeded. -- This is an autom

[GitHub] [beam] suztomo commented on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
suztomo commented on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006754027 Run PostCommit_Java_DataflowV2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [beam] lukecwik commented on pull request #16409: [BEAM-13015] Cache the state backed iterable used for large GBK results.

2022-01-06 Thread GitBox
lukecwik commented on pull request #16409: URL: https://github.com/apache/beam/pull/16409#issuecomment-1006754696 > Thanks, LGTM. Would this be safe in memory usage increased by caching? The cache has an upper bound of 20% of max JVM allocated memory or 100mb if the max is unspecifie

[GitHub] [beam] lukecwik merged pull request #16409: [BEAM-13015] Cache the state backed iterable used for large GBK results.

2022-01-06 Thread GitBox
lukecwik merged pull request #16409: URL: https://github.com/apache/beam/pull/16409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16267: [BEAM-10277] re-write encoding position tests to declare schema protos explicitly

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16267: URL: https://github.com/apache/beam/pull/16267#issuecomment-996360630 # [Codecov](https://codecov.io/gh/apache/beam/pull/16267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] timrobertson100 merged pull request #16442: [BEAM-13604] NPE while getting null from BigDecimal column

2022-01-06 Thread GitBox
timrobertson100 merged pull request #16442: URL: https://github.com/apache/beam/pull/16442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-

[GitHub] [beam] timrobertson100 commented on pull request #16442: [BEAM-13604] NPE while getting null from BigDecimal column

2022-01-06 Thread GitBox
timrobertson100 commented on pull request #16442: URL: https://github.com/apache/beam/pull/16442#issuecomment-1006759383 Thanks @vitaly-ivanov -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] lukecwik opened a new pull request #16443: Fix formatting/alignment

2022-01-06 Thread GitBox
lukecwik opened a new pull request #16443: URL: https://github.com/apache/beam/pull/16443 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

[GitHub] [beam] lukecwik commented on pull request #16443: Fix formatting/alignment

2022-01-06 Thread GitBox
lukecwik commented on pull request #16443: URL: https://github.com/apache/beam/pull/16443#issuecomment-1006761622 R: @ihji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] lukecwik merged pull request #16443: Fix formatting/alignment

2022-01-06 Thread GitBox
lukecwik merged pull request #16443: URL: https://github.com/apache/beam/pull/16443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] pabloem merged pull request #16183: [BEAM-13427] [Playground] show logs for precompiled objects

2022-01-06 Thread GitBox
pabloem merged pull request #16183: URL: https://github.com/apache/beam/pull/16183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16267: [BEAM-10277] re-write encoding position tests to declare schema protos explicitly

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16267: URL: https://github.com/apache/beam/pull/16267#issuecomment-996360630 # [Codecov](https://codecov.io/gh/apache/beam/pull/16267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16267: [BEAM-10277] re-write encoding position tests to declare schema protos explicitly

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16267: URL: https://github.com/apache/beam/pull/16267#issuecomment-996360630 # [Codecov](https://codecov.io/gh/apache/beam/pull/16267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16267: [BEAM-10277] re-write encoding position tests to declare schema protos explicitly

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16267: URL: https://github.com/apache/beam/pull/16267#issuecomment-996360630 # [Codecov](https://codecov.io/gh/apache/beam/pull/16267?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] aromanenko-dev commented on a change in pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-06 Thread GitBox
aromanenko-dev commented on a change in pull request #16128: URL: https://github.com/apache/beam/pull/16128#discussion_r779735655 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/coders/AwsCoders.java ## @@ -0,0 +1,135 @@ +/* + * Licens

[GitHub] [beam] TheNeuralBit merged pull request #16267: [BEAM-10277] re-write encoding position tests to declare schema protos explicitly

2022-01-06 Thread GitBox
TheNeuralBit merged pull request #16267: URL: https://github.com/apache/beam/pull/16267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] emilymye merged pull request #16421: [release-2.36.0][BEAM-13541] More intelligent caching of CoGBK values. (#16354, #16407)

2022-01-06 Thread GitBox
emilymye merged pull request #16421: URL: https://github.com/apache/beam/pull/16421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] TheNeuralBit opened a new pull request #16444: Minor: Fix local_env_tests.yml syntax error

2022-01-06 Thread GitBox
TheNeuralBit opened a new pull request #16444: URL: https://github.com/apache/beam/pull/16444 local_env_tests.yml has been failing since https://github.com/apache/beam/pull/16291 Seems to be due to a minor typo. `ValidatesRunner` compliance status (on master branch) ---

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] TheNeuralBit opened a new pull request #16445: [WIP] Proof of concept for DataFrame plotting tools

2022-01-06 Thread GitBox
TheNeuralBit opened a new pull request #16445: URL: https://github.com/apache/beam/pull/16445 `ValidatesRunner` compliance status (on master branch) Lang ULR Dataflow Flink

[GitHub] [beam] lostluck opened a new pull request #16446: [BEAM-13597] Setup Go in github actions

2022-01-06 Thread GitBox
lostluck opened a new pull request #16446: URL: https://github.com/apache/beam/pull/16446 With the removal of the GoGradlePlugin, we use our own shell scripts to deal with Go builds (such as for container boot scripts), but this mandates a minimum version of Go 1.16. This updates ou

[GitHub] [beam] lukecwik opened a new pull request #16447: [BEAM-13015] Remove dead code now that all instances have migrated to the state caching implementation.

2022-01-06 Thread GitBox
lukecwik opened a new pull request #16447: URL: https://github.com/apache/beam/pull/16447 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] lukecwik commented on pull request #16447: [BEAM-13015] Remove dead code now that all instances have migrated to the state caching implementation.

2022-01-06 Thread GitBox
lukecwik commented on pull request #16447: URL: https://github.com/apache/beam/pull/16447#issuecomment-1006840863 R: @ihji -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] lostluck commented on pull request #16444: Minor: Fix local_env_tests.yml syntax error

2022-01-06 Thread GitBox
lostluck commented on pull request #16444: URL: https://github.com/apache/beam/pull/16444#issuecomment-1006843673 lol. Was just working on that (https://github.com/apache/beam/pull/16446) due to https://issues.apache.org/jira/browse/BEAM-13597 -- This is an automated message from the Apa

[GitHub] [beam] lostluck merged pull request #16444: Minor: Fix local_env_tests.yml syntax error

2022-01-06 Thread GitBox
lostluck merged pull request #16444: URL: https://github.com/apache/beam/pull/16444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] lukecwik commented on pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2022-01-06 Thread GitBox
lukecwik commented on pull request #15378: URL: https://github.com/apache/beam/pull/15378#issuecomment-1006879983 I don't think it should be reverted but better care around adding new test categories without verifying them should be done in the future. -- This is an automated message fro

[GitHub] [beam] lostluck commented on pull request #16446: [BEAM-13597] Setup Go in github actions

2022-01-06 Thread GitBox
lostluck commented on pull request #16446: URL: https://github.com/apache/beam/pull/16446#issuecomment-1006881952 R: @TheNeuralBit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] suztomo commented on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
suztomo commented on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006884715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [beam] ibzib commented on pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2022-01-06 Thread GitBox
ibzib commented on pull request #15378: URL: https://github.com/apache/beam/pull/15378#issuecomment-1006885097 I've proposed making Flink/Spark validates runner tests precommits for `runners/flink` and `runners/spark` file changes respectively, as well as `sdks/java/core/src/test/java/org/

[GitHub] [beam] AnandInguva opened a new pull request #16448: [BEAM-4032]Download whl if the container image is the default container image.

2022-01-06 Thread GitBox
AnandInguva opened a new pull request #16448: URL: https://github.com/apache/beam/pull/16448 If a user uses default container image, the target platform is debian. Here we can download whls instead of sources which would decrease startup time of the workers.

[GitHub] [beam] aaltay commented on pull request #16156: [BEAM-13391] Fix temporary file format in WriteToBigQuery

2022-01-06 Thread GitBox
aaltay commented on pull request #16156: URL: https://github.com/apache/beam/pull/16156#issuecomment-1006890742 @satybald @chunyang - Is this ready for a review by a Beam committer? It looks like there is some open comments and the change needs to be rebased. R: @pabloem could help w

[GitHub] [beam] TheNeuralBit commented on a change in pull request #16256: [WIP][BEAM-12562] Dataframe pipe implementation

2022-01-06 Thread GitBox
TheNeuralBit commented on a change in pull request #16256: URL: https://github.com/apache/beam/pull/16256#discussion_r779855416 ## File path: sdks/python/apache_beam/dataframe/frames_test.py ## @@ -1245,6 +1245,39 @@ def test_idxmax(self): self._run_test(lambda s2: s2.idxm

[GitHub] [beam] codecov[bot] commented on pull request #16448: [BEAM-4032]Download whl if the container image is the default container image.

2022-01-06 Thread GitBox
codecov[bot] commented on pull request #16448: URL: https://github.com/apache/beam/pull/16448#issuecomment-1006925634 # [Codecov](https://codecov.io/gh/apache/beam/pull/16448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16448: [BEAM-4032]Download whl if the container image is the default container image.

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16448: URL: https://github.com/apache/beam/pull/16448#issuecomment-1006925634 # [Codecov](https://codecov.io/gh/apache/beam/pull/16448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16448: [BEAM-4032]Download whl if the container image is the default container image.

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16448: URL: https://github.com/apache/beam/pull/16448#issuecomment-1006925634 # [Codecov](https://codecov.io/gh/apache/beam/pull/16448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AnandInguva commented on pull request #16448: [BEAM-4032]Download whl if the container image is the default container image.

2022-01-06 Thread GitBox
AnandInguva commented on pull request #16448: URL: https://github.com/apache/beam/pull/16448#issuecomment-1006953389 cc: @tvalentyn. Still verifying if these files match the files that the worker looks for in the requirements cache -- This is an automated message from the Apache

[GitHub] [beam] codecov[bot] edited a comment on pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16441: URL: https://github.com/apache/beam/pull/16441#issuecomment-1006469627 # [Codecov](https://codecov.io/gh/apache/beam/pull/16441?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16428: [BEAM-13574] Filesystem abstraction Rename support

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16428: URL: https://github.com/apache/beam/pull/16428#issuecomment-1005930475 # [Codecov](https://codecov.io/gh/apache/beam/pull/16428?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16428: [BEAM-13574] Filesystem abstraction Rename support

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16428: URL: https://github.com/apache/beam/pull/16428#issuecomment-1005930475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16428: [BEAM-13574] Filesystem abstraction Rename support

2022-01-06 Thread GitBox
codecov[bot] edited a comment on pull request #16428: URL: https://github.com/apache/beam/pull/16428#issuecomment-1005930475 # [Codecov](https://codecov.io/gh/apache/beam/pull/16428?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck merged pull request #16428: [BEAM-13574] Filesystem abstraction Rename support

2022-01-06 Thread GitBox
lostluck merged pull request #16428: URL: https://github.com/apache/beam/pull/16428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] lostluck merged pull request #16446: [BEAM-13597] Setup Go in github actions

2022-01-06 Thread GitBox
lostluck merged pull request #16446: URL: https://github.com/apache/beam/pull/16446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] tvalentyn commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-06 Thread GitBox
tvalentyn commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1006991862 > I wonder if we can skip those tests for the three runners and link to a new Jira to continue with this activity, or do you think is it better to fix those here? Skipping

[GitHub] [beam] tvalentyn edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-06 Thread GitBox
tvalentyn edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1006991862 > I wonder if we can skip those tests for the three runners and link to a new Jira to continue with this activity, or do you think is it better to fix those here?

[GitHub] [beam] aaltay commented on pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2022-01-06 Thread GitBox
aaltay commented on pull request #15378: URL: https://github.com/apache/beam/pull/15378#issuecomment-1006992749 I agree with @lukecwik, and @ibzib's proposal sounds like a good idea to enforce that. @ibzib - How do we proceed with your proposal? Are you planning to do that? Are you

[GitHub] [beam] ibzib commented on pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2022-01-06 Thread GitBox
ibzib commented on pull request #15378: URL: https://github.com/apache/beam/pull/15378#issuecomment-1006996158 We've converted portable Flink VR to a precommit already, I'll follow up with other jobs later. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [beam] KevinGG commented on pull request #15562: [BEAM-11985] Python Bigtable - Implement IO Request Count metrics

2022-01-06 Thread GitBox
KevinGG commented on pull request #15562: URL: https://github.com/apache/beam/pull/15562#issuecomment-1006998611 @rashidjeffreysky, @aaltay The expected behavior is a single response (based on the [REST API](https://cloud.google.com/bigtable/docs/reference/data/rpc/google.bigtable.v2#mu

  1   2   >