[GitHub] [beam] mosche commented on pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-10 Thread GitBox
mosche commented on pull request #16287: URL: https://github.com/apache/beam/pull/16287#issuecomment-1008627385 @masahitojp Sorry, I was off for a couple of days. Thanks for the changes! I'm aware RedisIO API doesn't contain breaking changes, though (while unlikely) a user might directly

[GitHub] [beam] AydarZaynutdinov commented on pull request #16344: [BEAM-13536][Playground][Bugfix] CI step doesn't log case with empty category value

2022-01-10 Thread GitBox
AydarZaynutdinov commented on pull request #16344: URL: https://github.com/apache/beam/pull/16344#issuecomment-1008634192 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] mosche commented on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
mosche commented on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-1008711308 @aromanenko-dev Could you have a look at the discussions on the previous PR for sdk v1 https://github.com/apache/beam/pull/9758 pls? A lot was already covered there. I tri

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] vitaly-ivanov commented on pull request #16451: [BEAM-13609] Not all variable length types works properly for Oracle DB

2022-01-10 Thread GitBox
vitaly-ivanov commented on pull request #16451: URL: https://github.com/apache/beam/pull/16451#issuecomment-1008724892 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] vitaly-ivanov removed a comment on pull request #16451: [BEAM-13609] Not all variable length types works properly for Oracle DB

2022-01-10 Thread GitBox
vitaly-ivanov removed a comment on pull request #16451: URL: https://github.com/apache/beam/pull/16451#issuecomment-1007446643 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] aromanenko-dev merged pull request #16456: [BEAM-8727] Bump software.amazon.awssdk to 2.17.106

2022-01-10 Thread GitBox
aromanenko-dev merged pull request #16456: URL: https://github.com/apache/beam/pull/16456 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] mosche commented on a change in pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-10 Thread GitBox
mosche commented on a change in pull request #16284: URL: https://github.com/apache/beam/pull/16284#discussion_r780965560 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/UuidLogicalType.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] ElessarST commented on a change in pull request #16363: [BEAM-13557] [Playground] show code execution time

2022-01-10 Thread GitBox
ElessarST commented on a change in pull request #16363: URL: https://github.com/apache/beam/pull/16363#discussion_r781123538 ## File path: playground/frontend/lib/pages/playground/states/playground_state.dart ## @@ -156,6 +166,39 @@ class PlaygroundState with ChangeNotifier {

[GitHub] [beam] ElessarST commented on a change in pull request #16385: [BEAM-13535] [Playground] add cancel execution button

2022-01-10 Thread GitBox
ElessarST commented on a change in pull request #16385: URL: https://github.com/apache/beam/pull/16385#discussion_r781127063 ## File path: playground/frontend/lib/pages/playground/states/playground_state.dart ## @@ -141,6 +143,18 @@ class PlaygroundState with ChangeNotifier {

[GitHub] [beam] ElessarST commented on a change in pull request #16385: [BEAM-13535] [Playground] add cancel execution button

2022-01-10 Thread GitBox
ElessarST commented on a change in pull request #16385: URL: https://github.com/apache/beam/pull/16385#discussion_r781134276 ## File path: playground/frontend/lib/modules/editor/repository/code_repository/run_code_result.dart ## @@ -58,17 +60,22 @@ class RunCodeResult {

[GitHub] [beam] masahitojp commented on pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-10 Thread GitBox
masahitojp commented on pull request #16287: URL: https://github.com/apache/beam/pull/16287#issuecomment-1008813993 @mosche I see what you mean, I agree with you completely. I'll add this to "breaking changes" in the next version (2.36.0?) at changes.md 😄 -- This is an automated message

[GitHub] [beam] masahitojp commented on pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-10 Thread GitBox
masahitojp commented on pull request #16287: URL: https://github.com/apache/beam/pull/16287#issuecomment-1008815564 @mosche Thanks. I updated CHANGES.md , Please review again 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pavel-avilov commented on a change in pull request #16384: [BEAM-13308] [Playground] Getting baseFileFolder from environment

2022-01-10 Thread GitBox
pavel-avilov commented on a change in pull request #16384: URL: https://github.com/apache/beam/pull/16384#discussion_r781148643 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper_test.go ## @@ -47,16 +48,17 @@ func TestSetup(t *testing.T) {

[GitHub] [beam] codecov[bot] edited a comment on pull request #16147: [BEAM-13359] [Playground] Tag existing examples

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16147: URL: https://github.com/apache/beam/pull/16147#issuecomment-987788733 # [Codecov](https://codecov.io/gh/apache/beam/pull/16147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pavel-avilov commented on pull request #16384: [BEAM-13308] [Playground] Getting baseFileFolder from environment

2022-01-10 Thread GitBox
pavel-avilov commented on pull request #16384: URL: https://github.com/apache/beam/pull/16384#issuecomment-1008831544 @AydarZaynutdinov I added your suggested changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [beam] aromanenko-dev commented on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
aromanenko-dev commented on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1008831857 @mosche Thanks, fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16147: [BEAM-13359] [Playground] Tag existing examples

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16147: URL: https://github.com/apache/beam/pull/16147#issuecomment-987788733 # [Codecov](https://codecov.io/gh/apache/beam/pull/16147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] mosche commented on pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-10 Thread GitBox
mosche commented on pull request #16287: URL: https://github.com/apache/beam/pull/16287#issuecomment-1008863944 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] vitaly-ivanov commented on a change in pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-10 Thread GitBox
vitaly-ivanov commented on a change in pull request #16284: URL: https://github.com/apache/beam/pull/16284#discussion_r781192128 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/UuidLogicalType.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] [beam] vitaly-ivanov commented on a change in pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-10 Thread GitBox
vitaly-ivanov commented on a change in pull request #16284: URL: https://github.com/apache/beam/pull/16284#discussion_r781192389 ## File path: sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/SchemaUtil.java ## @@ -105,7 +108,8 @@ Schema.Field create(int index,

[GitHub] [beam] vitaly-ivanov commented on a change in pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-10 Thread GitBox
vitaly-ivanov commented on a change in pull request #16284: URL: https://github.com/apache/beam/pull/16284#discussion_r781192749 ## File path: sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/JdbcIOTest.java ## @@ -706,7 +710,9 @@ public void testWriteWithoutPrepare

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16147: [BEAM-13359] [Playground] Tag existing examples

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16147: URL: https://github.com/apache/beam/pull/16147#issuecomment-987788733 # [Codecov](https://codecov.io/gh/apache/beam/pull/16147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] vitaly-ivanov commented on a change in pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-10 Thread GitBox
vitaly-ivanov commented on a change in pull request #16284: URL: https://github.com/apache/beam/pull/16284#discussion_r781198467 ## File path: sdks/java/io/jdbc/src/test/java/org/apache/beam/sdk/io/jdbc/OtherJdbcTypesIT.java ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16128: [BEAM-13243][BEAM-8374] Add support for missing PublishResponse fields in SnsIO.Write (AWS SDK v2)

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16128: URL: https://github.com/apache/beam/pull/16128#issuecomment-985693866 # [Codecov](https://codecov.io/gh/apache/beam/pull/16128?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] aromanenko-dev commented on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
aromanenko-dev commented on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1008929386 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] mosche opened a new pull request #16468: [BEAM-8806] Integration test for SqsIO using Localstack

2022-01-10 Thread GitBox
mosche opened a new pull request #16468: URL: https://github.com/apache/beam/pull/16468 Integration test for SqsIO using Localstack (or AWS SQS) Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and

[GitHub] [beam] mosche commented on pull request #16468: [BEAM-8806] Integration test for SqsIO using Localstack

2022-01-10 Thread GitBox
mosche commented on pull request #16468: URL: https://github.com/apache/beam/pull/16468#issuecomment-1008956773 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16454: URL: https://github.com/apache/beam/pull/16454#issuecomment-1007607190 # [Codecov](https://codecov.io/gh/apache/beam/pull/16454?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AydarZaynutdinov opened a new pull request #16469: [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output

2022-01-10 Thread GitBox
AydarZaynutdinov opened a new pull request #16469: URL: https://github.com/apache/beam/pull/16469 [BEAM-13623] Add getting of error's output from `RunOutput` in case unit test is failed Thank you for your contribution! Follow this checklist to help u

[GitHub] [beam] AydarZaynutdinov commented on pull request #16469: [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output

2022-01-10 Thread GitBox
AydarZaynutdinov commented on pull request #16469: URL: https://github.com/apache/beam/pull/16469#issuecomment-1009016572 R: @KhaninArtur @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] KhaninArtur commented on a change in pull request #16469: [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output

2022-01-10 Thread GitBox
KhaninArtur commented on a change in pull request #16469: URL: https://github.com/apache/beam/pull/16469#discussion_r781320645 ## File path: playground/backend/internal/code_processing/code_processing.go ## @@ -189,8 +189,13 @@ func Process(ctx context.Context, cacheService ca

[GitHub] [beam] jrmccluskey opened a new pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
jrmccluskey opened a new pull request #16470: URL: https://github.com/apache/beam/pull/16470 Adds automated TCP port selection for the expansion service runner if a port isn't specified rather than defaulting to `localhost:8097`. Also updates relevant unit tests and integration test. --

[GitHub] [beam] codecov[bot] commented on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] commented on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] jrmccluskey commented on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
jrmccluskey commented on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009037483 Run Go Spark ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] jrmccluskey commented on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
jrmccluskey commented on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009037699 Run Go Samza ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] jrmccluskey commented on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
jrmccluskey commented on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009054740 R: @lostluck @youngoli Took the hard-coded 8097 port out. Codecov is a little under the bar but not by much, and the tests are all happy -- This is an automated me

[GitHub] [beam] codecov[bot] edited a comment on pull request #16256: [WIP][BEAM-12562] Dataframe pipe implementation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16256: URL: https://github.com/apache/beam/pull/16256#issuecomment-996042622 # [Codecov](https://codecov.io/gh/apache/beam/pull/16256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] aromanenko-dev merged pull request #16454: [BEAM-4868] Bump com.amazonaws to 1.12.135

2022-01-10 Thread GitBox
aromanenko-dev merged pull request #16454: URL: https://github.com/apache/beam/pull/16454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] codecov[bot] edited a comment on pull request #16256: [BEAM-12562] Dataframe pipe implementation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16256: URL: https://github.com/apache/beam/pull/16256#issuecomment-996042622 # [Codecov](https://codecov.io/gh/apache/beam/pull/16256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] aromanenko-dev merged pull request #16287: [BEAM-12092] Bump jedis to version 4.0.1

2022-01-10 Thread GitBox
aromanenko-dev merged pull request #16287: URL: https://github.com/apache/beam/pull/16287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] lostluck commented on a change in pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
lostluck commented on a change in pull request #16470: URL: https://github.com/apache/beam/pull/16470#discussion_r781358735 ## File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go ## @@ -30,20 +31,39 @@ type ExpansionServiceRunner struct { serviceComman

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16469: [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output

2022-01-10 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16469: URL: https://github.com/apache/beam/pull/16469#discussion_r781376441 ## File path: playground/backend/internal/code_processing/code_processing.go ## @@ -189,8 +189,13 @@ func Process(ctx context.Context, cacheServic

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-10 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1009133802 Run Python Examples_Direct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] jrmccluskey commented on a change in pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
jrmccluskey commented on a change in pull request #16470: URL: https://github.com/apache/beam/pull/16470#discussion_r781386046 ## File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process_test.go ## @@ -22,15 +22,28 @@ import ( "testing" ) +func TestFindOpen

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-10 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1009143283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16469: [BEAM-13623][Playground] [Bugfix] During unit tests failing there is no any output

2022-01-10 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16469: URL: https://github.com/apache/beam/pull/16469#discussion_r781387542 ## File path: playground/backend/internal/code_processing/code_processing.go ## @@ -189,8 +189,13 @@ func Process(ctx context.Context, cacheServic

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-10 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1009143702 Run Python Examples_Dataflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] jrmccluskey commented on a change in pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
jrmccluskey commented on a change in pull request #16470: URL: https://github.com/apache/beam/pull/16470#discussion_r781387880 ## File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go ## @@ -30,20 +31,39 @@ type ExpansionServiceRunner struct { serviceCom

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck commented on a change in pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
lostluck commented on a change in pull request #16470: URL: https://github.com/apache/beam/pull/16470#discussion_r781391174 ## File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go ## @@ -30,20 +31,40 @@ type ExpansionServiceRunner struct { serviceComman

[GitHub] [beam] codecov[bot] edited a comment on pull request #16256: [BEAM-12562] Dataframe pipe implementation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16256: URL: https://github.com/apache/beam/pull/16256#issuecomment-996042622 # [Codecov](https://codecov.io/gh/apache/beam/pull/16256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] jrmccluskey commented on a change in pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
jrmccluskey commented on a change in pull request #16470: URL: https://github.com/apache/beam/pull/16470#discussion_r781398709 ## File path: sdks/go/pkg/beam/core/runtime/xlangx/expansionx/process.go ## @@ -30,20 +31,40 @@ type ExpansionServiceRunner struct { serviceCom

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16470: [BEAM-13534] Add automated port polling to expansion service runner if port isn't provided

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16470: URL: https://github.com/apache/beam/pull/16470#issuecomment-1009033892 # [Codecov](https://codecov.io/gh/apache/beam/pull/16470?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-10 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1009175241 Hi @tvalentyn, with the skipped tests, all the test suites are passing now - [Dataflow](https://ci-beam.apache.org/job/beam_PostCommit_Python_Examples_Dataflow/11/testReport/)

[GitHub] [beam] chamikaramj commented on pull request #16464: [BEAM-13617] don't close streams in finalize

2022-01-10 Thread GitBox
chamikaramj commented on pull request #16464: URL: https://github.com/apache/beam/pull/16464#issuecomment-1009184845 LGTM. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration as a requirement so that portable runners can reject such jobs.

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] roger-mike commented on pull request #16256: [BEAM-12562] Dataframe pipe implementation

2022-01-10 Thread GitBox
roger-mike commented on pull request #16256: URL: https://github.com/apache/beam/pull/16256#issuecomment-1009205012 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] emilymye closed pull request #16397: Add empty file in order to create PR

2022-01-10 Thread GitBox
emilymye closed pull request #16397: URL: https://github.com/apache/beam/pull/16397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16256: [BEAM-12562] Dataframe pipe implementation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16256: URL: https://github.com/apache/beam/pull/16256#issuecomment-996042622 # [Codecov](https://codecov.io/gh/apache/beam/pull/16256?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 # [Codecov](https://codecov.io/gh/apache/beam/pull/16458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16458: [BEAM-13614] Add OnWindowExpiration support to the Java SDK harness and proto translation

2022-01-10 Thread GitBox
codecov[bot] edited a comment on pull request #16458: URL: https://github.com/apache/beam/pull/16458#issuecomment-1007741254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

  1   2   3   >