[GitHub] [beam] ihji merged pull request #16225: [BEAM-13455] Remove duplicated artifacts when using multiple environm…

2022-01-14 Thread GitBox
ihji merged pull request #16225: URL: https://github.com/apache/beam/pull/16225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [beam] ihji commented on pull request #15767: [BEAM-13093] Enable JavaUsingPython CrossLanguageValidateRunner test …

2022-01-14 Thread GitBox
ihji commented on pull request #15767: URL: https://github.com/apache/beam/pull/15767#issuecomment-1012927405 Run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] ihji removed a comment on pull request #15767: [BEAM-13093] Enable JavaUsingPython CrossLanguageValidateRunner test …

2022-01-14 Thread GitBox
ihji removed a comment on pull request #15767: URL: https://github.com/apache/beam/pull/15767#issuecomment-1012927405 Run seed job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] tvalentyn commented on a change in pull request #16457: [BEAM-12621] - Update Jenkins VMs to modern Ubuntu version

2022-01-14 Thread GitBox
tvalentyn commented on a change in pull request #16457: URL: https://github.com/apache/beam/pull/16457#discussion_r784335180 ## File path: .test-infra/tools/python_installer.sh ## @@ -0,0 +1,92 @@ +#!/usr/bin/env bash +# +#Licensed to the Apache Software Foundation (ASF) un

[GitHub] [beam] ihji commented on pull request #15767: [BEAM-13093] Enable JavaUsingPython CrossLanguageValidateRunner test …

2022-01-14 Thread GitBox
ihji commented on pull request #15767: URL: https://github.com/apache/beam/pull/15767#issuecomment-1012933779 Run xvr_javausingpython_dataflow postcommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [beam] ihji removed a comment on pull request #15767: [BEAM-13093] Enable JavaUsingPython CrossLanguageValidateRunner test …

2022-01-14 Thread GitBox
ihji removed a comment on pull request #15767: URL: https://github.com/apache/beam/pull/15767#issuecomment-1012933779 Run xvr_javausingpython_dataflow postcommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [beam] aromanenko-dev commented on pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-14 Thread GitBox
aromanenko-dev commented on pull request #16284: URL: https://github.com/apache/beam/pull/16284#issuecomment-1012944066 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] KhaninArtur commented on a change in pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-14 Thread GitBox
KhaninArtur commented on a change in pull request #16515: URL: https://github.com/apache/beam/pull/16515#discussion_r784646242 ## File path: playground/infrastructure/logger.py ## @@ -33,7 +33,7 @@ def setup_logger(): log = logging.getLogger() log.setLevel(logging.INFO)

[GitHub] [beam] Krasavinigor opened a new pull request #16516: [Databeam 129] Add ContextWrapper for Context classes in CDAP

2022-01-14 Thread GitBox
Krasavinigor opened a new pull request #16516: URL: https://github.com/apache/beam/pull/16516 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution q

[GitHub] [beam] Krasavinigor closed pull request #16516: [Databeam 129] Add ContextWrapper for Context classes in CDAP

2022-01-14 Thread GitBox
Krasavinigor closed pull request #16516: URL: https://github.com/apache/beam/pull/16516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] tvalentyn commented on a change in pull request #16457: [BEAM-12621] - Update Jenkins VMs to modern Ubuntu version

2022-01-14 Thread GitBox
tvalentyn commented on a change in pull request #16457: URL: https://github.com/apache/beam/pull/16457#discussion_r784676692 ## File path: .test-infra/tools/python_installer.sh ## @@ -0,0 +1,92 @@ +#!/usr/bin/env bash +# +#Licensed to the Apache Software Foundation (ASF) un

[GitHub] [beam] tvalentyn merged pull request #16450: [BEAM-12572] Run java examples on multiple runners

2022-01-14 Thread GitBox
tvalentyn merged pull request #16450: URL: https://github.com/apache/beam/pull/16450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] tvalentyn commented on pull request #16386: [Beam-12622] Modified PR Trigger Phrases Jenkins tests and README updated with changes and missed jobs

2022-01-14 Thread GitBox
tvalentyn commented on pull request #16386: URL: https://github.com/apache/beam/pull/16386#issuecomment-1012994027 Missed the last comment - could you please try to go to https://github.com/apache/beam/pull/13626 and type the seed job command there in a comment once you are ready? I won

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] echauchot commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
echauchot commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013062209 Thanks for work work @egalpin, taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [beam] echauchot commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
echauchot commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013063017 > All previously skipped tests passed: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20510/testReport/org.apache.beam.sdk.io.elasticsearch/ElasticsearchIOTest/ >

[GitHub] [beam] echauchot edited a comment on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
echauchot edited a comment on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013063017 > All previously skipped tests passed: https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/20510/testReport/org.apache.beam.sdk.io.elasticsearch/ElasticsearchIOTes

[GitHub] [beam] miamihotline commented on a change in pull request #16505: [BEAM-13527] [Playground] Pipeline options dialog

2022-01-14 Thread GitBox
miamihotline commented on a change in pull request #16505: URL: https://github.com/apache/beam/pull/16505#discussion_r784796139 ## File path: playground/frontend/lib/modules/editor/components/pipeline_options_dropdown/pipeline_options_dropdown_input.dart ## @@ -0,0 +1,46 @@ +/

[GitHub] [beam] nielm commented on pull request #15493: [BEAM-11982] Java Spanner - Implement IO Request Count metrics

2022-01-14 Thread GitBox
nielm commented on pull request #15493: URL: https://github.com/apache/beam/pull/15493#issuecomment-1013080316 Note: This PR makes the GCP projectID a required parameter - which it was not before, as it could be inferred from the environment - and thus breaks backward compatibility.

[GitHub] [beam] SandyChapman opened a new pull request #16517: BEAM-13439 Type annotation for ptransform_fn

2022-01-14 Thread GitBox
SandyChapman opened a new pull request #16517: URL: https://github.com/apache/beam/pull/16517 Because the return type of the ptransform_fn is not specified, [certain typecheckers](https://github.com/microsoft/pyright/issues/2688#issuecomment-990238720) will assume the type signature of fun

[GitHub] [beam] SandyChapman commented on pull request #16517: BEAM-13439 Type annotation for ptransform_fn

2022-01-14 Thread GitBox
SandyChapman commented on pull request #16517: URL: https://github.com/apache/beam/pull/16517#issuecomment-1013086159 @robertwb Can you review this please? Kenneth Knowles mentioned you may be a good reviewer for this change. -- This is an automated message from the Apache Git Service. T

[GitHub] [beam] codecov[bot] commented on pull request #16517: BEAM-13439 Type annotation for ptransform_fn

2022-01-14 Thread GitBox
codecov[bot] commented on pull request #16517: URL: https://github.com/apache/beam/pull/16517#issuecomment-1013099750 # [Codecov](https://codecov.io/gh/apache/beam/pull/16517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] miamihotline opened a new pull request #16518: [BEAM-13619] [Playground] Add loading animation to the catalog

2022-01-14 Thread GitBox
miamihotline opened a new pull request #16518: URL: https://github.com/apache/beam/pull/16518 Added loading animation to the catalog Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] miamihotline opened a new pull request #16519: [BEAM-13639] [Playground] Add notification to Log/Output tabs about cached example

2022-01-14 Thread GitBox
miamihotline opened a new pull request #16519: URL: https://github.com/apache/beam/pull/16519 Added log about cached results for precompiled examples. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly a

[GitHub] [beam] codecov[bot] edited a comment on pull request #16517: BEAM-13439 Type annotation for ptransform_fn

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16517: URL: https://github.com/apache/beam/pull/16517#issuecomment-1013099750 # [Codecov](https://codecov.io/gh/apache/beam/pull/16517?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] RustedBones commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
RustedBones commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r784862869 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroSink.java ## @@ -38,20 +42,52 @@ }) public class AvroSink extends FileBase

[GitHub] [beam] miamihotline commented on pull request #16322: [BEAM-13407] [Playground] Preload fonts for the web application

2022-01-14 Thread GitBox
miamihotline commented on pull request #16322: URL: https://github.com/apache/beam/pull/16322#issuecomment-1013160234 > Hello, @aaltay! Please, check my last commit - did I understand your suggestion in the right way? -- This is an automated message from the Apache Git Service. T

[GitHub] [beam] miamihotline edited a comment on pull request #16322: [BEAM-13407] [Playground] Preload fonts for the web application

2022-01-14 Thread GitBox
miamihotline edited a comment on pull request #16322: URL: https://github.com/apache/beam/pull/16322#issuecomment-1013160234 > Hello, @aaltay! Please, check my last commit, did I understand your suggestion in the right way? -- This is an automated message from the Apache Git Serv

[GitHub] [beam] aromanenko-dev commented on pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types…

2022-01-14 Thread GitBox
aromanenko-dev commented on pull request #16284: URL: https://github.com/apache/beam/pull/16284#issuecomment-1013189234 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] RustedBones commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
RustedBones commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r784913604 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/coders/AvroCoder.java ## @@ -272,26 +263,8 @@ public Schema get() { } } - /*

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-14 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r784923669 ## File path: playground/backend/configs/DEFAULT_EXAMPLES.json ## @@ -0,0 +1,5 @@ +{ Review comment: Done. -- This is an automated messag

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-14 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r784923828 ## File path: playground/backend/internal/cloud_bucket/precompiled_objects.go ## @@ -173,6 +175,30 @@ func (cd *CloudStorage) GetPrecompiledObjects(ct

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-14 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r784926745 ## File path: playground/backend/cmd/server/controller.go ## @@ -294,3 +294,28 @@ func (controller *playgroundController) GetPrecompiledObjectLogs(ct

[GitHub] [beam] suztomo commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-14 Thread GitBox
suztomo commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1013220233 "Java Tests / setup-go" says > Can't find any online and idle self-hosted runner in the current repository, account/organization that matches the required labels: 'ubuntu

[GitHub] [beam] riteshghorse commented on pull request #16455: [BEAM-13574] Large Wordcount

2022-01-14 Thread GitBox
riteshghorse commented on pull request #16455: URL: https://github.com/apache/beam/pull/16455#issuecomment-1013223336 LGTM. I found the example easy to understand and the comments are helpful in that process. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] egalpin commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
egalpin commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013239084 @echauchot I added back the setting `index.store.stats_refresh_interval` as you mentioned in the Jira ticket for this PR. I ran 100 iterations of the test suite and only had one

[GitHub] [beam] egalpin commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
egalpin commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013242039 (force push was to remove a commit from my WIP on BEAM-13136 which snuck into this branch accidentally) -- This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] aromanenko-dev commented on a change in pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

2022-01-14 Thread GitBox
aromanenko-dev commented on a change in pull request #16077: URL: https://github.com/apache/beam/pull/16077#discussion_r784953203 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java ## @@ -522,4 +651,393 @@ public Re

[GitHub] [beam] jrmccluskey opened a new pull request #16520: [BEAM-10206] Resolve go vet errors in protox package

2022-01-14 Thread GitBox
jrmccluskey opened a new pull request #16520: URL: https://github.com/apache/beam/pull/16520 Removes implicit copies of BytesValue objects in test cases, which threw errors when go vet was run. Part of an effort to make the Go SDK code base go vet-compliant. ---

[GitHub] [beam] jrmccluskey commented on pull request #16520: [BEAM-10206] Resolve go vet errors in protox package

2022-01-14 Thread GitBox
jrmccluskey commented on pull request #16520: URL: https://github.com/apache/beam/pull/16520#issuecomment-1013244151 R: @lostluck @youngoli CC: @riteshghorse -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [beam] mosche commented on a change in pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

2022-01-14 Thread GitBox
mosche commented on a change in pull request #16077: URL: https://github.com/apache/beam/pull/16077#discussion_r784956745 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java ## @@ -522,4 +651,393 @@ public Read withM

[GitHub] [beam] codecov[bot] commented on pull request #16520: [BEAM-10206] Resolve go vet errors in protox package

2022-01-14 Thread GitBox
codecov[bot] commented on pull request #16520: URL: https://github.com/apache/beam/pull/16520#issuecomment-1013245670 # [Codecov](https://codecov.io/gh/apache/beam/pull/16520?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] mosche commented on a change in pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

2022-01-14 Thread GitBox
mosche commented on a change in pull request #16077: URL: https://github.com/apache/beam/pull/16077#discussion_r784958608 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java ## @@ -522,4 +651,393 @@ public Read withM

[GitHub] [beam] mosche commented on a change in pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

2022-01-14 Thread GitBox
mosche commented on a change in pull request #16077: URL: https://github.com/apache/beam/pull/16077#discussion_r784958976 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java ## @@ -522,4 +651,393 @@ public Read withM

[GitHub] [beam] codecov[bot] edited a comment on pull request #16520: [BEAM-10206] Resolve go vet errors in protox package

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16520: URL: https://github.com/apache/beam/pull/16520#issuecomment-1013245670 # [Codecov](https://codecov.io/gh/apache/beam/pull/16520?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] mosche commented on a change in pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

2022-01-14 Thread GitBox
mosche commented on a change in pull request #16077: URL: https://github.com/apache/beam/pull/16077#discussion_r784960765 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java ## @@ -522,4 +651,393 @@ public Read withM

[GitHub] [beam] echauchot commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
echauchot commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013249810 > (force push was to remove a commit from my WIP on [BEAM-13136](https://issues.apache.org/jira/browse/BEAM-13136) which snuck into this branch accidentally) I saw the

[GitHub] [beam] echauchot edited a comment on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
echauchot edited a comment on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013249810 > (force push was to remove a commit from my WIP on [BEAM-13136](https://issues.apache.org/jira/browse/BEAM-13136) which snuck into this branch accidentally) I s

[GitHub] [beam] echauchot commented on pull request #16507: [BEAM-13137] Fixes ES utest size flakiness with _flush api

2022-01-14 Thread GitBox
echauchot commented on pull request #16507: URL: https://github.com/apache/beam/pull/16507#issuecomment-1013250235 > @echauchot I added back the setting `index.store.stats_refresh_interval` as you mentioned in the Jira ticket for this PR. I ran 100 iterations of the test suite and only had

[GitHub] [beam] mosche commented on a change in pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

2022-01-14 Thread GitBox
mosche commented on a change in pull request #16077: URL: https://github.com/apache/beam/pull/16077#discussion_r784967763 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/kinesis/KinesisIO.java ## @@ -522,4 +651,393 @@ public Read withM

[GitHub] [beam] mosche commented on pull request #16077: [BEAM-13175] Add KinesisIO.write for AWS SDK v2.

2022-01-14 Thread GitBox
mosche commented on pull request #16077: URL: https://github.com/apache/beam/pull/16077#issuecomment-1013256654 Still planning to run a few more tests on EMR @aromanenko-dev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [beam] KhaninArtur commented on pull request #16373: [BEAM-13515] [Playground] Hiding lines in an example that are not necessary

2022-01-14 Thread GitBox
KhaninArtur commented on pull request #16373: URL: https://github.com/apache/beam/pull/16373#issuecomment-1013258722 R: @damondouglas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] KhaninArtur commented on pull request #16369: [BEAM-13558] [Playground] Hide the Graph tab and SCIO from SDK options

2022-01-14 Thread GitBox
KhaninArtur commented on pull request #16369: URL: https://github.com/apache/beam/pull/16369#issuecomment-1013258843 R: @damondouglas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1013261848 Run Portable_Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] kennknowles commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
kennknowles commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r785007324 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AvroRecordSchema.java ## @@ -32,12 +32,14 @@ * objects, creating a schema tha

[GitHub] [beam] emilymye commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-14 Thread GitBox
emilymye commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1013309890 Run Dataflow ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] RustedBones commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
RustedBones commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r785021987 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AvroRecordSchema.java ## @@ -32,12 +32,14 @@ * objects, creating a schema tha

[GitHub] [beam] aromanenko-dev merged pull request #16284: [BEAM-13400] JDBC IO does not support UUID and JSONB PostgreSQL types and OTHER JDBC types in general

2022-01-14 Thread GitBox
aromanenko-dev merged pull request #16284: URL: https://github.com/apache/beam/pull/16284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] kennknowles commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
kennknowles commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r785028496 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AvroRecordSchema.java ## @@ -32,12 +32,14 @@ * objects, creating a schema tha

[GitHub] [beam] kennknowles commented on pull request #16513: [BEAM-12976] Implement Java projection pushdown optimizer.

2022-01-14 Thread GitBox
kennknowles commented on pull request #16513: URL: https://github.com/apache/beam/pull/16513#issuecomment-1013321519 Me and @pabloem were chatting the other day and I bet he's interested in how this is implemented. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1013323037 Run Python Examples_Direct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] ryanthompson591 commented on pull request #16508: [BEAM-13656] [BEAM-12558] Provide an API to check whether a hint is known.

2022-01-14 Thread GitBox
ryanthompson591 commented on pull request #16508: URL: https://github.com/apache/beam/pull/16508#issuecomment-1013323153 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] RustedBones commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
RustedBones commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r785032910 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AvroRecordSchema.java ## @@ -32,12 +32,14 @@ * objects, creating a schema tha

[GitHub] [beam] aaltay commented on pull request #16322: [BEAM-13407] [Playground] Preload fonts for the web application

2022-01-14 Thread GitBox
aaltay commented on pull request #16322: URL: https://github.com/apache/beam/pull/16322#issuecomment-1013324038 > > > > Hello, @aaltay! Please, check my last commit, did I understand your suggestion in the right way? Yes. I think that is the right direction. I do not

[GitHub] [beam] dpcollins-google commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-14 Thread GitBox
dpcollins-google commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1013324044 Can you please revert the pubsublite changes? The version in the BOM is not high enough. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] dpcollins-google edited a comment on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-14 Thread GitBox
dpcollins-google edited a comment on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1013324044 Can you please revert the pubsublite changes? The version in the BOM is not high enough. EDIT: Apologies, I'm wrong. This change is okay -- This i

[GitHub] [beam] lukecwik commented on pull request #15493: [BEAM-11982] Java Spanner - Implement IO Request Count metrics

2022-01-14 Thread GitBox
lukecwik commented on pull request #15493: URL: https://github.com/apache/beam/pull/15493#issuecomment-1013329775 Thanks, filed https://issues.apache.org/jira/browse/BEAM-13665. @nielm is this something you are interested in fixing? -- This is an automated message from the Apache G

[GitHub] [beam] aaltay commented on pull request #15378: [RFC] Define and document per-key ordering semantics for runners

2022-01-14 Thread GitBox
aaltay commented on pull request #15378: URL: https://github.com/apache/beam/pull/15378#issuecomment-1013338703 > We've converted portable Flink VR to a precommit already, I'll follow up with other jobs later. @ibzib, did the Spark VR also become a precommit? -- This is an automat

[GitHub] [beam] chamikaramj commented on pull request #16284: [BEAM-13400] JdbcIO should support UUID and JSONB PostgreSQL types and OTHER JDBC types in general

2022-01-14 Thread GitBox
chamikaramj commented on pull request #16284: URL: https://github.com/apache/beam/pull/16284#issuecomment-1013350313 LGTM. Thanks for adding this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1013366535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [beam] kennknowles commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
kennknowles commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r785075074 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AvroRecordSchema.java ## @@ -32,12 +32,14 @@ * objects, creating a schema tha

[GitHub] [beam] kennknowles commented on a change in pull request #16271: [BEAM-8388] Make sdk-java-core compatible with avro 1.8 & 1.9

2022-01-14 Thread GitBox
kennknowles commented on a change in pull request #16271: URL: https://github.com/apache/beam/pull/16271#discussion_r785076419 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AvroRecordSchema.java ## @@ -32,12 +32,14 @@ * objects, creating a schema tha

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] roger-mike opened a new pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-14 Thread GitBox
roger-mike opened a new pull request #16521: URL: https://github.com/apache/beam/pull/16521 - Lang ULR Dataflow Flink Samza Spark Twister2 Go ---

[GitHub] [beam] roger-mike opened a new pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-14 Thread GitBox
roger-mike opened a new pull request #16522: URL: https://github.com/apache/beam/pull/16522 Lang ULR Dataflow Flink Samza Spark Twister2

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-988168868 # [Codecov](https://codecov.io/gh/apache/beam/pull/16154?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] benWize commented on pull request #16154: [BEAM-12572] Run python examples on multiple runners

2022-01-14 Thread GitBox
benWize commented on pull request #16154: URL: https://github.com/apache/beam/pull/16154#issuecomment-1013382937 Hi @kileys, I merged it with master and JavaPrecommit is not failing now. Results from the last examples jobs: - [Direct](https://ci-beam.apache.org/job/beam_PostCo

[GitHub] [beam] tvalentyn merged pull request #16508: [BEAM-13656] [BEAM-12558] Provide an API to check whether a hint is known.

2022-01-14 Thread GitBox
tvalentyn merged pull request #16508: URL: https://github.com/apache/beam/pull/16508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] suztomo commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-14 Thread GitBox
suztomo commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1013390108 @dpcollins-google Thank you for checking! > This change is okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] suztomo commented on pull request #16509: [BEAM-13616] Update com.google.cloud:libraries-bom to 24.2.0

2022-01-14 Thread GitBox
suztomo commented on pull request #16509: URL: https://github.com/apache/beam/pull/16509#issuecomment-1013390322 "Java Tests / setup-go" doesn't start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] codecov[bot] commented on pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-14 Thread GitBox
codecov[bot] commented on pull request #16521: URL: https://github.com/apache/beam/pull/16521#issuecomment-1013397280 # [Codecov](https://codecov.io/gh/apache/beam/pull/16521?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] commented on pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-14 Thread GitBox
codecov[bot] commented on pull request #16522: URL: https://github.com/apache/beam/pull/16522#issuecomment-1013397583 # [Codecov](https://codecov.io/gh/apache/beam/pull/16522?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] lukecwik commented on a change in pull request #16495: [BEAM-13015] Provide caching statistics in the status client.

2022-01-14 Thread GitBox
lukecwik commented on a change in pull request #16495: URL: https://github.com/apache/beam/pull/16495#discussion_r785104313 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/util/WeightedValue.java ## @@ -47,4 +49,26 @@ public long getWeight() { public T getVal

[GitHub] [beam] codecov[bot] edited a comment on pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-14 Thread GitBox
codecov[bot] edited a comment on pull request #16521: URL: https://github.com/apache/beam/pull/16521#issuecomment-1013397280 # [Codecov](https://codecov.io/gh/apache/beam/pull/16521?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem commented on pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-14 Thread GitBox
pabloem commented on pull request #16477: URL: https://github.com/apache/beam/pull/16477#issuecomment-1013427791 ah this LGTM. Thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] pabloem merged pull request #16477: [BEAM-13560][Playground] Split builder into several builders for each step of the pipeline execution

2022-01-14 Thread GitBox
pabloem merged pull request #16477: URL: https://github.com/apache/beam/pull/16477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] jrmccluskey opened a new pull request #16523: [BEAM-13628] Fix Primitives hashing benchmark

2022-01-14 Thread GitBox
jrmccluskey opened a new pull request #16523: URL: https://github.com/apache/beam/pull/16523 Update Primitives hashing benchmark to successfully execute. Previous benchmark as written led to nil pointer exceptions stemming from a lack of window encoders being put into the hash types.

[GitHub] [beam] jrmccluskey commented on pull request #16523: [BEAM-13628] Fix Primitives hashing benchmark

2022-01-14 Thread GitBox
jrmccluskey commented on pull request #16523: URL: https://github.com/apache/beam/pull/16523#issuecomment-1013431255 R: @lostluck @youngoli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] codecov[bot] commented on pull request #16523: [BEAM-13628] Fix Primitives hashing benchmark

2022-01-14 Thread GitBox
codecov[bot] commented on pull request #16523: URL: https://github.com/apache/beam/pull/16523#issuecomment-1013431947 # [Codecov](https://codecov.io/gh/apache/beam/pull/16523?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

  1   2   3   >