[GitHub] [beam] darshan-sj commented on pull request #16243: Making rpcPriority a ValueProvider in SpannerConfig

2022-01-16 Thread GitBox
darshan-sj commented on pull request #16243: URL: https://github.com/apache/beam/pull/16243#issuecomment-1013878662 @pabloem @nielm Please review this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [beam] darshan-sj opened a new pull request #16530: Adding JSON support in SpannerIO and Spanner schema parser

2022-01-16 Thread GitBox
darshan-sj opened a new pull request #16530: URL: https://github.com/apache/beam/pull/16530 Adding JSON support in SpannerIO and Spanner schema parser Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

[GitHub] [beam] darshan-sj commented on pull request #16530: Adding JSON support in SpannerIO and Spanner schema parser

2022-01-16 Thread GitBox
darshan-sj commented on pull request #16530: URL: https://github.com/apache/beam/pull/16530#issuecomment-1013905459 @pabloem @nielm @allenpradeep Please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [beam] thiagotnunes edited a comment on pull request #16514: [BEAM-12164]: Add SDF for reading change stream records

2022-01-16 Thread GitBox
thiagotnunes edited a comment on pull request #16514: URL: https://github.com/apache/beam/pull/16514#issuecomment-1012783957 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] nielm commented on pull request #16530: Adding JSON support in SpannerIO and Spanner schema parser

2022-01-16 Thread GitBox
nielm commented on pull request #16530: URL: https://github.com/apache/beam/pull/16530#issuecomment-1014229810 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] nielm commented on pull request #16530: Adding JSON support in SpannerIO and Spanner schema parser

2022-01-16 Thread GitBox
nielm commented on pull request #16530: URL: https://github.com/apache/beam/pull/16530#issuecomment-1014230188 LGTM and thanks for the changes. Failing tests seem to be just flakey ones. -- This is an automated message from the Apache Git Service. To respond to the message, please log on