[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16486: [BEAM-13544][Playground] Add logs to examples CI/CD to see the progress

2022-01-18 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16486: URL: https://github.com/apache/beam/pull/16486#discussion_r786501157 ## File path: playground/infrastructure/cd_helper.py ## @@ -26,6 +26,7 @@ from pathlib import Path from typing import List +from tqdm import t

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16506: [BEAM-13652][Playground] Send examples' links to the frontend

2022-01-18 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16506: URL: https://github.com/apache/beam/pull/16506#discussion_r786512078 ## File path: playground/api/v1/api.proto ## @@ -151,6 +151,7 @@ message PrecompiledObject{ string description = 3; PrecompiledObjectType ty

[GitHub] [beam] miamihotline opened a new pull request #16545: [BEAM-13680] [Playground] [Bugfix] Fix tests on frontend

2022-01-18 Thread GitBox
miamihotline opened a new pull request #16545: URL: https://github.com/apache/beam/pull/16545 Fixed tests on frontend Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choos

[GitHub] [beam] miamihotline commented on pull request #16545: [BEAM-13680] [Playground] [Bugfix] Fix tests on frontend

2022-01-18 Thread GitBox
miamihotline commented on pull request #16545: URL: https://github.com/apache/beam/pull/16545#issuecomment-1015274367 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #16543: [BEAM-13616][BEAM-13645] Switch to vendored grpc 1.43.2

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16543: URL: https://github.com/apache/beam/pull/16543#issuecomment-1015090398 # [Codecov](https://codecov.io/gh/apache/beam/pull/16543?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] scwhittle commented on a change in pull request #16537: [BEAM-13015] Calculate exception for closing BeamFnDataInboundObserver2 statically

2022-01-18 Thread GitBox
scwhittle commented on a change in pull request #16537: URL: https://github.com/apache/beam/pull/16537#discussion_r786645321 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserver2.java ## @@ -62,6 +62,9 @@ public static BeamFn

[GitHub] [beam] scwhittle commented on pull request #16537: [BEAM-13015] Calculate exception for closing BeamFnDataInboundObserver2 statically

2022-01-18 Thread GitBox
scwhittle commented on pull request #16537: URL: https://github.com/apache/beam/pull/16537#issuecomment-1015307715 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] aromanenko-dev merged pull request #16480: [BEAM-13631] Add deterministic SQS message coder to fix reading from SQS in batch mode (AWS Sdk v1)

2022-01-18 Thread GitBox
aromanenko-dev merged pull request #16480: URL: https://github.com/apache/beam/pull/16480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] aromanenko-dev commented on pull request #16481: [BEAM-8806] Integration test for SqsIO using Localstack (AWS Sdk v1)

2022-01-18 Thread GitBox
aromanenko-dev commented on pull request #16481: URL: https://github.com/apache/beam/pull/16481#issuecomment-1015311957 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-18 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r786674076 ## File path: playground/backend/internal/cloud_bucket/precompiled_objects_test.go ## @@ -250,6 +250,6 @@ func Benchmark_GetPrecompiledObjectOutput(b

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-18 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r786674218 ## File path: playground/backend/internal/environment/environment_service_test.go ## @@ -308,3 +310,40 @@ func Test_getConfigFromJson(t *testing.T) {

[GitHub] [beam] pavel-avilov opened a new pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
pavel-avilov opened a new pull request #16546: URL: https://github.com/apache/beam/pull/16546 [[BEAM-13661]](https://issues.apache.org/jira/browse/BEAM-13661) - Add default_example field to the tags - Remove empty optional fields from tags; Th

[GitHub] [beam] pavel-avilov commented on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
pavel-avilov commented on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015350499 @ilya-kozyrev @KhaninArtur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] commented on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] commented on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] aromanenko-dev merged pull request #16481: [BEAM-8806] Integration test for SqsIO using Localstack (AWS Sdk v1)

2022-01-18 Thread GitBox
aromanenko-dev merged pull request #16481: URL: https://github.com/apache/beam/pull/16481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] scwhittle commented on pull request #16537: [BEAM-13015] Calculate exception for closing BeamFnDataInboundObserver2 statically

2022-01-18 Thread GitBox
scwhittle commented on pull request #16537: URL: https://github.com/apache/beam/pull/16537#issuecomment-1015371766 Fixed up test. In doing so I had to fix the CancellableQueue contract on multiple cancellations, previously this was masked because the interesting exception was a cause of t

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] ilya-kozyrev commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-18 Thread GitBox
ilya-kozyrev commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r786793309 ## File path: playground/backend/cmd/server/controller.go ## @@ -241,22 +241,27 @@ func (controller *playgroundController) Cancel(ctx context.Context

[GitHub] [beam] ilya-kozyrev commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-18 Thread GitBox
ilya-kozyrev commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r786797822 ## File path: playground/backend/internal/cache/cache.go ## @@ -55,6 +55,9 @@ const ( // LogsIndex is the index of the start of the log

[GitHub] [beam] mlhamel commented on pull request #15977: [BEAM-13250] Factorise gcsio.GcsIO() from gcsfilesystem

2022-01-18 Thread GitBox
mlhamel commented on pull request #15977: URL: https://github.com/apache/beam/pull/15977#issuecomment-1015467635 @aaltay @ihji - Friendly ping, what do you think of the implementation. Does it make sense ? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on a change in pull request #16534: [BEAM-13671][Playground] Add backend contribute guide to the project

2022-01-18 Thread GitBox
KhaninArtur commented on a change in pull request #16534: URL: https://github.com/apache/beam/pull/16534#discussion_r786830275 ## File path: playground/backend/CONTRIBUTE.md ## @@ -0,0 +1,120 @@ + + +# Contribution Guide + +This guide consists of: + +- [Project structure](#proj

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16534: [BEAM-13671][Playground] Add backend contribute guide to the project

2022-01-18 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16534: URL: https://github.com/apache/beam/pull/16534#discussion_r786846752 ## File path: playground/backend/CONTRIBUTE.md ## @@ -0,0 +1,120 @@ + + +# Contribution Guide + +This guide consists of: + +- [Project structure](

[GitHub] [beam] egalpin commented on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

2022-01-18 Thread GitBox
egalpin commented on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1015499432 Thanks for the effort to patch this bug @khersey, LGTM! @echauchot Could you have another pass over the changes (if you choose) and merge when you're also satisfied? --

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-18 Thread GitBox
KhaninArtur commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r786853496 ## File path: playground/backend/internal/environment/environment_service.go ## @@ -240,6 +246,16 @@ func getConfigFromJson(configPath string) (*Execu

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on a change in pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
KhaninArtur commented on a change in pull request #16546: URL: https://github.com/apache/beam/pull/16546#discussion_r786856173 ## File path: playground/categories.yaml ## @@ -36,4 +36,5 @@ categories: - Flatten - Core Transforms - Windowing - - Debugging \ No newline

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] nielm opened a new pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-18 Thread GitBox
nielm opened a new pull request #16547: URL: https://github.com/apache/beam/pull/16547 Fixes regression introduced by PR #15493 which inadvertently caused an NPE when the projectID was not specified for a SpannerIO read. Adds unit test for reading both with and without projectID

[GitHub] [beam] nielm commented on pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-18 Thread GitBox
nielm commented on pull request #16547: URL: https://github.com/apache/beam/pull/16547#issuecomment-1015570741 @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] nielm commented on pull request #15493: [BEAM-11982] Java Spanner - Implement IO Request Count metrics

2022-01-18 Thread GitBox
nielm commented on pull request #15493: URL: https://github.com/apache/beam/pull/15493#issuecomment-1015571276 Filed https://github.com/apache/beam/pull/16547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [beam] MarcoRob closed pull request #16386: [Beam-12622] Modified PR Trigger Phrases Jenkins tests and README updated with changes and missed jobs

2022-01-18 Thread GitBox
MarcoRob closed pull request #16386: URL: https://github.com/apache/beam/pull/16386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #13626: [DO NOT MERGE] Run seed job on open PRs.

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #13626: URL: https://github.com/apache/beam/pull/13626#issuecomment-754898721 # [Codecov](https://codecov.io/gh/apache/beam/pull/13626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] andreykus opened a new pull request #16548: [BEAM-13681][Playground] Refactoring terraform scripts

2022-01-18 Thread GitBox
andreykus opened a new pull request #16548: URL: https://github.com/apache/beam/pull/16548 Come up with the following terraform structure: 1. Distinguish modules (vpc, artifact_registry , memorystore (redis), bucket, Kubernet)\ 2. Implement the description of the modules as a scri

[GitHub] [beam] andreykus closed pull request #16548: [BEAM-13681][Playground] Refactoring terraform scripts

2022-01-18 Thread GitBox
andreykus closed pull request #16548: URL: https://github.com/apache/beam/pull/16548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] emilymye commented on pull request #16544: [BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2

2022-01-18 Thread GitBox
emilymye commented on pull request #16544: URL: https://github.com/apache/beam/pull/16544#issuecomment-1015628326 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] emilymye commented on pull request #16543: [BEAM-13616][BEAM-13645] Switch to vendored grpc 1.43.2

2022-01-18 Thread GitBox
emilymye commented on pull request #16543: URL: https://github.com/apache/beam/pull/16543#issuecomment-1015631668 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] andreykus opened a new pull request #16549: [BEAM-13681][Playground] Refactoring terraform scripts

2022-01-18 Thread GitBox
andreykus opened a new pull request #16549: URL: https://github.com/apache/beam/pull/16549 Come up with the following terraform structure: 1. Distinguish modules (vpc, artifact_registry , memorystore (redis), bucket, Kubernet)\ 2. Implement the description of the modules as a scri

[GitHub] [beam] lukecwik commented on pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-18 Thread GitBox
lukecwik commented on pull request #16547: URL: https://github.com/apache/beam/pull/16547#issuecomment-1015639199 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] emilymye commented on pull request #16544: [BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2

2022-01-18 Thread GitBox
emilymye commented on pull request #16544: URL: https://github.com/apache/beam/pull/16544#issuecomment-1015639501 Run Portable_Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [beam] brucearctor commented on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-18 Thread GitBox
brucearctor commented on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-1015639940 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] brucearctor edited a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-18 Thread GitBox
brucearctor edited a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-933994371 Cool — I’ll try that for logging into Jenkins/CI. Looks like code runs/compiles, but the new tests are failing since it isn’t actually doing what is desired ( is crea

[GitHub] [beam] codecov[bot] edited a comment on pull request #16529: Bump beam container version.

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16529: URL: https://github.com/apache/beam/pull/16529#issuecomment-1013576763 # [Codecov](https://codecov.io/gh/apache/beam/pull/16529?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] robertwb commented on pull request #16529: Bump beam container version.

2022-01-18 Thread GitBox
robertwb commented on pull request #16529: URL: https://github.com/apache/beam/pull/16529#issuecomment-1015648468 Oh, I thought that we were using external containers for FnAPI these days. (An aside, is there an ETA for that?) Built and bumped the FnAPI one as well. -- This is an

[GitHub] [beam] lukecwik commented on a change in pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-18 Thread GitBox
lukecwik commented on a change in pull request #16547: URL: https://github.com/apache/beam/pull/16547#discussion_r786997483 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java ## @@ -193,15 +193,16 @@ public v

[GitHub] [beam] lukecwik commented on a change in pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-18 Thread GitBox
lukecwik commented on a change in pull request #16547: URL: https://github.com/apache/beam/pull/16547#discussion_r786997483 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java ## @@ -193,15 +193,16 @@ public v

[GitHub] [beam] codecov[bot] edited a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-926034602 # [Codecov](https://codecov.io/gh/apache/beam/pull/15548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16543: [BEAM-13616][BEAM-13645] Switch to vendored grpc 1.43.2

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16543: URL: https://github.com/apache/beam/pull/16543#issuecomment-1015090398 # [Codecov](https://codecov.io/gh/apache/beam/pull/16543?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-926034602 # [Codecov](https://codecov.io/gh/apache/beam/pull/15548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] pabloem commented on pull request #16322: [BEAM-13407] [Playground] Preload fonts for the web application

2022-01-18 Thread GitBox
pabloem commented on pull request #16322: URL: https://github.com/apache/beam/pull/16322#issuecomment-1015660063 LGTM. I'll merge once we get green tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] codecov[bot] edited a comment on pull request #16529: Bump beam container version.

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16529: URL: https://github.com/apache/beam/pull/16529#issuecomment-1013576763 # [Codecov](https://codecov.io/gh/apache/beam/pull/16529?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] emilymye merged pull request #16543: [BEAM-13616][BEAM-13645] Switch to vendored grpc 1.43.2

2022-01-18 Thread GitBox
emilymye merged pull request #16543: URL: https://github.com/apache/beam/pull/16543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] lukecwik commented on a change in pull request #16537: [BEAM-13015] Calculate exception for closing BeamFnDataInboundObserver2 statically

2022-01-18 Thread GitBox
lukecwik commented on a change in pull request #16537: URL: https://github.com/apache/beam/pull/16537#discussion_r787020075 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataInboundObserver2.java ## @@ -62,6 +62,19 @@ public static BeamFn

[GitHub] [beam] codecov[bot] edited a comment on pull request #16544: [BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16544: URL: https://github.com/apache/beam/pull/16544#issuecomment-1015090765 # [Codecov](https://codecov.io/gh/apache/beam/pull/16544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lukecwik closed pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for user state and side

2022-01-18 Thread GitBox
lukecwik closed pull request #16525: URL: https://github.com/apache/beam/pull/16525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for use

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16525: URL: https://github.com/apache/beam/pull/16525#issuecomment-1013492151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] lukecwik commented on pull request #16495: [BEAM-13015] Provide caching statistics in the status client.

2022-01-18 Thread GitBox
lukecwik commented on pull request #16495: URL: https://github.com/apache/beam/pull/16495#issuecomment-1015682070 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] talatuyarer commented on pull request #16380: [BEAM-13577] Beam Select's uniquifyNames function loses nullability of Complex types while inferring schema

2022-01-18 Thread GitBox
talatuyarer commented on pull request #16380: URL: https://github.com/apache/beam/pull/16380#issuecomment-1015683176 @ibzib Do you think we can merge this PR to master ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [beam] ibzib commented on pull request #16380: [BEAM-13577] Beam Select's uniquifyNames function loses nullability of Complex types while inferring schema

2022-01-18 Thread GitBox
ibzib commented on pull request #16380: URL: https://github.com/apache/beam/pull/16380#issuecomment-1015684312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [beam] codecov[bot] edited a comment on pull request #16544: [BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16544: URL: https://github.com/apache/beam/pull/16544#issuecomment-1015090765 # [Codecov](https://codecov.io/gh/apache/beam/pull/16544?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16529: Bump beam container version.

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16529: URL: https://github.com/apache/beam/pull/16529#issuecomment-1013576763 # [Codecov](https://codecov.io/gh/apache/beam/pull/16529?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] brucearctor commented on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-18 Thread GitBox
brucearctor commented on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-1015698539 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] y1chi commented on a change in pull request #16439: [BEAM-13193] Aggregates fn api outbound data/timers of different endpoints

2022-01-18 Thread GitBox
y1chi commented on a change in pull request #16439: URL: https://github.com/apache/beam/pull/16439#discussion_r787048060 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to th

[GitHub] [beam] y1chi commented on a change in pull request #16439: [BEAM-13193] Aggregates fn api outbound data/timers of different endpoints

2022-01-18 Thread GitBox
y1chi commented on a change in pull request #16439: URL: https://github.com/apache/beam/pull/16439#discussion_r787048391 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/BeamFnDataWriteRunner.java ## @@ -72,87 +69,67 @@ public BeamFnDataWriteRunner

[GitHub] [beam] y1chi commented on a change in pull request #16439: [BEAM-13193] Aggregates fn api outbound data/timers of different endpoints

2022-01-18 Thread GitBox
y1chi commented on a change in pull request #16439: URL: https://github.com/apache/beam/pull/16439#discussion_r787048500 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to th

[GitHub] [beam] y1chi commented on a change in pull request #16439: [BEAM-13193] Aggregates fn api outbound data/timers of different endpoints

2022-01-18 Thread GitBox
y1chi commented on a change in pull request #16439: URL: https://github.com/apache/beam/pull/16439#discussion_r787048698 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to th

[GitHub] [beam] y1chi commented on a change in pull request #16439: [BEAM-13193] Aggregates fn api outbound data/timers of different endpoints

2022-01-18 Thread GitBox
y1chi commented on a change in pull request #16439: URL: https://github.com/apache/beam/pull/16439#discussion_r787050309 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to th

[GitHub] [beam] y1chi commented on a change in pull request #16439: [BEAM-13193] Aggregates fn api outbound data/timers of different endpoints

2022-01-18 Thread GitBox
y1chi commented on a change in pull request #16439: URL: https://github.com/apache/beam/pull/16439#discussion_r787050714 ## File path: sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataOutboundAggregator.java ## @@ -0,0 +1,232 @@ +/* + * Licensed to th

[GitHub] [beam] robertwb merged pull request #16529: Bump beam container version.

2022-01-18 Thread GitBox
robertwb merged pull request #16529: URL: https://github.com/apache/beam/pull/16529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] pabloem commented on pull request #16371: [BEAM-13518][Playground] Beam Playground quickstart page on the Beam website

2022-01-18 Thread GitBox
pabloem commented on pull request #16371: URL: https://github.com/apache/beam/pull/16371#issuecomment-1015726174 this looks good to me. I'd like to follow up with a couple things, if possible: - Add an embedded example in the homepage - When an example loads, scroll down to the 'inter

[GitHub] [beam] codecov[bot] edited a comment on pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for use

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16525: URL: https://github.com/apache/beam/pull/16525#issuecomment-1013492151 # [Codecov](https://codecov.io/gh/apache/beam/pull/16525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for use

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16525: URL: https://github.com/apache/beam/pull/16525#issuecomment-1013492151 # [Codecov](https://codecov.io/gh/apache/beam/pull/16525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for use

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16525: URL: https://github.com/apache/beam/pull/16525#issuecomment-1013492151 # [Codecov](https://codecov.io/gh/apache/beam/pull/16525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] emilymye merged pull request #16544: [BEAM-13616][BEAM-13646] Upgrade vendored calcite to 1.28.0:0.2

2022-01-18 Thread GitBox
emilymye merged pull request #16544: URL: https://github.com/apache/beam/pull/16544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] pranavbhandari24 opened a new pull request #16550: Allow users to specify MoveOptions to FileIO

2022-01-18 Thread GitBox
pranavbhandari24 opened a new pull request #16550: URL: https://github.com/apache/beam/pull/16550 Allow users to specify strategy to employ when destination file exists. Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] pranavbhandari24 commented on pull request #16550: Allow users to specify MoveOptions to FileIO

2022-01-18 Thread GitBox
pranavbhandari24 commented on pull request #16550: URL: https://github.com/apache/beam/pull/16550#issuecomment-1015745777 R: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [beam] damondouglas commented on a change in pull request #16373: [BEAM-13515] [Playground] Hiding lines in an example that are not necessary

2022-01-18 Thread GitBox
damondouglas commented on a change in pull request #16373: URL: https://github.com/apache/beam/pull/16373#discussion_r787076397 ## File path: playground/frontend/lib/modules/editor/components/editor_textarea.dart ## @@ -51,6 +60,7 @@ class EditorTextArea extends StatefulWidget

[GitHub] [beam] codecov[bot] edited a comment on pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for use

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16525: URL: https://github.com/apache/beam/pull/16525#issuecomment-1013492151 # [Codecov](https://codecov.io/gh/apache/beam/pull/16525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for use

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16525: URL: https://github.com/apache/beam/pull/16525#issuecomment-1013492151 # [Codecov](https://codecov.io/gh/apache/beam/pull/16525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] nielm commented on a change in pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-18 Thread GitBox
nielm commented on a change in pull request #16547: URL: https://github.com/apache/beam/pull/16547#discussion_r787090397 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/BatchSpannerRead.java ## @@ -193,15 +193,16 @@ public void

[GitHub] [beam] jrmccluskey opened a new pull request #16551: [BEAM-13683] Correct SQL transform schema, fix expansion address override bug

2022-01-18 Thread GitBox
jrmccluskey opened a new pull request #16551: URL: https://github.com/apache/beam/pull/16551 Converts the `sqlx` package's `ExpansionPayload` to have its `Options` field unexported, as it is incompatible with the SQL transform schema as implemented in Java. Also propagates a corrected expa

[GitHub] [beam] codecov[bot] edited a comment on pull request #16525: [BEAM-13015] Add state caching capability to be used as hint for runners to not duplicate cached data if the SDK can do it for use

2022-01-18 Thread GitBox
codecov[bot] edited a comment on pull request #16525: URL: https://github.com/apache/beam/pull/16525#issuecomment-1013492151 # [Codecov](https://codecov.io/gh/apache/beam/pull/16525?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] jrmccluskey commented on pull request #16551: [BEAM-13683] Correct SQL transform schema, fix expansion address override bug

2022-01-18 Thread GitBox
jrmccluskey commented on pull request #16551: URL: https://github.com/apache/beam/pull/16551#issuecomment-1015787497 Run Go Flink ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] scwhittle commented on a change in pull request #16495: [BEAM-13015] Provide caching statistics in the status client.

2022-01-18 Thread GitBox
scwhittle commented on a change in pull request #16495: URL: https://github.com/apache/beam/pull/16495#discussion_r787108590 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/Caches.java ## @@ -166,6 +165,10 @@ public int weigh(Object key, WeightedValue

  1   2   3   >