[GitHub] [beam] vitaly-ivanov opened a new pull request #16559: [BEAM-13686] OOM while logging a large pipeline even when logging lev…

2022-01-19 Thread GitBox
vitaly-ivanov opened a new pull request #16559: URL: https://github.com/apache/beam/pull/16559 …el is higher * Use not deprecated methods for logging a pipeline proto * Don't calculate potentially heavy string when the logging level is higher Logging message is calculated ev

[GitHub] [beam] vitaly-ivanov commented on pull request #16559: [BEAM-13686] OOM while logging a large pipeline even when logging lev…

2022-01-19 Thread GitBox
vitaly-ivanov commented on pull request #16559: URL: https://github.com/apache/beam/pull/16559#issuecomment-1016193965 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] echauchot commented on pull request #12610: [BEAM-10723] ElasticsearchIO SSL authentication key fix

2022-01-19 Thread GitBox
echauchot commented on pull request #12610: URL: https://github.com/apache/beam/pull/12610#issuecomment-1016204944 @mareksimunek can you please add the tests ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [beam] echauchot commented on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

2022-01-19 Thread GitBox
echauchot commented on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1016215863 @khersey thanks for your work ! As a general advice for future contributions (:smile: ) to not merge master to your PR branch because merge commits are confusing when merged b

[GitHub] [beam] echauchot edited a comment on pull request #16309: [BEAM-13503] Fixes bug in java ElasticsearchIO BulkIO constructor

2022-01-19 Thread GitBox
echauchot edited a comment on pull request #16309: URL: https://github.com/apache/beam/pull/16309#issuecomment-1016215863 @khersey thanks for your work ! As a general advice for future contributions (:smile: ) do not merge master to your PR branch because merge commits are confusing when m

[GitHub] [beam] echauchot merged pull request #16309: [BEAM-13503] Set a default value to throwWriteErrors in BulkIO constructor

2022-01-19 Thread GitBox
echauchot merged pull request #16309: URL: https://github.com/apache/beam/pull/16309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] dpcollins-google commented on a change in pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
dpcollins-google commented on a change in pull request #16552: URL: https://github.com/apache/beam/pull/16552#discussion_r787556126 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -807,6 +807,14 @@ class BeamModulePlugin implements P

[GitHub] [beam] nielm commented on pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-19 Thread GitBox
nielm commented on pull request #16547: URL: https://github.com/apache/beam/pull/16547#issuecomment-1016297121 @ajamato This needs a followup to move the creation of the metrics out of the ProcessElement function so that they are not recreated for every single element processed -- This

[GitHub] [beam] miamihotline commented on pull request #16373: [BEAM-13515] [Playground] Hiding lines in an example that are not necessary

2022-01-19 Thread GitBox
miamihotline commented on pull request #16373: URL: https://github.com/apache/beam/pull/16373#issuecomment-1016309647 > @miamihotline realizing that testing this is challenging, could you provide some guidance on testing this PR at least by visual inspection? What are the steps someone sho

[GitHub] [beam] miamihotline commented on a change in pull request #16373: [BEAM-13515] [Playground] Hiding lines in an example that are not necessary

2022-01-19 Thread GitBox
miamihotline commented on a change in pull request #16373: URL: https://github.com/apache/beam/pull/16373#discussion_r787618883 ## File path: playground/frontend/lib/modules/editor/components/editor_textarea.dart ## @@ -51,6 +60,7 @@ class EditorTextArea extends StatefulWidget

[GitHub] [beam] scwhittle commented on pull request #16495: [BEAM-13015] Provide caching statistics in the status client.

2022-01-19 Thread GitBox
scwhittle commented on pull request #16495: URL: https://github.com/apache/beam/pull/16495#issuecomment-1016315974 LGTM thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] scwhittle commented on pull request #16537: [BEAM-13015] Calculate exception for closing BeamFnDataInboundObserver2 statically

2022-01-19 Thread GitBox
scwhittle commented on pull request #16537: URL: https://github.com/apache/beam/pull/16537#issuecomment-1016320906 @lukecwik What is next step here? Are you able to merge including your commit to change the string? or do I need to somehow squash it first? Thanks! -- This is an automated

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-19 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r787688661 ## File path: playground/backend/internal/environment/environment_service.go ## @@ -240,6 +246,16 @@ func getConfigFromJson(configPath string) (*Exec

[GitHub] [beam] lukecwik merged pull request #16495: [BEAM-13015] Provide caching statistics in the status client.

2022-01-19 Thread GitBox
lukecwik merged pull request #16495: URL: https://github.com/apache/beam/pull/16495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] mosche commented on pull request #16503: [BEAM-13635] Fix usage of SnsIO.write topicArn (AWS Sdk v2)

2022-01-19 Thread GitBox
mosche commented on pull request #16503: URL: https://github.com/apache/beam/pull/16503#issuecomment-1016521885 R: @aromanenko-dev (sorry, just noticed i didn't ping you earlier) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16546: URL: https://github.com/apache/beam/pull/16546#issuecomment-1015351959 # [Codecov](https://codecov.io/gh/apache/beam/pull/16546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] TheNeuralBit merged pull request #16554: [BEAM-13611] Skip test_xlang_jdbc_write

2022-01-19 Thread GitBox
TheNeuralBit merged pull request #16554: URL: https://github.com/apache/beam/pull/16554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] darshan-sj commented on pull request #16530: Adding JSON support in SpannerIO and Spanner schema parser

2022-01-19 Thread GitBox
darshan-sj commented on pull request #16530: URL: https://github.com/apache/beam/pull/16530#issuecomment-1016542865 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] riteshghorse commented on pull request #16560: [BEAM-13688] fixed typo in BPG 4.5.3 window section for Go

2022-01-19 Thread GitBox
riteshghorse commented on pull request #16560: URL: https://github.com/apache/beam/pull/16560#issuecomment-1016546167 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] riteshghorse opened a new pull request #16560: [BEAM-13688] fixed typo in BPG 4.5.3 window section for Go

2022-01-19 Thread GitBox
riteshghorse opened a new pull request #16560: URL: https://github.com/apache/beam/pull/16560 Fixes the typo described in [BEAM-13688](https://issues.apache.org/jira/browse/BEAM-13688). Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] KhaninArtur commented on pull request #16371: [BEAM-13518][Playground] Beam Playground quickstart page on the Beam website

2022-01-19 Thread GitBox
KhaninArtur commented on pull request #16371: URL: https://github.com/apache/beam/pull/16371#issuecomment-1016567971 > * Add an embedded example in the homepage I'm not sure, where it fits on the homepage, where do you want to add it? > * When an example loads, scroll down to t

[GitHub] [beam] steveniemitz opened a new pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
steveniemitz opened a new pull request #16561: URL: https://github.com/apache/beam/pull/16561 Similar to other IOs (Bigtable, FileIO, etc), it would be useful for BigQueryIO to emit an element (the TableDestination that was just loaded) when the load completes. We've been running th

[GitHub] [beam] roger-mike opened a new pull request #16562: [WIP][BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

2022-01-19 Thread GitBox
roger-mike opened a new pull request #16562: URL: https://github.com/apache/beam/pull/16562 Lang ULR Dataflow Flink Samza Spark Twister2

[GitHub] [beam] daria-malkova opened a new pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
daria-malkova opened a new pull request #16563: URL: https://github.com/apache/beam/pull/16563 [BEAM-13562][Playground] Support SCIO SDK. Create sbt project for compiling and running scio code Thank you for your contribution! Follow this checklist to h

[GitHub] [beam] codecov[bot] commented on pull request #16562: [WIP][BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

2022-01-19 Thread GitBox
codecov[bot] commented on pull request #16562: URL: https://github.com/apache/beam/pull/16562#issuecomment-1016616248 # [Codecov](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] steveniemitz commented on pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
steveniemitz commented on pull request #16561: URL: https://github.com/apache/beam/pull/16561#issuecomment-1016616550 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] y1chi commented on pull request #16439: [BEAM-13193] Aggregates fn api outbound data/timers of different endpoints

2022-01-19 Thread GitBox
y1chi commented on pull request #16439: URL: https://github.com/apache/beam/pull/16439#issuecomment-1016623600 @lukecwik addressed comments, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #16562: [WIP][BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16562: URL: https://github.com/apache/beam/pull/16562#issuecomment-1016616248 # [Codecov](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem merged pull request #16370: [BEAM-13556] playground - color and scroll tabs with new content

2022-01-19 Thread GitBox
pabloem merged pull request #16370: URL: https://github.com/apache/beam/pull/16370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #16370: [BEAM-13556] playground - color and scroll tabs with new content

2022-01-19 Thread GitBox
pabloem commented on pull request #16370: URL: https://github.com/apache/beam/pull/16370#issuecomment-1016638046 thanks all LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] pabloem commented on pull request #16531: [BEAM-13567] [playground] Handle run code validation and preparation errors

2022-01-19 Thread GitBox
pabloem commented on pull request #16531: URL: https://github.com/apache/beam/pull/16531#issuecomment-1016639441 LGTM thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] pabloem merged pull request #16531: [BEAM-13567] [playground] Handle run code validation and preparation errors

2022-01-19 Thread GitBox
pabloem merged pull request #16531: URL: https://github.com/apache/beam/pull/16531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #16518: [BEAM-13619] [Playground] Add loading animation to the catalog

2022-01-19 Thread GitBox
pabloem commented on pull request #16518: URL: https://github.com/apache/beam/pull/16518#issuecomment-1016640740 nice : ) - LGTM. I'm re-running tests to see what may be theissue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [beam] codecov[bot] commented on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] commented on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem merged pull request #16533: [BEAM-13548] [Playground] Add example description popover

2022-01-19 Thread GitBox
pabloem merged pull request #16533: URL: https://github.com/apache/beam/pull/16533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] tvalentyn opened a new pull request #16564: Remove obsolete commands from Inventory job.

2022-01-19 Thread GitBox
tvalentyn opened a new pull request #16564: URL: https://github.com/apache/beam/pull/16564 These currently failing and not required for our Jenkins infra. ``` 11:10:21 [beam_Inventory_apache-beam-jenkins-1] $ /bin/bash -xe /tmp/jenkins1167683408123032334.sh 11:10:21 + /home/jen

[GitHub] [beam] codecov[bot] edited a comment on pull request #16562: [WIP][BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16562: URL: https://github.com/apache/beam/pull/16562#issuecomment-1016616248 # [Codecov](https://codecov.io/gh/apache/beam/pull/16562?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem merged pull request #16519: [BEAM-13639] [Playground] Add notification to Log/Output tabs about cached example

2022-01-19 Thread GitBox
pabloem merged pull request #16519: URL: https://github.com/apache/beam/pull/16519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem merged pull request #16518: [BEAM-13619] [Playground] Add loading animation to the catalog

2022-01-19 Thread GitBox
pabloem merged pull request #16518: URL: https://github.com/apache/beam/pull/16518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AydarZaynutdinov opened a new pull request #16565: [BEAM-13692][Playground] Implement method to receive Graph

2022-01-19 Thread GitBox
AydarZaynutdinov opened a new pull request #16565: URL: https://github.com/apache/beam/pull/16565 Add `GRAPH` subKey Add `GetGraph` API method Update `GetValue` cache method to correctly receive graph from the cache Fixes according to `staticcheck`

[GitHub] [beam] AydarZaynutdinov commented on pull request #16565: [BEAM-13692][Playground] Implement method to receive Graph

2022-01-19 Thread GitBox
AydarZaynutdinov commented on pull request #16565: URL: https://github.com/apache/beam/pull/16565#issuecomment-1016671274 R: @KhaninArtur @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] ajamato commented on pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-19 Thread GitBox
ajamato commented on pull request #16547: URL: https://github.com/apache/beam/pull/16547#issuecomment-1016671728 Hi. I am no longer working on Beam. @aaltay would you please make sure @nielm gets the help they need here. -- This is an automated message from the Apache Git Service. To r

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] reuvenlax commented on pull request #16558: Add schemacoder and update row coder urn version

2022-01-19 Thread GitBox
reuvenlax commented on pull request #16558: URL: https://github.com/apache/beam/pull/16558#issuecomment-1016677830 @TheNeuralBit Unclear to me if Python failures are related. Also to test this further I need to add some serialized payloads in standard_coders.yaml - is there a tool to gener

[GitHub] [beam] TheNeuralBit commented on pull request #16558: Add schemacoder and update row coder urn version

2022-01-19 Thread GitBox
TheNeuralBit commented on pull request #16558: URL: https://github.com/apache/beam/pull/16558#issuecomment-1016680283 > Also to test this further I need to add some serialized payloads in standard_coders.yaml - is there a tool to generate those serialized payloads? I've used the Pyth

[GitHub] [beam] TheNeuralBit edited a comment on pull request #16558: Add schemacoder and update row coder urn version

2022-01-19 Thread GitBox
TheNeuralBit edited a comment on pull request #16558: URL: https://github.com/apache/beam/pull/16558#issuecomment-1016680283 > Also to test this further I need to add some serialized payloads in standard_coders.yaml - is there a tool to generate those serialized payloads? I've used t

[GitHub] [beam] codecov[bot] edited a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-926034602 # [Codecov](https://codecov.io/gh/apache/beam/pull/15548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] steveniemitz commented on a change in pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
steveniemitz commented on a change in pull request #16561: URL: https://github.com/apache/beam/pull/16561#discussion_r787986082 ## File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java ## @@ -2088,7 +2088,7 @@

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] kennknowles commented on a change in pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
kennknowles commented on a change in pull request #16552: URL: https://github.com/apache/beam/pull/16552#discussion_r788007093 ## File path: sdks/java/container/common.gradle ## @@ -45,6 +45,8 @@ dependencies { } task copyDockerfileDependencies(type: Copy) { +duplicates

[GitHub] [beam] pcoet opened a new pull request #16566: edited README and comments in Python multi-lang pipes examples

2022-01-19 Thread GitBox
pcoet opened a new pull request #16566: URL: https://github.com/apache/beam/pull/16566 Edited the README and the comments in the Python multi-language pipeline examples. @chamikaramj Thank you for your contribution! Follow this checklist to hel

[GitHub] [beam] robertwb commented on pull request #16556: Disable logging for memoization test.

2022-01-19 Thread GitBox
robertwb commented on pull request #16556: URL: https://github.com/apache/beam/pull/16556#issuecomment-1016729126 Run Python_PVR_Flink PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] pabloem commented on pull request #16243: Making rpcPriority a ValueProvider in SpannerConfig

2022-01-19 Thread GitBox
pabloem commented on pull request #16243: URL: https://github.com/apache/beam/pull/16243#issuecomment-1016732434 this LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] pabloem merged pull request #16243: Making rpcPriority a ValueProvider in SpannerConfig

2022-01-19 Thread GitBox
pabloem merged pull request #16243: URL: https://github.com/apache/beam/pull/16243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] ibzib commented on pull request #16380: [BEAM-13577] Beam Select's uniquifyNames function loses nullability of Complex types while inferring schema

2022-01-19 Thread GitBox
ibzib commented on pull request #16380: URL: https://github.com/apache/beam/pull/16380#issuecomment-1016734816 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] tvalentyn commented on pull request #7912: Obviating need for calling CombineFn.compact for TopCombineFn.

2022-01-19 Thread GitBox
tvalentyn commented on pull request #7912: URL: https://github.com/apache/beam/pull/7912#issuecomment-1016742142 In case someone is available to investigate, Beam users report an assertion failure in the code added in this PR: https://issues.apache.org/jira/browse/BEAM-12847 -- This is

[GitHub] [beam] suztomo closed pull request #16441: [WIP][no need to review] Testing Google Cloud libraries dependencies

2022-01-19 Thread GitBox
suztomo closed pull request #16441: URL: https://github.com/apache/beam/pull/16441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
pabloem commented on pull request #16561: URL: https://github.com/apache/beam/pull/16561#issuecomment-1016745305 I've received requests for this feature as well. Thanks for contributing it back, Steve. Let me take a look, but yes, I'm in favor of adding this functionality. -- This is an

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem commented on a change in pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
pabloem commented on a change in pull request #16561: URL: https://github.com/apache/beam/pull/16561#discussion_r788029966 ## File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java ## @@ -2088,7 +2088,7 @@ publi

[GitHub] [beam] pabloem commented on a change in pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
pabloem commented on a change in pull request #16561: URL: https://github.com/apache/beam/pull/16561#discussion_r788030919 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.java ## @@ -77,13 +96,41 @@ private WriteRe

[GitHub] [beam] jrmccluskey opened a new pull request #16567: [BEAM-13683] Make cross-language SQL example pipeline

2022-01-19 Thread GitBox
jrmccluskey opened a new pull request #16567: URL: https://github.com/apache/beam/pull/16567 Create a cross-language Beam pipeline that runs SQL transforms in the Go SDK. Serves as both an example for users on how to use the sql package as well as a proven case of the SQL cross-language tr

[GitHub] [beam] steveniemitz commented on a change in pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
steveniemitz commented on a change in pull request #16561: URL: https://github.com/apache/beam/pull/16561#discussion_r788032113 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.java ## @@ -77,13 +96,41 @@ private Wr

[GitHub] [beam] steveniemitz commented on a change in pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
steveniemitz commented on a change in pull request #16561: URL: https://github.com/apache/beam/pull/16561#discussion_r788032670 ## File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOWriteTest.java ## @@ -2088,7 +2088,7 @@

[GitHub] [beam] codecov[bot] edited a comment on pull request #16556: Disable logging for memoization test.

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16556: URL: https://github.com/apache/beam/pull/16556#issuecomment-1015992375 # [Codecov](https://codecov.io/gh/apache/beam/pull/16556?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] brucearctor commented on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-19 Thread GitBox
brucearctor commented on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-1016764837 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] brucearctor removed a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-19 Thread GitBox
brucearctor removed a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-1016065365 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [beam] brucearctor removed a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-19 Thread GitBox
brucearctor removed a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-933855633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] brucearctor removed a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-19 Thread GitBox
brucearctor removed a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-933720806 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] steveniemitz commented on a change in pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-19 Thread GitBox
steveniemitz commented on a change in pull request #16561: URL: https://github.com/apache/beam/pull/16561#discussion_r788045904 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteResult.java ## @@ -77,13 +96,41 @@ private Wr

[GitHub] [beam] jrmccluskey commented on pull request #16567: [BEAM-13683] Make cross-language SQL example pipeline

2022-01-19 Thread GitBox
jrmccluskey commented on pull request #16567: URL: https://github.com/apache/beam/pull/16567#issuecomment-1016769493 R: @lostluck @youngoli First run at an example. Plan is to get this finalized/submitted first, then add in automated start-up as an option in a follow-up PR -- Thi

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-19 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] aaltay commented on pull request #7912: Obviating need for calling CombineFn.compact for TopCombineFn.

2022-01-19 Thread GitBox
aaltay commented on pull request #7912: URL: https://github.com/apache/beam/pull/7912#issuecomment-1016782378 @tvalentyn - could you find an owner among the people working in Beam. This is almost 3 years old, probably no one has much context here. -- This is an automated message from the

[GitHub] [beam] lostluck commented on pull request #16567: [BEAM-13683] Make cross-language SQL example pipeline

2022-01-19 Thread GitBox
lostluck commented on pull request #16567: URL: https://github.com/apache/beam/pull/16567#issuecomment-1016782767 Thank you kindly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] lostluck merged pull request #16567: [BEAM-13683] Make cross-language SQL example pipeline

2022-01-19 Thread GitBox
lostluck merged pull request #16567: URL: https://github.com/apache/beam/pull/16567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] lostluck merged pull request #16560: [BEAM-13688] fixes typo in BPG 4.5.3 window section for Go

2022-01-19 Thread GitBox
lostluck merged pull request #16560: URL: https://github.com/apache/beam/pull/16560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

  1   2   3   >