[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r788496963 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -65,6 +70,11 @@ func Setup(sdk pb.Sdk, code string,

[GitHub] [beam] daria-malkova commented on a change in pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
daria-malkova commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r788517325 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -65,6 +70,11 @@ func Setup(sdk pb.Sdk, code string, pip

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13562][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-20 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16546: URL: https://github.com/apache/beam/pull/16546#discussion_r786853017 ## File path: playground/categories.yaml ## @@ -36,4 +36,5 @@ categories: - Flatten - Core Transforms - Windowing - - Debugging \ No new

[GitHub] [beam] andreykus opened a new pull request #16574: [BEAM-13700][Playground][Bugfix] Fixed bug in file structure yaml

2022-01-20 Thread GitBox
andreykus opened a new pull request #16574: URL: https://github.com/apache/beam/pull/16574 Fixed bug in file structure 'build_playground_backend.yml' **Please** add a meaningful description for your change here Thank you for your contribution! Fo

[GitHub] [beam] KhaninArtur commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
KhaninArtur commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r788672842 ## File path: playground/backend/containers/scio/Dockerfile ## @@ -0,0 +1,70 @@ +##

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r788723560 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -143,3 +153,42 @@ func updateJavaLogConfigFile(paths

[GitHub] [beam] KhaninArtur commented on a change in pull request #16373: [BEAM-13515] [Playground] Hiding lines in an example that are not necessary

2022-01-20 Thread GitBox
KhaninArtur commented on a change in pull request #16373: URL: https://github.com/apache/beam/pull/16373#discussion_r788726928 ## File path: playground/frontend/lib/modules/editor/components/editor_textarea.dart ## @@ -31,6 +31,15 @@ import 'package:playground/modules/example

[GitHub] [beam] daria-malkova commented on a change in pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-20 Thread GitBox
daria-malkova commented on a change in pull request #16515: URL: https://github.com/apache/beam/pull/16515#discussion_r788726697 ## File path: playground/infrastructure/api/v1/api_pb2_grpc.py ## @@ -302,6 +370,40 @@ def GetRunError(request, options, channel_credent

[GitHub] [beam] daria-malkova commented on a change in pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-20 Thread GitBox
daria-malkova commented on a change in pull request #16546: URL: https://github.com/apache/beam/pull/16546#discussion_r788733546 ## File path: examples/java/src/test/java/org/apache/beam/examples/complete/TfIdfTest.java ## @@ -21,7 +21,6 @@ // name: TfIdfTest // descript

[GitHub] [beam] KhaninArtur commented on a change in pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-20 Thread GitBox
KhaninArtur commented on a change in pull request #16546: URL: https://github.com/apache/beam/pull/16546#discussion_r788739265 ## File path: examples/java/src/test/java/org/apache/beam/examples/complete/TfIdfTest.java ## @@ -21,7 +21,6 @@ // name: TfIdfTest // descriptio

[GitHub] [beam] ilya-kozyrev commented on a change in pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-20 Thread GitBox
ilya-kozyrev commented on a change in pull request #16515: URL: https://github.com/apache/beam/pull/16515#discussion_r788739659 ## File path: playground/infrastructure/ci_helper.py ## @@ -97,5 +101,18 @@ async def _verify_examples_status(self, examples: List[Example]):

[GitHub] [beam] daria-malkova commented on a change in pull request #16546: [BEAM-13661] [Playground] Add default_example field to the tags

2022-01-20 Thread GitBox
daria-malkova commented on a change in pull request #16546: URL: https://github.com/apache/beam/pull/16546#discussion_r788747808 ## File path: examples/java/src/test/java/org/apache/beam/examples/complete/TfIdfTest.java ## @@ -21,7 +21,6 @@ // name: TfIdfTest // descript

[GitHub] [beam] daria-malkova commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
daria-malkova commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r788750936 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -143,3 +152,41 @@ func updateJavaLogConfigFile(paths fs

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
KhaninArtur commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r788762121 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -143,3 +152,41 @@ func updateJavaLogConfigFile(paths fs_t

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pavel-avilov commented on a change in pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-20 Thread GitBox
pavel-avilov commented on a change in pull request #16515: URL: https://github.com/apache/beam/pull/16515#discussion_r788776443 ## File path: playground/infrastructure/api/v1/api_pb2_grpc.py ## @@ -302,6 +370,40 @@ def GetRunError(request, options, channel_credenti

[GitHub] [beam] steveniemitz commented on pull request #16561: [BEAM-13689] Output TableDestination elements when BQ batch writes complete.

2022-01-20 Thread GitBox
steveniemitz commented on pull request #16561: URL: https://github.com/apache/beam/pull/16561#issuecomment-1017539581 I don't know what's going on with the setup-go check here, it seems like its stuck? -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [beam] pavel-avilov commented on a change in pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-20 Thread GitBox
pavel-avilov commented on a change in pull request #16515: URL: https://github.com/apache/beam/pull/16515#discussion_r788799290 ## File path: playground/infrastructure/helper.py ## @@ -268,25 +270,28 @@ def _validate(tag: dict, supported_categories: List[str]) -> bool:

[GitHub] [beam] steveniemitz commented on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2022-01-20 Thread GitBox
steveniemitz commented on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-1017579519 random musings from me, because we've tried to do something like this as well w/ our own SQL-ish IO. If you introduce an (implicit) reshuffle between the producer o

[GitHub] [beam] steveniemitz edited a comment on pull request #15863: [BEAM-13184] Autosharding for JdbcIO.write* transforms

2022-01-20 Thread GitBox
steveniemitz edited a comment on pull request #15863: URL: https://github.com/apache/beam/pull/15863#issuecomment-1017579519 random musings from me, because we've tried to do something like this as well w/ our own SQL-ish IO. If you introduce an (implicit) reshuffle between the pro

[GitHub] [beam] riteshghorse commented on pull request #16573: [BEAM-13699] Replace fnv with maphash.

2022-01-20 Thread GitBox
riteshghorse commented on pull request #16573: URL: https://github.com/apache/beam/pull/16573#issuecomment-1017640843 Great. Huge speed improvement for string/1 🤯 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [beam] riteshghorse edited a comment on pull request #16573: [BEAM-13699] Replace fnv with maphash.

2022-01-20 Thread GitBox
riteshghorse edited a comment on pull request #16573: URL: https://github.com/apache/beam/pull/16573#issuecomment-1017640843 Great. Huge speed improvement for string/1 🤯 in the first one. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] codecov[bot] edited a comment on pull request #16573: [BEAM-13699] Replace fnv with maphash.

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16573: URL: https://github.com/apache/beam/pull/16573#issuecomment-1017075275 # [Codecov](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16573: [BEAM-13699] Replace fnv with maphash.

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16573: URL: https://github.com/apache/beam/pull/16573#issuecomment-1017075275 # [Codecov](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] ihji commented on pull request #15767: [BEAM-13093] Enable JavaUsingPython CrossLanguageValidateRunner test …

2022-01-20 Thread GitBox
ihji commented on pull request #15767: URL: https://github.com/apache/beam/pull/15767#issuecomment-1017655621 R: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [beam] codecov[bot] edited a comment on pull request #16573: [BEAM-13699] Replace fnv with maphash.

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16573: URL: https://github.com/apache/beam/pull/16573#issuecomment-1017075275 # [Codecov](https://codecov.io/gh/apache/beam/pull/16573?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] damondouglas commented on a change in pull request #16369: [BEAM-13558] [Playground] Hide the Graph tab and SCIO from SDK options

2022-01-20 Thread GitBox
damondouglas commented on a change in pull request #16369: URL: https://github.com/apache/beam/pull/16369#discussion_r788918953 ## File path: playground/frontend/lib/modules/output/components/output.dart ## @@ -33,7 +33,7 @@ class _OutputState extends State with SingleTickerPr

[GitHub] [beam] jrmccluskey opened a new pull request #16575: [WIP] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
jrmccluskey opened a new pull request #16575: URL: https://github.com/apache/beam/pull/16575 Replace goroutines calling Fatalf in tests/benchmarks to address `go vet` warnings. Thank you for your contribution! Follow this checklist to help us incorpo

[GitHub] [beam] codecov[bot] commented on pull request #16575: [WIP] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
codecov[bot] commented on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017673100 # [Codecov](https://codecov.io/gh/apache/beam/pull/16575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] jrmccluskey commented on pull request #16575: [WIP] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
jrmccluskey commented on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017676051 R: @lostluck CC: @riteshghorse @youngoli First run at fixing these. Had a lot of trouble with blocking on channel reads piping out of the goroutine, but found a su

[GitHub] [beam] codecov[bot] edited a comment on pull request #16575: [WIP] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017673100 # [Codecov](https://codecov.io/gh/apache/beam/pull/16575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck commented on a change in pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
lostluck commented on a change in pull request #16575: URL: https://github.com/apache/beam/pull/16575#discussion_r788940176 ## File path: sdks/go/pkg/beam/core/runtime/exec/pardo_test.go ## @@ -132,10 +132,12 @@ func BenchmarkParDo_EmitSumFn(b *testing.B) { } go

[GitHub] [beam] pabloem merged pull request #16569: Revert "Merge pull request #15863 from [BEAM-13184] Autosharding for …

2022-01-20 Thread GitBox
pabloem merged pull request #16569: URL: https://github.com/apache/beam/pull/16569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017673100 # [Codecov](https://codecov.io/gh/apache/beam/pull/16575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] emilymye commented on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
emilymye commented on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1017705214 The failing test is related, but the solution is not clear, hence not merging. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] jrmccluskey commented on a change in pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
jrmccluskey commented on a change in pull request #16575: URL: https://github.com/apache/beam/pull/16575#discussion_r788955658 ## File path: sdks/go/pkg/beam/core/runtime/exec/pardo_test.go ## @@ -132,10 +132,12 @@ func BenchmarkParDo_EmitSumFn(b *testing.B) { }

[GitHub] [beam] pabloem merged pull request #16371: [BEAM-13518][Playground] Beam Playground quickstart page on the Beam website

2022-01-20 Thread GitBox
pabloem merged pull request #16371: URL: https://github.com/apache/beam/pull/16371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #16371: [BEAM-13518][Playground] Beam Playground quickstart page on the Beam website

2022-01-20 Thread GitBox
pabloem commented on pull request #16371: URL: https://github.com/apache/beam/pull/16371#issuecomment-1017716707 i'll merge this for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] brucearctor commented on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-20 Thread GitBox
brucearctor commented on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-1017721292 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] codecov[bot] edited a comment on pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017673100 # [Codecov](https://codecov.io/gh/apache/beam/pull/16575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] aaltay commented on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
aaltay commented on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1017730279 > The failing test is related, but the solution is not clear, hence not merging. Ack. Thank you. Please ask for help if you need. -- This is an automated message from th

[GitHub] [beam] emilymye merged pull request #16572: Update Java FnAPI beam master

2022-01-20 Thread GitBox
emilymye merged pull request #16572: URL: https://github.com/apache/beam/pull/16572 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16521: URL: https://github.com/apache/beam/pull/16521#issuecomment-1013397280 # [Codecov](https://codecov.io/gh/apache/beam/pull/16521?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] roger-mike commented on a change in pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16521: URL: https://github.com/apache/beam/pull/16521#discussion_r788993110 ## File path: sdks/python/.pylintrc ## @@ -85,7 +85,6 @@ disable = arguments-renamed, attribute-defined-outside-init, bad-builtin, - bad-super

[GitHub] [beam] roger-mike commented on a change in pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16521: URL: https://github.com/apache/beam/pull/16521#discussion_r789004728 ## File path: sdks/python/apache_beam/typehints/decorators_test.py ## @@ -369,9 +369,7 @@ def test_disable_type_annotations(self): decorators.disab

[GitHub] [beam] TheNeuralBit opened a new pull request #16576: [BEAM-13693] Bump beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming timeout to 12 hours

2022-01-20 Thread GitBox
TheNeuralBit opened a new pull request #16576: URL: https://github.com/apache/beam/pull/16576 `ValidatesRunner` compliance status (on master branch) Lang ULR Dataflow Flink

[GitHub] [beam] TheNeuralBit commented on pull request #16576: [BEAM-13693] Bump beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming timeout to 12 hours

2022-01-20 Thread GitBox
TheNeuralBit commented on pull request #16576: URL: https://github.com/apache/beam/pull/16576#issuecomment-1017761157 R: @kennknowles -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] codecov[bot] edited a comment on pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16521: URL: https://github.com/apache/beam/pull/16521#issuecomment-1013397280 # [Codecov](https://codecov.io/gh/apache/beam/pull/16521?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] roger-mike commented on a change in pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16521: URL: https://github.com/apache/beam/pull/16521#discussion_r789017255 ## File path: sdks/python/.pylintrc ## @@ -97,7 +96,6 @@ disable = cyclic-import, design, fixme, - function-redefined, Review comment:

[GitHub] [beam] roger-mike commented on pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
roger-mike commented on pull request #16521: URL: https://github.com/apache/beam/pull/16521#issuecomment-1017774122 R: @TheNeuralBit could you take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [beam] roger-mike commented on a change in pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16521: URL: https://github.com/apache/beam/pull/16521#discussion_r789021608 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -3863,7 +3863,6 @@ def idxmin(self, **kwargs): def idxmax(self, **kwargs): retur

[GitHub] [beam] codecov[bot] edited a comment on pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16521: URL: https://github.com/apache/beam/pull/16521#issuecomment-1013397280 # [Codecov](https://codecov.io/gh/apache/beam/pull/16521?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KevinGG commented on pull request #16547: [BEAM-13665] Fix SpannerIO NPE when projectID is not specified

2022-01-20 Thread GitBox
KevinGG commented on pull request #16547: URL: https://github.com/apache/beam/pull/16547#issuecomment-1017795234 > Thank you @nielm and @ajamato > > @KevinGG - Do you mind fixing this or if you do not have time filing a jira for us to track it? I'll take BEAM-13687 -- This

[GitHub] [beam] codecov[bot] edited a comment on pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16555: URL: https://github.com/apache/beam/pull/16555#issuecomment-1015978202 # [Codecov](https://codecov.io/gh/apache/beam/pull/16555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck commented on a change in pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
lostluck commented on a change in pull request #16575: URL: https://github.com/apache/beam/pull/16575#discussion_r789050393 ## File path: sdks/go/pkg/beam/core/runtime/exec/pardo_test.go ## @@ -131,13 +133,12 @@ func BenchmarkParDo_EmitSumFn(b *testing.B) { b.Fa

[GitHub] [beam] jrmccluskey commented on a change in pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
jrmccluskey commented on a change in pull request #16575: URL: https://github.com/apache/beam/pull/16575#discussion_r789057466 ## File path: sdks/go/pkg/beam/core/runtime/exec/pardo_test.go ## @@ -131,13 +133,12 @@ func BenchmarkParDo_EmitSumFn(b *testing.B) { b

[GitHub] [beam] codecov[bot] edited a comment on pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017673100 # [Codecov](https://codecov.io/gh/apache/beam/pull/16575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017673100 # [Codecov](https://codecov.io/gh/apache/beam/pull/16575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16555: URL: https://github.com/apache/beam/pull/16555#issuecomment-1015978202 # [Codecov](https://codecov.io/gh/apache/beam/pull/16555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16575: [BEAM-10206] Remove Fatalf calls in non-test goroutines for tests/benchmarks

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16575: URL: https://github.com/apache/beam/pull/16575#issuecomment-1017673100 # [Codecov](https://codecov.io/gh/apache/beam/pull/16575?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16555: URL: https://github.com/apache/beam/pull/16555#issuecomment-1015978202 # [Codecov](https://codecov.io/gh/apache/beam/pull/16555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck commented on pull request #16573: [BEAM-13699] Replace fnv with maphash.

2022-01-20 Thread GitBox
lostluck commented on pull request #16573: URL: https://github.com/apache/beam/pull/16573#issuecomment-1017839003 I think a small change to also having a io buffer to the more complicated encodings, will also improve hashing for custom coders and the like. I'll try it, but send a different

[GitHub] [beam] lostluck merged pull request #16573: [BEAM-13699] Replace fnv with maphash.

2022-01-20 Thread GitBox
lostluck merged pull request #16573: URL: https://github.com/apache/beam/pull/16573 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-926034602 # [Codecov](https://codecov.io/gh/apache/beam/pull/15548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16555: URL: https://github.com/apache/beam/pull/16555#issuecomment-1015978202 # [Codecov](https://codecov.io/gh/apache/beam/pull/16555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] TheNeuralBit merged pull request #16576: [BEAM-13693] Bump beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming timeout to 12 hours

2022-01-20 Thread GitBox
TheNeuralBit merged pull request #16576: URL: https://github.com/apache/beam/pull/16576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] roger-mike commented on a change in pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16522: URL: https://github.com/apache/beam/pull/16522#discussion_r789094772 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -3863,7 +3863,6 @@ def idxmin(self, **kwargs): def idxmax(self, **kwargs): retur

[GitHub] [beam] brucearctor commented on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-20 Thread GitBox
brucearctor commented on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-1017861273 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] codecov[bot] edited a comment on pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16522: URL: https://github.com/apache/beam/pull/16522#issuecomment-1013397583 # [Codecov](https://codecov.io/gh/apache/beam/pull/16522?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AnandInguva opened a new pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-20 Thread GitBox
AnandInguva opened a new pull request #16577: URL: https://github.com/apache/beam/pull/16577 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution qu

[GitHub] [beam] roger-mike commented on pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-20 Thread GitBox
roger-mike commented on pull request #16522: URL: https://github.com/apache/beam/pull/16522#issuecomment-1017876490 I tried adding an `init-hook` to the `.pylintrc` to solve all the import errors but it didn't work. It remained enabled for now. Here's the example: ``` [MASTER] init

[GitHub] [beam] roger-mike commented on pull request #16522: [WIP][BEAM-13051][B] Enable pylint warnings (import-error/invalid-unary-operand-type)

2022-01-20 Thread GitBox
roger-mike commented on pull request #16522: URL: https://github.com/apache/beam/pull/16522#issuecomment-1017876977 R: @TheNeuralBit could you take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [beam] roger-mike commented on a change in pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16526: URL: https://github.com/apache/beam/pull/16526#discussion_r789113845 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -3863,7 +3863,6 @@ def idxmin(self, **kwargs): def idxmax(self, **kwargs): retur

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-926034602 # [Codecov](https://codecov.io/gh/apache/beam/pull/15548?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] brucearctor commented on pull request #15548: [BEAM-10652] removed check that blocked clustering without partitioning

2022-01-20 Thread GitBox
brucearctor commented on pull request #15548: URL: https://github.com/apache/beam/pull/15548#issuecomment-1017898980 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] roger-mike commented on a change in pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16526: URL: https://github.com/apache/beam/pull/16526#discussion_r789128545 ## File path: sdks/python/apache_beam/io/external/xlang_kinesisio_it_test.py ## @@ -290,7 +290,7 @@ def get_first_shard_id(self, stream_name): ti

[GitHub] [beam] roger-mike commented on a change in pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16526: URL: https://github.com/apache/beam/pull/16526#discussion_r789129151 ## File path: sdks/python/apache_beam/runners/common.py ## @@ -1262,7 +1262,7 @@ def finalize(self): def _reraise_augmented(self, exn): if get

[GitHub] [beam] roger-mike commented on a change in pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16526: URL: https://github.com/apache/beam/pull/16526#discussion_r789129853 ## File path: sdks/python/apache_beam/io/external/xlang_kinesisio_it_test.py ## @@ -267,10 +267,10 @@ def create_stream(self, stream_name): )

[GitHub] [beam] VictorPlusC commented on a change in pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
VictorPlusC commented on a change in pull request #16555: URL: https://github.com/apache/beam/pull/16555#discussion_r789131069 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@ -220,6 +220,24 @@ def display_timezone(self, value): """

[GitHub] [beam] VictorPlusC commented on a change in pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
VictorPlusC commented on a change in pull request #16555: URL: https://github.com/apache/beam/pull/16555#discussion_r789131069 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@ -220,6 +220,24 @@ def display_timezone(self, value): """

[GitHub] [beam] roger-mike commented on a change in pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-20 Thread GitBox
roger-mike commented on a change in pull request #16526: URL: https://github.com/apache/beam/pull/16526#discussion_r789131739 ## File path: sdks/python/apache_beam/runners/portability/portable_runner.py ## @@ -628,12 +628,10 @@ def _cleanup(self, on_exit=False): ' w

[GitHub] [beam] codecov[bot] edited a comment on pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16555: URL: https://github.com/apache/beam/pull/16555#issuecomment-1015978202 # [Codecov](https://codecov.io/gh/apache/beam/pull/16555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16555: URL: https://github.com/apache/beam/pull/16555#issuecomment-1015978202 # [Codecov](https://codecov.io/gh/apache/beam/pull/16555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] VictorPlusC commented on a change in pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
VictorPlusC commented on a change in pull request #16555: URL: https://github.com/apache/beam/pull/16555#discussion_r789142974 ## File path: sdks/python/apache_beam/runners/interactive/interactive_beam.py ## @@ -220,6 +220,24 @@ def display_timezone(self, value): """

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] roger-mike commented on pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-20 Thread GitBox
roger-mike commented on pull request #16526: URL: https://github.com/apache/beam/pull/16526#issuecomment-101792 The `no-member` warning remained enabled because most of the warnings are false positives related to the message classes generated by protobuf or because didn't find the clas

[GitHub] [beam] roger-mike commented on pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-20 Thread GitBox
roger-mike commented on pull request #16526: URL: https://github.com/apache/beam/pull/16526#issuecomment-1017926217 R: @TheNeuralBit could you take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [beam] codecov[bot] commented on pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-20 Thread GitBox
codecov[bot] commented on pull request #16577: URL: https://github.com/apache/beam/pull/16577#issuecomment-1017920222 # [Codecov](https://codecov.io/gh/apache/beam/pull/16577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16552: [BEAM-13430] Re-add provided configuration

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16552: URL: https://github.com/apache/beam/pull/16552#issuecomment-1015839913 # [Codecov](https://codecov.io/gh/apache/beam/pull/16552?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16555: [BEAM-13685] Enable users to specify cache directory under Interactive Beam options

2022-01-20 Thread GitBox
codecov[bot] edited a comment on pull request #16555: URL: https://github.com/apache/beam/pull/16555#issuecomment-1015978202 # [Codecov](https://codecov.io/gh/apache/beam/pull/16555?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

  1   2   >