[GitHub] [beam] pavel-avilov commented on a change in pull request #16582: [BEAM-13711] [Playground] [Bugfix] Add Cloud Logging API in allow list

2022-01-24 Thread GitBox
pavel-avilov commented on a change in pull request #16582: URL: https://github.com/apache/beam/pull/16582#discussion_r790487723 ## File path: playground/infrastructure/proxy/allow_list.py ## @@ -26,4 +26,5 @@ "dataflow-samples", "beam-samples", "apache-beam-sampl

[GitHub] [beam] mosche commented on a change in pull request #16503: [BEAM-13653] Fix usage of SnsIO.write topicArn (AWS Sdk v2)

2022-01-24 Thread GitBox
mosche commented on a change in pull request #16503: URL: https://github.com/apache/beam/pull/16503#discussion_r790492045 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sns/SnsIO.java ## @@ -385,6 +378,15 @@ private static boolean isT

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] potiuk commented on pull request #16511: [BEAM-12812] - Run Github Actions on GCP workers in the apache-beam-testing project

2022-01-24 Thread GitBox
potiuk commented on pull request #16511: URL: https://github.com/apache/beam/pull/16511#issuecomment-1019935956 Sorry I had been really busy recently - is there still somethign I can help with ? :) -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] KhaninArtur commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
KhaninArtur commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r790596717 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper_test.go ## @@ -33,7 +33,6 @@ const ( javaSourceFileExtensi

[GitHub] [beam] potiuk commented on pull request #16511: [BEAM-12812] - Run Github Actions on GCP workers in the apache-beam-testing project

2022-01-24 Thread GitBox
potiuk commented on pull request #16511: URL: https://github.com/apache/beam/pull/16511#issuecomment-1019940228 Happy to help this week if needed. I will take a close look at it. The last week was really crazy for me, -- This is an automated message from the Apache Git Service. To respon

[GitHub] [beam] ashb commented on pull request #16511: [BEAM-12812] - Run Github Actions on GCP workers in the apache-beam-testing project

2022-01-24 Thread GitBox
ashb commented on pull request #16511: URL: https://github.com/apache/beam/pull/16511#issuecomment-1019954730 Ditto -- happy to help answer questions about the GH token and asking INFRA side of things, but I think you probably know everything there already after chatting to Jarek. -- Th

[GitHub] [beam] ashb commented on a change in pull request #16511: [BEAM-12812] - Run Github Actions on GCP workers in the apache-beam-testing project

2022-01-24 Thread GitBox
ashb commented on a change in pull request #16511: URL: https://github.com/apache/beam/pull/16511#discussion_r790613682 ## File path: .github/dockerized-gh-actions-runners/self-hosted-linux/docker/entrypoint.sh ## @@ -0,0 +1,46 @@ +#!/usr/bin/env bash + +# Licensed to the Apac

[GitHub] [beam] ashb commented on a change in pull request #16511: [BEAM-12812] - Run Github Actions on GCP workers in the apache-beam-testing project

2022-01-24 Thread GitBox
ashb commented on a change in pull request #16511: URL: https://github.com/apache/beam/pull/16511#discussion_r790613682 ## File path: .github/dockerized-gh-actions-runners/self-hosted-linux/docker/entrypoint.sh ## @@ -0,0 +1,46 @@ +#!/usr/bin/env bash + +# Licensed to the Apac

[GitHub] [beam] ashb commented on a change in pull request #16511: [BEAM-12812] - Run Github Actions on GCP workers in the apache-beam-testing project

2022-01-24 Thread GitBox
ashb commented on a change in pull request #16511: URL: https://github.com/apache/beam/pull/16511#discussion_r790630802 ## File path: .github/dockerized-gh-actions-runners/self-hosted-linux/docker/entrypoint.sh ## @@ -0,0 +1,46 @@ +#!/usr/bin/env bash + +# Licensed to the Apac

[GitHub] [beam] andreykus commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
andreykus commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r790640966 ## File path: playground/backend/containers/scio/Dockerfile ## @@ -0,0 +1,70 @@ +

[GitHub] [beam] andreykus commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
andreykus commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r790645660 ## File path: playground/backend/containers/scio/build.gradle ## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [beam] AydarZaynutdinov opened a new pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-24 Thread GitBox
AydarZaynutdinov opened a new pull request #16592: URL: https://github.com/apache/beam/pull/16592 [BEAM-13722] Add receiving graph value from backend to send it as a metadata field Thank you for your contribution! Follow this checklist to help us in

[GitHub] [beam] AydarZaynutdinov commented on pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-24 Thread GitBox
AydarZaynutdinov commented on pull request #16592: URL: https://github.com/apache/beam/pull/16592#issuecomment-1020023836 R: @KhaninArtur @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] AydarZaynutdinov opened a new pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-24 Thread GitBox
AydarZaynutdinov opened a new pull request #16593: URL: https://github.com/apache/beam/pull/16593 [BEAM-13725] Add graph field to `PrecompiledObject` Thank you for your contribution! Follow this checklist to help us incorporate your contribution qui

[GitHub] [beam] AydarZaynutdinov commented on pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-24 Thread GitBox
AydarZaynutdinov commented on pull request #16593: URL: https://github.com/apache/beam/pull/16593#issuecomment-1020030966 R: @KhaninArtur @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] yeandy commented on pull request #16571: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-24 Thread GitBox
yeandy commented on pull request #16571: URL: https://github.com/apache/beam/pull/16571#issuecomment-1020105622 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] codecov[bot] edited a comment on pull request #16111: [BEAM-13293] XLang Jdbc IO for Go SDK

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16111: URL: https://github.com/apache/beam/pull/16111#issuecomment-984936432 # [Codecov](https://codecov.io/gh/apache/beam/pull/16111?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] aromanenko-dev merged pull request #16503: [BEAM-13653] Fix usage of SnsIO.write topicArn (AWS Sdk v2)

2022-01-24 Thread GitBox
aromanenko-dev merged pull request #16503: URL: https://github.com/apache/beam/pull/16503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] pavel-avilov commented on pull request #16582: [BEAM-13711] [Playground] [Bugfix] Add Cloud Logging API in allow list

2022-01-24 Thread GitBox
pavel-avilov commented on pull request #16582: URL: https://github.com/apache/beam/pull/16582#issuecomment-1020183517 @pabloem I resolved Artur's comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [beam] msbukal commented on pull request #16586: FhirIO: Add support for BATCH bundle errors.

2022-01-24 Thread GitBox
msbukal commented on pull request #16586: URL: https://github.com/apache/beam/pull/16586#issuecomment-1020186825 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] pavel-avilov commented on pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-24 Thread GitBox
pavel-avilov commented on pull request #16515: URL: https://github.com/apache/beam/pull/16515#issuecomment-1020199933 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] johnjcasey commented on pull request #16588: [BEAM-13310] remove call to get offset consumer config, which was rep…

2022-01-24 Thread GitBox
johnjcasey commented on pull request #16588: URL: https://github.com/apache/beam/pull/16588#issuecomment-1020202785 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] johnjcasey commented on pull request #16588: [BEAM-13310] remove call to get offset consumer config, which was rep…

2022-01-24 Thread GitBox
johnjcasey commented on pull request #16588: URL: https://github.com/apache/beam/pull/16588#issuecomment-1020208892 run setup-go -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] AnandInguva commented on a change in pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
AnandInguva commented on a change in pull request #16589: URL: https://github.com/apache/beam/pull/16589#discussion_r790847557 ## File path: sdks/python/apache_beam/runners/worker/sdk_worker_main.py ## @@ -252,7 +252,8 @@ def _load_main_session(semi_persistent_directory):

[GitHub] [beam] AnandInguva commented on a change in pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
AnandInguva commented on a change in pull request #16589: URL: https://github.com/apache/beam/pull/16589#discussion_r790847557 ## File path: sdks/python/apache_beam/runners/worker/sdk_worker_main.py ## @@ -252,7 +252,8 @@ def _load_main_session(semi_persistent_directory):

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AnandInguva commented on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
AnandInguva commented on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1020221510 PTAL: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] KhaninArtur opened a new pull request #16594: [BEAM-13710][Playground] Update the Apache Beam privacy policy with Playground note

2022-01-24 Thread GitBox
KhaninArtur opened a new pull request #16594: URL: https://github.com/apache/beam/pull/16594 This PR contains the following changes: - Updated the Apache Beam website privacy policy with "Apache Beam Playground website may temporarily store and process data submitted by users throug

[GitHub] [beam] msbukal commented on pull request #16586: FhirIO: Add support for BATCH bundle errors.

2022-01-24 Thread GitBox
msbukal commented on pull request #16586: URL: https://github.com/apache/beam/pull/16586#issuecomment-1020222733 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] mosche opened a new pull request #16595: [BEAM-8807] Add integration test for SnsIO.write (Sdk v1 & v2)

2022-01-24 Thread GitBox
mosche opened a new pull request #16595: URL: https://github.com/apache/beam/pull/16595 Add integration test for SnsIO.write (Sdk v1 & v2) Also fixes a bug in `BasicSnsProvider` (Sdk v1) which didn't set the service endpoint. For clarity, obsolete implementations to create CloudWa

[GitHub] [beam] mosche commented on pull request #16595: [BEAM-8807] Add integration test for SnsIO.write (Sdk v1 & v2)

2022-01-24 Thread GitBox
mosche commented on pull request #16595: URL: https://github.com/apache/beam/pull/16595#issuecomment-1020226056 R: @aromanenko-dev R: @echauchot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-24 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r790867248 ## File path: playground/backend/cmd/server/controller.go ## @@ -241,22 +241,24 @@ func (controller *playgroundController) Cancel(ctx context.Con

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-24 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r790873989 ## File path: playground/backend/internal/cache/cache.go ## @@ -75,4 +79,10 @@ type Cache interface { // SetExpTime adds expiration time of t

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on pull request #16594: [BEAM-13710][Playground] Update the Apache Beam privacy policy with Playground note

2022-01-24 Thread GitBox
KhaninArtur commented on pull request #16594: URL: https://github.com/apache/beam/pull/16594#issuecomment-1020256115 R: @ElessarST @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pcoet commented on a change in pull request #16587: Improved multi-language pipelines section of the programming guide

2022-01-24 Thread GitBox
pcoet commented on a change in pull request #16587: URL: https://github.com/apache/beam/pull/16587#discussion_r790898157 ## File path: website/www/site/content/en/documentation/programming-guide.md ## @@ -6568,28 +6569,28 @@ In this section, we will use [KafkaIO.Read](https://

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-24 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r790917634 ## File path: playground/backend/cmd/server/controller.go ## @@ -294,3 +299,29 @@ func (controller *playgroundController) GetPrecompiledObjectLogs(ct

[GitHub] [beam] TheNeuralBit commented on pull request #16521: [WIP][BEAM-13051][A] Enable pylint warnings (function-redefined/bad-super-call)

2022-01-24 Thread GitBox
TheNeuralBit commented on pull request #16521: URL: https://github.com/apache/beam/pull/16521#issuecomment-1020285229 Also, @roger-mike, I appreciate that you've split out the pylint changes into multiple PRs, that's really helpful. Could you also try to distribute review requests for thes

[GitHub] [beam] KhaninArtur commented on pull request #16538: [BEAM-13676][Playground][Bugfix]Build Of Playground Applications Is Broken

2022-01-24 Thread GitBox
KhaninArtur commented on pull request #16538: URL: https://github.com/apache/beam/pull/16538#issuecomment-1020286117 @pabloem there was a small bug in master, I've fixed it – now this PR passes all Playground checks, can we merge it?🙂 -- This is an automated message from the Apache Git S

[GitHub] [beam] pcoet commented on a change in pull request #16587: Improved multi-language pipelines section of the programming guide

2022-01-24 Thread GitBox
pcoet commented on a change in pull request #16587: URL: https://github.com/apache/beam/pull/16587#discussion_r790937882 ## File path: website/www/site/content/en/documentation/programming-guide.md ## @@ -6568,28 +6569,28 @@ In this section, we will use [KafkaIO.Read](https://

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-24 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r790939943 ## File path: playground/backend/cmd/server/controller.go ## @@ -241,22 +241,24 @@ func (controller *playgroundController) Cancel(ctx context.Context,

[GitHub] [beam] pcoet commented on pull request #16587: Improved multi-language pipelines section of the programming guide

2022-01-24 Thread GitBox
pcoet commented on pull request #16587: URL: https://github.com/apache/beam/pull/16587#issuecomment-1020306618 Okay, I think I got everything. Thanks for the feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [beam] ilya-kozyrev commented on pull request #16574: [BEAM-13700][Playground][Bugfix] Fixed bug in file structure yaml

2022-01-24 Thread GitBox
ilya-kozyrev commented on pull request #16574: URL: https://github.com/apache/beam/pull/16574#issuecomment-1020313413 I think we can close this PR :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] ryanthompson591 commented on a change in pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
ryanthompson591 commented on a change in pull request #16589: URL: https://github.com/apache/beam/pull/16589#discussion_r790937340 ## File path: sdks/python/apache_beam/runners/worker/sdk_worker_main.py ## @@ -76,8 +76,9 @@ def create_harness(environment, dry_run=False): # T

[GitHub] [beam] tvalentyn merged pull request #16553: [BEAM-10897] Update the fastavro lower bound due to an issue on Windows

2022-01-24 Thread GitBox
tvalentyn merged pull request #16553: URL: https://github.com/apache/beam/pull/16553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] msbukal commented on pull request #16586: [BEAM-13731] FhirIO: Add support for BATCH bundle errors.

2022-01-24 Thread GitBox
msbukal commented on pull request #16586: URL: https://github.com/apache/beam/pull/16586#issuecomment-1020336240 Done, thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] TheNeuralBit merged pull request #16571: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-24 Thread GitBox
TheNeuralBit merged pull request #16571: URL: https://github.com/apache/beam/pull/16571 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-uns

[GitHub] [beam] msbukal commented on pull request #16586: [BEAM-13731] FhirIO: Add support for BATCH bundle errors.

2022-01-24 Thread GitBox
msbukal commented on pull request #16586: URL: https://github.com/apache/beam/pull/16586#issuecomment-1020349918 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] roger-mike commented on pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-24 Thread GitBox
roger-mike commented on pull request #16526: URL: https://github.com/apache/beam/pull/16526#issuecomment-1020350135 R: @pabloem could you take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [beam] roger-mike commented on pull request #16562: [WIP][BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

2022-01-24 Thread GitBox
roger-mike commented on pull request #16562: URL: https://github.com/apache/beam/pull/16562#issuecomment-1020351026 R: @pabloem could you take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [beam] emilymye commented on a change in pull request #16572: Update Java FnAPI beam master

2022-01-24 Thread GitBox
emilymye commented on a change in pull request #16572: URL: https://github.com/apache/beam/pull/16572#discussion_r790990370 ## File path: runners/google-cloud-dataflow-java/build.gradle ## @@ -55,7 +55,7 @@ processResources { 'dataflow.legacy_environment_major_version' : '

[GitHub] [beam] emilymye opened a new pull request #16596: Fix beam-master tag for Java FnAPI

2022-01-24 Thread GitBox
emilymye opened a new pull request #16596: URL: https://github.com/apache/beam/pull/16596 Fixing error made in #16572 R: @kennknowles @tvalentyn Thank you for your contribution! Follow this checklist to help us incorporate your contribution qui

[GitHub] [beam] pabloem commented on pull request #16538: [BEAM-13676][Playground][Bugfix]Build Of Playground Applications Is Broken

2022-01-24 Thread GitBox
pabloem commented on pull request #16538: URL: https://github.com/apache/beam/pull/16538#issuecomment-1020377131 LGTM thanks all! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] pabloem merged pull request #16538: [BEAM-13676][Playground][Bugfix]Build Of Playground Applications Is Broken

2022-01-24 Thread GitBox
pabloem merged pull request #16538: URL: https://github.com/apache/beam/pull/16538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Set pickle library to cloud pickle

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] msbukal commented on pull request #16586: [BEAM-13731] FhirIO: Add support for BATCH bundle errors.

2022-01-24 Thread GitBox
msbukal commented on pull request #16586: URL: https://github.com/apache/beam/pull/16586#issuecomment-1020395738 R: pableom@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] pabloem merged pull request #16582: [BEAM-13711] [Playground] [Bugfix] Add Cloud Logging API in allow list

2022-01-24 Thread GitBox
pabloem merged pull request #16582: URL: https://github.com/apache/beam/pull/16582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] pabloem commented on pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-24 Thread GitBox
pabloem commented on pull request #16515: URL: https://github.com/apache/beam/pull/16515#issuecomment-1020430973 LGTM thanks all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] pabloem merged pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-24 Thread GitBox
pabloem merged pull request #16515: URL: https://github.com/apache/beam/pull/16515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-24 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r789534496 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java ## @@ -725,79 +757,104 @@ private

[GitHub] [beam] chamikaramj commented on pull request #16550: Allow users to specify MoveOptions to FileIO

2022-01-24 Thread GitBox
chamikaramj commented on pull request #16550: URL: https://github.com/apache/beam/pull/16550#issuecomment-1020435019 Hi Alexey, Pranav sent a design doc: https://lists.apache.org/thread/543590mg41rytt8r3hk6nj4nq7n40y1j So this PR is on hold. -- This is an automated message from th

[GitHub] [beam] johnjcasey commented on pull request #16588: [BEAM-13310] remove call to get offset consumer config, which was rep…

2022-01-24 Thread GitBox
johnjcasey commented on pull request #16588: URL: https://github.com/apache/beam/pull/16588#issuecomment-1020457632 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] johnjcasey commented on pull request #16588: [BEAM-13310] remove call to get offset consumer config, which was rep…

2022-01-24 Thread GitBox
johnjcasey commented on pull request #16588: URL: https://github.com/apache/beam/pull/16588#issuecomment-1020472749 Run Go PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] KevinGG opened a new pull request #16597: [BEAM-13275] Removed the explicit selenium dependency from setup

2022-01-24 Thread GitBox
KevinGG opened a new pull request #16597: URL: https://github.com/apache/beam/pull/16597 The dependency can be transitively installed through needle, no need to fix it in setup. Thank you for your contribution! Follow this checklist to help us incor

[GitHub] [beam] KevinGG commented on pull request #16597: [BEAM-13275] Removed the explicit selenium dependency from setup

2022-01-24 Thread GitBox
KevinGG commented on pull request #16597: URL: https://github.com/apache/beam/pull/16597#issuecomment-1020488857 Not a binary change, the dependency is only used in an Interactive Beam integration test, not executed by github pre- or post- submits. -- This is an automated message from th

[GitHub] [beam] KevinGG merged pull request #16597: [BEAM-13275] Removed the explicit selenium dependency from setup

2022-01-24 Thread GitBox
KevinGG merged pull request #16597: URL: https://github.com/apache/beam/pull/16597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] youngoli opened a new pull request #16598: [BEAM-13321] Go SDK BigQuery IO wrapper. Initial implementation.

2022-01-24 Thread GitBox
youngoli opened a new pull request #16598: URL: https://github.com/apache/beam/pull/16598 Implementing the Go SDK API for a cross-language BigQuery IO transform. Matches the in-progress Java BQIO externalization that hasn't been merged yet, so will be nonfunctional until that's merged.

[GitHub] [beam] youngoli commented on pull request #16598: [BEAM-13321] Go SDK BigQuery IO wrapper. Initial implementation.

2022-01-24 Thread GitBox
youngoli commented on pull request #16598: URL: https://github.com/apache/beam/pull/16598#issuecomment-1020498157 R: @lostluck @riteshghorse @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] codecov[bot] commented on pull request #16598: [BEAM-13321] Go SDK BigQuery IO wrapper. Initial implementation.

2022-01-24 Thread GitBox
codecov[bot] commented on pull request #16598: URL: https://github.com/apache/beam/pull/16598#issuecomment-1020499435 # [Codecov](https://codecov.io/gh/apache/beam/pull/16598?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16598: [BEAM-13321] Go SDK BigQuery IO wrapper. Initial implementation.

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16598: URL: https://github.com/apache/beam/pull/16598#issuecomment-1020499435 # [Codecov](https://codecov.io/gh/apache/beam/pull/16598?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] daria-malkova commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
daria-malkova commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r790502311 ## File path: playground/backend/internal/validators/scio_validators.go ## @@ -0,0 +1,50 @@ +// Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] youngoli opened a new pull request #16599: [BEAM-13321] Fix exception with BigQuery StreamWriter TraceID.

2022-01-24 Thread GitBox
youngoli opened a new pull request #16599: URL: https://github.com/apache/beam/pull/16599 When running a BigQuery IO transform with a query and query location set, was given the exception: "java.lang.IllegalArgumentException: TraceId must follow the format of A:B. Actual:Dataflow". Documen

[GitHub] [beam] kennknowles commented on pull request #3379: [BEAM] Fixed handling of --use_public_ips.

2022-01-24 Thread GitBox
kennknowles commented on pull request #3379: URL: https://github.com/apache/beam/pull/3379#issuecomment-1020527108 Unfortunately it seems that `store_true` still allows a value via `--use_public_ips=false` but our usage of the result does not take this into account (https://issues.apache.o

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16577: URL: https://github.com/apache/beam/pull/16577#issuecomment-1017920222 # [Codecov](https://codecov.io/gh/apache/beam/pull/16577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AnandInguva commented on pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
AnandInguva commented on pull request #16577: URL: https://github.com/apache/beam/pull/16577#issuecomment-1020552181 cc: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] AnandInguva commented on a change in pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
AnandInguva commented on a change in pull request #16577: URL: https://github.com/apache/beam/pull/16577#discussion_r791156246 ## File path: sdks/python/setup.py ## @@ -153,6 +152,7 @@ def get_version(): 'pytz>=2018.3', 'requests>=2.24.0,<3.0.0', 'typing-extensio

[GitHub] [beam] codecov[bot] edited a comment on pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16577: URL: https://github.com/apache/beam/pull/16577#issuecomment-1017920222 # [Codecov](https://codecov.io/gh/apache/beam/pull/16577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16577: URL: https://github.com/apache/beam/pull/16577#issuecomment-1017920222 # [Codecov](https://codecov.io/gh/apache/beam/pull/16577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AnandInguva commented on a change in pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
AnandInguva commented on a change in pull request #16577: URL: https://github.com/apache/beam/pull/16577#discussion_r791163692 ## File path: sdks/python/apache_beam/runners/portability/stager.py ## @@ -686,12 +723,49 @@ def _populate_requirements_cache(requirements_file, cache

[GitHub] [beam] pabloem commented on a change in pull request #16526: [WIP][BEAM-13051][C] Enable pylint warnings (misplaced-bare-raise/no-member)

2022-01-24 Thread GitBox
pabloem commented on a change in pull request #16526: URL: https://github.com/apache/beam/pull/16526#discussion_r791170279 ## File path: sdks/python/apache_beam/io/external/xlang_kinesisio_it_test.py ## @@ -267,10 +267,10 @@ def create_stream(self, stream_name): )

[GitHub] [beam] pabloem commented on a change in pull request #16562: [WIP][BEAM-13051][D] Enable pylint warnings (no-name-in-module/no-value-for-parameter)

2022-01-24 Thread GitBox
pabloem commented on a change in pull request #16562: URL: https://github.com/apache/beam/pull/16562#discussion_r791172083 ## File path: sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py ## @@ -216,7 +216,7 @@ def __init__( 'InfluxDB') self.f

[GitHub] [beam] codecov[bot] edited a comment on pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16577: URL: https://github.com/apache/beam/pull/16577#issuecomment-1017920222 # [Codecov](https://codecov.io/gh/apache/beam/pull/16577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16577: [BEAM-4032]Support staging binary distributions of dependency packages

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #16577: URL: https://github.com/apache/beam/pull/16577#issuecomment-1017920222 # [Codecov](https://codecov.io/gh/apache/beam/pull/16577?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] johnjcasey commented on pull request #16588: [BEAM-13310] remove call to get offset consumer config, which was rep…

2022-01-24 Thread GitBox
johnjcasey commented on pull request #16588: URL: https://github.com/apache/beam/pull/16588#issuecomment-1020577472 @chamikaramj ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] devinbost commented on pull request #15572: [BEAM-8218] WIP, PulsarIO, looking forward for initial feedback

2022-01-24 Thread GitBox
devinbost commented on pull request #15572: URL: https://github.com/apache/beam/pull/15572#issuecomment-1020580084 I'd also like to help. What else needs to be done? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [beam] devinbost commented on pull request #15572: [BEAM-8218] WIP, PulsarIO, looking forward for initial feedback

2022-01-24 Thread GitBox
devinbost commented on pull request #15572: URL: https://github.com/apache/beam/pull/15572#issuecomment-1020580932 If you could at least rebase this PR so we can see it compared to the current master, that would help. -- This is an automated message from the Apache Git Service. To respo

[GitHub] [beam] pabloem commented on a change in pull request #16565: [BEAM-13692][Playground] Implement method to receive Graph

2022-01-24 Thread GitBox
pabloem commented on a change in pull request #16565: URL: https://github.com/apache/beam/pull/16565#discussion_r791177741 ## File path: playground/api/v1/api.proto ## @@ -135,6 +135,16 @@ message GetLogsResponse { string output = 1; } +// GetGraphRequest contains informa

[GitHub] [beam] codecov[bot] edited a comment on pull request #15572: [BEAM-8218] WIP, PulsarIO, looking forward for initial feedback

2022-01-24 Thread GitBox
codecov[bot] edited a comment on pull request #15572: URL: https://github.com/apache/beam/pull/15572#issuecomment-926194094 # [Codecov](https://codecov.io/gh/apache/beam/pull/15572?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

  1   2   >