[GitHub] [beam] KhaninArtur commented on pull request #16594: [BEAM-13710][Playground] Update the Apache Beam privacy policy with Playground note

2022-01-25 Thread GitBox
KhaninArtur commented on pull request #16594: URL: https://github.com/apache/beam/pull/16594#issuecomment-1020905565 Retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] mosche commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791458947 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java ## @@ -509,70 +524,87 @@ void maybeCl

[GitHub] [beam] mkuthan opened a new pull request #16604: BEAM-13714 Get rid of unnecessary logs for BigQuery streaming writes

2022-01-25 Thread GitBox
mkuthan opened a new pull request #16604: URL: https://github.com/apache/beam/pull/16604 As reported in https://issues.apache.org/jira/browse/BEAM-13714 BigQuery connector logs every batch in streaming mode. For real-world pipeline it causes Cloud Logging throttling. As long as

[GitHub] [beam] daria-malkova commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
daria-malkova commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r791461159 ## File path: playground/backend/internal/cloud_bucket/precompiled_objects.go ## @@ -52,6 +52,7 @@ type ObjectInfo struct { Categories [

[GitHub] [beam] mosche commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791462436 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java ## @@ -725,79 +757,104 @@ private voi

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r791463241 ## File path: playground/backend/internal/cloud_bucket/precompiled_objects.go ## @@ -52,6 +52,7 @@ type ObjectInfo struct { Categories

[GitHub] [beam] mosche commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791465121 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java ## @@ -725,79 +757,104 @@ private voi

[GitHub] [beam] andreykus opened a new pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
andreykus opened a new pull request #16605: URL: https://github.com/apache/beam/pull/16605 Add routing service. Build and Deploy Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] mosche commented on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1020932498 Thanks for the thorough review @echauchot 🏅 I've addressed all your comments -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] AydarZaynutdinov commented on pull request #16502: [BEAM-13650][Playground] Add link for examples

2022-01-25 Thread GitBox
AydarZaynutdinov commented on pull request #16502: URL: https://github.com/apache/beam/pull/16502#issuecomment-1020934374 > Don't we need also to read this link and return to the frontend? It's already done. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791483523 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java ## @@ -725,79 +757,104 @@ private

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791487687 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */

[GitHub] [beam] codecov[bot] commented on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] commented on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791487687 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */

[GitHub] [beam] echauchot commented on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1020948953 > Thanks for the thorough review @echauchot medal_sports I've addressed all your comments My pleasure ! Thanks for the prompt replies ! -- This is an automated messag

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791492199 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsIOTest.java ## @@ -35,19 +37,18 @@ /** Tests on {@li

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791492491 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791493057 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791493768 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] mosche commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791497043 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */ pa

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r791496999 ## File path: playground/backend/internal/cloud_bucket/precompiled_objects.go ## @@ -52,6 +52,7 @@ type ObjectInfo struct { Categories

[GitHub] [beam] echauchot commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791498011 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedSourceTest.java ## @@ -17,36 +17,20 @@ */ p

[GitHub] [beam] echauchot edited a comment on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot edited a comment on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1020948953 > Thanks for the thorough review @echauchot medal_sports I've addressed all your comments My pleasure ! I worked late yesterday to no keep you waiting too much on

[GitHub] [beam] mosche commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791507813 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */ pa

[GitHub] [beam] mosche commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791511328 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedSourceTest.java ## @@ -17,36 +17,20 @@ */ pack

[GitHub] [beam] mosche commented on a change in pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on a change in pull request #16478: URL: https://github.com/apache/beam/pull/16478#discussion_r791511507 ## File path: sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java ## @@ -17,113 +17,155 @@ */ pa

[GitHub] [beam] echauchot commented on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1020979664 @mosche please ping me when all is done for a final round of review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] daria-malkova commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-25 Thread GitBox
daria-malkova commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r791512285 ## File path: playground/backend/cmd/server/controller.go ## @@ -294,3 +293,35 @@ func (controller *playgroundController) GetPrecompiledObjectLogs(c

[GitHub] [beam] AydarZaynutdinov commented on pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-25 Thread GitBox
AydarZaynutdinov commented on pull request #16592: URL: https://github.com/apache/beam/pull/16592#issuecomment-1020984030 > The same, I think we need to store and read from a separate file Changed -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] AydarZaynutdinov commented on pull request #16502: [BEAM-13650][Playground] Add link for examples

2022-01-25 Thread GitBox
AydarZaynutdinov commented on pull request #16502: URL: https://github.com/apache/beam/pull/16502#issuecomment-1020985174 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] KhaninArtur commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
KhaninArtur commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r791520054 ## File path: playground/api/v1/api.proto ## @@ -186,6 +186,11 @@ message GetPrecompiledObjectLogsRequest{ string cloud_path = 1; } +// GetPrecom

[GitHub] [beam] mosche commented on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1020987502 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] KhaninArtur commented on a change in pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-25 Thread GitBox
KhaninArtur commented on a change in pull request #16592: URL: https://github.com/apache/beam/pull/16592#discussion_r791526086 ## File path: playground/infrastructure/grpc_client.py ## @@ -130,6 +130,21 @@ async def get_compile_output(self, pipeline_uuid: str) -> str: res

[GitHub] [beam] daria-malkova commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-25 Thread GitBox
daria-malkova commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r791530274 ## File path: playground/backend/internal/utils/precompiled_objects_utils.go ## @@ -38,3 +40,54 @@ func PutPrecompiledObjectsToCategory(categoryName

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-25 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16592: URL: https://github.com/apache/beam/pull/16592#discussion_r791532064 ## File path: playground/infrastructure/grpc_client.py ## @@ -130,6 +130,21 @@ async def get_compile_output(self, pipeline_uuid: str) -> str:

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-25 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r791534120 ## File path: playground/backend/internal/utils/precompiled_objects_utils.go ## @@ -38,3 +40,54 @@ func PutPrecompiledObjectsToCategory(categoryName st

[GitHub] [beam] mosche commented on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
mosche commented on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1021002447 @echauchot all done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] KhaninArtur commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
KhaninArtur commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r791538397 ## File path: playground/backend/containers/scio/Dockerfile ## @@ -0,0 +1,70 @@ +##

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-25 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16592: URL: https://github.com/apache/beam/pull/16592#discussion_r791541253 ## File path: playground/infrastructure/grpc_client.py ## @@ -130,6 +130,21 @@ async def get_compile_output(self, pipeline_uuid: str) -> str:

[GitHub] [beam] KhaninArtur commented on pull request #16549: [BEAM-13681][Playground] Refactoring terraform scripts

2022-01-25 Thread GitBox
KhaninArtur commented on pull request #16549: URL: https://github.com/apache/beam/pull/16549#issuecomment-1021005730 @andreykus do we need to update this PR with the latest master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [beam] KhaninArtur commented on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
KhaninArtur commented on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1021009509 @andreykus could you please name the PR with the same name from the Jira task? And you also need to follow the format [BEAM-X] at the beginning of the title to properly

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r791556987 ## File path: playground/api/v1/api.proto ## @@ -186,6 +186,11 @@ message GetPrecompiledObjectLogsRequest{ string cloud_path = 1; } +// GetP

[GitHub] [beam] AydarZaynutdinov commented on pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
AydarZaynutdinov commented on pull request #16593: URL: https://github.com/apache/beam/pull/16593#issuecomment-1021023374 @KhaninArtur updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] KhaninArtur commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
KhaninArtur commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r791562185 ## File path: playground/backend/internal/utils/precompiled_objects_utils_test.go ## @@ -24,7 +24,7 @@ import ( func TestPutPrecompiledObjectsToCate

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-25 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r791570051 ## File path: playground/backend/internal/utils/precompiled_objects_utils_test.go ## @@ -24,7 +24,7 @@ import ( func TestPutPrecompiledObjectsT

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
KhaninArtur commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r791586062 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -143,3 +153,41 @@ func updateJavaLogConfigFile(paths fs_t

[GitHub] [beam] aromanenko-dev commented on pull request #16595: [BEAM-8807] Add integration test for SnsIO.write (Sdk v1 & v2)

2022-01-25 Thread GitBox
aromanenko-dev commented on pull request #16595: URL: https://github.com/apache/beam/pull/16595#issuecomment-1021058075 Run Java PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] daria-malkova commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
daria-malkova commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r791593001 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -143,3 +153,41 @@ func updateJavaLogConfigFile(paths fs

[GitHub] [beam] KhaninArtur commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
KhaninArtur commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r791593979 ## File path: playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go ## @@ -143,3 +153,41 @@ func updateJavaLogConfigFile(paths fs_t

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] echauchot edited a comment on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot edited a comment on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1020948953 > Thanks for the thorough review @echauchot medal_sports I've addressed all your comments My pleasure ! I worked late yesterday to not keep you waiting too much o

[GitHub] [beam] codecov[bot] edited a comment on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168 # [Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] echauchot commented on pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot commented on pull request #16478: URL: https://github.com/apache/beam/pull/16478#issuecomment-1021084472 Thanks @mosche for your very good work (as usual I'd say :+1:) ! Merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] echauchot merged pull request #16478: [BEAM-13510] Don't retry on invalid SQS receipt handles (AWS Sdk v2)

2022-01-25 Thread GitBox
echauchot merged pull request #16478: URL: https://github.com/apache/beam/pull/16478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubs

[GitHub] [beam] aromanenko-dev commented on a change in pull request #16595: [BEAM-8807] Add integration test for SnsIO.write (Sdk v1 & v2)

2022-01-25 Thread GitBox
aromanenko-dev commented on a change in pull request #16595: URL: https://github.com/apache/beam/pull/16595#discussion_r791628922 ## File path: sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/dynamodb/AwsClientsProvider.java ## @@ -28,7 +28,11 @@ *

[GitHub] [beam] miamihotline opened a new pull request #16606: [BEAM-13247] [Playground] Embedding iframe

2022-01-25 Thread GitBox
miamihotline opened a new pull request #16606: URL: https://github.com/apache/beam/pull/16606 Implemented a new version of the embedded iFrame with: - adjustable height, - ability to run code (examples, arbitrary code) & get outputs, - ability to set the editability of the text fi

[GitHub] [beam] AydarZaynutdinov commented on pull request #16534: [BEAM-13671][Playground] Add backend contribute guide to the project

2022-01-25 Thread GitBox
AydarZaynutdinov commented on pull request #16534: URL: https://github.com/apache/beam/pull/16534#issuecomment-1021193267 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] ElessarST commented on a change in pull request #16606: [BEAM-13247] [Playground] Embedding iframe

2022-01-25 Thread GitBox
ElessarST commented on a change in pull request #16606: URL: https://github.com/apache/beam/pull/16606#discussion_r791724383 ## File path: playground/frontend/lib/modules/output/components/output_header/output_header.dart ## @@ -43,7 +45,7 @@ class OutputHeader extends Statele

[GitHub] [beam] KhaninArtur commented on pull request #16594: [BEAM-13710][Playground] Update the Apache Beam privacy policy with Playground note

2022-01-25 Thread GitBox
KhaninArtur commented on pull request #16594: URL: https://github.com/apache/beam/pull/16594#issuecomment-1021220435 R: @aijamalnk @pabloem @damondouglas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Don't load main session when cloudpickle is used.

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] yeandy commented on a change in pull request #16590: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-25 Thread GitBox
yeandy commented on a change in pull request #16590: URL: https://github.com/apache/beam/pull/16590#discussion_r791776356 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -638,10 +638,13 @@ def replace(self, to_replace, value, limit, method, **kwargs): orde

[GitHub] [beam] yeandy commented on a change in pull request #16590: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-25 Thread GitBox
yeandy commented on a change in pull request #16590: URL: https://github.com/apache/beam/pull/16590#discussion_r791778383 ## File path: sdks/python/apache_beam/dataframe/frames.py ## @@ -4120,6 +4126,22 @@ def dtypes(self): grouping_columns = self._grouping_columns re

[GitHub] [beam] daria-malkova commented on a change in pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
daria-malkova commented on a change in pull request #16563: URL: https://github.com/apache/beam/pull/16563#discussion_r791779907 ## File path: playground/backend/containers/scio/Dockerfile ## @@ -0,0 +1,70 @@ +

[GitHub] [beam] lostluck commented on pull request #16603: [BEAM-13736] Make lifting cache exact.

2022-01-25 Thread GitBox
lostluck commented on pull request #16603: URL: https://github.com/apache/beam/pull/16603#issuecomment-1021258142 The 3 places where the overflow linked list needed to be handled were why the cache needed to be promoted to it's own type. -- This is an automated message from the Apache Gi

[GitHub] [beam] aromanenko-dev commented on pull request #16550: Allow users to specify MoveOptions to FileIO

2022-01-25 Thread GitBox
aromanenko-dev commented on pull request #16550: URL: https://github.com/apache/beam/pull/16550#issuecomment-1021258624 @chamikaramj Thanks for letting me know! Then it would be helpful to keep it as a draft PR or just add `[WIP]` suffix to title. -- This is an automated message from the

[GitHub] [beam] yeandy commented on pull request #16590: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-25 Thread GitBox
yeandy commented on pull request #16590: URL: https://github.com/apache/beam/pull/16590#issuecomment-1021263068 R: @TheNeuralBit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Don't load main session when cloudpickle is used.

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-25 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r791811526 ## File path: playground/backend/cmd/server/controller.go ## @@ -294,3 +299,29 @@ func (controller *playgroundController) GetPrecompiledObjectLogs(ct

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-25 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r791812342 ## File path: playground/backend/internal/utils/precompiled_objects_utils.go ## @@ -34,7 +43,61 @@ func PutPrecompiledObjectsToCategory(categoryName s

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-25 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r791812409 ## File path: playground/backend/internal/utils/precompiled_objects_utils.go ## @@ -34,7 +43,61 @@ func PutPrecompiledObjectsToCategory(categoryName s

[GitHub] [beam] mattrudary opened a new pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-25 Thread GitBox
mattrudary opened a new pull request #16607: URL: https://github.com/apache/beam/pull/16607 This change allows users of the v2 Amazon S3 SDK to access other filesystems that speak the S3 API using the FileIO transforms. It introduces the S3FileSystemSchemeRegistrar and S3FilesystemConfigur

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-25 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r791815557 ## File path: playground/backend/internal/utils/precompiled_objects_utils.go ## @@ -34,7 +43,61 @@ func PutPrecompiledObjectsToCategory(categoryName s

[GitHub] [beam] mattrudary commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-25 Thread GitBox
mattrudary commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1021291525 R: @aromanenko-dev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [beam] pavel-avilov commented on a change in pull request #16484: [BEAM-13633] [Playground] Implement method to get a default example for each SDKs

2022-01-25 Thread GitBox
pavel-avilov commented on a change in pull request #16484: URL: https://github.com/apache/beam/pull/16484#discussion_r791815704 ## File path: playground/backend/cmd/server/controller.go ## @@ -294,3 +293,35 @@ func (controller *playgroundController) GetPrecompiledObjectLogs(ct

[GitHub] [beam] riteshghorse commented on pull request #16598: [BEAM-13732] Go SDK BigQuery IO wrapper. Initial implementation.

2022-01-25 Thread GitBox
riteshghorse commented on pull request #16598: URL: https://github.com/apache/beam/pull/16598#issuecomment-1021293682 LGTM. Thanks for adding a wrapper for payload in schemaio as well. It will be helpful in other XLang IOs too. -- This is an automated message from the Apache Git Service.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Don't load main session when cloudpickle is used.

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] riteshghorse edited a comment on pull request #16598: [BEAM-13732] Go SDK BigQuery IO wrapper. Initial implementation.

2022-01-25 Thread GitBox
riteshghorse edited a comment on pull request #16598: URL: https://github.com/apache/beam/pull/16598#issuecomment-1021293682 LGTM. Thanks for adding a wrapper for payload in schemaio as well. It will be helpful in other XLang IOs too. I guess the test will be added once the java external

[GitHub] [beam] daria-malkova commented on pull request #16563: [BEAM-13701][Playground] Support SCIO SDK via sbt projects

2022-01-25 Thread GitBox
daria-malkova commented on pull request #16563: URL: https://github.com/apache/beam/pull/16563#issuecomment-1021307650 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam 13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16589: [BEAM-13595] Don't load main session when cloudpickle is used.

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16589: URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582 # [Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam-13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam-13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam-13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on pull request #16605: [Beam-13634][Playground] add routing service

2022-01-25 Thread GitBox
KhaninArtur commented on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1021347632 @andreykus I know you are new at this, you can find the naming convention in our guide, could you please rename this PR accordingly? I'll help you with this one – `[BEAM-136

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [Beam-13634][Playground] add routing service

2022-01-25 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] andoni-guzman commented on pull request #16541: [BEAM-13051] Fixed pylint warnings : unexpected-keyword-arg (E1123), undefined-variable (E0602)

2022-01-25 Thread GitBox
andoni-guzman commented on pull request #16541: URL: https://github.com/apache/beam/pull/16541#issuecomment-1021380868 Hi @TheNeuralBit , do you have any comment with this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] AydarZaynutdinov commented on pull request #16592: [BEAM-13722][Playground] Add precompiling of the graph into examples CI/CD

2022-01-25 Thread GitBox
AydarZaynutdinov commented on pull request #16592: URL: https://github.com/apache/beam/pull/16592#issuecomment-1020984030 > The same, I think we need to store and read from a separate file Changed -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] ihji removed a comment on pull request #16591: [BEAM-13716] Clear before creating a new virtual environment in setupVirtualenv

2022-01-25 Thread GitBox
ihji removed a comment on pull request #16591: URL: https://github.com/apache/beam/pull/16591#issuecomment-1020646162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [beam] codecov[bot] commented on pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-25 Thread GitBox
codecov[bot] commented on pull request #16601: URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508 # [Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] pabloem commented on pull request #16515: [BEAM-13636] [Playground] Checking the default field on CI/CD step

2022-01-25 Thread GitBox
pabloem commented on pull request #16515: URL: https://github.com/apache/beam/pull/16515#issuecomment-1020430973 LGTM thanks all -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] emilymye commented on a change in pull request #16572: Update Java FnAPI beam master

2022-01-25 Thread GitBox
emilymye commented on a change in pull request #16572: URL: https://github.com/apache/beam/pull/16572#discussion_r790990370 ## File path: runners/google-cloud-dataflow-java/build.gradle ## @@ -55,7 +55,7 @@ processResources { 'dataflow.legacy_environment_major_version' : '

  1   2   3   4   >