KhaninArtur commented on pull request #16594:
URL: https://github.com/apache/beam/pull/16594#issuecomment-1020905565
Retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
mosche commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791458947
##
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java
##
@@ -509,70 +524,87 @@ void maybeCl
mkuthan opened a new pull request #16604:
URL: https://github.com/apache/beam/pull/16604
As reported in https://issues.apache.org/jira/browse/BEAM-13714 BigQuery
connector logs every batch in streaming mode.
For real-world pipeline it causes Cloud Logging throttling.
As long as
daria-malkova commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791461159
##
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##
@@ -52,6 +52,7 @@ type ObjectInfo struct {
Categories [
mosche commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791462436
##
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java
##
@@ -725,79 +757,104 @@ private voi
AydarZaynutdinov commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791463241
##
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##
@@ -52,6 +52,7 @@ type ObjectInfo struct {
Categories
mosche commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791465121
##
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java
##
@@ -725,79 +757,104 @@ private voi
andreykus opened a new pull request #16605:
URL: https://github.com/apache/beam/pull/16605
Add routing service. Build and Deploy
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
mosche commented on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1020932498
Thanks for the thorough review @echauchot 🏅
I've addressed all your comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
AydarZaynutdinov commented on pull request #16502:
URL: https://github.com/apache/beam/pull/16502#issuecomment-1020934374
> Don't we need also to read this link and return to the frontend?
It's already done.
--
This is an automated message from the Apache Git Service.
To respond to
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791483523
##
File path:
sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReader.java
##
@@ -725,79 +757,104 @@ private
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791487687
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
codecov[bot] commented on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791487687
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
echauchot commented on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1020948953
> Thanks for the thorough review @echauchot medal_sports I've addressed all
your comments
My pleasure ! Thanks for the prompt replies !
--
This is an automated messag
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791492199
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsIOTest.java
##
@@ -35,19 +37,18 @@
/** Tests on {@li
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791492491
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791493057
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791493768
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
mosche commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791497043
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
pa
AydarZaynutdinov commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791496999
##
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##
@@ -52,6 +52,7 @@ type ObjectInfo struct {
Categories
echauchot commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791498011
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedSourceTest.java
##
@@ -17,36 +17,20 @@
*/
p
echauchot edited a comment on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1020948953
> Thanks for the thorough review @echauchot medal_sports I've addressed all
your comments
My pleasure ! I worked late yesterday to no keep you waiting too much on
mosche commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791507813
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
pa
mosche commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791511328
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedSourceTest.java
##
@@ -17,36 +17,20 @@
*/
pack
mosche commented on a change in pull request #16478:
URL: https://github.com/apache/beam/pull/16478#discussion_r791511507
##
File path:
sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/sqs/SqsUnboundedReaderTest.java
##
@@ -17,113 +17,155 @@
*/
pa
echauchot commented on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1020979664
@mosche please ping me when all is done for a final round of review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
daria-malkova commented on a change in pull request #16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r791512285
##
File path: playground/backend/cmd/server/controller.go
##
@@ -294,3 +293,35 @@ func (controller *playgroundController)
GetPrecompiledObjectLogs(c
AydarZaynutdinov commented on pull request #16592:
URL: https://github.com/apache/beam/pull/16592#issuecomment-1020984030
> The same, I think we need to store and read from a separate file
Changed
--
This is an automated message from the Apache Git Service.
To respond to the messag
AydarZaynutdinov commented on pull request #16502:
URL: https://github.com/apache/beam/pull/16502#issuecomment-1020985174
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
KhaninArtur commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791520054
##
File path: playground/api/v1/api.proto
##
@@ -186,6 +186,11 @@ message GetPrecompiledObjectLogsRequest{
string cloud_path = 1;
}
+// GetPrecom
mosche commented on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1020987502
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
KhaninArtur commented on a change in pull request #16592:
URL: https://github.com/apache/beam/pull/16592#discussion_r791526086
##
File path: playground/infrastructure/grpc_client.py
##
@@ -130,6 +130,21 @@ async def get_compile_output(self, pipeline_uuid: str) ->
str:
res
daria-malkova commented on a change in pull request #16493:
URL: https://github.com/apache/beam/pull/16493#discussion_r791530274
##
File path: playground/backend/internal/utils/precompiled_objects_utils.go
##
@@ -38,3 +40,54 @@ func PutPrecompiledObjectsToCategory(categoryName
AydarZaynutdinov commented on a change in pull request #16592:
URL: https://github.com/apache/beam/pull/16592#discussion_r791532064
##
File path: playground/infrastructure/grpc_client.py
##
@@ -130,6 +130,21 @@ async def get_compile_output(self, pipeline_uuid: str) ->
str:
KhaninArtur commented on a change in pull request #16493:
URL: https://github.com/apache/beam/pull/16493#discussion_r791534120
##
File path: playground/backend/internal/utils/precompiled_objects_utils.go
##
@@ -38,3 +40,54 @@ func PutPrecompiledObjectsToCategory(categoryName st
mosche commented on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1021002447
@echauchot all done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
KhaninArtur commented on a change in pull request #16563:
URL: https://github.com/apache/beam/pull/16563#discussion_r791538397
##
File path: playground/backend/containers/scio/Dockerfile
##
@@ -0,0 +1,70 @@
+##
AydarZaynutdinov commented on a change in pull request #16592:
URL: https://github.com/apache/beam/pull/16592#discussion_r791541253
##
File path: playground/infrastructure/grpc_client.py
##
@@ -130,6 +130,21 @@ async def get_compile_output(self, pipeline_uuid: str) ->
str:
KhaninArtur commented on pull request #16549:
URL: https://github.com/apache/beam/pull/16549#issuecomment-1021005730
@andreykus do we need to update this PR with the latest master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
KhaninArtur commented on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1021009509
@andreykus could you please name the PR with the same name from the Jira
task? And you also need to follow the format [BEAM-X] at the beginning of
the title to properly
AydarZaynutdinov commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791556987
##
File path: playground/api/v1/api.proto
##
@@ -186,6 +186,11 @@ message GetPrecompiledObjectLogsRequest{
string cloud_path = 1;
}
+// GetP
AydarZaynutdinov commented on pull request #16593:
URL: https://github.com/apache/beam/pull/16593#issuecomment-1021023374
@KhaninArtur updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
KhaninArtur commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791562185
##
File path: playground/backend/internal/utils/precompiled_objects_utils_test.go
##
@@ -24,7 +24,7 @@ import (
func TestPutPrecompiledObjectsToCate
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
AydarZaynutdinov commented on a change in pull request #16593:
URL: https://github.com/apache/beam/pull/16593#discussion_r791570051
##
File path: playground/backend/internal/utils/precompiled_objects_utils_test.go
##
@@ -24,7 +24,7 @@ import (
func TestPutPrecompiledObjectsT
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
codecov[bot] edited a comment on pull request #16563:
URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
KhaninArtur commented on a change in pull request #16563:
URL: https://github.com/apache/beam/pull/16563#discussion_r791586062
##
File path:
playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go
##
@@ -143,3 +153,41 @@ func updateJavaLogConfigFile(paths fs_t
aromanenko-dev commented on pull request #16595:
URL: https://github.com/apache/beam/pull/16595#issuecomment-1021058075
Run Java PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
codecov[bot] edited a comment on pull request #16563:
URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
daria-malkova commented on a change in pull request #16563:
URL: https://github.com/apache/beam/pull/16563#discussion_r791593001
##
File path:
playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go
##
@@ -143,3 +153,41 @@ func updateJavaLogConfigFile(paths fs
KhaninArtur commented on a change in pull request #16563:
URL: https://github.com/apache/beam/pull/16563#discussion_r791593979
##
File path:
playground/backend/internal/setup_tools/life_cycle/life_cycle_setuper.go
##
@@ -143,3 +153,41 @@ func updateJavaLogConfigFile(paths fs_t
codecov[bot] edited a comment on pull request #16563:
URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
echauchot edited a comment on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1020948953
> Thanks for the thorough review @echauchot medal_sports I've addressed all
your comments
My pleasure ! I worked late yesterday to not keep you waiting too much o
codecov[bot] edited a comment on pull request #16563:
URL: https://github.com/apache/beam/pull/16563#issuecomment-1016643168
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
echauchot commented on pull request #16478:
URL: https://github.com/apache/beam/pull/16478#issuecomment-1021084472
Thanks @mosche for your very good work (as usual I'd say :+1:) ! Merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
echauchot merged pull request #16478:
URL: https://github.com/apache/beam/pull/16478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubs
aromanenko-dev commented on a change in pull request #16595:
URL: https://github.com/apache/beam/pull/16595#discussion_r791628922
##
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/dynamodb/AwsClientsProvider.java
##
@@ -28,7 +28,11 @@
*
miamihotline opened a new pull request #16606:
URL: https://github.com/apache/beam/pull/16606
Implemented a new version of the embedded iFrame with:
- adjustable height,
- ability to run code (examples, arbitrary code) & get outputs,
- ability to set the editability of the text fi
AydarZaynutdinov commented on pull request #16534:
URL: https://github.com/apache/beam/pull/16534#issuecomment-1021193267
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ElessarST commented on a change in pull request #16606:
URL: https://github.com/apache/beam/pull/16606#discussion_r791724383
##
File path:
playground/frontend/lib/modules/output/components/output_header/output_header.dart
##
@@ -43,7 +45,7 @@ class OutputHeader extends Statele
KhaninArtur commented on pull request #16594:
URL: https://github.com/apache/beam/pull/16594#issuecomment-1021220435
R: @aijamalnk @pabloem @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
codecov[bot] edited a comment on pull request #16589:
URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
yeandy commented on a change in pull request #16590:
URL: https://github.com/apache/beam/pull/16590#discussion_r791776356
##
File path: sdks/python/apache_beam/dataframe/frames.py
##
@@ -638,10 +638,13 @@ def replace(self, to_replace, value, limit, method,
**kwargs):
orde
yeandy commented on a change in pull request #16590:
URL: https://github.com/apache/beam/pull/16590#discussion_r791778383
##
File path: sdks/python/apache_beam/dataframe/frames.py
##
@@ -4120,6 +4126,22 @@ def dtypes(self):
grouping_columns = self._grouping_columns
re
daria-malkova commented on a change in pull request #16563:
URL: https://github.com/apache/beam/pull/16563#discussion_r791779907
##
File path: playground/backend/containers/scio/Dockerfile
##
@@ -0,0 +1,70 @@
+
lostluck commented on pull request #16603:
URL: https://github.com/apache/beam/pull/16603#issuecomment-1021258142
The 3 places where the overflow linked list needed to be handled were why
the cache needed to be promoted to it's own type.
--
This is an automated message from the Apache Gi
aromanenko-dev commented on pull request #16550:
URL: https://github.com/apache/beam/pull/16550#issuecomment-1021258624
@chamikaramj Thanks for letting me know! Then it would be helpful to keep it
as a draft PR or just add `[WIP]` suffix to title.
--
This is an automated message from the
yeandy commented on pull request #16590:
URL: https://github.com/apache/beam/pull/16590#issuecomment-1021263068
R: @TheNeuralBit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
codecov[bot] edited a comment on pull request #16589:
URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
pavel-avilov commented on a change in pull request #16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r791811526
##
File path: playground/backend/cmd/server/controller.go
##
@@ -294,3 +299,29 @@ func (controller *playgroundController)
GetPrecompiledObjectLogs(ct
pavel-avilov commented on a change in pull request #16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r791812342
##
File path: playground/backend/internal/utils/precompiled_objects_utils.go
##
@@ -34,7 +43,61 @@ func PutPrecompiledObjectsToCategory(categoryName s
pavel-avilov commented on a change in pull request #16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r791812409
##
File path: playground/backend/internal/utils/precompiled_objects_utils.go
##
@@ -34,7 +43,61 @@ func PutPrecompiledObjectsToCategory(categoryName s
mattrudary opened a new pull request #16607:
URL: https://github.com/apache/beam/pull/16607
This change allows users of the v2 Amazon S3 SDK to access other filesystems
that speak the S3 API using the FileIO transforms. It introduces the
S3FileSystemSchemeRegistrar and S3FilesystemConfigur
pavel-avilov commented on a change in pull request #16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r791815557
##
File path: playground/backend/internal/utils/precompiled_objects_utils.go
##
@@ -34,7 +43,61 @@ func PutPrecompiledObjectsToCategory(categoryName s
mattrudary commented on pull request #16607:
URL: https://github.com/apache/beam/pull/16607#issuecomment-1021291525
R: @aromanenko-dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
pavel-avilov commented on a change in pull request #16484:
URL: https://github.com/apache/beam/pull/16484#discussion_r791815704
##
File path: playground/backend/cmd/server/controller.go
##
@@ -294,3 +293,35 @@ func (controller *playgroundController)
GetPrecompiledObjectLogs(ct
riteshghorse commented on pull request #16598:
URL: https://github.com/apache/beam/pull/16598#issuecomment-1021293682
LGTM. Thanks for adding a wrapper for payload in schemaio as well. It will
be helpful in other XLang IOs too.
--
This is an automated message from the Apache Git Service.
codecov[bot] edited a comment on pull request #16589:
URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
riteshghorse edited a comment on pull request #16598:
URL: https://github.com/apache/beam/pull/16598#issuecomment-1021293682
LGTM. Thanks for adding a wrapper for payload in schemaio as well. It will
be helpful in other XLang IOs too.
I guess the test will be added once the java external
daria-malkova commented on pull request #16563:
URL: https://github.com/apache/beam/pull/16563#issuecomment-1021307650
R: @pabloem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
codecov[bot] edited a comment on pull request #16589:
URL: https://github.com/apache/beam/pull/16589#issuecomment-1018921582
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16589?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
KhaninArtur commented on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1021347632
@andreykus I know you are new at this, you can find the naming convention in
our guide, could you please rename this PR accordingly? I'll help you with this
one – `[BEAM-136
codecov[bot] edited a comment on pull request #16605:
URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+
andoni-guzman commented on pull request #16541:
URL: https://github.com/apache/beam/pull/16541#issuecomment-1021380868
Hi @TheNeuralBit , do you have any comment with this PR?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
AydarZaynutdinov commented on pull request #16592:
URL: https://github.com/apache/beam/pull/16592#issuecomment-1020984030
> The same, I think we need to store and read from a separate file
Changed
--
This is an automated message from the Apache Git Service.
To respond to the messag
ihji removed a comment on pull request #16591:
URL: https://github.com/apache/beam/pull/16591#issuecomment-1020646162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
codecov[bot] commented on pull request #16601:
URL: https://github.com/apache/beam/pull/16601#issuecomment-1020672508
#
[Codecov](https://codecov.io/gh/apache/beam/pull/16601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+
pabloem commented on pull request #16515:
URL: https://github.com/apache/beam/pull/16515#issuecomment-1020430973
LGTM thanks all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
emilymye commented on a change in pull request #16572:
URL: https://github.com/apache/beam/pull/16572#discussion_r790990370
##
File path: runners/google-cloud-dataflow-java/build.gradle
##
@@ -55,7 +55,7 @@ processResources {
'dataflow.legacy_environment_major_version' : '
1 - 100 of 341 matches
Mail list logo