[GitHub] [beam] codecov[bot] edited a comment on pull request #16614: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16614: URL: https://github.com/apache/beam/pull/16614#issuecomment-1021716439 # [Codecov](https://codecov.io/gh/apache/beam/pull/16614?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16613: Supporting JdbcIO driver in classpath for x-lang

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16613: URL: https://github.com/apache/beam/pull/16613#issuecomment-1021658774 # [Codecov](https://codecov.io/gh/apache/beam/pull/16613?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16614: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16614: URL: https://github.com/apache/beam/pull/16614#issuecomment-1021716439 # [Codecov](https://codecov.io/gh/apache/beam/pull/16614?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16613: Supporting JdbcIO driver in classpath for x-lang

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16613: URL: https://github.com/apache/beam/pull/16613#issuecomment-1021658774 # [Codecov](https://codecov.io/gh/apache/beam/pull/16613?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16613: Supporting JdbcIO driver in classpath for x-lang

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16613: URL: https://github.com/apache/beam/pull/16613#issuecomment-1021658774 # [Codecov](https://codecov.io/gh/apache/beam/pull/16613?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-26 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r792456224 ## File path: playground/backend/internal/cache/cache.go ## @@ -55,6 +55,9 @@ const ( // LogsIndex is the index of the start of the log

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-26 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r792457161 ## File path: playground/backend/internal/utils/precompiled_objects_utils.go ## @@ -37,3 +46,37 @@ func PutPrecompiledObjectsToCategory(categoryName st

[GitHub] [beam] KhaninArtur commented on a change in pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-26 Thread GitBox
KhaninArtur commented on a change in pull request #16493: URL: https://github.com/apache/beam/pull/16493#discussion_r792457299 ## File path: playground/backend/cmd/server/controller.go ## @@ -241,22 +241,27 @@ func (controller *playgroundController) Cancel(ctx context.Context,

[GitHub] [beam] daria-malkova commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-26 Thread GitBox
daria-malkova commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r792457376 ## File path: playground/backend/cmd/server/controller.go ## @@ -309,3 +309,15 @@ func (controller *playgroundController) GetPrecompiledObjectLogs(c

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AydarZaynutdinov commented on a change in pull request #16593: [BEAM-13725][Playground] Add graph to the precompiled objects

2022-01-26 Thread GitBox
AydarZaynutdinov commented on a change in pull request #16593: URL: https://github.com/apache/beam/pull/16593#discussion_r792471221 ## File path: playground/backend/internal/cloud_bucket/precompiled_objects.go ## @@ -128,6 +129,16 @@ func (cd *CloudStorage) GetPrecompiledObject

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] daria-malkova commented on a change in pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
daria-malkova commented on a change in pull request #16605: URL: https://github.com/apache/beam/pull/16605#discussion_r792475223 ## File path: .github/workflows/build_playground_backend.yml ## @@ -81,21 +81,30 @@ jobs: - name: Preapre Build Go run: ./gradlew pla

[GitHub] [beam] daria-malkova commented on pull request #16617: [BEAM-13743] [Playground] Add context line for examples

2022-01-26 Thread GitBox
daria-malkova commented on pull request #16617: URL: https://github.com/apache/beam/pull/16617#issuecomment-1022043619 Please add a description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [beam] daria-malkova commented on a change in pull request #16617: [BEAM-13743] [Playground] Add context line for examples

2022-01-26 Thread GitBox
daria-malkova commented on a change in pull request #16617: URL: https://github.com/apache/beam/pull/16617#discussion_r792478037 ## File path: playground/infrastructure/helper.py ## @@ -331,6 +333,17 @@ def _validate(tag: dict, supported_categories: List[str]) -> bool:

[GitHub] [beam] KhaninArtur commented on a change in pull request #16611: [BEAM-13712][Playground] Add graph for python

2022-01-26 Thread GitBox
KhaninArtur commented on a change in pull request #16611: URL: https://github.com/apache/beam/pull/16611#discussion_r792473823 ## File path: playground/backend/internal/code_processing/code_processing.go ## @@ -535,12 +535,14 @@ func processCompileSuccess(ctx context.Context, o

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] miamihotline commented on a change in pull request #16606: [BEAM-13247] [Playground] Embedding iframe

2022-01-26 Thread GitBox
miamihotline commented on a change in pull request #16606: URL: https://github.com/apache/beam/pull/16606#discussion_r792506539 ## File path: playground/frontend/lib/pages/embedded_playground/embedded_page_providers.dart ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Soft

[GitHub] [beam] miamihotline commented on a change in pull request #16606: [BEAM-13247] [Playground] Embedding iframe

2022-01-26 Thread GitBox
miamihotline commented on a change in pull request #16606: URL: https://github.com/apache/beam/pull/16606#discussion_r792514616 ## File path: playground/frontend/lib/modules/editor/components/editor_textarea.dart ## @@ -82,7 +86,9 @@ class _EditorTextAreaState extends State {

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] scwhittle opened a new pull request #16619: [BEAM-11648] Share thread pool across RetryManager instances.

2022-01-26 Thread GitBox
scwhittle opened a new pull request #16619: URL: https://github.com/apache/beam/pull/16619 RetryManager's have short lifetime (for example processElement). This means that many different threads are created instead of effectively reusing them. This is adds expense but also can result i

[GitHub] [beam] scwhittle commented on pull request #16619: [BEAM-11648] Share thread pool across RetryManager instances.

2022-01-26 Thread GitBox
scwhittle commented on pull request #16619: URL: https://github.com/apache/beam/pull/16619#issuecomment-1022100202 R: @reuvenlax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] KhaninArtur commented on pull request #16493: [BEAM-13632][Playground] Save catalog data to the cache

2022-01-26 Thread GitBox
KhaninArtur commented on pull request #16493: URL: https://github.com/apache/beam/pull/16493#issuecomment-1022118726 R: @pabloem -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [beam] aromanenko-dev merged pull request #16595: [BEAM-8807] Add integration test for SnsIO.write (Sdk v1 & v2)

2022-01-26 Thread GitBox
aromanenko-dev merged pull request #16595: URL: https://github.com/apache/beam/pull/16595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] aromanenko-dev commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
aromanenko-dev commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022128962 R: @mosche -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] codecov[bot] edited a comment on pull request #16605: [BEAM-13634][Playground] Create a separate Dockerfile for the routing service

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16605: URL: https://github.com/apache/beam/pull/16605#issuecomment-1020948543 # [Codecov](https://codecov.io/gh/apache/beam/pull/16605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] AydarZaynutdinov opened a new pull request #16620: [BEAM-13737][Playground] Local retrieving of example objects may fail with context deadline

2022-01-26 Thread GitBox
AydarZaynutdinov opened a new pull request #16620: URL: https://github.com/apache/beam/pull/16620 [BEAM-13737] Update logic of receiving precompiled objects; Increase timeout; Thank you for your contribution! Follow this checklist to help us inco

[GitHub] [beam] AydarZaynutdinov commented on pull request #16620: [BEAM-13737][Playground] Local retrieving of example objects may fail with context deadline

2022-01-26 Thread GitBox
AydarZaynutdinov commented on pull request #16620: URL: https://github.com/apache/beam/pull/16620#issuecomment-1022179048 R: @KhaninArtur @ilya-kozyrev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16618: [BEAM-13744] [Playground] Add context line field to the tags

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16618: URL: https://github.com/apache/beam/pull/16618#issuecomment-1021947095 # [Codecov](https://codecov.io/gh/apache/beam/pull/16618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pcoet opened a new pull request #16621: added GitHub example references to Python multilang quickstart

2022-01-26 Thread GitBox
pcoet opened a new pull request #16621: URL: https://github.com/apache/beam/pull/16621 **Please** add a meaningful description for your change here @chamikaramj Added references to the example implementation to the Python multilang quickstart, and moved the instructions on ru

[GitHub] [beam] mosche commented on a change in pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mosche commented on a change in pull request #16607: URL: https://github.com/apache/beam/pull/16607#discussion_r792593619 ## File path: sdks/java/io/amazon-web-services2/build.gradle ## @@ -78,3 +78,8 @@ test { ]) maxParallelForks 4 } + +task writeClasspath { Review com

[GitHub] [beam] mosche commented on a change in pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mosche commented on a change in pull request #16607: URL: https://github.com/apache/beam/pull/16607#discussion_r792593619 ## File path: sdks/java/io/amazon-web-services2/build.gradle ## @@ -78,3 +78,8 @@ test { ]) maxParallelForks 4 } + +task writeClasspath { Review com

[GitHub] [beam] mosche commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mosche commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022304125 Actually, just noticed this fails lots of unit tests for dynamodb... ``` java.lang.IllegalArgumentException: Failed to serialize and deserialize property 'SSECustomerKey

[GitHub] [beam] mosche commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mosche commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022329807 @mattrudary I created https://issues.apache.org/jira/browse/BEAM-13746 for the issue above. Let me handle it, my bad 🤦 -- This is an automated message from the Apache Git Serv

[GitHub] [beam] jrmccluskey opened a new pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-26 Thread GitBox
jrmccluskey opened a new pull request #16622: URL: https://github.com/apache/beam/pull/16622 Adds a user-facing option to pass a disk type argument for a dataflow pipeline. Requires no validation of input as Dataflow will try to pick a reasonable option for the user on both empty and unrec

[GitHub] [beam] jrmccluskey commented on pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-26 Thread GitBox
jrmccluskey commented on pull request #16622: URL: https://github.com/apache/beam/pull/16622#issuecomment-1022338486 Run Go PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] jrmccluskey commented on pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-26 Thread GitBox
jrmccluskey commented on pull request #16622: URL: https://github.com/apache/beam/pull/16622#issuecomment-1022338884 R: @lostluck @youngoli -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [beam] codecov[bot] commented on pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-26 Thread GitBox
codecov[bot] commented on pull request #16622: URL: https://github.com/apache/beam/pull/16622#issuecomment-1022340893 # [Codecov](https://codecov.io/gh/apache/beam/pull/16622?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16622: URL: https://github.com/apache/beam/pull/16622#issuecomment-1022340893 # [Codecov](https://codecov.io/gh/apache/beam/pull/16622?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] aromanenko-dev commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
aromanenko-dev commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022364940 @mosche Interesting how we missed that. It was not covered by tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] mosche opened a new pull request #16623: [BEAM-13746] Fix deserialization of SSECustomerKey for AWS Sdk v2

2022-01-26 Thread GitBox
mosche opened a new pull request #16623: URL: https://github.com/apache/beam/pull/16623 Fix deserialization of SSECustomerKey to allow all fields to be nullable and add missing tests for serialization / deserialization. Thank you for your contribution!

[GitHub] [beam] mosche commented on pull request #16623: [BEAM-13746] Fix deserialization of SSECustomerKey for AWS Sdk v2

2022-01-26 Thread GitBox
mosche commented on pull request #16623: URL: https://github.com/apache/beam/pull/16623#issuecomment-1022372148 R: @aromanenko-dev R: @mattrudary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] mosche commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mosche commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022373263 Yes @aromanenko-dev, there was no test coverage :/ Added the missing tests https://github.com/apache/beam/pull/16623 -- This is an automated message from the Apache

[GitHub] [beam] mosche edited a comment on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mosche edited a comment on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022373263 Yes @aromanenko-dev, there was no test coverage :/ Added the missing tests https://github.com/apache/beam/pull/16623 Though, wondering why S3FileSystemIT didn't surfa

[GitHub] [beam] chamikaramj commented on pull request #16599: [BEAM-13321] Fix exception with BigQuery StreamWriter TraceID.

2022-01-26 Thread GitBox
chamikaramj commented on pull request #16599: URL: https://github.com/apache/beam/pull/16599#issuecomment-1022396649 Created https://issues.apache.org/jira/browse/BEAM-13747 with some info. Our team may not have time to work on this immediately so appreciate if you or Reuven can add this

[GitHub] [beam] codecov[bot] edited a comment on pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16622: URL: https://github.com/apache/beam/pull/16622#issuecomment-1022340893 # [Codecov](https://codecov.io/gh/apache/beam/pull/16622?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] yeandy edited a comment on pull request #16590: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-26 Thread GitBox
yeandy edited a comment on pull request #16590: URL: https://github.com/apache/beam/pull/16590#issuecomment-1021550520 I see a bunch of `grpc` errors in some of the unit tests. I think we can ignore? I also see doctest errors for the `replace` method, specifically for the `s.replace

[GitHub] [beam] codecov[bot] edited a comment on pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16231: URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704 # [Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] TheNeuralBit commented on pull request #16590: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-26 Thread GitBox
TheNeuralBit commented on pull request #16590: URL: https://github.com/apache/beam/pull/16590#issuecomment-1022422437 > I see a bunch of `grpc` errors in some of the unit tests. I think we can ignore? > > I also see doctest errors for the `replace` method, specifically for the `s.re

[GitHub] [beam] TheNeuralBit edited a comment on pull request #16590: [BEAM-13605] Update pandas_doctests_test denylists in preparation for pandas 1.4.0

2022-01-26 Thread GitBox
TheNeuralBit edited a comment on pull request #16590: URL: https://github.com/apache/beam/pull/16590#issuecomment-1022422437 > I see a bunch of `grpc` errors in some of the unit tests. I think we can ignore? Yeah I think these are safe to ignore. Sometimes the GHA checks flake with

[GitHub] [beam] andoni-guzman commented on a change in pull request #16541: [BEAM-13051] Fixed pylint warnings : unexpected-keyword-arg (E1123), undefined-variable (E0602)

2022-01-26 Thread GitBox
andoni-guzman commented on a change in pull request #16541: URL: https://github.com/apache/beam/pull/16541#discussion_r792875917 ## File path: sdks/python/apache_beam/dataframe/frame_base_test.py ## @@ -65,9 +65,9 @@ def add_one(frame): x = frames.DeferredSeries(original_e

[GitHub] [beam] lostluck merged pull request #16622: [BEAM-7928] Allow users to specify worker disk type for Dataflow runner

2022-01-26 Thread GitBox
lostluck merged pull request #16622: URL: https://github.com/apache/beam/pull/16622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] aromanenko-dev merged pull request #16623: [BEAM-13746] Fix deserialization of SSECustomerKey for AWS Sdk v2

2022-01-26 Thread GitBox
aromanenko-dev merged pull request #16623: URL: https://github.com/apache/beam/pull/16623 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-u

[GitHub] [beam] andoni-guzman commented on a change in pull request #16541: [BEAM-13051] Fixed pylint warnings : unexpected-keyword-arg (E1123), undefined-variable (E0602)

2022-01-26 Thread GitBox
andoni-guzman commented on a change in pull request #16541: URL: https://github.com/apache/beam/pull/16541#discussion_r792878379 ## File path: sdks/python/apache_beam/transforms/cy_combiners.py ## @@ -83,13 +83,14 @@ def extract_output(self): class SumInt64Accumulator(obje

[GitHub] [beam] aromanenko-dev commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
aromanenko-dev commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022427522 @mattrudary I merged a @mosche 's fix, cuold you rebase your PR please? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] aromanenko-dev edited a comment on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
aromanenko-dev edited a comment on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022427522 @mattrudary I merged a @mosche 's fix, could you rebase your PR please? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] andoni-guzman commented on a change in pull request #16541: [BEAM-13051] Fixed pylint warnings : unexpected-keyword-arg (E1123), undefined-variable (E0602)

2022-01-26 Thread GitBox
andoni-guzman commented on a change in pull request #16541: URL: https://github.com/apache/beam/pull/16541#discussion_r792880400 ## File path: sdks/python/apache_beam/utils/processes_test.py ## @@ -48,11 +48,9 @@ def test_method_forwarding_not_windows(self, *unused_mocks):

[GitHub] [beam] yirutang commented on pull request #16599: [BEAM-13321] Fix exception with BigQuery StreamWriter TraceID.

2022-01-26 Thread GitBox
yirutang commented on pull request #16599: URL: https://github.com/apache/beam/pull/16599#issuecomment-1022432298 Thanks Chamikara, Our team can look into picking this up. On Wed, Jan 26, 2022 at 8:58 AM Chamikara Jayalath ***@***.***> wrote: > Created https://issues.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16231: URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704 # [Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16231: URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16231: URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704 # [Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16231: URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704 # [Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] rohdesamuel commented on a change in pull request #16601: [BEAM-13734] Support cache directories that use GCS buckets

2022-01-26 Thread GitBox
rohdesamuel commented on a change in pull request #16601: URL: https://github.com/apache/beam/pull/16601#discussion_r792890853 ## File path: sdks/python/apache_beam/runners/interactive/interactive_environment.py ## @@ -675,3 +683,25 @@ def get_sql_chain(self, pipeline, set_use

[GitHub] [beam] codecov[bot] edited a comment on pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16231: URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704 # [Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] codecov[bot] edited a comment on pull request #16231: [BEAM-13271] Bump errorprone to 2.10.0

2022-01-26 Thread GitBox
codecov[bot] edited a comment on pull request #16231: URL: https://github.com/apache/beam/pull/16231#issuecomment-993827704 # [Codecov](https://codecov.io/gh/apache/beam/pull/16231?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+A

[GitHub] [beam] mattrudary commented on a change in pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mattrudary commented on a change in pull request #16607: URL: https://github.com/apache/beam/pull/16607#discussion_r792921622 ## File path: sdks/java/io/amazon-web-services2/build.gradle ## @@ -78,3 +78,8 @@ test { ]) maxParallelForks 4 } + +task writeClasspath { Review

[GitHub] [beam] mattrudary commented on pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mattrudary commented on pull request #16607: URL: https://github.com/apache/beam/pull/16607#issuecomment-1022471126 > Thanks so much for working on this and helping to maintain feature parity between the two AWS modules, @mattrudary. We'd like to eventually sunset `amazon-web-services` for

[GitHub] [beam] mattrudary commented on a change in pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mattrudary commented on a change in pull request #16607: URL: https://github.com/apache/beam/pull/16607#discussion_r792924331 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystemConfiguration.java ## @@ -0,0 +1,115 @@ +/* +

[GitHub] [beam] mattrudary commented on a change in pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mattrudary commented on a change in pull request #16607: URL: https://github.com/apache/beam/pull/16607#discussion_r792928048 ## File path: sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2/s3/S3FileSystemConfiguration.java ## @@ -0,0 +1,115 @@ +/* +

[GitHub] [beam] mattrudary commented on a change in pull request #16607: [BEAM-12435] Generalize S3FileSystem to support multiple URI schemes.

2022-01-26 Thread GitBox
mattrudary commented on a change in pull request #16607: URL: https://github.com/apache/beam/pull/16607#discussion_r792928829 ## File path: CHANGES.md ## @@ -56,6 +56,7 @@ ## I/Os * Support for stopReadTime on KafkaIO SDF (Java).([BEAM-13171](https://issues.apache.org/jira

[GitHub] [beam] TheNeuralBit commented on a change in pull request #16541: [BEAM-13051] Fixed pylint warnings : unexpected-keyword-arg (E1123), undefined-variable (E0602)

2022-01-26 Thread GitBox
TheNeuralBit commented on a change in pull request #16541: URL: https://github.com/apache/beam/pull/16541#discussion_r792930643 ## File path: sdks/python/apache_beam/utils/processes_test.py ## @@ -48,11 +48,9 @@ def test_method_forwarding_not_windows(self, *unused_mocks):

[GitHub] [beam] emilymye commented on pull request #16614: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-01-26 Thread GitBox
emilymye commented on pull request #16614: URL: https://github.com/apache/beam/pull/16614#issuecomment-1022480749 Confirmed that Twister2 Runner ValidatesRunner Tests are failing due to new test ([Per](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2_PR/57/testR

[GitHub] [beam] emilymye edited a comment on pull request #16614: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

2022-01-26 Thread GitBox
emilymye edited a comment on pull request #16614: URL: https://github.com/apache/beam/pull/16614#issuecomment-1022480749 Confirmed that Twister2 Runner ValidatesRunner Tests are [failing](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2_PR/57/testReport/junit/org

[GitHub] [beam] pabloem opened a new pull request #16624: Exclude per-key order tests on Twister2 runner

2022-01-26 Thread GitBox
pabloem opened a new pull request #16624: URL: https://github.com/apache/beam/pull/16624 r: @emilymye Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer

  1   2   3   >