[GitHub] [beam] codecov[bot] edited a comment on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085292938 # [Codecov](https://codecov.io/gh/apache/beam/pull/17147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck commented on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
lostluck commented on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085544237 Run Go Flink ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] lostluck commented on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
lostluck commented on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085544358 Run Go PostCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [beam] codecov[bot] edited a comment on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085292938 # [Codecov](https://codecov.io/gh/apache/beam/pull/17147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck commented on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
lostluck commented on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085550796 R: @jrmccluskey This should unblock the imports. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [beam] github-actions[bot] commented on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
github-actions[bot] commented on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085552430 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apac

[GitHub] [beam] codecov[bot] edited a comment on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085292938 # [Codecov](https://codecov.io/gh/apache/beam/pull/17147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085292938 # [Codecov](https://codecov.io/gh/apache/beam/pull/17147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] thempatel commented on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
thempatel commented on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1085806815 > So the vast majority of Python changes seem to be unrelated to this (mostly go specific, already very large) change. Is there a way we could break them out and review them s

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] damccorm commented on a change in pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
damccorm commented on a change in pull request #17147: URL: https://github.com/apache/beam/pull/17147#discussion_r840523993 ## File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go ## @@ -66,8 +65,7 @@ const ( URNLegacyProgressReporting = "beam:protocol:progress_

[GitHub] [beam] damccorm commented on a change in pull request #17240: [BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed.

2022-04-01 Thread GitBox
damccorm commented on a change in pull request #17240: URL: https://github.com/apache/beam/pull/17240#discussion_r840539459 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/BeamFnStateGrpcClientCache.java ## @@ -59,74 +58,108 @@ public BeamFnState

[GitHub] [beam] mosche opened a new pull request #17242: Row with getters jmh getters logic push down

2022-04-01 Thread GitBox
mosche opened a new pull request #17242: URL: https://github.com/apache/beam/pull/17242 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] riteshghorse commented on pull request #17216: Simplify specifying additional dependencies in Go SDK in XLang IOs

2022-04-01 Thread GitBox
riteshghorse commented on pull request #17216: URL: https://github.com/apache/beam/pull/17216#issuecomment-1085913262 Used the expansion address builder which eliminated the breaking change and the need to have a separate `CrossLanguage` function for classpath. PTAL. -- This is an aut

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] asf-ci commented on pull request #17243: [BEAM-13015] Disable retries for fnapi grpc channels which otherwise defaults on.

2022-04-01 Thread GitBox
asf-ci commented on pull request #17243: URL: https://github.com/apache/beam/pull/17243#issuecomment-1085924582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] scwhittle opened a new pull request #17243: [BEAM-13015] Disable retries for fnapi grpc channels which otherwise defaults on.

2022-04-01 Thread GitBox
scwhittle opened a new pull request #17243: URL: https://github.com/apache/beam/pull/17243 Since the channel is to the local runner process, retries are not expected to help. This simplifies the grpc stream stack to not involve a RetryStream object.

[GitHub] [beam] scwhittle commented on pull request #17243: [BEAM-13015] Disable retries for fnapi grpc channels which otherwise defaults on.

2022-04-01 Thread GitBox
scwhittle commented on pull request #17243: URL: https://github.com/apache/beam/pull/17243#issuecomment-1085924679 R: @lukecwik -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] mosche closed pull request #17242: Row with getters jmh getters logic push down

2022-04-01 Thread GitBox
mosche closed pull request #17242: URL: https://github.com/apache/beam/pull/17242 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr.

[GitHub] [beam] codecov[bot] edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1053851306 # [Codecov](https://codecov.io/gh/apache/beam/pull/16961?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] johnjcasey commented on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
johnjcasey commented on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1085944396 run java precommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] ryanthompson591 commented on a change in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-01 Thread GitBox
ryanthompson591 commented on a change in pull request #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r840622351 ## File path: sdks/python/apache_beam/ml/inference/base.py ## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] ryanthompson591 commented on a change in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-01 Thread GitBox
ryanthompson591 commented on a change in pull request #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r840625167 ## File path: sdks/python/apache_beam/ml/inference/base.py ## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] ryanthompson591 commented on a change in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-01 Thread GitBox
ryanthompson591 commented on a change in pull request #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r840633104 ## File path: sdks/python/apache_beam/ml/inference/base.py ## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] mosche commented on pull request #17172: [BEAM-14166] Performance / Cache improvements to RowWithGetter

2022-04-01 Thread GitBox
mosche commented on pull request #17172: URL: https://github.com/apache/beam/pull/17172#issuecomment-1085981280 I've drilled down into this a bit and I think I've got some interesting finding's to share @reuvenlax & @TheNeuralBit. Investigating a few approaches, I would to suggest to

[GitHub] [beam] ryanthompson591 commented on a change in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-01 Thread GitBox
ryanthompson591 commented on a change in pull request #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r840656241 ## File path: sdks/python/apache_beam/ml/inference/base.py ## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [beam] johnjcasey commented on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
johnjcasey commented on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1085990948 Run Portable_Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #16970: [BEAM-13982] A base class for run inference

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16970: URL: https://github.com/apache/beam/pull/16970#issuecomment-1054615571 # [Codecov](https://codecov.io/gh/apache/beam/pull/16970?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck commented on a change in pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
lostluck commented on a change in pull request #17147: URL: https://github.com/apache/beam/pull/17147#discussion_r840729416 ## File path: sdks/go/pkg/beam/core/runtime/graphx/translate.go ## @@ -66,8 +65,7 @@ const ( URNLegacyProgressReporting = "beam:protocol:progress_

[GitHub] [beam] codecov[bot] edited a comment on pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17147: URL: https://github.com/apache/beam/pull/17147#issuecomment-1085292938 # [Codecov](https://codecov.io/gh/apache/beam/pull/17147?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] ryanthompson591 opened a new pull request #17244: [BEAM-14014] Support impersonation credentials in dataflow runner

2022-04-01 Thread GitBox
ryanthompson591 opened a new pull request #17244: URL: https://github.com/apache/beam/pull/17244 Adds the ability to set impersonation credentials for jobs running in dataflow. Adds the ability to set the target_principal and delegate accounts to the authentication singleton.

[GitHub] [beam] asf-ci commented on pull request #17244: [BEAM-14014] Support impersonation credentials in dataflow runner

2022-04-01 Thread GitBox
asf-ci commented on pull request #17244: URL: https://github.com/apache/beam/pull/17244#issuecomment-1086104151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] lostluck merged pull request #17147: [BEAM-14153] Reshuffled Row Coder PCollection used as Side Input cause encoder issues.

2022-04-01 Thread GitBox
lostluck merged pull request #17147: URL: https://github.com/apache/beam/pull/17147 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] kileys opened a new pull request #17245: Update python container version

2022-04-01 Thread GitBox
kileys opened a new pull request #17245: URL: https://github.com/apache/beam/pull/17245 gcr.io/cloud-dataflow/v1beta3/python36:beam-master-20220331 gcr.io/cloud-dataflow/v1beta3/python36-fnapi:beam-master-20220331 Thank you for your contribution! Fol

[GitHub] [beam] kileys commented on pull request #17245: Update python container version

2022-04-01 Thread GitBox
kileys commented on pull request #17245: URL: https://github.com/apache/beam/pull/17245#issuecomment-1086117872 R: @emilymye -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] aromanenko-dev opened a new pull request #17246: [WIP][BEAM-8715] Bump Avro version to 1.11.0

2022-04-01 Thread GitBox
aromanenko-dev opened a new pull request #17246: URL: https://github.com/apache/beam/pull/17246 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] reuvenlax commented on pull request #17070: Handle changing schemas in Storage API sink

2022-04-01 Thread GitBox
reuvenlax commented on pull request #17070: URL: https://github.com/apache/beam/pull/17070#issuecomment-1086128589 @TheNeuralBit friendly ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] robertwb commented on pull request #17236: Py java debug

2022-04-01 Thread GitBox
robertwb commented on pull request #17236: URL: https://github.com/apache/beam/pull/17236#issuecomment-1086131392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [beam] robertwb commented on pull request #17235: [BEAM-14148] Roll PyExpansionService forward, skipping flaky test for now.

2022-04-01 Thread GitBox
robertwb commented on pull request #17235: URL: https://github.com/apache/beam/pull/17235#issuecomment-1086132170 Only failure is CommunityMetrics, which looks unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [beam] robertwb merged pull request #17235: [BEAM-14148] Roll PyExpansionService forward, skipping flaky test for now.

2022-04-01 Thread GitBox
robertwb merged pull request #17235: URL: https://github.com/apache/beam/pull/17235 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lukecwik commented on a change in pull request #17244: [BEAM-14014] Support impersonation credentials in dataflow runner

2022-04-01 Thread GitBox
lukecwik commented on a change in pull request #17244: URL: https://github.com/apache/beam/pull/17244#discussion_r840768114 ## File path: sdks/python/apache_beam/internal/gcp/auth.py ## @@ -125,30 +139,22 @@ def get_service_credentials(cls): "socket default timeout i

[GitHub] [beam] chamikaramj commented on a change in pull request #17244: [BEAM-14014] Support impersonation credentials in dataflow runner

2022-04-01 Thread GitBox
chamikaramj commented on a change in pull request #17244: URL: https://github.com/apache/beam/pull/17244#discussion_r840775779 ## File path: sdks/python/apache_beam/internal/gcp/auth.py ## @@ -125,30 +139,22 @@ def get_service_credentials(cls): "socket default timeou

[GitHub] [beam] benWize commented on a change in pull request #17233: [BEAM-8970] Add docs to run wordcount example on portable Spark Runner

2022-04-01 Thread GitBox
benWize commented on a change in pull request #17233: URL: https://github.com/apache/beam/pull/17233#discussion_r840779089 ## File path: website/www/site/content/en/documentation/runners/spark.md ## @@ -240,6 +240,82 @@ See [here](/roadmap/portability/#sdk-harness-config) for

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lukecwik commented on pull request #17243: [BEAM-13015] Disable retries for fnapi grpc channels which otherwise defaults on.

2022-04-01 Thread GitBox
lukecwik commented on pull request #17243: URL: https://github.com/apache/beam/pull/17243#issuecomment-1086164124 This will be true for Dataflow as designed today but this would limit other runners to use a local process as well. -- This is an automated message from the Apache Git Servic

[GitHub] [beam] kileys commented on pull request #17210: [BEAM-14192] Update legacy container version

2022-04-01 Thread GitBox
kileys commented on pull request #17210: URL: https://github.com/apache/beam/pull/17210#issuecomment-1086164270 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] kileys commented on pull request #17245: Update python container version

2022-04-01 Thread GitBox
kileys commented on pull request #17245: URL: https://github.com/apache/beam/pull/17245#issuecomment-1086167185 Run Python PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] kileys commented on pull request #17214: [BEAM-13952] Sickbay testAfterProcessingTimeContinuationTriggerUsingState

2022-04-01 Thread GitBox
kileys commented on pull request #17214: URL: https://github.com/apache/beam/pull/17214#issuecomment-1086168898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] lukecwik commented on a change in pull request #17240: [BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed.

2022-04-01 Thread GitBox
lukecwik commented on a change in pull request #17240: URL: https://github.com/apache/beam/pull/17240#discussion_r840792682 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/state/BeamFnStateGrpcClientCache.java ## @@ -59,74 +58,108 @@ public BeamFnState

[GitHub] [beam] codecov[bot] commented on pull request #17246: [WIP][BEAM-8715] Bump Avro version to 1.11.0

2022-04-01 Thread GitBox
codecov[bot] commented on pull request #17246: URL: https://github.com/apache/beam/pull/17246#issuecomment-1086171218 # [Codecov](https://codecov.io/gh/apache/beam/pull/17246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] TheNeuralBit commented on pull request #17224: [rollback][release-2.38.0][BEAM-14116][BEAM-14179] Rolling back PRs causing release-blocking issues.

2022-04-01 Thread GitBox
TheNeuralBit commented on pull request #17224: URL: https://github.com/apache/beam/pull/17224#issuecomment-1086171371 @youngoli you said earlier: > I think the issue with https://github.com/apache/beam/pull/17004 was a false positive (or at least not reproducible) If it was a

[GitHub] [beam] lukecwik commented on pull request #17240: [BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed.

2022-04-01 Thread GitBox
lukecwik commented on pull request #17240: URL: https://github.com/apache/beam/pull/17240#issuecomment-1086171578 > This generally looks good to me in terms of providing good thread safety, I'd appreciate another review for someone who has a little more context on the change though (did yo

[GitHub] [beam] lukecwik commented on pull request #17240: [BEAM-13519] Solve race issues when the server responds with an error before the GrpcStateClient finishes being constructed.

2022-04-01 Thread GitBox
lukecwik commented on pull request #17240: URL: https://github.com/apache/beam/pull/17240#issuecomment-1086173083 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] TheNeuralBit commented on a change in pull request #17070: Handle changing schemas in Storage API sink

2022-04-01 Thread GitBox
TheNeuralBit commented on a change in pull request #17070: URL: https://github.com/apache/beam/pull/17070#discussion_r840794938 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiDynamicDestinationsTableRow.java ## @@ -

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #17236: Py java debug

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17236: URL: https://github.com/apache/beam/pull/17236#issuecomment-1085215280 # [Codecov](https://codecov.io/gh/apache/beam/pull/17236?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] lostluck opened a new pull request #17247: Delint: initialism names and missing doc strings.

2022-04-01 Thread GitBox
lostluck opened a new pull request #17247: URL: https://github.com/apache/beam/pull/17247 Delint: initialism names and missing doc strings. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easi

[GitHub] [beam] robertwb commented on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
robertwb commented on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1086179486 Just to confirm, imports of the form `from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload` are no longer supported, and that's why the diff is so huge

[GitHub] [beam] lostluck commented on pull request #17247: Delint: initialism names and missing doc strings.

2022-04-01 Thread GitBox
lostluck commented on pull request #17247: URL: https://github.com/apache/beam/pull/17247#issuecomment-1086180028 R: @jrmccluskey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] ihji opened a new pull request #17248: [BEAM-14233] Merge requirements from expanded response for Java Exter…

2022-04-01 Thread GitBox
ihji opened a new pull request #17248: URL: https://github.com/apache/beam/pull/17248 …nal transform **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] kileys commented on pull request #17210: [BEAM-14192] Update legacy container version

2022-04-01 Thread GitBox
kileys commented on pull request #17210: URL: https://github.com/apache/beam/pull/17210#issuecomment-1086181500 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] kileys commented on pull request #17210: [BEAM-14192] Update legacy container version

2022-04-01 Thread GitBox
kileys commented on pull request #17210: URL: https://github.com/apache/beam/pull/17210#issuecomment-1086183226 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [beam] codecov[bot] commented on pull request #17245: Update python container version

2022-04-01 Thread GitBox
codecov[bot] commented on pull request #17245: URL: https://github.com/apache/beam/pull/17245#issuecomment-1086183342 # [Codecov](https://codecov.io/gh/apache/beam/pull/17245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+

[GitHub] [beam] ihji opened a new pull request #17249: [BEAM-14232] Only resolve artifacts in expanded environments for Java…

2022-04-01 Thread GitBox
ihji opened a new pull request #17249: URL: https://github.com/apache/beam/pull/17249 … External transform **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate

[GitHub] [beam] ihji commented on pull request #17249: [BEAM-14232] Only resolve artifacts in expanded environments for Java…

2022-04-01 Thread GitBox
ihji commented on pull request #17249: URL: https://github.com/apache/beam/pull/17249#issuecomment-1086183962 R: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] ihji commented on pull request #17248: [BEAM-14233] Merge requirements from expanded response for Java Exter…

2022-04-01 Thread GitBox
ihji commented on pull request #17248: URL: https://github.com/apache/beam/pull/17248#issuecomment-1086184341 R: @chamikaramj -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [beam] laraschmidt commented on a change in pull request #17181: [BEAM-14035] Convert BigQuery SchemaIO to SchemaTransform

2022-04-01 Thread GitBox
laraschmidt commented on a change in pull request #17181: URL: https://github.com/apache/beam/pull/17181#discussion_r840795608 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQuerySchemaTransformReadConfiguration.java ## @@

[GitHub] [beam] lostluck merged pull request #17247: Delint: initialism names and missing doc strings.

2022-04-01 Thread GitBox
lostluck merged pull request #17247: URL: https://github.com/apache/beam/pull/17247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] pabloem merged pull request #16841: Revert "Revert "Merge pull request #15441 from [BEAM-8823] Make FnApi…

2022-04-01 Thread GitBox
pabloem merged pull request #16841: URL: https://github.com/apache/beam/pull/16841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr

[GitHub] [beam] codecov[bot] edited a comment on pull request #17246: [WIP][BEAM-8715] Bump Avro version to 1.11.0

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17246: URL: https://github.com/apache/beam/pull/17246#issuecomment-1086171218 # [Codecov](https://codecov.io/gh/apache/beam/pull/17246?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] thempatel commented on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
thempatel commented on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1086214648 > Just to confirm, imports of the form `from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload` are no longer supported, and that's why the diff is so h

[GitHub] [beam] robertwb commented on pull request #17236: Py java debug

2022-04-01 Thread GitBox
robertwb commented on pull request #17236: URL: https://github.com/apache/beam/pull/17236#issuecomment-1086215201 Timeout waiting for Python service startup after 28.677 seconds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [beam] lukecwik merged pull request #17210: [BEAM-14192] Update legacy container version

2022-04-01 Thread GitBox
lukecwik merged pull request #17210: URL: https://github.com/apache/beam/pull/17210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [beam] codecov[bot] edited a comment on pull request #17245: Update python container version

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17245: URL: https://github.com/apache/beam/pull/17245#issuecomment-1086183342 # [Codecov](https://codecov.io/gh/apache/beam/pull/17245?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] codecov[bot] edited a comment on pull request #16923: [BEAM-10529] nullable xlang coder

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #16923: URL: https://github.com/apache/beam/pull/16923#issuecomment-1048999684 # [Codecov](https://codecov.io/gh/apache/beam/pull/16923?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] thempatel edited a comment on pull request #16961: BEAM-13939: Restructure Protos to fix namespace conflicts

2022-04-01 Thread GitBox
thempatel edited a comment on pull request #16961: URL: https://github.com/apache/beam/pull/16961#issuecomment-1086214648 > Just to confirm, imports of the form `from apache_beam.portability.api.beam_runner_api_pb2 import TestStreamPayload` are no longer supported, and that's why the diff

[GitHub] [beam] jrmccluskey opened a new pull request #17250: [BEAM-13901] Add unit tests for graphx/cogbk.go

2022-04-01 Thread GitBox
jrmccluskey opened a new pull request #17250: URL: https://github.com/apache/beam/pull/17250 Adds unit tests for graphx/cogbk.co, making sure that the composed union coders are correct. Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] asf-ci commented on pull request #17250: [BEAM-13901] Add unit tests for graphx/cogbk.go

2022-04-01 Thread GitBox
asf-ci commented on pull request #17250: URL: https://github.com/apache/beam/pull/17250#issuecomment-1086219926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [beam] codecov[bot] edited a comment on pull request #17236: Py java debug

2022-04-01 Thread GitBox
codecov[bot] edited a comment on pull request #17236: URL: https://github.com/apache/beam/pull/17236#issuecomment-1085215280 # [Codecov](https://codecov.io/gh/apache/beam/pull/17236?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+

[GitHub] [beam] robertwb commented on pull request #17249: [BEAM-14232] Only resolve artifacts in expanded environments for Java External Transform

2022-04-01 Thread GitBox
robertwb commented on pull request #17249: URL: https://github.com/apache/beam/pull/17249#issuecomment-1086227871 Could you add some more details to this PR description or the JIRA what problem you're trying to solve here? -- This is an automated message from the Apache Git Service. To

[GitHub] [beam] robertwb commented on a change in pull request #16970: [BEAM-13982] A base class for run inference

2022-04-01 Thread GitBox
robertwb commented on a change in pull request #16970: URL: https://github.com/apache/beam/pull/16970#discussion_r840845214 ## File path: sdks/python/apache_beam/ml/inference/base.py ## @@ -0,0 +1,252 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [beam] ihji commented on pull request #16800: [BEAM-13793] Adding external transform registry for schema-based payl…

2022-04-01 Thread GitBox
ihji commented on pull request #16800: URL: https://github.com/apache/beam/pull/16800#issuecomment-1086230840 Yes, we don't need this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

  1   2   >