[GitHub] [beam] mosche opened a new pull request, #26711: Drop deprecated AWS SnsIO.writeAsync

2023-05-16 Thread via GitHub
mosche opened a new pull request, #26711: URL: https://github.com/apache/beam/pull/26711 In Beam 2.37.0 ([BEAM-13203](https://issues.apache.org/jira/browse/BEAM-13203)) `SnsIO.writeAsync` was deprecated, the implementation is wrong and risks losing data. This PR finally drops `SnsIO.writeA

[GitHub] [beam] github-actions[bot] commented on pull request #26711: Drop deprecated AWS SnsIO.writeAsync

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26711: URL: https://github.com/apache/beam/pull/26711#issuecomment-1549114000 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] tvalentyn commented on pull request #26712: Explicitly link the license to Keras dependency

2023-05-16 Thread via GitHub
tvalentyn commented on PR #26712: URL: https://github.com/apache/beam/pull/26712#issuecomment-1549470077 Run Python RC Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] github-actions[bot] commented on pull request #26557: Render inputDir in HadoopFormatIO.Read DisplayData

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26557: URL: https://github.com/apache/beam/pull/26557#issuecomment-1549548500 Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`: R: @kennknowle

[GitHub] [beam] github-actions[bot] commented on pull request #25843: fixes:#25841 Improve-error-messages-for-the-validateStateApplicableForInput-method…

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #25843: URL: https://github.com/apache/beam/pull/25843#issuecomment-1549548686 Reminder, please take a look at this pr: @robertwb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [beam] github-actions[bot] commented on pull request #26712: Explicitly link the license to Keras dependency

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26712: URL: https://github.com/apache/beam/pull/26712#issuecomment-1549591261 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @liferoad for label python. Available commands: - `stop

[GitHub] [beam] tvalentyn commented on a diff in pull request #26712: Explicitly link the license to Keras dependency

2023-05-16 Thread via GitHub
tvalentyn commented on code in PR #26712: URL: https://github.com/apache/beam/pull/26712#discussion_r1195126483 ## sdks/python/container/license_scripts/dep_urls_py.yaml: ## @@ -94,6 +94,8 @@ pip_dependencies: license: "https://raw.githubusercontent.com/mtth/hdfs/master/LIC

[GitHub] [beam] tvalentyn commented on pull request #26712: Explicitly link the license to Keras dependency

2023-05-16 Thread via GitHub
tvalentyn commented on PR #26712: URL: https://github.com/apache/beam/pull/26712#issuecomment-1549613403 Run Python RC Dataflow ValidatesContainer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] tvalentyn commented on pull request #26712: Explicitly link the license to Keras dependency

2023-05-16 Thread via GitHub
tvalentyn commented on PR #26712: URL: https://github.com/apache/beam/pull/26712#issuecomment-1549615049 R: @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [beam] github-actions[bot] commented on pull request #26712: Explicitly link the license to Keras dependency

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26712: URL: https://github.com/apache/beam/pull/26712#issuecomment-1549618191 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] TSultanov opened a new pull request, #26713: Add minimal example for BigQuery usage

2023-05-16 Thread via GitHub
TSultanov opened a new pull request, #26713: URL: https://github.com/apache/beam/pull/26713 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quic

[GitHub] [beam] tvalentyn merged pull request #26712: Explicitly link the license to Keras dependency

2023-05-16 Thread via GitHub
tvalentyn merged PR #26712: URL: https://github.com/apache/beam/pull/26712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] johnjcasey commented on a diff in pull request #26702: [#26644] Set GCS UserAgent to Beam for Go.

2023-05-16 Thread via GitHub
johnjcasey commented on code in PR #26702: URL: https://github.com/apache/beam/pull/26702#discussion_r1195198494 ## sdks/go/pkg/beam/util/gcsx/gcs.go: ## @@ -28,15 +28,19 @@ import ( "google.golang.org/api/option" ) +var userAgent = option.WithUserAgent("GPN:Beam") R

[GitHub] [beam] mosche commented on pull request #26711: Drop deprecated AWS SnsIO.writeAsync

2023-05-16 Thread via GitHub
mosche commented on PR #26711: URL: https://github.com/apache/beam/pull/26711#issuecomment-1549719150 All tests completed, somehow the state is not reflected here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [beam] mosche merged pull request #26711: Drop deprecated AWS SnsIO.writeAsync

2023-05-16 Thread via GitHub
mosche merged PR #26711: URL: https://github.com/apache/beam/pull/26711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] Abacn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners

2023-05-16 Thread via GitHub
Abacn commented on PR #26707: URL: https://github.com/apache/beam/pull/26707#issuecomment-1549735127 Run Samza ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] Abacn commented on pull request #26707: Properly tag test so it is excluded on unsupported runners

2023-05-16 Thread via GitHub
Abacn commented on PR #26707: URL: https://github.com/apache/beam/pull/26707#issuecomment-1549735915 Run ULR Loopback ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [beam] bvolpato opened a new pull request, #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
bvolpato opened a new pull request, #26714: URL: https://github.com/apache/beam/pull/26714 This will be useful to get more context for failures that happen when parsing the TableRow. Right now, user has no idea of knowing the reason, although it might be something simple (e.g., bad t

[GitHub] [beam] bvolpato commented on pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
bvolpato commented on PR #26714: URL: https://github.com/apache/beam/pull/26714#issuecomment-1549758160 R: @johnjcasey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] github-actions[bot] commented on pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26714: URL: https://github.com/apache/beam/pull/26714#issuecomment-1549760170 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] mosche opened a new pull request, #26715: Remove deprecated AWS coders

2023-05-16 Thread via GitHub
mosche opened a new pull request, #26715: URL: https://github.com/apache/beam/pull/26715 Remove deprecated, obsolete AWS coders that were replaced by schemas in Beam v2.43.0 (see #16947). (closes #23315) Thank you for your contribution! Follow th

[GitHub] [beam] mosche commented on pull request #26715: Remove deprecated AWS coders

2023-05-16 Thread via GitHub
mosche commented on PR #26715: URL: https://github.com/apache/beam/pull/26715#issuecomment-1549764076 R: @aromanenko-dev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [beam] bvolpato commented on a diff in pull request #26699: Add BigTable batch size and latency metrics for writes

2023-05-16 Thread via GitHub
bvolpato commented on code in PR #26699: URL: https://github.com/apache/beam/pull/26699#discussion_r1195236139 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java: ## @@ -548,6 +566,7 @@ public CompletionStage writeRe

[GitHub] [beam] github-actions[bot] commented on pull request #26715: Remove deprecated AWS coders

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26715: URL: https://github.com/apache/beam/pull/26715#issuecomment-1549766636 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] olehborysevych commented on a diff in pull request #26513: Playground Cloud Build deployment and CI/CD triggers

2023-05-16 Thread via GitHub
olehborysevych commented on code in PR #26513: URL: https://github.com/apache/beam/pull/26513#discussion_r1195238208 ## playground/terraform/infrastructure/cloudbuild-manual-setup/README.md: ## @@ -20,97 +20,131 @@ This directory organizes Infrastructure-as-Code to provision de

[GitHub] [beam] johnjcasey commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
johnjcasey commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195239450 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] bvolpato commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
bvolpato commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195272376 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] Abacn commented on a diff in pull request #26557: Render inputDir in HadoopFormatIO.Read DisplayData

2023-05-16 Thread via GitHub
Abacn commented on code in PR #26557: URL: https://github.com/apache/beam/pull/26557#discussion_r1195288700 ## sdks/java/io/hadoop-format/src/test/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIOReadTest.java: ## @@ -1076,6 +1080,16 @@ private static SerializableConfigur

[GitHub] [beam] Abacn commented on pull request #26697: Implement a fast (lcg) random generator for Python SyntheticSource

2023-05-16 Thread via GitHub
Abacn commented on PR #26697: URL: https://github.com/apache/beam/pull/26697#issuecomment-1549830908 R: @tvalentyn @AnandInguva -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [beam] johnjcasey commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
johnjcasey commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195292633 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] github-actions[bot] commented on pull request #26697: Implement a fast (lcg) random generator for Python SyntheticSource

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26697: URL: https://github.com/apache/beam/pull/26697#issuecomment-1549832959 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] EdwardCuiPeacock opened a new issue, #26716: [Bug]: ApproximateQuantilesCombineFn "TypeError: Expected tuple, got dict"

2023-05-16 Thread via GitHub
EdwardCuiPeacock opened a new issue, #26716: URL: https://github.com/apache/beam/issues/26716 ### What happened? I subclassed `beam.transforms.stats.ApproximateQuantilesCombineFn` in the following way: ```python class ApproxQuantileCombiner(ApproximateQuantilesCombineFn):

[GitHub] [beam] tvalentyn commented on issue #26673: [Failing Test]: beam_PreCommit_Python_Cron failing TestWriteBigTable.test_write_metrics

2023-05-16 Thread via GitHub
tvalentyn commented on issue #26673: URL: https://github.com/apache/beam/issues/26673#issuecomment-1549856593 looks like this error reappeared this morning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [beam] tvalentyn commented on issue #26673: [Failing Test]: beam_PreCommit_Python_Cron failing TestWriteBigTable.test_write_metrics

2023-05-16 Thread via GitHub
tvalentyn commented on issue #26673: URL: https://github.com/apache/beam/issues/26673#issuecomment-1549859852 Caused by 2.18.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] tvalentyn commented on issue #26673: [Failing Test]: beam_PreCommit_Python_Cron failing TestWriteBigTable.test_write_metrics

2023-05-16 Thread via GitHub
tvalentyn commented on issue #26673: URL: https://github.com/apache/beam/issues/26673#issuecomment-1549864274 fwiw we should be able to `git bisect` this to a particular google-cloud-bigquery commit assuming we can install that dep from sources -- This is an automated message from the Apa

[GitHub] [beam] Abacn commented on issue #26673: [Failing Test]: beam_PreCommit_Python_Cron failing TestWriteBigTable.test_write_metrics

2023-05-16 Thread via GitHub
Abacn commented on issue #26673: URL: https://github.com/apache/beam/issues/26673#issuecomment-1549878080 For now we should pin `google-cloud-bigtable<2.18.0` for now. I just excluded it as `google-cloud-bigtable!=2.18.0`. I suggested to investigate the cause https://github.com/googleapis/

[GitHub] [beam] pabloem commented on a diff in pull request #26699: Add BigTable batch size and latency metrics for writes

2023-05-16 Thread via GitHub
pabloem commented on code in PR #26699: URL: https://github.com/apache/beam/pull/26699#discussion_r1195335897 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java: ## @@ -548,6 +566,7 @@ public CompletionStage writeRec

[GitHub] [beam] Abacn commented on issue #26673: [Failing Test]: beam_PreCommit_Python_Cron failing TestWriteBigTable.test_write_metrics

2023-05-16 Thread via GitHub
Abacn commented on issue #26673: URL: https://github.com/apache/beam/issues/26673#issuecomment-1549909710 @tvalentyn the cause is known due and the commit that got reverted. Reverting that PR the beam test passes. The new tag 2.18.1 is identical to 2.18.0 It contains the two commit:

[GitHub] [beam] Abacn opened a new pull request, #26717: Set upperbound for cloud bigtable client

2023-05-16 Thread via GitHub
Abacn opened a new pull request, #26717: URL: https://github.com/apache/beam/pull/26717 Mitigate #26673 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate you

[GitHub] [beam] Abacn commented on issue #26673: [Failing Test]: beam_PreCommit_Python_Cron failing TestWriteBigTable.test_write_metrics

2023-05-16 Thread via GitHub
Abacn commented on issue #26673: URL: https://github.com/apache/beam/issues/26673#issuecomment-1549926651 opened #26717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

[GitHub] [beam] Abacn commented on pull request #26717: Set upperbound for cloud bigtable client

2023-05-16 Thread via GitHub
Abacn commented on PR #26717: URL: https://github.com/apache/beam/pull/26717#issuecomment-1549926977 R: @tvalentyn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [beam] github-actions[bot] commented on pull request #26717: Set upperbound for cloud bigtable client

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26717: URL: https://github.com/apache/beam/pull/26717#issuecomment-1549928727 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] liferoad commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
liferoad commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195383215 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] codecov[bot] commented on pull request #26717: Set upperbound for cloud bigtable client

2023-05-16 Thread via GitHub
codecov[bot] commented on PR #26717: URL: https://github.com/apache/beam/pull/26717#issuecomment-1549955705 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26717?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] liferoad commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
liferoad commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195398735 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] Abacn commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
Abacn commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195418886 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] pabloem merged pull request #26699: Add BigTable batch size and latency metrics for writes

2023-05-16 Thread via GitHub
pabloem merged PR #26699: URL: https://github.com/apache/beam/pull/26699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected].

[GitHub] [beam] xinyuiscool commented on a diff in pull request #26649: Basic Opeartor Metric Support For Data Shuffle (GBK and Combine Per Key) Operators for Samza Runner

2023-05-16 Thread via GitHub
xinyuiscool commented on code in PR #26649: URL: https://github.com/apache/beam/pull/26649#discussion_r1195435078 ## runners/samza/src/main/java/org/apache/beam/runners/samza/metrics/SamzaMetricOpFactory.java: ## @@ -53,17 +55,31 @@ public enum OpType { * @return a {@link Op

[GitHub] [beam] reuvenlax commented on pull request #26707: Properly tag test so it is excluded on unsupported runners

2023-05-16 Thread via GitHub
reuvenlax commented on PR #26707: URL: https://github.com/apache/beam/pull/26707#issuecomment-1550026081 Run ULR Loopback ValidatesRunner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] lostluck commented on a diff in pull request #26702: [#26644] Set GCS UserAgent to Beam for Go.

2023-05-16 Thread via GitHub
lostluck commented on code in PR #26702: URL: https://github.com/apache/beam/pull/26702#discussion_r1195452105 ## sdks/go/pkg/beam/util/gcsx/gcs.go: ## @@ -28,15 +28,19 @@ import ( "google.golang.org/api/option" ) +var userAgent = option.WithUserAgent("GPN:Beam") Rev

[GitHub] [beam] johnjcasey opened a new pull request, #26720: Update cloud profile download to use curl instead of wget

2023-05-16 Thread via GitHub
johnjcasey opened a new pull request, #26720: URL: https://github.com/apache/beam/pull/26720 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in

[GitHub] [beam] Abacn commented on pull request #26717: Set upperbound for cloud bigtable client

2023-05-16 Thread via GitHub
Abacn commented on PR #26717: URL: https://github.com/apache/beam/pull/26717#issuecomment-1550099549 Ignore GitHub Action test hanging, merging for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [beam] Abacn merged pull request #26717: Set upperbound for cloud bigtable client

2023-05-16 Thread via GitHub
Abacn merged PR #26717: URL: https://github.com/apache/beam/pull/26717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] mosche merged pull request #26715: Remove deprecated AWS coders

2023-05-16 Thread via GitHub
mosche merged PR #26715: URL: https://github.com/apache/beam/pull/26715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] tonytanger closed pull request #25549: Read new partitions as the result of splits and merges

2023-05-16 Thread via GitHub
tonytanger closed pull request #25549: Read new partitions as the result of splits and merges URL: https://github.com/apache/beam/pull/25549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [beam] tonytanger closed pull request #25539: Lock ReadChangeStreamPartition so only one DoFn can work on one partition

2023-05-16 Thread via GitHub
tonytanger closed pull request #25539: Lock ReadChangeStreamPartition so only one DoFn can work on one partition URL: https://github.com/apache/beam/pull/25539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [beam] tonytanger closed pull request #25538: Advance DetectNewPartition's watermark by aggregating the watermark of ReadChangeStreamPartitions

2023-05-16 Thread via GitHub
tonytanger closed pull request #25538: Advance DetectNewPartition's watermark by aggregating the watermark of ReadChangeStreamPartitions URL: https://github.com/apache/beam/pull/25538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [beam] tonytanger closed pull request #25523: Google Cloud Bigtable Change Stream Connector

2023-05-16 Thread via GitHub
tonytanger closed pull request #25523: Google Cloud Bigtable Change Stream Connector URL: https://github.com/apache/beam/pull/25523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [beam] github-actions[bot] commented on pull request #26718: Revert "Increase streaming wordcount IT timeout "

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26718: URL: https://github.com/apache/beam/pull/26718#issuecomment-1550133778 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @damccorm for label python. Available commands: - `stop

[GitHub] [beam] robertwb merged pull request #26370: Ensure FnApi bag appends are not batched if it would exceed 10MB limit

2023-05-16 Thread via GitHub
robertwb merged PR #26370: URL: https://github.com/apache/beam/pull/26370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] robertwb closed issue #26369: [Bug]: BagUserState should chunk appends

2023-05-16 Thread via GitHub
robertwb closed issue #26369: [Bug]: BagUserState should chunk appends URL: https://github.com/apache/beam/issues/26369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [beam] github-actions[bot] commented on pull request #26718: Revert "Increase streaming wordcount IT timeout "

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26718: URL: https://github.com/apache/beam/pull/26718#issuecomment-1550156766 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] riteshghorse commented on pull request #26683: [Python] Added load model option args for PyTorch Model Handler

2023-05-16 Thread via GitHub
riteshghorse commented on PR #26683: URL: https://github.com/apache/beam/pull/26683#issuecomment-1550160059 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [beam] jrmccluskey merged pull request #26701: [Go SDK] Fix poor implementation of type identity checks.

2023-05-16 Thread via GitHub
jrmccluskey merged PR #26701: URL: https://github.com/apache/beam/pull/26701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] codecov[bot] commented on pull request #26718: Revert "Increase streaming wordcount IT timeout "

2023-05-16 Thread via GitHub
codecov[bot] commented on PR #26718: URL: https://github.com/apache/beam/pull/26718#issuecomment-1550170347 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26718?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] github-actions[bot] commented on pull request #26720: Update cloud profile download to use curl instead of wget

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26720: URL: https://github.com/apache/beam/pull/26720#issuecomment-1550173007 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @robertwb for label java. Available commands: - `stop re

[GitHub] [beam] damccorm opened a new issue, #26721: [Task]: Configure repository branch protection rules in .asf.yaml

2023-05-16 Thread via GitHub
damccorm opened a new issue, #26721: URL: https://github.com/apache/beam/issues/26721 ### What needs to happen? During the last release, we had an accident that briefly caused the whole beam repo to be deleted and we needed to lift the branch protection rules briefly in order to rewr

[GitHub] [beam] reuvenlax commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
reuvenlax commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195626037 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] damccorm opened a new pull request, #26722: Allow model handlers to consume multi_process_shared for large models

2023-05-16 Thread via GitHub
damccorm opened a new pull request, #26722: URL: https://github.com/apache/beam/pull/26722 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution quick

[GitHub] [beam] jrmccluskey opened a new issue, #26723: [Failing Test]: Tour of Beam Frontend Test suite is perma-red on master

2023-05-16 Thread via GitHub
jrmccluskey opened a new issue, #26723: URL: https://github.com/apache/beam/issues/26723 ### What happened? The Tour of Beam Frontend Test Suite is perma-red on master with the following error: ``` Failure Details: Failure in method: ToB miscellaneous ui ══╡ EXCEPTION

[GitHub] [beam] jrmccluskey merged pull request #26624: Bump golang.org/x/oauth2 from 0.7.0 to 0.8.0 in /sdks

2023-05-16 Thread via GitHub
jrmccluskey merged PR #26624: URL: https://github.com/apache/beam/pull/26624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] dependabot[bot] closed pull request #26708: Bump google.golang.org/api from 0.121.0 to 0.122.0 in /sdks

2023-05-16 Thread via GitHub
dependabot[bot] closed pull request #26708: Bump google.golang.org/api from 0.121.0 to 0.122.0 in /sdks URL: https://github.com/apache/beam/pull/26708 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] dependabot[bot] commented on pull request #26708: Bump google.golang.org/api from 0.121.0 to 0.122.0 in /sdks

2023-05-16 Thread via GitHub
dependabot[bot] commented on PR #26708: URL: https://github.com/apache/beam/pull/26708#issuecomment-1550322912 Looks like google.golang.org/api is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [beam] riteshghorse merged pull request #26683: [Python] Added load model option args for PyTorch Model Handler

2023-05-16 Thread via GitHub
riteshghorse merged PR #26683: URL: https://github.com/apache/beam/pull/26683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] Abacn merged pull request #26718: Revert "Increase streaming wordcount IT timeout "

2023-05-16 Thread via GitHub
Abacn merged PR #26718: URL: https://github.com/apache/beam/pull/26718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] Abacn merged pull request #26720: Update cloud profile download to use curl instead of wget

2023-05-16 Thread via GitHub
Abacn merged PR #26720: URL: https://github.com/apache/beam/pull/26720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] codecov[bot] commented on pull request #26722: Allow model handlers to consume multi_process_shared for large models

2023-05-16 Thread via GitHub
codecov[bot] commented on PR #26722: URL: https://github.com/apache/beam/pull/26722#issuecomment-1550351108 ## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26722?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report

[GitHub] [beam] Sanil15 commented on a diff in pull request #26649: Basic Opeartor Metric Support For Data Shuffle (GBK and Combine Per Key) Operators for Samza Runner

2023-05-16 Thread via GitHub
Sanil15 commented on code in PR #26649: URL: https://github.com/apache/beam/pull/26649#discussion_r1195741905 ## runners/samza/src/main/java/org/apache/beam/runners/samza/metrics/SamzaMetricOpFactory.java: ## @@ -53,17 +55,31 @@ public enum OpType { * @return a {@link Op} fo

[GitHub] [beam] reuvenlax merged pull request #26707: Properly tag test so it is excluded on unsupported runners

2023-05-16 Thread via GitHub
reuvenlax merged PR #26707: URL: https://github.com/apache/beam/pull/26707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] Abacn closed issue #26706: [Failing Test]: Java ValidateRunner test ViewTest.testTriggeredLatestSingleton flaky/permared on multiple runners

2023-05-16 Thread via GitHub
Abacn closed issue #26706: [Failing Test]: Java ValidateRunner test ViewTest.testTriggeredLatestSingleton flaky/permared on multiple runners URL: https://github.com/apache/beam/issues/26706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [beam] github-actions[bot] commented on pull request #26722: Allow model handlers to consume multi_process_shared for large models

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26722: URL: https://github.com/apache/beam/pull/26722#issuecomment-1550618289 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @tvalentyn for label python. Available commands: - `stop

[GitHub] [beam] github-actions[bot] commented on pull request #26722: Allow model handlers to consume multi_process_shared for large models

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26722: URL: https://github.com/apache/beam/pull/26722#issuecomment-1550621704 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] pabloem merged pull request #26454: Update Bigtable Change Stream Connector to include latest features

2023-05-16 Thread via GitHub
pabloem merged PR #26454: URL: https://github.com/apache/beam/pull/26454 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected].

[GitHub] [beam] lostluck merged pull request #26709: Bump cloud.google.com/go/spanner from 1.45.1 to 1.46.0 in /sdks

2023-05-16 Thread via GitHub
lostluck merged PR #26709: URL: https://github.com/apache/beam/pull/26709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected]

[GitHub] [beam] darshan-sj opened a new pull request, #26727: Spanner - add default retryable codes

2023-05-16 Thread via GitHub
darshan-sj opened a new pull request, #26727: URL: https://github.com/apache/beam/pull/26727 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution qui

[GitHub] [beam] bvolpato commented on a diff in pull request #26714: Log the exception's cause when failed to parse TableRow

2023-05-16 Thread via GitHub
bvolpato commented on code in PR #26714: URL: https://github.com/apache/beam/pull/26714#discussion_r1195906446 ## sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiWriteUnshardedRecords.java: ## @@ -571,7 +571,7 @@ long flush(

[GitHub] [beam] bvolpato commented on pull request #26508: Replace another use of `ClassLoadingStrategy.Default.INJECTION`

2023-05-16 Thread via GitHub
bvolpato commented on PR #26508: URL: https://github.com/apache/beam/pull/26508#issuecomment-1550675245 This looks good to me, but I'm not a committer to merge, so ping for @chamikaramj @kennknowles -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] github-actions[bot] commented on pull request #26727: Spanner - add default retryable codes

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26727: URL: https://github.com/apache/beam/pull/26727#issuecomment-1550708486 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @bvolpato for label java. R: @manavgarg for label io. R: @ni

[GitHub] [beam] dependabot[bot] opened a new pull request, #26728: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.24 to 1.18.25 in /sdks

2023-05-16 Thread via GitHub
dependabot[bot] opened a new pull request, #26728: URL: https://github.com/apache/beam/pull/26728 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.18.24 to 1.18.25. Changelog Sourced from https://github.com/aws/aws-sdk-go-v2/blob/main/CHANGE

[GitHub] [beam] dependabot[bot] opened a new pull request, #26729: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.66 to 1.11.67 in /sdks

2023-05-16 Thread via GitHub
dependabot[bot] opened a new pull request, #26729: URL: https://github.com/apache/beam/pull/26729 Bumps [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) from 1.11.66 to 1.11.67. Commits https://github.com/aws/aws-sdk-go-v2/commit/a86beba1

[GitHub] [beam] chamikaramj commented on pull request #26508: Replace another use of `ClassLoadingStrategy.Default.INJECTION`

2023-05-16 Thread via GitHub
chamikaramj commented on PR #26508: URL: https://github.com/apache/beam/pull/26508#issuecomment-1550752252 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [beam] johannaojeling commented on issue #26703: [Failing Test][Go SDK]: Flake in lastModified test for local filesystem.

2023-05-16 Thread via GitHub
johannaojeling commented on issue #26703: URL: https://github.com/apache/beam/issues/26703#issuecomment-1550778226 Interesting, thanks for raising this. I'll open a PR. Looks like the system mod time in this case is below the range though? I can increase the range on both ends -- This is

[GitHub] [beam] johannaojeling opened a new pull request, #26731: [Go SDK]: Fix flaky local fs LastModified test

2023-05-16 Thread via GitHub
johannaojeling opened a new pull request, #26731: URL: https://github.com/apache/beam/pull/26731 Fixes #26703 by increasing the expected time range for the local fs LastModified unit test Thank you for your contribution! Follow this checklist to help us

[GitHub] [beam] johannaojeling commented on pull request #26731: [Go SDK]: Fix flaky local fs LastModified test

2023-05-16 Thread via GitHub
johannaojeling commented on PR #26731: URL: https://github.com/apache/beam/pull/26731#issuecomment-1550790294 R: @lostluck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [beam] github-actions[bot] commented on pull request #26729: Bump github.com/aws/aws-sdk-go-v2/feature/s3/manager from 1.11.66 to 1.11.67 in /sdks

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26729: URL: https://github.com/apache/beam/pull/26729#issuecomment-1550791133 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @jrmccluskey for label go. Available commands: - `stop r

[GitHub] [beam] github-actions[bot] commented on pull request #26728: Bump github.com/aws/aws-sdk-go-v2/config from 1.18.24 to 1.18.25 in /sdks

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26728: URL: https://github.com/apache/beam/pull/26728#issuecomment-1550791348 Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`: R: @riteshghorse for label go. Available commands: - `stop

[GitHub] [beam] github-actions[bot] commented on pull request #26731: [Go SDK]: Fix flaky local fs LastModified test

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26731: URL: https://github.com/apache/beam/pull/26731#issuecomment-1550792031 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git Serv

[GitHub] [beam] Malarg opened a new pull request, #26732: returned run shortcut, fixed pipeline options validation, added logs to ToB tests

2023-05-16 Thread via GitHub
Malarg opened a new pull request, #26732: URL: https://github.com/apache/beam/pull/26732 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] alexeyinkin commented on a diff in pull request #26732: returned run shortcut, fixed pipeline options validation, added logs to ToB tests

2023-05-16 Thread via GitHub
alexeyinkin commented on code in PR #26732: URL: https://github.com/apache/beam/pull/26732#discussion_r1196001070 ## learning/tour-of-beam/frontend/integration_test/tour_page_test.dart: ## @@ -86,6 +88,7 @@ Future _checkModule(ModuleModel module, WidgetTester wt) async { }

[GitHub] [beam] github-actions[bot] commented on pull request #26732: returned run shortcut, fixed pipeline options validation, added logs to ToB tests

2023-05-16 Thread via GitHub
github-actions[bot] commented on PR #26732: URL: https://github.com/apache/beam/pull/26732#issuecomment-1550819566 Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers` -- This is an automated me

  1   2   >