Abacn commented on code in PR #31143:
URL: https://github.com/apache/beam/pull/31143#discussion_r1586982975
##
.github/workflows/beam_PreCommit_Java_ElasticSearch_IO_Direct.yml:
##
@@ -22,12 +22,16 @@ on:
paths:
- "sdks/java/io/elasticsearch/**"
-
Abacn merged PR #31155:
URL: https://github.com/apache/beam/pull/31155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Abacn commented on code in PR #31143:
URL: https://github.com/apache/beam/pull/31143#discussion_r1586976742
##
build.gradle.kts:
##
@@ -328,12 +328,6 @@ tasks.register("javaioPreCommit") {
dependsOn(":sdks:java:io:clickhouse:build")
Abacn commented on code in PR #31143:
URL: https://github.com/apache/beam/pull/31143#discussion_r1586976742
##
build.gradle.kts:
##
@@ -328,12 +328,6 @@ tasks.register("javaioPreCommit") {
dependsOn(":sdks:java:io:clickhouse:build")
github-actions[bot] commented on PR #31094:
URL: https://github.com/apache/beam/pull/31094#issuecomment-2089369000
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
damccorm commented on PR #31094:
URL: https://github.com/apache/beam/pull/31094#issuecomment-2089367971
R: @liferoad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kennknowles commented on code in PR #31143:
URL: https://github.com/apache/beam/pull/31143#discussion_r1586956719
##
.github/workflows/beam_PreCommit_Java_ElasticSearch_IO_Direct.yml:
##
@@ -22,12 +22,16 @@ on:
paths:
- "sdks/java/io/elasticsearch/**"
-
github-actions[bot] commented on PR #31155:
URL: https://github.com/apache/beam/pull/31155#issuecomment-2089337563
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
JayajP commented on PR #31155:
URL: https://github.com/apache/beam/pull/31155#issuecomment-2089336586
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kennknowles opened a new pull request, #31156:
URL: https://github.com/apache/beam/pull/31156
This rolls forward the Java SDK reference implementation of `Redistribute`.
This does not include runner translations.
- In the prior attempt at this change: many runners failed the
JayajP opened a new pull request, #31155:
URL: https://github.com/apache/beam/pull/31155
Highlight per-worker BigQuery metrics enablement in Changes.md
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
egalpin commented on code in PR #31151:
URL: https://github.com/apache/beam/pull/31151#discussion_r1586911399
##
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##
@@ -2854,9 +2865,28 @@ private List flushBatch() throws
github-actions[bot] commented on PR #31136:
URL: https://github.com/apache/beam/pull/31136#issuecomment-2089242279
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @damccorm added as fallback since no labels match configuration
github-actions[bot] commented on PR #31154:
URL: https://github.com/apache/beam/pull/31154#issuecomment-2089234534
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
Polber commented on PR #31154:
URL: https://github.com/apache/beam/pull/31154#issuecomment-2089233511
R: @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Polber opened a new pull request, #31154:
URL: https://github.com/apache/beam/pull/31154
There have been cases of name collisions on parallel tests, so adding random
suffix to avoid collision.
Thank you for your contribution! Follow this checklist to
camphillips22 commented on issue #31153:
URL: https://github.com/apache/beam/issues/31153#issuecomment-2089207967
I messed up the bug report (submitted too early) and it got classified as P3
whereas I think it should be P2
--
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on PR #31151:
URL: https://github.com/apache/beam/pull/31151#issuecomment-2089174395
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @kennknowles for label java.
R: @shunping for label io.
liferoad opened a new issue, #31152:
URL: https://github.com/apache/beam/issues/31152
### What happened?
# Test code
```python
import apache_beam as beam
import datetime
CSV_DATA = r"""a,b,c,d,e,f,g,h,i,j,k,l,m,n,o,p,q,r
github-actions[bot] commented on PR #31151:
URL: https://github.com/apache/beam/pull/31151#issuecomment-2089049485
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated
andyzhangdialpad commented on PR #31151:
URL: https://github.com/apache/beam/pull/31151#issuecomment-2088994362
cc @egalpin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
andyzhangdialpad opened a new pull request, #31151:
URL: https://github.com/apache/beam/pull/31151
# Issue
When `org.elasticsearch.client.ResponseException` is thrown in
`org.apache.beam.sdk.io.elasticsearch.ElasticsearchIO.BulkIO.BulkIOBaseFn#flushBatch`,
it throws as is, which will
johnjcasey commented on PR #31106:
URL: https://github.com/apache/beam/pull/31106#issuecomment-2088916288
@Abacn @ahmedabu98 could you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
robertwb merged PR #31092:
URL: https://github.com/apache/beam/pull/31092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
shunping commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586642831
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
shunping commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586642831
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
robertwb commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586618153
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
robertwb merged PR #30793:
URL: https://github.com/apache/beam/pull/30793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
robertwb merged PR #31149:
URL: https://github.com/apache/beam/pull/31149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
damccorm commented on PR #31038:
URL: https://github.com/apache/beam/pull/31038#issuecomment-2088879104
Summary of failures:
### Java IO Performance Tests (3 failures)
Actually succeeded, just failed publishing test results
### Java PVR Spark Batch (1 failure)
Naireen commented on PR #31136:
URL: https://github.com/apache/beam/pull/31136#issuecomment-2088877291
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
jrmccluskey merged PR #31145:
URL: https://github.com/apache/beam/pull/31145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Abacn merged PR #31146:
URL: https://github.com/apache/beam/pull/31146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
github-actions[bot] commented on PR #31149:
URL: https://github.com/apache/beam/pull/31149#issuecomment-2088815766
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
robertwb commented on PR #31087:
URL: https://github.com/apache/beam/pull/31087#issuecomment-2088814514
> This seems a likely culprit for the failure at
https://ge.apache.org/s/6b22rnlopcdxk/tests/overview?outcome=FAILED
https://github.com/apache/beam/pull/31149
--
This is an
robertwb commented on PR #31149:
URL: https://github.com/apache/beam/pull/31149#issuecomment-2088814181
R: @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
robertwb opened a new pull request, #31149:
URL: https://github.com/apache/beam/pull/31149
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in
robertwb commented on PR #31087:
URL: https://github.com/apache/beam/pull/31087#issuecomment-2088799356
I think you're right. This was masked by
```
Naireen commented on PR #31137:
URL: https://github.com/apache/beam/pull/31137#issuecomment-2088792583
Run Java_Kafka_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kennknowles merged PR #31140:
URL: https://github.com/apache/beam/pull/31140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kennknowles commented on PR #31140:
URL: https://github.com/apache/beam/pull/31140#issuecomment-2088782751
Both failures are on master already. Confirmed that
`:runners:google-cloud-dataflow-java:worker:test` broken by #11987
--
This is an automated message from the Apache Git Service.
Naireen commented on PR #31136:
URL: https://github.com/apache/beam/pull/31136#issuecomment-2088780141
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kennknowles commented on PR #31087:
URL: https://github.com/apache/beam/pull/31087#issuecomment-2088775740
This seems a likely culprit for the failure at
https://ge.apache.org/s/6b22rnlopcdxk/tests/overview?outcome=FAILED
--
This is an automated message from the Apache Git Service.
To
tvalentyn commented on code in PR #31094:
URL: https://github.com/apache/beam/pull/31094#discussion_r1586490061
##
CHANGES.md:
##
@@ -72,26 +72,16 @@
## Breaking Changes
-* X behavior was changed ([#X](https://github.com/apache/beam/issues/X)).
* Default consumer polling
github-actions[bot] commented on PR #31148:
URL: https://github.com/apache/beam/pull/31148#issuecomment-2088736330
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated
Abacn commented on PR #31146:
URL: https://github.com/apache/beam/pull/31146#issuecomment-2088703214
PreCommit Java Examples Dataflow E2EWordcount failed with quota issue
(cannot bring up any worker), not related
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on PR #31146:
URL: https://github.com/apache/beam/pull/31146#issuecomment-2088695361
Assigning reviewers. If you would like to opt out of this review, comment
`assign to next reviewer`:
R: @m-trieu for label java.
R: @damondouglas for label io.
Abacn commented on PR #31146:
URL: https://github.com/apache/beam/pull/31146#issuecomment-2088693693
assign set of reviewers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #31146:
URL: https://github.com/apache/beam/pull/31146#issuecomment-2088688487
Checks are failing. Will not request review until checks are succeeding. If
you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated
shunping commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
shunping commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
shunping commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
shunping commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
shunping commented on code in PR #31092:
URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290
##
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##
@@ -1063,6 +1087,10 @@ message StateAppendRequest {
// Represents a
m-trieu opened a new pull request, #31148:
URL: https://github.com/apache/beam/pull/31148
Add work processing context
R: @scwhittle
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and
damccorm merged PR #31147:
URL: https://github.com/apache/beam/pull/31147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Abacn commented on PR #31140:
URL: https://github.com/apache/beam/pull/31140#issuecomment-2088598422
kafka spotbug actually failing on master:
https://github.com/apache/beam/actions/workflows/beam_PreCommit_Java_Kafka_IO_Direct.yml?query=event%3Aschedule
fix in #31146
--
This is an
github-actions[bot] commented on PR #31147:
URL: https://github.com/apache/beam/pull/31147#issuecomment-2088581944
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
damccorm commented on PR #31147:
URL: https://github.com/apache/beam/pull/31147#issuecomment-2088580202
R: @liferoad
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
damccorm opened a new pull request, #31147:
URL: https://github.com/apache/beam/pull/31147
Added in #31052 cherry-picked to release branch in #31104
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
Abacn opened a new pull request, #31146:
URL: https://github.com/apache/beam/pull/31146
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
m-trieu commented on PR #31133:
URL: https://github.com/apache/beam/pull/31133#issuecomment-2088502442
failing test is unrelated and passes on local runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
damccorm merged PR #31135:
URL: https://github.com/apache/beam/pull/31135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
codecov-commenter commented on PR #28733:
URL: https://github.com/apache/beam/pull/28733#issuecomment-2088410587
##
[Codecov](https://app.codecov.io/gh/apache/beam/pull/28733?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache)
Report
github-actions[bot] commented on PR #28733:
URL: https://github.com/apache/beam/pull/28733#issuecomment-2088410242
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
github-actions[bot] commented on PR #29792:
URL: https://github.com/apache/beam/pull/29792#issuecomment-2088410206
This pull request has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any
time.
--
This
github-actions[bot] closed pull request #29792: Default max Parallelism should
not apply all UnBoundedSource.
URL: https://github.com/apache/beam/pull/29792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
github-actions[bot] closed pull request #30399: DO NOT SUBMIT Direct path test
URL: https://github.com/apache/beam/pull/30399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
github-actions[bot] commented on PR #30399:
URL: https://github.com/apache/beam/pull/30399#issuecomment-2088410131
This pull request has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any
time.
--
This
github-actions[bot] commented on PR #31145:
URL: https://github.com/apache/beam/pull/31145#issuecomment-2088399339
Stopping reviewer notifications for this pull request: review requested by
someone other than the bot, ceding control
--
This is an automated message from the Apache Git
damccorm commented on PR #31145:
URL: https://github.com/apache/beam/pull/31145#issuecomment-2088398121
R: @jrmccluskey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
damccorm opened a new pull request, #31145:
URL: https://github.com/apache/beam/pull/31145
I noticed a different version of tf was getting installed locally and
remotely and that was causing the notebook to fail. We should pin to avoid
chances of this causing issues. I think leaving tf_hub
damccorm commented on PR #31145:
URL: https://github.com/apache/beam/pull/31145#issuecomment-2088398242
(found this while doing RC validation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on PR #30172:
URL: https://github.com/apache/beam/pull/30172#issuecomment-2088382169
Assigning new set of reviewers because Pr has gone too long without review.
If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb
m-trieu commented on code in PR #31133:
URL: https://github.com/apache/beam/pull/31133#discussion_r1585964743
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##
@@ -387,24 +393,53 @@ private
m-trieu commented on code in PR #31133:
URL: https://github.com/apache/beam/pull/31133#discussion_r1585963336
##
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##
@@ -373,10 +350,39 @@ private
76 matches
Mail list logo
