Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-03 Thread via GitHub
damccorm commented on code in PR #30793: URL: https://github.com/apache/beam/pull/30793#discussion_r1589346429 ## sdks/python/apache_beam/yaml/yaml_provider.py: ## @@ -152,6 +169,17 @@ def __init__(self, urns, service): def provided_transforms(self): return

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-03 Thread via GitHub
damccorm commented on code in PR #30793: URL: https://github.com/apache/beam/pull/30793#discussion_r1589346078 ## sdks/python/apache_beam/yaml/yaml_provider.py: ## @@ -152,6 +169,17 @@ def __init__(self, urns, service): def provided_transforms(self): return

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-03 Thread via GitHub
damccorm commented on code in PR #30793: URL: https://github.com/apache/beam/pull/30793#discussion_r1589345057 ## sdks/python/apache_beam/yaml/yaml_provider.py: ## @@ -152,6 +169,17 @@ def __init__(self, urns, service): def provided_transforms(self): return

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-03 Thread via GitHub
robertwb commented on code in PR #30793: URL: https://github.com/apache/beam/pull/30793#discussion_r1589343690 ## sdks/python/apache_beam/yaml/yaml_provider.py: ## @@ -152,6 +169,17 @@ def __init__(self, urns, service): def provided_transforms(self): return

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-03 Thread via GitHub
damccorm commented on code in PR #30793: URL: https://github.com/apache/beam/pull/30793#discussion_r1589335802 ## sdks/python/apache_beam/yaml/yaml_provider.py: ## @@ -152,6 +169,17 @@ def __init__(self, urns, service): def provided_transforms(self): return

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-03 Thread via GitHub
damccorm commented on PR #30793: URL: https://github.com/apache/beam/pull/30793#issuecomment-2093190723 Looks like this likely broke our python tests - https://github.com/apache/beam/actions/workflows/python_tests.yml?query=branch%3Amaster+event%3Apush - since this was merged, they've

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-01 Thread via GitHub
robertwb merged PR #30793: URL: https://github.com/apache/beam/pull/30793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-04-12 Thread via GitHub
robertwb commented on PR #30793: URL: https://github.com/apache/beam/pull/30793#issuecomment-2051924037 > Took a bit for me to wrap my head around the logic, but this makes sense to me. > > So now with this logic, if we were to package all turnkey external transforms in a common

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-04-11 Thread via GitHub
robertwb commented on PR #30793: URL: https://github.com/apache/beam/pull/30793#issuecomment-2050038374 Any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-03-28 Thread via GitHub
github-actions[bot] commented on PR #30793: URL: https://github.com/apache/beam/pull/30793#issuecomment-2025976248 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-03-28 Thread via GitHub
robertwb commented on PR #30793: URL: https://github.com/apache/beam/pull/30793#issuecomment-2025974733 R: @Polber -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-03-28 Thread via GitHub
robertwb opened a new pull request, #30793: URL: https://github.com/apache/beam/pull/30793 We use the schema transform discovery service to determine all the transforms that a given provider vends which may be larger than those that were explicitly declared (e.g. the basic mapping