Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
robertwb merged PR #31092: URL: https://github.com/apache/beam/pull/31092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586642831 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586642831 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
robertwb commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586618153 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586453290 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
robertwb commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1585535722 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
robertwb commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1585535722 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
shunping commented on PR #31092: URL: https://github.com/apache/beam/pull/31092#issuecomment-2086033582 All other failed tests are related to macos, which is an issue related to using the latest macos artifact. @damccorm already addressed this in #31115 and #31123 by pinning an older

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
shunping commented on PR #31092: URL: https://github.com/apache/beam/pull/31092#issuecomment-2085929173 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1584948151 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
shunping commented on PR #31092: URL: https://github.com/apache/beam/pull/31092#issuecomment-2085530945 Run Java PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1584948151 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-30 Thread via GitHub
shunping commented on PR #31092: URL: https://github.com/apache/beam/pull/31092#issuecomment-2085530713 Run GoPortable PreCommit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-26 Thread via GitHub
robertwb commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1581522019 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-24 Thread via GitHub
acrites commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1578267027 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-24 Thread via GitHub
github-actions[bot] commented on PR #31092: URL: https://github.com/apache/beam/pull/31092#issuecomment-2075307311 Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control -- This is an automated message from the Apache Git

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-04-24 Thread via GitHub
robertwb commented on PR #31092: URL: https://github.com/apache/beam/pull/31092#issuecomment-2075304678 R: @acrites -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] FnAPI proto changes for ordered list state. [beam]

2024-04-24 Thread via GitHub
robertwb opened a new pull request, #31092: URL: https://github.com/apache/beam/pull/31092 This is the proto changes only for https://github.com/apache/beam/pull/30317 to unblock runner-side implementations. Thank you for your contribution! Follow this