Weijun-H commented on PR #12379:
URL: https://github.com/apache/datafusion/pull/12379#issuecomment-2336534360
Thanks @maronavenue for contribution and @Dandandan for review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
Weijun-H merged PR #12379:
URL: https://github.com/apache/datafusion/pull/12379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
maronavenue commented on code in PR #12379:
URL: https://github.com/apache/datafusion/pull/12379#discussion_r1749050920
##
datafusion/core/src/execution/session_state.rs:
##
@@ -1922,4 +1929,32 @@ mod tests {
assert!(new_state.catalog_list().catalog(&default_catalog).is
github-actions[bot] closed pull request #10149: Array agg groups accumulator
URL: https://github.com/apache/datafusion/pull/10149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ngli-me commented on issue #8932:
URL: https://github.com/apache/datafusion/issues/8932#issuecomment-2336510088
Hi, I'm new to this project and was poking through the issues, can I try
working this one out?
It looks like, to remove the hash we would need to first compare by enum
var
codecov-commenter commented on PR #923:
URL: https://github.com/apache/datafusion-comet/pull/923#issuecomment-2336473324
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/923?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campai
rickspencer3 commented on issue #862:
URL:
https://github.com/apache/datafusion-python/issues/862#issuecomment-2336472790
> Oh, I just realized that might not work since `functions.when` was
recently exposed. You would need to do something like `F.case(col("count") !=
lit(0)).when(lit(True
comphead commented on PR #923:
URL: https://github.com/apache/datafusion-comet/pull/923#issuecomment-2336466004
Thanks @himadripal for your contribution, triggering the workflow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
timsaucer commented on issue #862:
URL:
https://github.com/apache/datafusion-python/issues/862#issuecomment-2336458296
Oh, I just realized that might not work since `functions.when` was recently
exposed. You would need to do something like `F.case(col("count") !=
lit(0)).when(lit(True), co
jcsherin commented on code in PR #12374:
URL: https://github.com/apache/datafusion/pull/12374#discussion_r1748972478
##
datafusion/expr/src/expr_schema.rs:
##
@@ -352,7 +358,18 @@ impl ExprSchemable for Expr {
}
}
WindowFunc
himadripal commented on PR #923:
URL: https://github.com/apache/datafusion-comet/pull/923#issuecomment-2336454885
@viirya @andygrove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
timsaucer commented on issue #862:
URL:
https://github.com/apache/datafusion-python/issues/862#issuecomment-2336452591
It's super hacky:
```
df = df.select("time_window", F.when(col("count") != lit(0),
col("count")).end().alias("count"))
```
--
This is an automated message f
timsaucer commented on issue #862:
URL:
https://github.com/apache/datafusion-python/issues/862#issuecomment-2336437952
Also, when I coerced the `count` field to be nullable it was able to work,
so I've got a strong suspicion about that mixture problem.
--
This is an automated message fro
maronavenue commented on issue #10895:
URL: https://github.com/apache/datafusion/issues/10895#issuecomment-2336432075
@alamb - Took my first stab at
https://github.com/apache/datafusion/pull/12379. I have started looking at the
docs setup. Hoping to contribute meaningfully on that front soo
rickspencer3 commented on issue #862:
URL:
https://github.com/apache/datafusion-python/issues/862#issuecomment-2336431893
When looking at the dataframe under the debugger, it looks like it skipped
the null values ok:
```
df
DataFrame()
+-+---+
| ti
maronavenue opened a new pull request, #12379:
URL: https://github.com/apache/datafusion/pull/12379
## Which issue does this PR close?
N/A
## Rationale for this change
My team and I have been exploring Datafusion's potential to federate our
custom sources
comphead commented on code in PR #922:
URL: https://github.com/apache/datafusion-comet/pull/922#discussion_r1748909897
##
docs/source/contributor-guide/plugin_overview.md:
##
@@ -57,3 +57,50 @@ and this serialized plan is passed into the native code by
`CometExecIterator`.
In
andygrove opened a new pull request, #922:
URL: https://github.com/apache/datafusion-comet/pull/922
## Which issue does this PR close?
N/A
## Rationale for this change
Add documentation to make it easier for new contributors to understand the
architecture
waruto210 opened a new issue, #12378:
URL: https://github.com/apache/datafusion/issues/12378
### Is your feature request related to a problem or challenge?
When I use the following code to attempt creating external tables using SQL
and Rust API respectively, a "Corrupt footer" error o
timsaucer opened a new issue, #12377:
URL: https://github.com/apache/datafusion/issues/12377
### Is your feature request related to a problem or challenge?
This function has a placeholder udaf but is not yet implemented.
### Describe the solution you'd like
Implement per
comphead commented on code in PR #12372:
URL: https://github.com/apache/datafusion/pull/12372#discussion_r1748609618
##
docs/source/contributor-guide/index.md:
##
@@ -88,35 +106,61 @@ committer who approved your PR to help remind them to
merge it.
## Creating Pull Requests
goldmedal commented on PR #11035:
URL: https://github.com/apache/datafusion/pull/11035#issuecomment-2335668800
> I plan to leave this PR open until Monday so anyone else who is interested
can take a look at it prior to merge.
š
> I left some suggestions on how to potentially im
Dandandan commented on code in PR #12369:
URL: https://github.com/apache/datafusion/pull/12369#discussion_r1748404550
##
datafusion/optimizer/tests/optimizer_integration.rs:
##
@@ -281,11 +278,9 @@ fn test_same_name_but_not_ambiguous() {
let expected = "LeftSemi Join: t1.co
goldmedal commented on code in PR #11035:
URL: https://github.com/apache/datafusion/pull/11035#discussion_r1748371500
##
datafusion/catalog/src/dynamic_file/catalog.rs:
##
@@ -0,0 +1,184 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor li
timsaucer opened a new issue, #12376:
URL: https://github.com/apache/datafusion/issues/12376
### Describe the bug
Less of a bug per se, but it would be nice to have identical function
signatures between first_value and last_value
### To Reproduce
_No response_
###
Dandandan opened a new issue, #12375:
URL: https://github.com/apache/datafusion/issues/12375
### Is your feature request related to a problem or challenge?
It probably is better to have it enabled by default, as pushing a filter
down below a join is generally faster than the overhead
jayzhan211 commented on code in PR #12374:
URL: https://github.com/apache/datafusion/pull/12374#discussion_r1748097339
##
datafusion/expr/src/expr_schema.rs:
##
@@ -352,7 +358,18 @@ impl ExprSchemable for Expr {
}
}
WindowFu
Rachelint commented on PR #11825:
URL: https://github.com/apache/datafusion/pull/11825#issuecomment-2335198529
> Here are some numebrs I got
>
> ```
>
> Benchmark clickbench_1.json
>
> āāāā³ā³āā
jcsherin commented on code in PR #12374:
URL: https://github.com/apache/datafusion/pull/12374#discussion_r1748094081
##
datafusion/physical-plan/src/windows/mod.rs:
##
@@ -73,7 +74,15 @@ pub fn schema_add_window_field(
.iter()
.map(|e| Arc::clone(e).as_ref().nu
jcsherin commented on code in PR #12374:
URL: https://github.com/apache/datafusion/pull/12374#discussion_r1748092364
##
datafusion/expr/src/expr_schema.rs:
##
@@ -352,7 +358,18 @@ impl ExprSchemable for Expr {
}
}
WindowFunc
jcsherin commented on code in PR #12374:
URL: https://github.com/apache/datafusion/pull/12374#discussion_r1748091147
##
datafusion/expr/src/expr_schema.rs:
##
@@ -352,7 +358,18 @@ impl ExprSchemable for Expr {
}
}
WindowFunc
jcsherin opened a new issue, #12373:
URL: https://github.com/apache/datafusion/issues/12373
### Is your feature request related to a problem or challenge?
> Instead of return_type + nullable. I think `field` is a better choice.
Given windowudf is pretty new so not widely used yet (?).
goldmedal commented on PR #12158:
URL: https://github.com/apache/datafusion/pull/12158#issuecomment-2335162233
Thanks @devinjdangelo @alamb @phillipleblanc for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
alamb merged PR #12362:
URL: https://github.com/apache/datafusion/pull/12362
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
timsaucer merged PR #860:
URL: https://github.com/apache/datafusion-python/pull/860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
alamb closed issue #12117: Support protobuf serialization for
`ScalarValue::Utf8View` and `ScalarValue::BinaryView`
URL: https://github.com/apache/datafusion/issues/12117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
allinux commented on code in PR #857:
URL: https://github.com/apache/datafusion-python/pull/857#discussion_r1748042239
##
python/datafusion/dataframe.py:
##
@@ -409,37 +409,62 @@ def except_all(self, other: DataFrame) -> DataFrame:
"""
return DataFrame(self.df.
allinux commented on code in PR #857:
URL: https://github.com/apache/datafusion-python/pull/857#discussion_r1748042148
##
python/datafusion/dataframe.py:
##
@@ -409,37 +409,62 @@ def except_all(self, other: DataFrame) -> DataFrame:
"""
return DataFrame(self.df.
allinux commented on code in PR #857:
URL: https://github.com/apache/datafusion-python/pull/857#discussion_r1748041887
##
python/datafusion/dataframe.py:
##
@@ -409,37 +409,62 @@ def except_all(self, other: DataFrame) -> DataFrame:
"""
return DataFrame(self.df.
alamb commented on PR #12270:
URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2335147328
Thank you for this PR @zhuliquan . Have you run any benchmarks that show
this approach is noticeably faster than the existing approach? It makes sense
that it would be faster as it do
allinux commented on code in PR #857:
URL: https://github.com/apache/datafusion-python/pull/857#discussion_r1748041401
##
python/datafusion/dataframe.py:
##
@@ -409,37 +409,62 @@ def except_all(self, other: DataFrame) -> DataFrame:
"""
return DataFrame(self.df.
alamb merged PR #12158:
URL: https://github.com/apache/datafusion/pull/12158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
ion-elgreco opened a new issue, #12370:
URL: https://github.com/apache/datafusion/issues/12370
### Describe the bug
Recently we made a change in delta-rs to make the schema's agnostic of
large/normal/view types. However datafusion can't properly coerce `List` and
`LargeList` yet
phillipleblanc commented on code in PR #12158:
URL: https://github.com/apache/datafusion/pull/12158#discussion_r1747999070
##
datafusion/sql/src/unparser/plan.rs:
##
@@ -532,6 +548,73 @@ impl Unparser<'_> {
}
}
+fn unparse_table_scan_pushdown(
+plan:
goldmedal commented on code in PR #12158:
URL: https://github.com/apache/datafusion/pull/12158#discussion_r1747985197
##
datafusion/sql/tests/cases/plan_to_sql.rs:
##
@@ -607,6 +609,151 @@ fn sql_round_trip(query: &str, expect: &str) {
assert_eq!(roundtrip_statement.to_stri
45 matches
Mail list logo
