alihan-synnada commented on code in PR #12531:
URL: https://github.com/apache/datafusion/pull/12531#discussion_r1768086606
##
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##
@@ -456,21 +458,72 @@ struct NestedLoopJoinStream {
// null_equals_null: bool
/// Jo
EpsilonPrime opened a new issue, #12541:
URL: https://github.com/apache/datafusion/issues/12541
### Is your feature request related to a problem or challenge?
_No response_
### Describe the solution you'd like
Here's a sample Substrait plan which uses a nested expression:
djouallah closed issue #535: add documentation how to read a list of files
URL: https://github.com/apache/datafusion-python/issues/535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
djouallah closed issue #414: Show documentation how to use Delta table
URL: https://github.com/apache/datafusion-python/issues/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
findepi commented on PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#issuecomment-2362708504
Thank you @notfilippo for working on this!
> `ScalarValue::Utf8View` and `ScalarValue::LargeUtf8` while keeping
`ScalarValue::Utf8`) in order to keep track of the represented t
findepi opened a new pull request, #12540:
URL: https://github.com/apache/datafusion/pull/12540
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
doupache commented on PR #12497:
URL: https://github.com/apache/datafusion/pull/12497#issuecomment-2362691758
Thanks @austin362667 and @alamb.
I have updated the PR and learned some Cargo tips from @austin362667.
Using debug build during development is much faster.
```
waruto210 commented on PR #12471:
URL: https://github.com/apache/datafusion/pull/12471#issuecomment-2362590513
@alamb PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
nrc commented on PR #12514:
URL: https://github.com/apache/datafusion/pull/12514#issuecomment-2362570825
Null handling and tests addressed. It took a tiny bit more code to make
`epoch` work.
@alamb ready for re-review, thanks!
--
This is an automated message from the Apache Git Ser
Weijun-H commented on code in PR #12490:
URL: https://github.com/apache/datafusion/pull/12490#discussion_r1767812352
##
datafusion/optimizer/src/analyzer/type_coercion.rs:
##
@@ -1811,6 +1811,211 @@ mod test {
Ok(())
}
+#[test]
+fn tes_case_when_list() ->
andygrove commented on issue #872:
URL:
https://github.com/apache/datafusion-python/issues/872#issuecomment-2362554275
I ran some benchmarks from @timsaucer's repo where he has upgraded to
DataFusion 41.
Performance is looking good.
 that field metadata doesn't actually
need to be equivalent for the invariant that this error is trying to catch to
be upheld
If the meta
mbutrovich commented on PR #952:
URL: https://github.com/apache/datafusion-comet/pull/952#issuecomment-2362415067
I was a bit surprised to see a performance win from changing an if-else to a
compound boolean expression, since this seems like something that an optimizing
compiler should hand
Stazer opened a new pull request, #12539:
URL: https://github.com/apache/datafusion/pull/12539
## Which issue does this PR close?
Closes #12538.
## Rationale for this change
## What changes are included in this PR?
I have added a missing block for u
Stazer opened a new issue, #12538:
URL: https://github.com/apache/datafusion/issues/12538
### Describe the bug
Unparsing OFFSET does not work as expected.
### To Reproduce
Parse and unparse the query `SELECT 1 OFFSET 95`.
### Expected behavior
_No response_
ngli-me commented on PR #12481:
URL: https://github.com/apache/datafusion/pull/12481#issuecomment-2362328143
Thanks for the feedback, really appreciate it! I'm happy to help out, I'll
start digging for some more issues following this (I had some personal stuff
come up, so sorry about leavin
ngli-me commented on code in PR #12481:
URL: https://github.com/apache/datafusion/pull/12481#discussion_r1767604834
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -232,8 +232,61 @@ impl Hash for CreateExternalTable {
}
}
+impl PartialOrd for CreateExternalTable {
Rev
ngli-me opened a new issue, #12537:
URL: https://github.com/apache/datafusion/issues/12537
### Is your feature request related to a problem or challenge?
> What requires this manual derivation? Is it some other extension trait
would need to also require `PartialOrd`?
>
> I am t
codecov-commenter commented on PR #946:
URL: https://github.com/apache/datafusion-comet/pull/946#issuecomment-2362297875
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/946?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campai
ngli-me commented on code in PR #12481:
URL: https://github.com/apache/datafusion/pull/12481#discussion_r1767604834
##
datafusion/expr/src/logical_plan/ddl.rs:
##
@@ -232,8 +232,61 @@ impl Hash for CreateExternalTable {
}
}
+impl PartialOrd for CreateExternalTable {
Rev
andygrove commented on PR #952:
URL: https://github.com/apache/datafusion-comet/pull/952#issuecomment-2362244962
Comparison between main branch and this PR:
.toDF("dt").write.parquet("/tmp/dt")
24/09/19
andygrove closed issue #44: Parquet column with integer logical type cannot
read as Spark date column
URL: https://github.com/apache/datafusion-comet/issues/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
viirya commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2361561256
Looks good to me, with a few minor questions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1767185241
##
dev/release/build-release-comet.sh:
##
@@ -0,0 +1,202 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor l
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1767167884
##
Makefile:
##
@@ -46,6 +46,22 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES
viirya commented on code in PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#discussion_r1767163890
##
Makefile:
##
@@ -46,6 +46,22 @@ format:
./mvnw compile test-compile scalafix:scalafix -Psemanticdb $(PROFILES)
./mvnw spotless:apply $(PROFILES
Abdullahsab3 commented on issue #11442:
URL: https://github.com/apache/datafusion/issues/11442#issuecomment-2361442745
> Any chance anyone on this issue (or @Abdullahsab3 ) wants to help organize
another European meetup?
Yes! My team and I would be interested in helping organize a me
parthchandra commented on PR #932:
URL: https://github.com/apache/datafusion-comet/pull/932#issuecomment-2361465911
@viirya Any further comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
franklsf95 commented on issue #872:
URL:
https://github.com/apache/datafusion-python/issues/872#issuecomment-2361460897
> @franklsf95 Would you be able to file an ICLA (unless you already have
one)? The instructions are at
https://www.apache.org/licenses/contributor-agreements.html
>
dependabot[bot] opened a new pull request, #954:
URL: https://github.com/apache/datafusion-comet/pull/954
Bumps
[com.google.protobuf:protobuf-java](https://github.com/protocolbuffers/protobuf)
from 3.19.6 to 3.25.5.
Release notes
Sourced from https://github.com/protocolbuffers/pro
dependabot[bot] opened a new pull request, #27:
URL: https://github.com/apache/datafusion-site/pull/27
Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf) from
4.26.1 to 4.27.5.
Commits
See full diff in https://github.com/protocolbuffers/protobuf/commits";>comp
austin362667 commented on issue #872:
URL:
https://github.com/apache/datafusion-python/issues/872#issuecomment-2361443689
The PR [Add ASF license
header](https://github.com/datafusion-contrib/ray-sql/pull/50)
--
This is an automated message from the Apache Git Service.
To respond to the
timsaucer commented on issue #874:
URL:
https://github.com/apache/datafusion-python/issues/874#issuecomment-2361418801
Verified. I have a fix I will push up tonight or first thing in the morning.
**Thank you for the bug report!**
In the mean time, are you able to use the udaf via dat
austin362667 commented on issue #872:
URL:
https://github.com/apache/datafusion-python/issues/872#issuecomment-2361390265
@andygrove Thanks for updating the title and yes, I can help.
I'll sent PR to https://github.com/datafusion-contrib/ray-sql that adds:
```
# Licensed to the Apa
wiedld commented on PR #12414:
URL: https://github.com/apache/datafusion/pull/12414#issuecomment-2361387578
> I believe you don't need to add a new logic for sort expr's. You should
only focus on the following conversion, when constant expressions appear as the
global order of the other chi
andygrove commented on issue #872:
URL:
https://github.com/apache/datafusion-python/issues/872#issuecomment-2361357793
@franklsf95 Would you be able to file an ICLA (unless you already have one)?
The instructions are at
https://www.apache.org/licenses/contributor-agreements.html
@au
alamb commented on issue #12533:
URL: https://github.com/apache/datafusion/issues/12533#issuecomment-2361342279
I think the expectation for `PERCENTILE_CONT` is that it will implement an
exact calculation -- and to do so the implementation needs to keep all the
actual values (e.g. the same
emanueledomingo opened a new issue, #874:
URL: https://github.com/apache/datafusion-python/issues/874
**Describe the bug**
During the update of Datafusion from 39 to 41, my script got broken because
the `register_udaf` crashes witht he following error:
```
in SessionContext.regi
berkaysynnada commented on PR #12531:
URL: https://github.com/apache/datafusion/pull/12531#issuecomment-2361305449
cc @korowa, @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
ozankabak commented on code in PR #12531:
URL: https://github.com/apache/datafusion/pull/12531#discussion_r1767011103
##
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##
@@ -595,27 +650,17 @@ fn join_left_and_right_batch(
column_indices: &[ColumnIndex],
schem
ozankabak commented on PR #12531:
URL: https://github.com/apache/datafusion/pull/12531#issuecomment-2361286349
/benchmark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
notfilippo commented on PR #12536:
URL: https://github.com/apache/datafusion/pull/12536#issuecomment-2361270997
The main change is contained in this file:
https://github.com/apache/datafusion/pull/12536/files#diff-2cc034babb8e7f8601dda34ecaa2119104eccd76d8ad2f9e19b26b01463634d6
All ot
comphead commented on PR #12474:
URL: https://github.com/apache/datafusion/pull/12474#issuecomment-2361269219
Related to https://github.com/apache/datafusion/issues/6531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
comphead merged PR #12522:
URL: https://github.com/apache/datafusion/pull/12522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alihan-synnada commented on code in PR #12531:
URL: https://github.com/apache/datafusion/pull/12531#discussion_r1766996632
##
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##
@@ -458,19 +457,47 @@ struct NestedLoopJoinStream {
join_metrics: BuildProbeJoinMetrics,
comphead commented on PR #12520:
URL: https://github.com/apache/datafusion/pull/12520#issuecomment-2361255895
Thanks everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
comphead closed issue #12519: DataFrame select_exprs
URL: https://github.com/apache/datafusion/issues/12519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
comphead merged PR #12520:
URL: https://github.com/apache/datafusion/pull/12520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb merged PR #12535:
URL: https://github.com/apache/datafusion/pull/12535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
andygrove merged PR #931:
URL: https://github.com/apache/datafusion-comet/pull/931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@da
devanbenz commented on code in PR #12466:
URL: https://github.com/apache/datafusion/pull/12466#discussion_r1766966988
##
datafusion/sql/src/statement.rs:
##
@@ -1136,14 +1136,29 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
schema: &DFSchemaRef,
planner_con
notfilippo opened a new pull request, #12536:
URL: https://github.com/apache/datafusion/pull/12536
This PR represents the first step originating from experiment #11978, which
itself stems from the broad objective described in proposal #11513.
---
## Rationale for this change
austin362667 commented on code in PR #12497:
URL: https://github.com/apache/datafusion/pull/12497#discussion_r1766347074
##
benchmarks/src/imdb/convert.rs:
##
@@ -0,0 +1,112 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreeme
devanbenz commented on PR #12466:
URL: https://github.com/apache/datafusion/pull/12466#issuecomment-2361106309
@alamb I have this working but I'm unsure if the *original* implementation
is working as expected. Shouldn't the times be descending in this first
selection?
```
> create
progval opened a new pull request, #12535:
URL: https://github.com/apache/datafusion/pull/12535
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
phillipleblanc commented on PR #11989:
URL: https://github.com/apache/datafusion/pull/11989#issuecomment-2361050053
> Could we keep all the fields for the logical plan to make them consistent?
That seems fine to me.
--
This is an automated message from the Apache Git Service.
To res
jayzhan211 commented on PR #11989:
URL: https://github.com/apache/datafusion/pull/11989#issuecomment-2361034346
I think the ideal way is to have something like `wildcard field` for both
logical and physical 🤔
--
This is an automated message from the Apache Git Service.
To respond to the
1 - 100 of 132 matches
Mail list logo
