gabotechs commented on code in PR #16345:
URL: https://github.com/apache/datafusion/pull/16345#discussion_r2139335258
##
datafusion/substrait/src/logical_plan/consumer/utils.rs:
##
@@ -81,98 +81,167 @@ pub(super) fn next_struct_field_name(
}
}
-pub(super) fn rename_field
ding-young commented on PR #16268:
URL: https://github.com/apache/datafusion/pull/16268#issuecomment-2961345444
This is ready for review :) @2010YOUY01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ding-young commented on issue #16367:
URL: https://github.com/apache/datafusion/issues/16367#issuecomment-2961338341
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
ding-young opened a new issue, #16367:
URL: https://github.com/apache/datafusion/issues/16367
### Is your feature request related to a problem or challenge?
Part of https://github.com/apache/datafusion/issues/16065 , Related to
https://github.com/apache/datafusion/issues/14078
a-agmon commented on PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#issuecomment-2961294401
@alamb - thank you very much for the generous comments. I appreciate it.
Re naming - I completely agree. Was just wondering whether its better to
introduce one function that infe
drtconway opened a new issue, #16366:
URL: https://github.com/apache/datafusion/issues/16366
### Is your feature request related to a problem or challenge?
Thanks for an awesome platform! I'm really loving it!
In R `pmin` and `pmax` do row-wise min and max respectively. They're
Dandandan commented on PR #16359:
URL: https://github.com/apache/datafusion/pull/16359#issuecomment-2961277605
> Thank you, this solves the memory overcounting issue across batches. I got
some suggestions/questions.
>
> This new pool implementation might cause some issue for
`MemoryR
alamb commented on PR #16320:
URL: https://github.com/apache/datafusion/pull/16320#issuecomment-2961275410
🤖: Benchmark completed
Details
```
group alamb_field_metadata2
main
-
zhuqi-lucas commented on issue #16353:
URL: https://github.com/apache/datafusion/issues/16353#issuecomment-2961255260
Thank you @alamb !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
alamb commented on code in PR #16332:
URL: https://github.com/apache/datafusion/pull/16332#discussion_r2139195148
##
datafusion-cli/src/functions.rs:
##
@@ -460,3 +473,92 @@ impl TableFunctionImpl for ParquetMetadataFunc {
Ok(Arc::new(parquet_metadata))
}
}
+
+///
Dandandan commented on code in PR #16359:
URL: https://github.com/apache/datafusion/pull/16359#discussion_r2139196390
##
datafusion/execution/src/memory_pool/mod.rs:
##
@@ -131,14 +133,58 @@ pub trait MemoryPool: Send + Sync + std::fmt::Debug {
/// This must always succeed
rishvin commented on PR #16350:
URL: https://github.com/apache/datafusion/pull/16350#issuecomment-2961232868
Thanks @andygrove / @getChan for the feedback. Please review the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
alamb commented on PR #15256:
URL: https://github.com/apache/datafusion/pull/15256#issuecomment-2961234354
I am trying to clean up the review queue and it wasn't clear to me what the
plan for this PR is, so marking it as draft
--
This is an automated message from the Apache Git Service.
T
alamb commented on code in PR #16300:
URL: https://github.com/apache/datafusion/pull/16300#discussion_r2139183428
##
datafusion-cli/src/object_storage.rs:
##
@@ -105,9 +106,52 @@ pub async fn get_s3_object_store_builder(
builder = builder.with_allow_http(*allow_http);
alamb opened a new issue, #16365:
URL: https://github.com/apache/datafusion/issues/16365
### Is your feature request related to a problem or challenge?
- Part of https://github.com/apache/datafusion/pull/16300/files
While testing https://github.com/apache/datafusion/pull/16300,
alamb commented on code in PR #16320:
URL: https://github.com/apache/datafusion/pull/16320#discussion_r2139153886
##
datafusion/expr/src/expr.rs:
##
@@ -601,7 +625,7 @@ pub struct Alias {
pub expr: Box,
pub relation: Option,
pub name: String,
-pub metadata: Op
alamb commented on issue #16326:
URL: https://github.com/apache/datafusion/issues/16326#issuecomment-2961213135
I believe this was fixed in
- https://github.com/apache/datafusion/pull/16313
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
alamb commented on PR #16320:
URL: https://github.com/apache/datafusion/pull/16320#issuecomment-2961193827
🤖 `./gh_compare_branch_bench.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_branch_bench.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~
alamb commented on PR #16317:
URL: https://github.com/apache/datafusion/pull/16317#issuecomment-2961187091
Here is a follow on PR to also use the same structure in `Expr::Alias`
(which also had metadata, but was stored as a HashMap)
- https://github.com/apache/datafusion/pull/16320/files
alamb commented on code in PR #16320:
URL: https://github.com/apache/datafusion/pull/16320#discussion_r2139153886
##
datafusion/expr/src/expr.rs:
##
@@ -601,7 +625,7 @@ pub struct Alias {
pub expr: Box,
pub relation: Option,
pub name: String,
-pub metadata: Op
alamb commented on issue #16323:
URL: https://github.com/apache/datafusion/issues/16323#issuecomment-2961181201
I am sorry @xudong963 -- there were apparently many other crates I didn't
add you as an owner for. I have just sent a bunch more invitations -- hopefully
after you accept them th
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139142869
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
alamb commented on PR #16335:
URL: https://github.com/apache/datafusion/pull/16335#issuecomment-2961170037
Thanks @tlm365 and @xudong963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
alamb commented on issue #16323:
URL: https://github.com/apache/datafusion/issues/16323#issuecomment-2961176597
👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
alamb commented on PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#issuecomment-2961173895
FWIW @phillipleblanc also hit this as well in SpiceAI. See this for more
details
- https://github.com/spiceai/spiceai/pull/6178
--
This is an automated message from the Apache Gi
alamb merged PR #16335:
URL: https://github.com/apache/datafusion/pull/16335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb closed issue #16327: to_hex cannot take UInt64
URL: https://github.com/apache/datafusion/issues/16327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139142869
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
zhuqi-lucas commented on code in PR #16290:
URL: https://github.com/apache/datafusion/pull/16290#discussion_r2139142869
##
datafusion/sqllogictest/test_files/arrow_files.slt:
##
@@ -61,22 +61,12 @@ LOCATION '../core/tests/data/partitioned_table_arrow/'
PARTITIONED BY (part);
alamb merged PR #16317:
URL: https://github.com/apache/datafusion/pull/16317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #16361:
URL: https://github.com/apache/datafusion/pull/16361#issuecomment-2961165506
Thank you for the review @2010YOUY01
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
UBarney commented on issue #16364:
URL: https://github.com/apache/datafusion/issues/16364#issuecomment-2961161122
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
comphead commented on code in PR #1860:
URL: https://github.com/apache/datafusion-comet/pull/1860#discussion_r2139136916
##
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##
@@ -2728,4 +2728,35 @@ class CometExpressionSuite extends CometTestBase with
Adaptive
alamb commented on PR #16243:
URL: https://github.com/apache/datafusion/pull/16243#issuecomment-2961158371
Marking as draft as I think this PR is no longer waiting on feedback and I
am trying to make it easier to find PRs in need of review. Please mark it as
ready for review when it is read
alamb commented on code in PR #16351:
URL: https://github.com/apache/datafusion/pull/16351#discussion_r2139135378
##
datafusion/common/src/config.rs:
##
@@ -591,6 +930,12 @@ config_namespace! {
/// writing out already in-memory data, such as from a cached
/// d
UBarney opened a new issue, #16364:
URL: https://github.com/apache/datafusion/issues/16364
### Is your feature request related to a problem or challenge?
The current Nested Loop Join implementation follows this simplified logic:
1. Buffer the Build Side: All data from the left (buil
lorenarosati commented on issue #16363:
URL: https://github.com/apache/datafusion/issues/16363#issuecomment-2961113864
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
lorenarosati opened a new issue, #16363:
URL: https://github.com/apache/datafusion/issues/16363
### Describe the bug
When we convert a Substrait plan (which includes a virtual table) to a
DataFusion LogicalPlan using the `from_substrait_plan()`
[function](https://github.com/apache/da
xudong963 commented on PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#issuecomment-2961055915
> Great to hear! Sorry for the inconvenience...
No problem!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
adriangb commented on PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#issuecomment-2961049931
Great to hear! Sorry for the inconvenience...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xudong963 commented on PR #16086:
URL: https://github.com/apache/datafusion/pull/16086#issuecomment-2961047647
Fyi, we've upgraded to DF47 with the fix successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
2010YOUY01 commented on code in PR #16361:
URL: https://github.com/apache/datafusion/pull/16361#discussion_r2139062181
##
datafusion/common/src/scalar/mod.rs:
##
@@ -3527,6 +3527,33 @@ impl ScalarValue {
}
}
+/// Compacts the data of an `ArrayData` into a new `ArrayData`
2010YOUY01 merged PR #16289:
URL: https://github.com/apache/datafusion/pull/16289
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
github-actions[bot] commented on PR #15622:
URL: https://github.com/apache/datafusion/pull/15622#issuecomment-2961018161
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
2010YOUY01 commented on code in PR #16359:
URL: https://github.com/apache/datafusion/pull/16359#discussion_r2139040880
##
datafusion/execution/src/memory_pool/mod.rs:
##
@@ -131,14 +133,58 @@ pub trait MemoryPool: Send + Sync + std::fmt::Debug {
/// This must always succeed
github-actions[bot] commented on PR #15510:
URL: https://github.com/apache/datafusion/pull/15510#issuecomment-2961018258
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #15441:
URL: https://github.com/apache/datafusion/pull/15441#issuecomment-2961018385
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #15490:
URL: https://github.com/apache/datafusion/pull/15490#issuecomment-2961018338
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #15506:
URL: https://github.com/apache/datafusion/pull/15506#issuecomment-2961018300
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #15603:
URL: https://github.com/apache/datafusion/pull/15603#issuecomment-2961018203
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
github-actions[bot] commented on PR #15638:
URL: https://github.com/apache/datafusion/pull/15638#issuecomment-2961018128
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
xudong963 opened a new pull request, #16362:
URL: https://github.com/apache/datafusion/pull/16362
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes teste
alamb commented on code in PR #16340:
URL: https://github.com/apache/datafusion/pull/16340#discussion_r2138991917
##
docs/source/library-user-guide/table-constraints.md:
##
@@ -0,0 +1,46 @@
+
+
+# Table Constraint Enforcement
+
+Table providers can describe table constraints usi
xudong963 commented on issue #16323:
URL: https://github.com/apache/datafusion/issues/16323#issuecomment-2960933902
Hi @alamb , it seems there is still something wrong:
```
Uploading datafusion-common v48.0.0
(/Users/xudong/opensource/datafusion/datafusion/common)
error: failed t
alamb commented on code in PR #16342:
URL: https://github.com/apache/datafusion/pull/16342#discussion_r2138987979
##
datafusion/core/src/datasource/file_format/csv.rs:
##
@@ -795,6 +796,25 @@ mod tests {
Ok(())
}
+#[tokio::test]
+async fn test_csv_write_e
alamb merged PR #16352:
URL: https://github.com/apache/datafusion/pull/16352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #16346:
URL: https://github.com/apache/datafusion/pull/16346#discussion_r2138985658
##
datafusion/functions-aggregate/src/array_agg.rs:
##
@@ -313,7 +315,11 @@ impl Accumulator for ArrayAggAccumulator {
};
if !val.is_empty() {
-
alamb opened a new pull request, #16361:
URL: https://github.com/apache/datafusion/pull/16361
## Which issue does this PR close?
- Closes #.
## Rationale for this change
- While reviewing https://github.com/apache/datafusion/pull/16346 from
@gabotechs I ran into
alamb merged PR #16354:
URL: https://github.com/apache/datafusion/pull/16354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb merged PR #16355:
URL: https://github.com/apache/datafusion/pull/16355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on code in PR #16360:
URL: https://github.com/apache/datafusion/pull/16360#discussion_r2138947851
##
docs/source/library-user-guide/upgrading.md:
##
@@ -200,7 +235,7 @@ working but no one knows due to lack of test coverage).
[api deprecation guidelines]:
http
alamb commented on PR #16170:
URL: https://github.com/apache/datafusion/pull/16170#issuecomment-2960852408
I also made a PR to add a note to the upgrade guide here:
- https://github.com/apache/datafusion/pull/16360
--
This is an automated message from the Apache Git Service.
To respond
alamb opened a new pull request, #16360:
URL: https://github.com/apache/datafusion/pull/16360
## Which issue does this PR close?
- Follow on to https://github.com/apache/datafusion/pull/16170
## Rationale for this change
I hit another required change while testing the delta-rs up
alamb commented on issue #16353:
URL: https://github.com/apache/datafusion/issues/16353#issuecomment-2960837514
Thank you @zhuqi-lucas -- I also added this as a wishlist item for
https://github.com/apache/datafusion/issues/16235
--
This is an automated message from the Apache Git Service
alamb commented on code in PR #1876:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1876#discussion_r2138936424
##
.github/workflows/rust.yml:
##
@@ -85,11 +88,8 @@ jobs:
uses: ./.github/actions/setup-builder
with:
rust-version: ${{ matrix.ru
alamb merged PR #1876:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr.
huaxingao commented on PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#issuecomment-2960779443
I don't think this is needed any more, so closing it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
huaxingao closed pull request #360: chore: add a utils method to
getColumnReader with SQLConf
URL: https://github.com/apache/datafusion-comet/pull/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
westonpace commented on code in PR #16345:
URL: https://github.com/apache/datafusion/pull/16345#discussion_r2138834078
##
datafusion/substrait/src/logical_plan/consumer/utils.rs:
##
@@ -81,98 +81,167 @@ pub(super) fn next_struct_field_name(
}
}
-pub(super) fn rename_fiel
andygrove commented on issue #1373:
URL:
https://github.com/apache/datafusion-comet/issues/1373#issuecomment-2960683018
We do now have a `CometFuzzSuite`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
andygrove closed issue #1373: Add fuzz testing to CI
URL: https://github.com/apache/datafusion-comet/issues/1373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
andygrove commented on code in PR #1862:
URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2138821947
##
native/core/src/execution/shuffle/range_partitioner.rs:
##
@@ -0,0 +1,432 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
andygrove commented on code in PR #1862:
URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2138822721
##
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##
@@ -2904,6 +2903,8 @@ object QueryPlanSerde extends Logging with CometExprShim {
andygrove commented on code in PR #1862:
URL: https://github.com/apache/datafusion-comet/pull/1862#discussion_r2138821450
##
native/core/src/execution/shuffle/range_partitioner.rs:
##
@@ -0,0 +1,432 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
andygrove closed pull request #616: feat: ANSI support for Add
URL: https://github.com/apache/datafusion-comet/pull/616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
codecov-commenter commented on PR #1870:
URL:
https://github.com/apache/datafusion-comet/pull/1870#issuecomment-2960634456
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1870?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove closed pull request #1374: feat: Add aggregate expression fuzz
testing in CI
URL: https://github.com/apache/datafusion-comet/pull/1374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
andygrove commented on PR #1135:
URL:
https://github.com/apache/datafusion-comet/pull/1135#issuecomment-2960630950
I am closing this PR since it is no longer active. Feel free to re-open if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andygrove closed pull request #1135: Add ANSI support for Add, Subtract &
Multiply
URL: https://github.com/apache/datafusion-comet/pull/1135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
andygrove commented on PR #1122:
URL:
https://github.com/apache/datafusion-comet/pull/1122#issuecomment-2960629920
I am closing this PR since it is no longer active. Feel free to re-open if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
andygrove closed pull request #989: feat: Implement ANSI support for Round
URL: https://github.com/apache/datafusion-comet/pull/989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
andygrove closed pull request #1122: feat: add expression array_size
URL: https://github.com/apache/datafusion-comet/pull/1122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
andygrove commented on PR #989:
URL: https://github.com/apache/datafusion-comet/pull/989#issuecomment-2960629321
I am closing this PR since it is no longer active. Feel free to re-open if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
andygrove commented on PR #958:
URL: https://github.com/apache/datafusion-comet/pull/958#issuecomment-2960628775
I am closing this PR since it is no longer active. Feel free to re-open if
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
andygrove closed pull request #958: chore: Override node name for
CometSparkToColumnar
URL: https://github.com/apache/datafusion-comet/pull/958
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
andygrove closed pull request #955: build: Upgrade Spark 4.0 to preview2
URL: https://github.com/apache/datafusion-comet/pull/955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
andygrove commented on PR #955:
URL: https://github.com/apache/datafusion-comet/pull/955#issuecomment-2960626602
I am closing this PR since it has not been active lately. Feel free to
re-open if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message
dependabot[bot] commented on PR #954:
URL: https://github.com/apache/datafusion-comet/pull/954#issuecomment-2960626032
OK, I won't notify you again about this release, but will get in touch when
a new version is available. If you'd rather skip all updates until the next
major or minor versi
andygrove closed pull request #954: build(deps): bump
com.google.protobuf:protobuf-java from 3.19.6 to 3.25.5
URL: https://github.com/apache/datafusion-comet/pull/954
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
andygrove commented on PR #616:
URL: https://github.com/apache/datafusion-comet/pull/616#issuecomment-2960624710
I am closing this PR since it has not been active lately. Feel free to
re-open if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message
andygrove commented on PR #360:
URL: https://github.com/apache/datafusion-comet/pull/360#issuecomment-2960623336
@huaxingao Is this PR still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
andygrove commented on PR #1203:
URL:
https://github.com/apache/datafusion-comet/pull/1203#issuecomment-2960622532
I am closing this PR since it has not been active lately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove closed pull request #1203: feat: Only create one native plan for a
query on an executor
URL: https://github.com/apache/datafusion-comet/pull/1203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Dandandan commented on PR #16359:
URL: https://github.com/apache/datafusion/pull/16359#issuecomment-2960579460
Hm - `.slice()` of course creates another `Arc`, so we actually have to use
the buffers `Arc` rather than arrays.
--
This is an automated message from the Apache Git Service.
To
andygrove opened a new pull request, #1870:
URL: https://github.com/apache/datafusion-comet/pull/1870
## Which issue does this PR close?
N/A
## Rationale for this change
Reduce developer overhead of keeping multiple diff files up-to-date for
Spark 3.5 and
GitHub user backkem added a comment to the discussion: Search Pushdown (e.g.
Vector Search) Into Table Providers
FWIW there is an existing implementation of the "full logical plan pushdown" in
[datafusion-contrib/datafusion-federation](https://github.com/datafusion-contrib/datafusion-federatio
andygrove closed pull request #1868: chore: Skip some Spark SQL test runs on PRs
URL: https://github.com/apache/datafusion-comet/pull/1868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Dandandan opened a new pull request, #16359:
URL: https://github.com/apache/datafusion/pull/16359
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes teste
codecov-commenter commented on PR #1869:
URL:
https://github.com/apache/datafusion-comet/pull/1869#issuecomment-2960381202
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1869?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
andygrove commented on issue #1123:
URL:
https://github.com/apache/datafusion-comet/issues/1123#issuecomment-2960359323
I'm going to go ahead and close this now that almost all of the issues
linked to this epic have been implemented. We have definitely seen a
significant improvement in shu
1 - 100 of 183 matches
Mail list logo
