andygrove closed issue #696: Ensure examples stay updated in CI.
URL: https://github.com/apache/datafusion-python/issues/696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
timsaucer commented on issue #696:
URL:
https://github.com/apache/datafusion-python/issues/696#issuecomment-2119241255
As an update, I've got the tests written as you describe. I removed the
reference files from the repo. Now it's checking against the official answer
files. There is one sp
Michael-J-Ward commented on issue #696:
URL:
https://github.com/apache/datafusion-python/issues/696#issuecomment-2117705572
My default would be *not* to add the data to the repo, but I'll let
@andygrove decide that. Maybe we could add it to the test-data submodule
https://github.com/apache
timsaucer commented on issue #696:
URL:
https://github.com/apache/datafusion-python/issues/696#issuecomment-2117480476
Ok, made some good progress on this. Will try to wrap up tomorrow.
https://github.com/timsaucer/datafusion-python/blob/tsaucer/prepare_tpch_examples_for_ci/examples/tpch/_t
Michael-J-Ward commented on issue #696:
URL:
https://github.com/apache/datafusion-python/issues/696#issuecomment-2115422069
We could make it stupid simple by making these snapshot tests and using
https://pypi.org/project/pytest-snapshot/
--
This is an automated message from the Apache Gi
Michael-J-Ward commented on issue #696:
URL:
https://github.com/apache/datafusion-python/issues/696#issuecomment-2115415705
After a little experimenting, I'm pretty sure this will work.
Create a `./example/tpch/_tests.py`
```python
def test_q01_pricing_summary_report():
timsaucer commented on issue #696:
URL:
https://github.com/apache/datafusion-python/issues/696#issuecomment-2115120820
I have a branch ready that corrects the examples to match the spec output.
Most of it was numerical errors between float and decimal representation, and
converting 3 month
timsaucer commented on issue #696:
URL:
https://github.com/apache/datafusion-python/issues/696#issuecomment-2110851781
There are a couple of things we'll need to do that immediately come to mind:
- A few of the examples have some differences with what the spec shows as
the expected o
Michael-J-Ward opened a new issue, #696:
URL: https://github.com/apache/datafusion-python/issues/696
Given the great work @timsaucer has done on the `examples/tpch`, I'd like to
ensure they stay up to date and don't break when we upgrade `datafusion`
versions.
**Describe the solution
