Re: [I] Re-implement support for count in window aggregate [datafusion-comet]

2024-08-01 Thread via GitHub
andygrove closed issue #645: Re-implement support for count in window aggregate URL: https://github.com/apache/datafusion-comet/issues/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Re-implement support for count in window aggregate [datafusion-comet]

2024-07-09 Thread via GitHub
huaxingao commented on issue #645: URL: https://github.com/apache/datafusion-comet/issues/645#issuecomment-2218146640 Looks like `min` and `max` will be removed from built-in function as well. I will re-implement the window aggregate support using `AggregateUDF` -- This is an aut

Re: [I] Re-implement support for count in window aggregate [datafusion-comet]

2024-07-09 Thread via GitHub
viirya commented on issue #645: URL: https://github.com/apache/datafusion-comet/issues/645#issuecomment-2218036771 cc @huaxingao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[I] Re-implement support for count in window aggregate [datafusion-comet]

2024-07-09 Thread via GitHub
andygrove opened a new issue, #645: URL: https://github.com/apache/datafusion-comet/issues/645 ### What is the problem the feature request solves? When upgrading to DataFusion 40.0.0-rc1 in https://github.com/apache/datafusion-comet/pull/644 I had to disable support for count in wind