andygrove merged PR #808:
URL: https://github.com/apache/datafusion-python/pull/808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@d
timsaucer commented on PR #808:
URL:
https://github.com/apache/datafusion-python/pull/808#issuecomment-2322882965
I've rebased on main and I think the window functions are good to go. Follow
on work:
https://github.com/apache/datafusion-python/issues/688
Address Aggregates for
timsaucer commented on code in PR #808:
URL: https://github.com/apache/datafusion-python/pull/808#discussion_r1730340120
##
python/datafusion/functions.py:
##
@@ -1479,12 +1502,17 @@ def approx_percentile_cont(
"""Returns the value that is approximately at a given percentil
timsaucer commented on PR #808:
URL:
https://github.com/apache/datafusion-python/pull/808#issuecomment-2308818882
That's a great suggestion about using the defaults instead. I'll convert
this over to that approach. It will be might tighter interface.
--
This is an automated message from
timsaucer commented on code in PR #808:
URL: https://github.com/apache/datafusion-python/pull/808#discussion_r1730328211
##
python/datafusion/functions.py:
##
@@ -1479,12 +1502,17 @@ def approx_percentile_cont(
"""Returns the value that is approximately at a given percentil
timsaucer commented on code in PR #808:
URL: https://github.com/apache/datafusion-python/pull/808#discussion_r1730328056
##
docs/source/user-guide/common-operations/windows.rst:
##
@@ -40,54 +43,86 @@ We'll use the pokemon dataset (from Ritchie Vink) in the
following examples.
Michael-J-Ward commented on PR #808:
URL:
https://github.com/apache/datafusion-python/pull/808#issuecomment-2308460179
IDK if you have used `polars` much, but I found their approach to
aggregation and windowing pretty intuitive and powerful.
Maybe I should do a deeper comparison by w
Michael-J-Ward commented on code in PR #808:
URL: https://github.com/apache/datafusion-python/pull/808#discussion_r1730026984
##
docs/source/user-guide/common-operations/windows.rst:
##
@@ -40,54 +43,86 @@ We'll use the pokemon dataset (from Ritchie Vink) in the
following examp
timsaucer commented on PR #808:
URL:
https://github.com/apache/datafusion-python/pull/808#issuecomment-2308338644
Since this is already getting a bit long, I'd like to merge it with just the
window functions and deal with the aggregate functions in a different PR.
--
This is an automated
