Re: [PR] Add arrow cast [datafusion-python]

2025-01-07 Thread via GitHub
timsaucer merged PR #962: URL: https://github.com/apache/datafusion-python/pull/962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@d

Re: [PR] Add arrow cast [datafusion-python]

2024-12-15 Thread via GitHub
kosiew commented on PR #962: URL: https://github.com/apache/datafusion-python/pull/962#issuecomment-2544620133 @timsaucer , Thanks for the detailed example. The other reason for this PR is also to add `arrow_cast` so that the [full set](https://arrow.apache.org/datafusion/user

Re: [PR] Add arrow cast [datafusion-python]

2024-12-12 Thread via GitHub
timsaucer commented on PR #962: URL: https://github.com/apache/datafusion-python/pull/962#issuecomment-2538772977 So doing a little testing to see if this is necessary: ``` from datafusion import SessionContext, col, lit import pyarrow as pa import datetime ctx = SessionCo

Re: [PR] Add arrow cast [datafusion-python]

2024-12-11 Thread via GitHub
kosiew commented on PR #962: URL: https://github.com/apache/datafusion-python/pull/962#issuecomment-2537654307 > Thank you for the additions. Do you think this is needed or to just use `Expr.cast`? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Add arrow cast [datafusion-python]

2024-12-11 Thread via GitHub
kosiew commented on code in PR #962: URL: https://github.com/apache/datafusion-python/pull/962#discussion_r1881289367 ## python/datafusion/__init__.py: ## @@ -107,6 +107,11 @@ def literal(value): return Expr.literal(value) +def utf8_literal(value): +"""Create a UTF8

Re: [PR] Add arrow cast [datafusion-python]

2024-12-11 Thread via GitHub
kosiew commented on code in PR #962: URL: https://github.com/apache/datafusion-python/pull/962#discussion_r1881280309 ## python/datafusion/functions.py: ## @@ -1108,6 +1109,11 @@ def arrow_typeof(arg: Expr) -> Expr: return Expr(f.arrow_typeof(arg.expr)) +def arrow_cast(

Re: [PR] Add arrow cast [datafusion-python]

2024-12-10 Thread via GitHub
timsaucer commented on code in PR #962: URL: https://github.com/apache/datafusion-python/pull/962#discussion_r1877966060 ## python/datafusion/__init__.py: ## @@ -107,6 +107,11 @@ def literal(value): return Expr.literal(value) +def utf8_literal(value): +"""Create a U

[PR] Add arrow cast [datafusion-python]

2024-12-02 Thread via GitHub
kosiew opened a new pull request, #962: URL: https://github.com/apache/datafusion-python/pull/962 # Which issue does this PR close? Completes a task in #463 # Rationale for this change This PR introduces the implementation of the `arrow_cast` function from d